google-ads-common 0.9.0 → 0.9.1

data/ChangeLog

@@ -1,3 +1,6 @@
+0.9.1:
+  - Fixed issues #93, #96, #97.
+
 0.9.0:
   - Switched to Signet OAuth implementation.
   - Removed deprecated OAuth1.0a scheme, please use OAuth2.0 instead.

data/lib/ads_common/auth/oauth2_jwt_handler.rb

@@ -138,7 +138,8 @@ module AdsCommon
         if credentials[:oauth2_keyfile] &&
             !File.file?(credentials[:oauth2_keyfile])
           raise AdsCommon::Errors::AuthError,
-              "Key file '%s' does not exist or not a file."
+              "Key file '%s' does not exist or not a file." %
+              credentials[:oauth2_keyfile]
         end
       end
 
@@ -170,6 +171,7 @@ module AdsCommon
         oauth_options = OAUTH2_CONFIG.merge({
             :issuer => credentials[:oauth2_issuer],
             :signing_key => credentials[:oauth2_key],
+            :person => credentials[:oauth2_prn],
             :scope => @scope,
         })
         return Signet::OAuth2::Client.new(oauth_options)

data/lib/ads_common/build/savon_registry.rb

@@ -128,7 +128,7 @@ module AdsCommon
             # This could be used to include documentation from wsdl.
             #:doc => get_element_doc(operation, 'wsdl')
         }
-        original_name = (name.snakecase.lower_camelcase == name)? nil : name
+        original_name = get_original_name_if_needed(name)
         method[:original_name] = original_name unless original_name.nil?
         return method
       end
@@ -207,7 +207,11 @@ module AdsCommon
       def get_element_fields(element)
         fields = []
         REXML::XPath.each(element, 'descendant::element') do |item|
-          field = {:name => get_element_name(item).snakecase.to_sym,
+          name = get_element_name(item)
+          original_name = get_original_name_if_needed(name)
+          field = {
+              :name => name.snakecase.to_sym,
+              :original_name => original_name,
               :type => item.attribute('type').to_s.gsub(/^.+:/, ''),
               :min_occurs => attribute_to_int(item.attribute('minOccurs')),
               :max_occurs => attribute_to_int(item.attribute('maxOccurs'))}
@@ -216,6 +220,13 @@ module AdsCommon
         return fields
       end
 
+      # Returns original name if it can not be back-converted and required for
+      # XML serialization.
+      def get_original_name_if_needed(name)
+        return (name.nil? || (name.snakecase.lower_camelcase == name)) ?
+            nil : name
+      end
+
       # Simple converter for int values.
       def attribute_to_int(attribute)
         return nil if attribute.nil?

data/lib/ads_common/parameters_validator.rb

@@ -63,6 +63,11 @@ module AdsCommon
         item = args_hash[key]
         check_required_argument_present(item, field)
         if item
+          original_name = field[:original_name]
+          if original_name
+            key = handle_name_override(args_hash, key, original_name)
+          end
+
           item_type = get_full_type_signature(field[:type])
           item_ns = field[:ns] || type_ns
           key = handle_namespace_override(args_hash, key, item_ns) if item_ns
@@ -108,6 +113,13 @@ module AdsCommon
       end
     end
 
+    # Overrides non-standard name conversion.
+    def handle_name_override(args, key, original_name)
+      rename_hash_key(args, key, original_name)
+      replace_array_item(args[:order!], key, original_name)
+      return original_name
+    end
+
     # Overrides non-default namespace if requested.
     def handle_namespace_override(args, key, ns)
       add_extra_namespace(ns)
@@ -125,7 +137,8 @@ module AdsCommon
         when Hash
           validate_hash_arg(arg, parent, key, arg_type)
         when Time
-          validate_time_arg(arg, parent, key)
+          arg = validate_time_arg(arg, parent, key)
+          validate_hash_arg(arg, parent, key, arg_type)
         else
           arg
       end

data/lib/ads_common/version.rb

@@ -21,6 +21,6 @@
 
 module AdsCommon
   module ApiConfig
-    CLIENT_LIB_VERSION = '0.9.0'
+    CLIENT_LIB_VERSION = '0.9.1'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-common
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-08 00:00:00.000000000 Z
+date: 2013-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon