google-ads-common 0.14.0 → 0.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3267da5cdfdc5eef0f5653e99c6bd8329addb03f
-  data.tar.gz: 06334b9e716c913d333d49089f30fd2fc2158823
+  metadata.gz: 991111457e7120b976a506c037b0fd935aa5c6f9
+  data.tar.gz: 0a769071c1c36367d1b5f484290584f43401bf72
 SHA512:
-  metadata.gz: c1a6a5e280a2897d4443224111473de8f75a7db7550c9372364038418321c475473b50149e4d4f829e7be5f8b32445ed719fbdf39db8fa2b73df8ee57f4a9758
-  data.tar.gz: 9b1612f9cc4b39666296a48be14960801773d401763dceaaee115193b21531bb6462d3a788c43dad93b724cd4c4ca0c57929e3dc0154583309fc10d3a3b1c93a
+  metadata.gz: 95974d42f490a7b4395089032f09afd8e570289831120fd51a95cad0fec249150e0a89a26cf4dbfe5286cd886c622ab9ba6f4ff695a74c403ee61e3cfda8a19f
+  data.tar.gz: 3bcc749b38ab140d2b994bdd2ae01bbf13a34947574412f49498b64f5c83d488bd355503bc399c5b76e49106d048e218099d0132e49a64afc8baa32973062a2b

data/ChangeLog

@@ -1,3 +1,6 @@
+0.14.1:
+  - Scrubbing an additional sensitive field present in some AdWords requests.
+
 0.14.0:
   - Standardizing logging format for requests, response, and summary.
 

data/lib/ads_common/savon_service.rb

@@ -220,8 +220,11 @@ module AdsCommon
 
     # Sanitize the request body, redacting sensitive information.
     def sanitize_request(body)
-      body.gsub(/developerToken>[a-zA-Z0-9_\-]+<\//,
+      body = body.gsub(/developerToken>[^<]+<\//,
           'developerToken>REDACTED</')
+      body = body.gsub(/httpAuthorizationHeader>[^<]+<\//,
+          'httpAuthorizationHeader>REDACTED</')
+      return body
     end
 
     # Format the fault message by capping length and removing newlines.

data/lib/ads_common/version.rb

@@ -19,6 +19,6 @@
 
 module AdsCommon
   module ApiConfig
-    CLIENT_LIB_VERSION = '0.14.0'
+    CLIENT_LIB_VERSION = '0.14.1'
   end
 end

data/test/test_savon_service.rb

@@ -90,9 +90,14 @@ class TestSavonService < Test::Unit::TestCase
     test2 = "<xml><element1></element1><element2></element2></xml>"
     test3 = "<xml><ns1:developerToken>w-x_Y-Z_</ns1:developerToken></xml>"
     expected3 = "<xml><ns1:developerToken>REDACTED</ns1:developerToken></xml>"
+    test4 = "<xml><httpAuthorizationHeader>Authorization: Bearer " +
+        "1/abcdEFGH1234</httpAuthorizationHeader></xml>"
+    expected4 = "<xml><httpAuthorizationHeader>REDACTED" +
+        "</httpAuthorizationHeader></xml>"
     assert_equal(expected1, @stub_service.sanitize_request(test1))
     assert_equal(test2, @stub_service.sanitize_request(test2))
     assert_equal(expected3, @stub_service.sanitize_request(test3))
+    assert_equal(expected4, @stub_service.sanitize_request(test4))
   end
 
   def test_format_fault()

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: google-ads-common
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.14.1
 platform: ruby
 authors:
 - Sergio Gomes
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-24 00:00:00.000000000 Z
+date: 2017-06-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: google-ads-savon