goodreads 0.4.3 → 0.5.0

data/spec/goodreads_spec.rb

@@ -1,54 +1,54 @@
-require 'spec_helper'
+require "spec_helper"
 
-describe 'Goodreads' do
-  describe '.new' do
-    it 'returns a new client instance' do
-      Goodreads.new.should be_a Goodreads::Client
+describe "Goodreads" do
+  describe ".new" do
+    it "returns a new client instance" do
+      expect(Goodreads.new).to be_a(Goodreads::Client)
     end
   end
 
-  describe '.configure' do
-    it 'sets a global configuration options' do
-      r = Goodreads.configure(:api_key => 'FOO', :api_secret => 'BAR')
-      r.should be_a Hash
-      r.should have_key(:api_key)
-      r.should have_key(:api_secret)
-      r[:api_key].should eql('FOO')
-      r[:api_secret].should eql('BAR')
+  describe ".configure" do
+    it "sets a global configuration options" do
+      config = Goodreads.configure(api_key: "FOO", api_secret: "BAR")
+      expect(config).to be_a(Hash)
+      expect(config).to have_key(:api_key)
+      expect(config).to have_key(:api_secret)
+      expect(config[:api_key]).to eql("FOO")
+      expect(config[:api_secret]).to eql("BAR")
     end
 
-    it 'raises ConfigurationError on invalid config parameter' do
-      proc { Goodreads.configure(nil) }.
-        should raise_error(ArgumentError, "Options hash required.")
+    it "raises ConfigurationError on invalid config parameter" do
+      expect { Goodreads.configure(nil) }
+        .to raise_error(ArgumentError, "Options hash required.")
 
-      proc { Goodreads.configure('foo') }.
-        should raise_error ArgumentError, "Options hash required."
+      expect { Goodreads.configure("foo") }
+        .to raise_error(ArgumentError, "Options hash required.")
     end
   end
 
-  describe '.configuration' do
+  describe ".configuration" do
     before do
-      Goodreads.configure(:api_key => 'FOO', :api_secret => 'BAR')
+      Goodreads.configure(api_key: "FOO", api_secret: "BAR")
     end
 
-    it 'returns global configuration options' do
-      r = Goodreads.configuration
-      r.should be_a Hash
-      r.should have_key(:api_key)
-      r.should have_key(:api_secret)
-      r[:api_key].should eql('FOO')
-      r[:api_secret].should eql('BAR')
+    it "returns global configuration options" do
+      config = Goodreads.configuration
+      expect(config).to be_a(Hash)
+      expect(config).to have_key(:api_key)
+      expect(config).to have_key(:api_secret)
+      expect(config[:api_key]).to eql("FOO")
+      expect(config[:api_secret]).to eql("BAR")
     end
   end
 
-  describe '.reset_configuration' do
+  describe ".reset_configuration" do
     before do
-      Goodreads.configure(:api_key => 'FOO', :api_secret => 'BAR')
+      Goodreads.configure(api_key: "FOO", api_secret: "BAR")
     end
 
-    it 'resets global configuration options' do
+    it "resets global configuration options" do
       Goodreads.reset_configuration
-      Goodreads.configuration.should eql({})
+      expect(Goodreads.configuration).to eql({})
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,32 +1,32 @@
-$:.unshift File.expand_path("../..", __FILE__)
+$LOAD_PATH.unshift(File.expand_path("../..", __FILE__))
 
-require 'simplecov'
+require "simplecov"
 
 SimpleCov.start do
   add_filter "spec/"
   add_filter ".bundle"
 end
 
-require 'goodreads'
-require 'webmock'
-require 'webmock/rspec'
+require "goodreads"
+require "webmock"
+require "webmock/rspec"
 
 def stub_get(path, params, fixture_name)
-  params[:format] = 'xml'
-  stub_request(:get, api_url(path)).
-    with(:query => params).
-    to_return(
-      :status => 200,
-      :body => fixture(fixture_name)
+  params[:format] = "xml"
+  stub_request(:get, api_url(path))
+    .with(query: params)
+    .to_return(
+      status: 200,
+      body: fixture(fixture_name)
     )
 end
 
 def stub_with_key_get(path, params, fixture_name)
-  params[:key] = 'SECRET_KEY'
+  params[:key] = "SECRET_KEY"
   stub_get(path, params, fixture_name)
 end
 
-def fixture_path(file=nil)
+def fixture_path(file = nil)
   path = File.expand_path("../fixtures", __FILE__)
   file.nil? ? path : File.join(path, file)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: goodreads
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.5.0
 platform: ruby
 authors:
 - Dan Sosedoff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-11 00:00:00.000000000 Z
+date: 2017-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: webmock
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
@@ -159,6 +159,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE
@@ -219,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Goodreads API wrapper
@@ -244,4 +245,3 @@ test_files:
 - spec/fixtures/user.xml
 - spec/goodreads_spec.rb
 - spec/spec_helper.rb
-has_rdoc: