gooddata_datawarehouse 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e6c19b17e345eb5ea10f389067f689544bc49ce1
-  data.tar.gz: 2d7bae04776af43c98eccd798352954d5678e7e2
+  metadata.gz: 7f98f560684ad94b0c65263eb0b8bb39748d3fe8
+  data.tar.gz: 5626327514feed7e85f5541871100b3e28373c0d
 SHA512:
-  metadata.gz: 926f231df825fdb1077d270a8944a9d2631d10f1ca15b1ee4d5a19fb31505a2325088872ff1a6a56b4598e197d90a7410cfaf15685fa0506e372e3829fb9839f
-  data.tar.gz: 20505562823f04ffb717260115bff12dd649ae0a81331012793fc370de1bc05e37ec73a6fbf7f7040d119e4576ccfc4bb7e8be5cf343bd720327f333949cdd9f
+  metadata.gz: 52e171a5c74e80cc056020263d98fe3ca25a28952d7a3ac338356de34003944279ca427370002589d9fb2ad21bdbe32679732f28b19ca2e1c66482e6996fd175
+  data.tar.gz: f285e427b6f9216cd578a9fa9f8ebf32d4a2769a62ed4bb1b03c4ea452009d36b91320463519524e9d97a1aece663155b4f45e731bd84af5f29c4893b41d1f0a

data/lib/gooddata_datawarehouse/datawarehouse.rb

@@ -65,8 +65,8 @@ module GoodData
         # temporary files to get the excepted records (if not given)
         exc = opts[:exceptions_file] ||= Tempfile.new('exceptions')
         rej = opts[:rejections_file] ||= Tempfile.new('rejections')
-        exc = File.new(exc) unless exc.is_a?(File)
-        rej = File.new(rej) unless rej.is_a?(File)
+        exc = File.new(exc, 'w') unless exc.is_a?(File)
+        rej = File.new(rej, 'w') unless rej.is_a?(File)
       end
 
       # execute the load

data/lib/gooddata_datawarehouse/version.rb

@@ -1,5 +1,5 @@
 module GoodData
   class Datawarehouse
-    VERSION = "0.0.4"
+    VERSION = "0.0.5"
   end
 end

data/spec/datawarehouse_spec.rb

@@ -172,6 +172,22 @@ describe GoodData::Datawarehouse do
       expected_cols = File.open(CSV_PATH, &:gets).strip.split(',')
       expect(Set.new(@dwh.get_columns(@random_table_name))).to eq Set.new(expected_cols.map {|c| {:column_name => c, :data_type => GoodData::SQLGenerator::DEFAULT_TYPE}})
     end
+
+    it "works with non-existing files" do
+      t = Tempfile.new('haha')
+      d = File.dirname(t)
+
+      rej = File.join(d, @random_table_name + '_rej')
+      exc = File.join(d, @random_table_name + '_exc')
+
+      expect(File.exists?(rej)).to be false
+      expect(File.exists?(exc)).to be false
+
+      @dwh.csv_to_new_table(@random_table_name, WRONG_CSV_PATH, :exceptions_file => exc, :rejections_file => rej, :ignore_parse_errors => true)
+
+      expect(File.size(rej)).to be > 0
+      expect(File.size(exc)).to be > 0
+    end
   end
 
   describe '#export_table' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gooddata_datawarehouse
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Petr Cvengros