gooddata 2.1.19 → 2.3.0

data/lib/gooddata/lcm/lcm2.rb

@@ -17,6 +17,7 @@ require_relative 'actions/actions'
 require_relative 'dsl/dsl'
 require_relative 'helpers/helpers'
 require_relative 'exceptions/lcm_execution_error'
+require_relative 'exceptions/lcm_execution_warning'
 
 using TrueExtensions
 using FalseExtensions
@@ -96,10 +97,14 @@ module GoodData
         CollectComputedAttributeMetrics,
         ImportObjectCollections,
         SynchronizeComputedAttributes,
+        SynchronizeDataSetMapping,
+        SynchronizeLdmLayout,
         SynchronizeProcesses,
         SynchronizeSchedules,
         SynchronizeColorPalette,
         SynchronizeUserGroups,
+        SynchronizePPDashboardPermissions,
+        SynchronizeKDDashboardPermissions,
         SynchronizeNewSegments,
         UpdateReleaseTable
       ],
@@ -121,11 +126,19 @@ module GoodData
         CollectClients,
         AssociateClients,
         RenameExistingClientProjects,
+        InitializeContinueOnErrorOption,
         ProvisionClients,
+        UpdateMetricFormats,
         EnsureTechnicalUsersDomain,
         EnsureTechnicalUsersProject,
         CollectDymanicScheduleParams,
-        SynchronizeETLsInSegment
+        SynchronizeDataSetMapping,
+        SynchronizeLdmLayout,
+        SynchronizeUserGroups,
+        SynchronizePPDashboardPermissions,
+        SynchronizeKDDashboardPermissions,
+        SynchronizeETLsInSegment,
+        CollectProjectsWarningStatus
       ],
 
       rollout: [
@@ -135,12 +148,20 @@ module GoodData
         CollectSegmentClients,
         EnsureTechnicalUsersDomain,
         EnsureTechnicalUsersProject,
+        InitializeContinueOnErrorOption,
         SynchronizeLdm,
+        SynchronizeDataSetMapping,
+        SynchronizeLdmLayout,
         MigrateGdcDateDimension,
         SynchronizeClients,
+        SynchronizeUserGroups,
+        SynchronizePPDashboardPermissions,
+        SynchronizeKDDashboardPermissions,
+        UpdateMetricFormats,
         SynchronizeComputedAttributes,
         CollectDymanicScheduleParams,
-        SynchronizeETLsInSegment
+        SynchronizeETLsInSegment,
+        CollectProjectsWarningStatus
       ],
 
       users: [
@@ -335,7 +356,7 @@ module GoodData
           # Invoke action
           begin
             out = run_action action, params
-          rescue Exception => e # rubocop:disable RescueException
+          rescue Exception => e # rubocop:disable Style/RescueException
             errors << {
               action: action,
               err: e,
@@ -357,7 +378,7 @@ module GoodData
           params.merge!(new_params)
 
           # Print action result
-          print_action_result(action, res)
+          print_action_result(action, res) if action.send(:print_result, params)
 
           # Store result for final summary
           results << res
@@ -384,9 +405,28 @@ module GoodData
           end
         end
 
+        process_sync_failed_projects(params) if GoodData::LCM2::Helpers.collect_synced_status(params) && strict_mode
+
         result
       end
 
+      def process_sync_failed_projects(params)
+        sync_failed_list = params[:sync_failed_list]
+        sync_project_list = sync_failed_list[:project_client_mappings]
+        sync_failed_project_list = sync_failed_list[:failed_detailed_projects]
+
+        if sync_project_list && sync_failed_project_list && sync_project_list.size.positive? && sync_failed_project_list.size.positive?
+          failed_project = sync_failed_project_list[0]
+          summary_message = "Existing errors during execution. See log for details"
+          error_message = failed_project[:message]
+          if sync_project_list.size == sync_failed_project_list.size
+            raise GoodData::LcmExecutionError.new(summary_message, error_message)
+          else
+            raise GoodData::LcmExecutionWarning.new(summary_message, error_message)
+          end
+        end
+      end
+
       def run_action(action, params)
         begin
           GoodData.gd_logger.start_action action, GoodData.gd_logger
@@ -396,6 +436,12 @@ module GoodData
           BaseAction.check_params(action.const_get('PARAMS'), params)
           params.setup_filters(action.const_get('PARAMS'))
           out = action.send(:call, params)
+        rescue Exception => e # rubocop:disable Style/RescueException
+          # Log to splunk
+          GoodData.gd_logger.error("action=#{action} status=failed message=#{e} exception=#{e.backtrace}")
+          # Log to execution log
+          GoodData.logger.error("Execution #{action} failed. Error: #{e}. Detail:#{e.backtrace}")
+          raise e
         ensure
           params.clear_filters
           GoodData.gd_logger.end_action GoodData.gd_logger

data/lib/gooddata/lcm/user_bricks_helper.rb

@@ -26,6 +26,15 @@ module GoodData
 
           goodot_id.empty? ? client.id : goodot_id
         end
+
+        def non_working_clients(domain_clients, working_client_ids)
+          non_working_clients = []
+          domain_clients.each do |c|
+            non_working_clients << c unless working_client_ids.include?(c.client_id.to_s)
+          end
+
+          non_working_clients
+        end
       end
     end
   end

data/lib/gooddata/mixins/inspector.rb

@@ -10,7 +10,7 @@ module GoodData
   module Mixin
     # When an RSpec test like this fails,
     #
-    #   @my_array.should == [@some_model, @some_model2]
+    #   expect(@my_array).to == [@some_model, @some_model2]
     #
     # RSpec will call inspect on each of the objects to "help" you figure out
     # what went wrong. Well, inspect will usually dump a TON OF SHIT and make trying

data/lib/gooddata/mixins/md_object_query.rb

@@ -54,6 +54,7 @@ module GoodData
               y << (klass ? client.create(klass, item, project: project) : item)
             end
             break if result['objects']['paging']['count'] < page_limit
+
             offset += page_limit
           end
         end

data/lib/gooddata/models/data_source.rb

@@ -34,7 +34,7 @@ module GoodData
             c.create(DataSource, ds_data)
           end
         else
-          c.create(DataSource, c.get("#{DATA_SOURCES_URL}/#{id}"))
+          c.create(DataSource, c.get(DATA_SOURCES_URL + '/' + id))
         end
       end
 
@@ -177,6 +177,10 @@ module GoodData
       @json['dataSource']['connectionInfo'][type]
     end
 
+    def type
+      @json['dataSource']['connectionInfo'].first[0].upcase
+    end
+
     private
 
     def build_connection_info

data/lib/gooddata/models/dataset_mapping.rb

@@ -0,0 +1,36 @@
+# encoding: UTF-8
+# frozen_string_literal: true
+#
+# Copyright (c) 2010-2021 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+module GoodData
+  class DatasetMapping
+    DATASET_MAPPING_GET_URI = '/gdc/dataload/projects/%<project_id>s/modelMapping/datasets'
+    DATASET_MAPPING_UPDATE_URI = '/gdc/dataload/projects/%<project_id>s/modelMapping/datasets/bulk/upsert'
+
+    class << self
+      def [](opts = { :client => GoodData.connection, :project => GoodData.project })
+        client, project = GoodData.get_client_and_project(opts)
+        get_uri = DATASET_MAPPING_GET_URI % { project_id: project.pid }
+        res = client.get(get_uri)
+        res
+      end
+
+      alias_method :get, :[]
+    end
+
+    def initialize(data)
+      @data = data
+    end
+
+    def save(opts)
+      client, project = GoodData.get_client_and_project(opts)
+
+      post_uri = DATASET_MAPPING_UPDATE_URI % { project_id: project.pid }
+      res = client.post(post_uri, @data, opts)
+      res
+    end
+  end
+end

data/lib/gooddata/models/ldm_layout.rb

@@ -0,0 +1,38 @@
+# encoding: UTF-8
+# frozen_string_literal: true
+#
+# Copyright (c) 2022 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+module GoodData
+  class LdmLayout
+    DEFAULT_EMPTY_LDM_LAYOUT = {
+      "ldmLayout" => {
+        "layout" => []
+      }
+    }
+
+    LDM_LAYOUT_URI = '/gdc/dataload/internal/projects/%<project_id>s/ldmLayout'
+
+    class << self
+      def get(opts = { :client => GoodData.connection, :project => GoodData.project })
+        client, project = GoodData.get_client_and_project(opts)
+        get_uri = LDM_LAYOUT_URI % { project_id: project.pid }
+
+        client.get(get_uri)
+      end
+    end
+
+    def initialize(data)
+      @data = data
+    end
+
+    def save(opts)
+      client, project = GoodData.get_client_and_project(opts)
+      post_uri = LDM_LAYOUT_URI % { project_id: project.pid }
+
+      client.post(post_uri, @data, opts)
+    end
+  end
+end

data/lib/gooddata/models/metadata/label.rb

@@ -40,22 +40,20 @@ module GoodData
       end
     end
 
-    # Gets valid elements using /validElements? API
+    # Gets valid elements of a label for a specific paging (:offset and :limit) or get validElements of a specific value (:filter).
+    # In the case filter a specific value, because the API /validElements only filter by partial match, we need to filter again at client side for exact match.
     # @return [Array] Results
     def get_valid_elements(*args)
-      results, params = valid_elements(*args)
-      # TMA-775 - the validElements API can possibly return more matches than requested (usually 1)
-      # so we do a preliminary first request to check and then increase the limit if needed
-      if results['validElements']['paging']['total'].to_i != params[:limit]
+      if args && !args.empty? && args.first[:filter]
+        params = args.first
         params[:limit] = 100_000
         results, = valid_elements params
-        if params[:filter]
-          results['validElements']['items'] = results['validElements']['items'].reject do |i|
-            i['element']['title'] != params[:filter]
-          end
+        results['validElements']['items'] = results['validElements']['items'].select do |i|
+          i['element']['title'] == params[:filter]
         end
+      else
+        results, = valid_elements(*args)
       end
-
       results
     end
 
@@ -74,24 +72,25 @@ module GoodData
     # @option options [Number] :limit limits the number of values to certain number. Default is 100
     # @return [Array]
     def values(options = {})
-      Enumerator.new do |y|
-        offset = options[:offset] || 0
-        page_limit = options[:limit] || 100
-        loop do
-          results = get_valid_elements(limit: page_limit, offset: offset)
-
-          elements = results['validElements']
-          elements['items'].map do |el|
-            v = el['element']
-            y << {
-              :value => v['title'],
-              :uri => v['uri']
-            }
-          end
-          break if elements['items'].count < page_limit
-          offset += page_limit
+      all_values = []
+      offset = options[:offset] || 0
+      page_limit = options[:limit] || 100
+      loop do
+        results = get_valid_elements(limit: page_limit, offset: offset)
+
+        elements = results['validElements']
+        elements['items'].map do |el|
+          v = el['element']
+          all_values << {
+            :value => v['title'],
+            :uri => v['uri']
+          }
         end
+        break if elements['items'].count < page_limit
+
+        offset += page_limit
       end
+      all_values
     end
 
     def values_count
@@ -136,7 +135,7 @@ module GoodData
       if status_url
         results = client.poll_on_response(status_url) do |body|
           status = body['taskState'] && body['taskState']['status']
-          status == 'RUNNING' || status == 'PREPARED'
+          status == 'RUNNING' || status == 'PREPARED' || body['uri']
         end
       end