gooddata 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 78388b62f10692bc8416395774aad6f3d4020b39
-  data.tar.gz: 925461dba225f4b742734c96a423fec33fca818a
+  metadata.gz: e42a132c41968e4869171cd83833ddd435d003f0
+  data.tar.gz: 5f57d656cdac4d45901f36a621b57404e109f80e
 SHA512:
-  metadata.gz: 4c50cccdecccfd33eb03bbd40e9d129e413d2a02a3ba5ee96f4a0e76c16f4007747fa697e6065480875d283f5f5169b3d21ccd920ca0880049d50fbd27030baf
-  data.tar.gz: ec7eb3f19ed6cad1915eb30133305ea2c97f052d5dfd1bd8a6f9897ebbd069c565d68d250cf518ee35ac6450edf283e33cd76811e4fd59ba94670bcf8bcfd2c4
+  metadata.gz: c5c2cceaded37c876c3dafcf0999027aed0f2aeb9a8dd8620b99ff913b5c03d5facdfd3af81e4002ff87ada7d9f1dcb25230e566711ebf17d145178a2d885059
+  data.tar.gz: cf6c751bffac63afc799a6ac24ee3698417ec247067ea6c72db8db3916dd2cefc83c6b9b99de62ad23003ae3c55c758aef8ace3d08f31083ba1c9946bf4a1c84

data/.gitignore

@@ -41,3 +41,6 @@ junit.xml
 # autogenerated file
 deprecations.txt
 .vscode/settings.json
+
+# test cache files
+./spec/cache/

data/.rubocop.yml

@@ -90,9 +90,6 @@ SignalException:
 TimesMap:
   Enabled: false
 
-UnneededDisable:
-  Enabled: false
-
 UnneededInterpolation:
   Enabled: false
 

data/.travis.yml

@@ -1,26 +1,36 @@
 language: ruby
 cache: bundler
 stages:
-  - unit
-  - name: integration
-    if: type = api
+- unit
+- name: integration
+  if: type IN (api, cron)
 jobs:
   include:
-    - stage: unit
-      script: bundle exec rake test:unit
-      rvm:
-        - 2.2
-        - jruby-9.1.7
-    - stage: integration
-      script: |
-              bundle exec rake -f lcm.rake docker:build
-              bundle exec rake -f lcm.rake docker:bundle
-              bundle exec rake -f lcm.rake test:integration:docker
-      rvm:
-        - jruby-9.1.7
-    - stage: integration
-      script: bundle exec rake test:sdk
-      rvm: jruby-9.1.7
-    - stage: integration
-      script: bundle exec rake test:project
-      rvm: jruby-9.1.7
+  - stage: unit
+    name: unit tests
+    script: bundle exec rake test:unit
+    rvm:
+    - 2.3
+    - jruby-9.1.7
+  - stage: unit
+    name: pronto code review
+    script: |
+      git remote add upstream https://github.com/gooddata/gooddata-ruby.git
+      git fetch upstream master
+      bundle exec pronto run -c upstream/master --exit-code
+  - stage: integration
+    name: lcm integration tests
+    script: |
+      bundle exec rake -f lcm.rake docker:build
+      bundle exec rake -f lcm.rake docker:bundle
+      bundle exec rake -f lcm.rake test:integration:docker
+    rvm:
+    - jruby-9.1.7
+  - stage: integration
+    name: sdk integration tests
+    script: bundle exec rake test:sdk
+    rvm: jruby-9.1.7
+  - stage: integration
+    name: sdk integration tests (project)
+    script: bundle exec rake test:project
+    rvm: jruby-9.1.7

data/CHANGELOG.md

@@ -1,4 +1,32 @@
 # GoodData Ruby SDK Changelog
+## 1.3.2
+ - Add rake task for changelog preview
+ - added possibility to run tests on PI
+ - TMA-1025: Parametrize output stage prefix
+ - TMA-1002 fix test run and added abbility to recover from mandatory projects delete
+ - Remove secret from .travis.yml
+ - Dont swallow error in .decrypt
+ - Properly escape secret in .travis.yml
+ - Update ruby in .travis.yml to 2.3
+ - Fix travis secret
+ - FEATURE: TMA-1034 Create image build pipeline
+ - TMA-1033: report pid in case of UFB failure
+ - Name travis build stages
+ - TMA-801: Update rubocop
+ - FEATURE: TMA-1052 Create execution script for each brick
+ - TMA-1081: fail UFB when multiple_project mode column is missing from UB input
+ - Enable running tests using cron in travis
+ - Reduce log size
+ - Set $HOME to writable directory
+ - Run pronto in travis
+ - TRIVIAL: Correct Ruby version used in brick Dockerfile
+ - FEATURE: TMA-1052 Change parameters passing
+ - TMA-1078: Generate stronger passwords
+ - Set correct default password
+ - TMA-986 fix random user selection in user filters test
+ - TMA-1005: Rotate test user password
+ - TMA-1005: Add description for rake password:rotate
+
 ## 1.3.1
  - FEATURE: TMA-1030 Raise jruby version used in K8s docker image (#1284)
  - Update README.md

data/CONTRIBUTING.md

@@ -19,6 +19,9 @@ describe 'New integration test', :vcr
 The VCR `record` mode can be set via `VCR_RECORD_MODE` environment variable. Set it to `all` to make a new recording.
 Please check the recorded payloads for possible sensitive data before submitting to github.
 
+#### PI test setup 
+If you are so lucky and have acces to PI, you can run the test agains it ... there is guide in [confluence](https://confluence.intgdc.com/display/SCRUM/Running+Tests+on+PI)
+
 ## Static analysis
 We use [Pronto](https://github.com/prontolabs/pronto) to detect code smells using static analysis. Comments are automatically created on pull requests when code smells are found.
 

data/Dockerfile

@@ -1,11 +1,11 @@
 FROM harbor.intgdc.com/tools/gdc-java-8-jre:b057b53
 
-MAINTAINER LCM <lcm@gooddata.com>
-
+ARG GIT_COMMIT=unspecified
 LABEL image_name="GDC LCM Bricks"
 LABEL maintainer="LCM <lcm@gooddata.com>"
-LABEL git_repostiory_url="https://github.com/gooddata/gooddata-ruby/"
+LABEL git_repository_url="https://github.com/gooddata/gooddata-ruby/"
 LABEL parent_image="harbor.intgdc.com/tools/gdc-java-8-jre:b057b53"
+LABEL git_commit=$GIT_COMMIT
 
 # which is required by RVM
 RUN yum install -y curl which \
@@ -13,17 +13,17 @@ RUN yum install -y curl which \
     && rm -rf /var/cache/yum
 
 RUN gpg --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3 7D2BAF1CF37B13E2069D6956105BD0E739499BDB
-RUN curl -sSL https://get.rvm.io | bash -s stable --ruby=jruby-9.1.14
+RUN curl -sSL https://get.rvm.io | bash -s stable --ruby=jruby-9.1.14.0
 
 # Switch to directory with sources
 WORKDIR /src
+ENV HOME=/src
 
 # login shell is required by rvm
 RUN /bin/bash -l -c ". /usr/local/rvm/scripts/rvm && gem update --system \
     && gem install bundler rake"
 
-ARG SOURCE_COMMIT
-ENV GOODDATA_RUBY_COMMIT=$SOURCE_COMMIT
+ENV GOODDATA_RUBY_COMMIT=$GIT_COMMIT
 
 ADD ./bin ./bin
 ADD ./lib ./lib
@@ -32,6 +32,4 @@ ADD ./gooddata.gemspec .
 
 RUN /bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle install"
 
-ENTRYPOINT ["/bin/bash", "-l", "-c"]
-
-CMD [ ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb" ]
+CMD [ "./bin/hello_world.sh" ]

data/Dockerfile.jruby

@@ -6,6 +6,7 @@ RUN apk add --no-cache curl make gcc git g++ python linux-headers binutils-gold
 
 # Switch to directory with sources
 WORKDIR /src
+ENV HOME=/src
 
 RUN gem update --system \
     && gem install bundler

data/Jenkinsfile

@@ -0,0 +1,18 @@
+/*
+ * Copyright (C) 2007-2018, GoodData(R) Corporation. All rights reserved.
+ */
+
+@Library('pipelines-shared-libs')
+import com.gooddata.pipeline.Pipeline
+
+def config = [
+        'microservices': [
+                'lcm-bricks': [
+                        'docker': [
+                                'dockerfile': './Dockerfile'
+                        ]
+                ]
+        ]
+]
+
+Pipeline.get(this, config).run()

data/Rakefile

@@ -145,23 +145,34 @@ end
 
 # Updates the changelog with commit messages
 def update_changelog(new_version)
-  changelog = File.read('CHANGELOG.md')
-  changelog_header = '# GoodData Ruby SDK Changelog'
-  changelog.slice! changelog_header
+  changelog = headless_changelog
   fail 'the version is already mentioned in the changelog' if changelog =~ /## #{new_version}/
   puts "Creating changelog for version #{new_version}"
-  current_commit = `git rev-parse HEAD`.chomp
-  last_release = changelog.split("\n").reject(&:empty?).first.delete('## ').chomp
-  last_release_commit = `git rev-parse #{last_release}`.chomp
-  changes = `git log --format=%s --no-merges #{last_release_commit}..#{current_commit}`.split("\n").reject(&:empty?)
   File.open('CHANGELOG.md', 'w+') do |file|
     file.puts changelog_header + "\n"
     file.puts "## #{new_version}"
-    changes.each { |change| file.puts ' - ' + change }
+    changes(changelog).each { |change| file.puts ' - ' + change }
     file.puts changelog
   end
 end
 
+def changes(changelog)
+  current_commit = `git rev-parse HEAD`.chomp
+  last_release = changelog.split("\n").reject(&:empty?).first.delete('## ').chomp
+  last_release_commit = `git rev-parse #{last_release}`.chomp
+  `git log --format=%s --no-merges #{last_release_commit}..#{current_commit}`.split("\n").reject(&:empty?)
+end
+
+def headless_changelog
+  changelog = File.read('CHANGELOG.md')
+  changelog.slice! changelog_header
+  changelog
+end
+
+def changelog_header
+  '# GoodData Ruby SDK Changelog'
+end
+
 namespace :version do
   desc 'Updates the changelog, commits and tags the bump'
   task :bump do
@@ -172,6 +183,11 @@ namespace :version do
     `git commit -m "Bump version to #{new_version}"`
     `git tag #{new_version}`
   end
+
+  desc 'Shows changes since last release'
+  task :changelog do
+    puts changes(headless_changelog)
+  end
 end
 
 RSpec::Core::RakeTask.new(:test)
@@ -226,6 +242,7 @@ namespace :gitflow do
   end
 end
 
+desc 'Rotates the password of the test domain admin'
 namespace :password do
   task :rotate, [:value, :encryption_key] do |_, args|
     key = 'password'

data/bin/hello_world.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+/bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb hello_world_brick"

data/bin/provisioning.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+/bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb provisioning_brick"

data/bin/release.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+/bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb release_brick"

data/bin/rollout.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+/bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb rollout_brick"

data/bin/run_brick.rb

@@ -4,22 +4,22 @@ require 'remote_syslog_logger'
 require_relative '../lib/gooddata'
 
 DEFAULT_BRICK = 'hello_world_brick'
+BRICK_PARAM_PREFIX = 'BRICK_PARAM_'
 
-brick_type = ENV['BRICK_TYPE'] || DEFAULT_BRICK
+brick_type = !ARGV.empty? ? ARGV[0] : DEFAULT_BRICK
 
 syslog_node = ENV['NODE_NAME']
 log = RemoteSyslogLogger.new(syslog_node, 514, :program => brick_type)
 
-log.info "action=#{brick_type}_execution status=start"
+log.info "action=#{brick_type}_execution status=init"
 
 begin
   brick_pipeline = GoodData::Bricks::Pipeline.send("#{brick_type}_pipeline")
-  params_json = ENV['BRICK_PARAMS_JSON']
-  params = params_json.nil? ? {} : JSON.parse(params_json)
-
-  params['gooddata_ruby_commit'] = ENV['GOODDATA_RUBY_COMMIT'] || '<unknown>'
+  params = ENV.select { |k,| k.to_s.match(/^#{BRICK_PARAM_PREFIX}.*/) }.map { |k, v| [k.slice(BRICK_PARAM_PREFIX.length..-1), v] }.to_h
+  commit_hash = ENV['GOODDATA_RUBY_COMMIT'] || ''
+  params['gooddata_ruby_commit'] = commit_hash
   params['log_directory'] = ENV['LOG_DIRECTORY'] || '/tmp/'
-
+  log.info "action=#{brick_type}_execution status=start commit_hash=#{commit_hash}"
   @brick_result = brick_pipeline.call(params)
   log.info "action=#{brick_type}_execution status=finished"
 rescue NoMethodError => e

data/bin/user_filters.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+/bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb user_filters_brick"

data/bin/users.sh

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+/bin/bash -l -c ". /usr/local/rvm/scripts/rvm && bundle exec ./bin/run_brick.rb users_brick"

data/gooddata.gemspec

@@ -35,7 +35,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rspec', '~> 3.5'
   s.add_development_dependency 'rspec-expectations', '~> 3.5'
   s.add_development_dependency 'rspec_junit_formatter', '~> 0.3.0'
-  s.add_development_dependency 'rubocop', '< 0.48' # TODO: remove it after dealing with new rules introduced in 0.48 version
+  s.add_development_dependency 'rubocop', '~> 0.59.1'
   s.add_development_dependency 'simplecov', '~> 0.12'
   s.add_development_dependency 'webmock', '~> 2.3.1'
   s.add_development_dependency 'yard', '~> 0.9.11'

data/lib/gooddata/commands/process.rb

@@ -56,7 +56,7 @@ module GoodData
           verbose = options[:v]
           dir = Pathname(dir)
           name = options[:name] || "Temporary deploy[#{dir}][#{options[:project_name]}]"
-          GoodData::Process.with_deploy(dir, options.merge(:name => name, :project_id => ProjectHelper::PROJECT_ID)) do |process|
+          GoodData::Process.with_deploy(dir, options.merge(:name => name, :project_id => ProjectHelper.project_id(options[:client]))) do |process|
             puts HighLine.color('Executing', HighLine::BOLD) if verbose
             process.execute(executable, options)
           end

data/lib/gooddata/helpers/crypto_helper.rb

@@ -0,0 +1,51 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2018 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'securerandom'
+
+module GoodData
+  module Helpers
+    module CryptoHelper
+      class << self
+        def generate_password
+          sprinkle(SecureRandom.base64(32))
+        end
+
+        private
+
+        # Pseudo-randomly "sprinkles" the given string
+        # with 4 character groups (digit, lower case,
+        # upper case, symbols).
+        # @param [String] password
+        def sprinkle(password)
+          password_dup = password.dup
+          positions = 0..password.size
+          password_dup.insert(rand(positions), digit)
+          password_dup.insert(rand(positions), lower)
+          password_dup.insert(rand(positions), upper)
+          password_dup.insert(rand(positions), symbol)
+          password_dup
+        end
+
+        def digit
+          (0..9).to_a.sample.to_s
+        end
+
+        def lower
+          ('a'..'z').to_a.sample
+        end
+
+        def upper
+          ('A'..'Z').to_a.sample
+        end
+
+        def symbol
+          '!@#$%&/()+?*'.chars.sample
+        end
+      end
+    end
+  end
+end

data/lib/gooddata/helpers/global_helpers.rb

@@ -241,14 +241,8 @@ module GoodData
         random_iv = data[0..15] # extract iv from first 16 bytes
         data = data[16..data.size - 1]
         cipher.iv = Digest::SHA256.digest(random_iv + cipher_key)[0..15]
-        begin
-          decrypted = cipher.update(data)
-          decrypted << cipher.final
-        rescue
-          puts 'Error'
-          return nil
-        end
-
+        decrypted = cipher.update(data)
+        decrypted << cipher.final
         decrypted
       end
     end

data/lib/gooddata/lcm/actions/collect_segments.rb

@@ -35,7 +35,8 @@ module GoodData
         def call(params)
           data_product = params.data_product
           data_product_segments = data_product.segments
-          params.gdc_logger.info("Domain segments: #{data_product_segments}")
+          segment_names = data_product_segments.map(&:segment_id)
+          params.gdc_logger.debug("Domain segments: #{segment_names}")
 
           if params.segments_filter
             params.gdc_logger.info("Segments filter: #{params.segments_filter}")

data/lib/gooddata/lcm/actions/collect_users_brick_users.rb

@@ -21,8 +21,17 @@ module GoodData
 
         description 'Input Source'
         param :input_source, instance_of(Type::HashType), required: false
+
+        description 'Synchronization Mode (e.g. sync_one_project_based_on_pid)'
+        param :sync_mode, instance_of(Type::StringType), required: false, default: 'sync_project'
       end
 
+      MULTIPLE_COLUMN_MODES = %w(
+        sync_domain_client_workspaces
+        sync_multiple_projects_based_on_custom_id
+        sync_multiple_projects_based_on_pid
+      )
+
       class << self
         def call(params)
           users_brick_users = []
@@ -39,12 +48,14 @@ module GoodData
                       headers: true,
                       return_headers: false,
                       encoding: 'utf-8') do |row|
+            pid = row[params.multiple_projects_column]
+            fail "The set multiple_projects_column '#{params.multiple_projects_column}' of the users input is empty" if !pid && MULTIPLE_COLUMN_MODES.include?(params.sync_mode)
+
             users_brick_users << {
-              login: row[login_column],
-              pid: row[params.multiple_projects_column]
+              login: row[login_column].downcase,
+              pid: pid
             }
           end
-
           {
             # TODO; TMA-989 return the real results when print of results is fixed for large sets
             results: [{ status: 'ok' }],

data/lib/gooddata/lcm/actions/create_segment_masters.rb

@@ -68,6 +68,7 @@ module GoodData
             driver = segment_in.driver.downcase
             token = params.tokens[driver.to_sym] || fail("Token for driver '#{driver}' was not specified")
             ads_output_stage_uri = segment_in.ads_output_stage_uri
+            ads_output_stage_prefix = segment_in.ads_output_stage_prefix
 
             # Create master project Postgres
             version = get_project_version(params, segment_id) + 1
@@ -126,6 +127,7 @@ module GoodData
               development_pid: development_pid,
               master_pid: project.pid,
               ads_output_stage_uri: ads_output_stage_uri,
+              ads_output_stage_prefix: ads_output_stage_prefix,
               driver: driver,
               status: status
             }
@@ -134,7 +136,8 @@ module GoodData
               segment: segment_id,
               from: development_pid,
               to: [{ pid: project.pid }],
-              ads_output_stage_uri: ads_output_stage_uri
+              ads_output_stage_uri: ads_output_stage_uri,
+              ads_output_stage_prefix: ads_output_stage_prefix
             }
           end
 

data/lib/gooddata/lcm/actions/synchronize_processes.rb

@@ -55,7 +55,12 @@ module GoodData
               to_project = client.projects(pid) || fail("Invalid 'to' project specified - '#{pid}'")
 
               params.gdc_logger.info "Transferring processes, from project: '#{from.title}', PID: '#{from.pid}', to project: '#{to_project.title}', PID: '#{to_project.pid}'"
-              res = GoodData::Project.transfer_processes(from, to_project, ads_output_stage_uri: info.ads_output_stage_uri)
+              res = GoodData::Project.transfer_processes(
+                from,
+                to_project,
+                ads_output_stage_uri: info.ads_output_stage_uri,
+                ads_output_stage_prefix: info.ads_output_stage_prefix
+              )
 
               to_project.add.output_stage.client_id = client_id if client_id && to_project.add.output_stage
 

data/lib/gooddata/lcm/actions/synchronize_user_filters.rb

@@ -78,9 +78,7 @@ module GoodData
 
       class << self
         MODES = %w(
-          add_to_organization
           sync_project
-          sync_domain_and_project
           sync_multiple_projects_based_on_pid
           sync_one_project_based_on_pid
           sync_one_project_based_on_custom_id

data/lib/gooddata/lcm/types/complex/segment.rb

@@ -29,6 +29,12 @@ module GoodData
 
           description 'Production Tag Names'
           param :production_tags, array_of(instance_of(Type::StringType)), required: false
+
+          description 'Uri of the source output stage. It must be in the same domain as the target project.'
+          param :ads_output_stage_uri, instance_of(Type::StringType), required: false
+
+          description 'Custom prefix for the target output stage.'
+          param :ads_output_stage_prefix, instance_of(Type::StringType), required: false
         end
 
         def check(value)

data/lib/gooddata/lcm/types/complex/synchronization_info.rb

@@ -24,6 +24,9 @@ module GoodData
 
           description 'Uri of the source output stage. It must be in the same domain as the target project.'
           param :ads_output_stage_uri, instance_of(Type::StringType), required: false
+
+          description 'Custom prefix for the target output stage.'
+          param :ads_output_stage_prefix, instance_of(Type::StringType), required: false
         end
 
         def check(value)

data/lib/gooddata/models/domain.rb

@@ -45,7 +45,7 @@ module GoodData
       # @param password [String] Default preset password
       # @return [Object] Raw response
       def add_user(user_data, name = nil, opts = { :client => GoodData.connection })
-        generated_pass = rand(10E10).to_s
+        generated_pass = GoodData::Helpers::CryptoHelper.generate_password
         domain_name = name || user_data[:domain]
         user_data = user_data.to_hash
         data = {
@@ -135,7 +135,6 @@ module GoodData
         user_data = user_data.to_hash if user_data.is_a?(GoodData::Profile)
         client = client(options)
         user_data = user_data.to_hash
-        # generated_pass = rand(10E10).to_s
         data = {
           :firstName => user_data[:first_name] || 'FirstName',
           :lastName => user_data[:last_name] || 'LastName',

data/lib/gooddata/models/project.rb

@@ -195,13 +195,15 @@ module GoodData
       end
 
       def transfer_output_stage(from_project, to_project, options)
+        from_prj_output_stage = from_project.add.output_stage
+        output_stage_prefix = options[:ads_output_stage_prefix] || from_prj_output_stage.output_stage_prefix
+        output_stage_uri = options[:ads_output_stage_uri] || from_prj_output_stage.schema
         if from_project.processes.any? { |p| p.type == :dataload }
           if to_project.processes.any? { |p| p.type == :dataload }
-            to_project.add.output_stage.schema = from_project.add.output_stage.schema
-            to_project.add.output_stage.output_stage_prefix = from_project.add.output_stage.output_stage_prefix
+            to_project.add.output_stage.schema = output_stage_uri
+            to_project.add.output_stage.output_stage_prefix = output_stage_prefix
             to_project.add.output_stage.save
           else
-            from_prj_output_stage = from_project.add.output_stage
             from_server = from_project.client.connection.server.url
             to_server = to_project.client.connection.server.url
             if from_server != to_server && options[:ads_output_stage_uri].nil?
@@ -214,9 +216,9 @@ module GoodData
 
             to_project.add.output_stage = GoodData::AdsOutputStage.create(
               client: to_project.client,
-              ads: options[:ads_output_stage_uri] || from_prj_output_stage.schema,
+              ads: output_stage_uri,
               client_id: from_prj_output_stage.client_id,
-              output_stage_prefix: from_prj_output_stage.output_stage_prefix,
+              output_stage_prefix: output_stage_prefix,
               project: to_project
             )
           end

data/lib/gooddata/models/user_filters/user_filter_builder.rb

@@ -390,12 +390,17 @@ module GoodData
       project_users = project.users
       filters = normalize_filters(user_filters)
       user_filters, errors = maqlify_filters(filters, project_users, options.merge(users_must_exist: users_must_exist, type: :muf))
+      if !ignore_missing_values && !errors.empty?
+        errors = errors.map do |e|
+          e.merge(pid: project.pid)
+        end
+        fail GoodData::FilterMaqlizationError, errors
+      end
 
-      fail GoodData::FilterMaqlizationError, errors if !ignore_missing_values && !errors.empty?
       filters = user_filters.map { |data| client.create(MandatoryUserFilter, data, project: project) }
       to_create, to_delete = resolve_user_filters(filters, project.data_permissions)
 
-      to_delete = sanitize_filters_to_delete(to_delete, options[:users_brick_input], project_users)
+      to_delete = sanitize_filters_to_delete(to_delete, options[:users_brick_input], project_users) unless options[:no_sanitize]
 
       if options[:do_not_touch_filters_that_are_not_mentioned]
         GoodData.logger.warn("Data permissions computed: #{to_create.count} to create")

data/lib/gooddata/rest/client.rb

@@ -169,9 +169,12 @@ module GoodData
       end
 
       def project_is_accessible?(id)
-        projects(id) && true
-      rescue
-        true
+        GoodData.logger.warn 'Beware! project_is_accessible is deprecated and should not be used.'
+        begin # rubocop:disable RedundantBegin TODO: remove this after droping JRuby which does not support rescue without begin
+          projects(id)
+        rescue RestClient::NotFound
+          false
+        end
       end
 
       def projects(id = :all)

data/lib/gooddata/version.rb

@@ -6,7 +6,7 @@
 
 # GoodData Module
 module GoodData
-  VERSION = '1.3.1'
+  VERSION = '1.3.2'
 
   class << self
     # Version

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gooddata
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Pavel Kolesnikov
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-17 00:00:00.000000000 Z
+date: 2018-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -115,16 +115,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.48'
+        version: 0.59.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.48'
+        version: 0.59.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -543,7 +543,13 @@ email: pavel@gooddata.com
 executables:
 - gitflow-init.sh
 - gooddata
+- hello_world.sh
+- provisioning.sh
+- release.sh
+- rollout.sh
 - run_brick.rb
+- user_filters.sh
+- users.sh
 extensions: []
 extra_rdoc_files:
 - LICENSE
@@ -568,6 +574,7 @@ files:
 - Dockerfile.ruby
 - Gemfile
 - Guardfile
+- Jenkinsfile
 - LICENSE
 - LICENSE.rb
 - README.md
@@ -577,7 +584,13 @@ files:
 - authors.sh
 - bin/gitflow-init.sh
 - bin/gooddata
+- bin/hello_world.sh
+- bin/provisioning.sh
+- bin/release.sh
+- bin/rollout.sh
 - bin/run_brick.rb
+- bin/user_filters.sh
+- bin/users.sh
 - ci.rake
 - data/2008.crt
 - data/new_ca.cer
@@ -677,6 +690,7 @@ files:
 - lib/gooddata/extract.rb
 - lib/gooddata/goodzilla/goodzilla.rb
 - lib/gooddata/helpers/auth_helpers.rb
+- lib/gooddata/helpers/crypto_helper.rb
 - lib/gooddata/helpers/csv_helper.rb
 - lib/gooddata/helpers/data_helper.rb
 - lib/gooddata/helpers/erb_helper.rb