gooddata 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 3e0b460e350ce558d51e952f2ceaf7ac6745818d59a9cd216c56aa09a05beffd
-  data.tar.gz: 3427347c50c34e5253c2c4817952595397b7bd4b90aca3295c5ba52f2b3baa35
+SHA1:
+  metadata.gz: 2fd2c88fc8ba7bc3e6e6f9aec01c2647fbdc1944
+  data.tar.gz: fe5004fa1d35bdb6f52c08ce457da2c38ba2c0ac
 SHA512:
-  metadata.gz: 9a98ad64efd8f69da7e41a73cf7d2604c4aa675674f2b125ec1c11f48ae2395f88e5827011e74d3c409b1b4bf6aa53fc3c03b482a1a1f1f8a43d4af3145a4e51
-  data.tar.gz: 66073861a519d77c3227b55801e1e8fc477b7b58b7e2fc3d10e7dc6dd2379130b1ebfbc72118080f8a68b2616d17c7d3d125ef1779668a5d437c50e7d091a513
+  metadata.gz: d8cddf4daefff255c001fa8187b36c3f49d6d50a0917be3d19518c0ac51cc7d19481358d1730f594b7dc07a147802e6588909a19710abe50704198c65727a56b
+  data.tar.gz: 3423a1d456ca6bf3f4c4e965e46f061515c60da85cf9f3d34a3b0b42febaa6760aa8b4771103e795d2bfea869c2527247196354b6997b157150eaada6a6beb5c

data/.pronto.yml

@@ -1,3 +1,4 @@
 verbose: true
 github:
   slug: gooddata/gooddata-ruby
+format: "%{level}: %{msg} (%{runner})"

data/CHANGELOG.md

@@ -1,4 +1,16 @@
 # GoodData Ruby SDK Changelog
+## 1.3.0
+ - Add changelog for 1.2.1
+ - Automate bumping version (#1243)
+ - TMA-787 added support M:N in LCM
+ - Fix spec for synchronize_ldm=diff_against_master
+ - TRIVIAL: remove the newline character from the CSV header string
+ - TMA-484: Fix getting latest master version (#1258)
+ - minor fixes to the load tests
+ - Enable lcm tests on personal instance
+ - TMA-787 added support M:N in LCM
+ - Fix logging error
+
 
 ## 1.2.1
  - Document gem release process (#1254)
@@ -124,7 +136,7 @@
  - TMA-604: can put metrics in folders
  - TMA-843: avoid abuse of obj resource in partial md import export
  - TMA-892: User filters brick dry run (#1156)
- - * TMA-892: User filters brick dry run
+ - * TMA-892: User filters brick dry run
  - TMA-761: add support for manual schedule execution
  - fix recovery from provision clients error
  - make sso backwards compatible

data/Rakefile

@@ -142,53 +142,34 @@ namespace :license do
   end
 end
 
-namespace :version do
-  desc 'Updates the changelog, commits and tags the bump'
-  task :bump do
-    require_relative 'lib/gooddata/version'
-    new_version = GoodData::VERSION
-    changelog = File.read('CHANGELOG.md')
-    changelog_header = '# GoodData Ruby SDK Changelog'
-    changelog.slice! changelog_header
-    fail 'the version is already mentioned in the changelog' if changelog =~ /## #{new_version}/
-    puts "Creating changelog for version #{new_version}"
-    current_commit = `git rev-parse HEAD`.chomp
-    last_release = changelog.split("\n").reject(&:empty?).first.delete('## ').chomp
-    puts "Last release was #{last_release}"
-    last_release_commit = `git rev-parse #{last_release}`.chomp
-    changes = `git log --format=%s --no-merges #{last_release_commit}..#{current_commit}`.split("\n").reject(&:empty?)
-    File.open('CHANGELOG.md', 'w+') do |file|
-      file.puts changelog_header + "\n"
-      file.puts "## #{new_version}"
-      changes.each { |change| file.puts ' - ' + change }
-      file.puts changelog
-    end
-    # `git add CHANGELOG.md lib/gooddata/version.rb`
-    # `git commit -m "Bump version to #{new_version}"`
-    # `git tag #{new_version}`
+# Updates the changelog with commit messages
+def update_changelog(new_version)
+  changelog = File.read('CHANGELOG.md')
+  changelog_header = '# GoodData Ruby SDK Changelog'
+  changelog.slice! changelog_header
+  fail 'the version is already mentioned in the changelog' if changelog =~ /## #{new_version}/
+  puts "Creating changelog for version #{new_version}"
+  current_commit = `git rev-parse HEAD`.chomp
+  last_release = changelog.split("\n").reject(&:empty?).first.delete('## ').chomp
+  last_release_commit = `git rev-parse #{last_release}`.chomp
+  changes = `git log --format=%s --no-merges #{last_release_commit}..#{current_commit}`.split("\n").reject(&:empty?)
+  File.open('CHANGELOG.md', 'w+') do |file|
+    file.puts changelog_header + "\n"
+    file.puts "## #{new_version}"
+    changes.each { |change| file.puts ' - ' + change }
+    file.puts changelog
   end
 end
 
-namespace :changelog do
-  desc 'Updates the changelog with commit messages'
-  task :update do
+namespace :version do
+  desc 'Updates the changelog, commits and tags the bump'
+  task :bump do
     require_relative 'lib/gooddata/version'
     new_version = GoodData::VERSION
-    changelog = File.read('CHANGELOG.md')
-    changelog_header = '# GoodData Ruby SDK Changelog'
-    changelog.slice! changelog_header
-    fail 'the version is already mentioned in the changelog' if changelog =~ /## #{new_version}/
-    puts "Creating changelog for version #{new_version}"
-    current_commit = `git rev-parse HEAD`.chomp
-    last_release = changelog.split("\n").reject(&:empty?).first.delete('## ').chomp
-    last_release_commit = `git rev-parse #{last_release}`.chomp
-    changes = `git log --format=%B --no-merges #{last_release_commit}..#{current_commit}`.split("\n").reject(&:empty?)
-    File.open('CHANGELOG.md', 'w+') do |file|
-      file.puts changelog_header + "\n"
-      file.puts "## #{new_version}"
-      changes.each { |change| file.puts ' - ' + change }
-      file.puts changelog
-    end
+    update_changelog(new_version)
+    `git add CHANGELOG.md lib/gooddata/version.rb`
+    `git commit -m "Bump version to #{new_version}"`
+    `git tag #{new_version}`
   end
 end
 

data/lib/gooddata/lcm/actions/collect_segment_clients.rb

@@ -35,8 +35,6 @@ module GoodData
         :to_pid
       ]
 
-      DEFAULT_TABLE_NAME = 'LCM_RELEASE'
-
       class << self
         def call(params)
           client = params.gdc_gd_client
@@ -49,16 +47,11 @@ module GoodData
 
             raise "Client(s) missing workspace: #{missing_project_clients.join(', ')}. Please make sure all clients have workspace." unless missing_project_clients.empty?
 
-            replacements = {
-              table_name: params.release_table_name || DEFAULT_TABLE_NAME,
-              segment_id: segment.segment_id
-            }
-
-            path = File.expand_path('../../data/select_from_lcm_release.sql.erb', __FILE__)
-            query = GoodData::Helpers::ErbHelper.template_file(path, replacements)
-
-            res = params.ads_client.execute_select(query)
-            latest_master_id = res.max_by { |row| row[:version] }[:master_project_id]
+            latest_master_id = GoodData::LCM2::Helpers.latest_master_project(
+              params.release_table_name,
+              params.ads_client,
+              segment.segment_id
+            )[:master_project_id]
             latest_master = client.projects(latest_master_id)
 
             # TODO: Check res.first.nil? || res.first[:master_project_id].nil?

data/lib/gooddata/lcm/actions/create_segment_masters.rb

@@ -46,8 +46,6 @@ module GoodData
         param :gdc_logger, instance_of(Type::GdLogger), required: true
       end
 
-      DEFAULT_TABLE_NAME = 'LCM_RELEASE'
-
       class << self
         def call(params)
           results = []
@@ -150,19 +148,13 @@ module GoodData
         end
 
         def get_project_version(params, segment_id)
-          replacements = {
-            table_name: params.release_table_name || DEFAULT_TABLE_NAME,
-            segment_id: segment_id
-          }
-
-          path = File.expand_path('../../data/select_from_lcm_release.sql.erb', __FILE__)
-          query = GoodData::Helpers::ErbHelper.template_file(path, replacements)
-
-          res = params.ads_client.execute_select(query)
-
-          return 0 if res.empty?
-
-          res[0][:version].to_i
+          current_master = GoodData::LCM2::Helpers.latest_master_project(
+            params.release_table_name,
+            params.ads_client,
+            segment_id
+          )
+          return 0 unless current_master
+          current_master[:version].to_i
         end
       end
     end

data/lib/gooddata/lcm/actions/synchronize_clients.rb

@@ -44,8 +44,6 @@ module GoodData
         :master_pid
       ]
 
-      DEFAULT_TABLE_NAME = 'LCM_RELEASE'
-
       class << self
         def call(params)
           client = params.gdc_gd_client
@@ -63,17 +61,11 @@ module GoodData
           end
 
           results = segments.map do |segment|
-            replacements = {
-              table_name: params.release_table_name || DEFAULT_TABLE_NAME,
-              segment_id: segment.segment_id
-            }
-
-            path = File.expand_path('../../data/select_from_lcm_release.sql.erb', __FILE__)
-            query = GoodData::Helpers::ErbHelper.template_file(path, replacements)
-
-            res = params.ads_client.execute_select(query)
-            sorted = res.sort_by { |row| row[:version] }
-            current_master = sorted.last[:master_project_id]
+            current_master = GoodData::LCM2::Helpers.latest_master_project(
+              params.release_table_name,
+              params.ads_client,
+              segment.segment_id
+            )[:master_project_id]
 
             # TODO: Check res.first.nil? || res.first[:master_project_id].nil?
             master = client.projects(current_master)

data/lib/gooddata/lcm/helpers/release_table_helper.rb

@@ -0,0 +1,29 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2018 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+module GoodData
+  module LCM2
+    class Helpers
+      DEFAULT_TABLE_NAME = 'LCM_RELEASE'
+
+      class << self
+        def latest_master_project(release_table_name, ads_client, segment_id)
+          replacements = {
+            table_name: release_table_name || DEFAULT_TABLE_NAME,
+            segment_id: segment_id
+          }
+
+          path = File.expand_path('../../data/select_from_lcm_release.sql.erb', __FILE__)
+          query = GoodData::Helpers::ErbHelper.template_file(path, replacements)
+
+          res = ads_client.execute_select(query)
+          sorted = res.sort_by { |row| row[:version] }
+          sorted.last
+        end
+      end
+    end
+  end
+end

data/lib/gooddata/models/blueprint/bridge_field.rb

@@ -0,0 +1,43 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require_relative 'blueprint_field'
+
+module GoodData
+  module Model
+    class BridgeBlueprintField < BlueprintField
+      # Returns the schema that is referenced by this ref
+      #
+      # @return [GoodData::Model::SchemaBlueprint] the referencesd schema
+      def dataset
+        dataset_blueprint.find_dataset(bridge, include_date_dimensions: true)
+      end
+
+      # Returns the string bridge of the ref which is string Id of dataset that is bridged.
+      #
+      # @return [String] Id of the bridged dataset
+      def bridge
+        data[:dataset]
+      end
+
+      # Validates the fields in the ref
+      #
+      # @return [Array] returns list of the errors represented by hash structures
+      def validate
+        validate_presence_of(:dataset).map do |e|
+          { type: :error, message: "Field \"#{e}\" is not defined or empty for bridge \"#{data}\"" }
+        end
+      end
+
+      # Returns the md object in associated project or throws error if not present
+      #
+      # @return [GoodData::MdObject] md object that is represented in the blueprint
+      def in_project(_project)
+        fail NotImplementedError, 'Reference does not have representation as an object in datamart'
+      end
+    end
+  end
+end

data/lib/gooddata/models/blueprint/dataset_blueprint.rb

@@ -166,6 +166,14 @@ module GoodData
         find_columns_by_type(dataset, :reference, :date)
       end
 
+      # Returns bridges of a dataset
+      #
+      # @param dataset [Hash] Dataset blueprint
+      # @return [Array<Hash>] returns the bridges or an empty array
+      def self.bridges(dataset)
+        find_columns_by_type(dataset, :bridge)
+      end
+
       # Returns anchor of a dataset
       #
       # @return [Hash] returns the anchor or nil
@@ -222,6 +230,8 @@ module GoodData
             GoodData::Model::FactBlueprintField.new(c, self)
           when :label
             GoodData::Model::LabelBlueprintField.new(c, self)
+          when :bridge
+            GoodData::Model::BridgeBlueprintField.new(c, self)
           when :reference
             GoodData::Model::ReferenceBlueprintField.new(c, self)
           when :date
@@ -352,6 +362,13 @@ module GoodData
         find_columns_by_type(:reference, :date)
       end
 
+      # Returns bridges of a dataset
+      #
+      # @return [Array<Hash>] returns the bridges or an empty array
+      def bridges
+        find_columns_by_type(:bridge)
+      end
+
       # Removes column from from the blueprint
       #
       # @param id [String] Id of the column to be removed

data/lib/gooddata/models/blueprint/schema_blueprint.rb

@@ -35,6 +35,13 @@ module GoodData
         []
       end
 
+      # Returns list of all bridges defined on the schema.
+      #
+      # @return [Array<GoodData::Model::BridgeBlueprintField>] refs on schema
+      def bridges
+        []
+      end
+
       # Returns list of all facts defined on the schema.
       #
       # @return [Array<GoodData::Model::FactBlueprintField>] facts on schema

data/lib/gooddata/models/blueprint/to_wire.rb

@@ -98,7 +98,8 @@ module GoodData
             anchor: anchor_to_wire(project, dataset),
             attributes: attributes_to_wire(project, dataset),
             facts: DatasetBlueprint.facts(dataset).map { |f| fact_to_wire(dataset, f) },
-            references: references_to_wire(project, dataset)
+            references: references_to_wire(project, dataset),
+            bridges: bridges_to_wire(project, dataset)
           }
         }
       end
@@ -108,12 +109,13 @@ module GoodData
       # @param project [Hash] Project blueprint hash represenation
       # @param dataset [Hash] Dataset blueprint hash represenation
       # @return [Hash] Manifest for a particular reference
-      def self.date_dimension_to_wire(_project, dataset)
+      def self.date_dimension_to_wire(project, dataset)
         payload = {}.tap do |dd|
           dd[:name] = dataset[:id]
           dd[:urn] = dataset[:urn] if dataset[:urn]
           dd[:title] = GoodData::Model.title(dataset)
           dd[:identifierPrefix] = dataset[:identifier_prefix] if dataset[:identifier_prefix]
+          dd[:bridges] = bridges_to_wire(project, dataset)
         end
         { dateDimension: payload }
       end
@@ -150,6 +152,16 @@ module GoodData
         end
       end
 
+      # Converts bridges to wire format.
+      #
+      # @param _project [Hash] Project blueprint hash represenation
+      # @return [Hash] Manifest for a particular bridge
+      def self.bridges_to_wire(_project, bridge)
+        DatasetBlueprint.bridges(bridge).map do |r|
+          r[:dataset]
+        end
+      end
+
       # Entry method. Converts ProjectBlueprint representation into wire format
       # which is understood by the API
       #

data/lib/gooddata/models/from_wire.rb

@@ -14,11 +14,10 @@ module GoodData
       def self.dataset_from_wire(dataset)
         {}.tap do |d|
           id = dataset['dataset']['identifier']
-
           d[:type] = :dataset
           d[:title] = dataset['dataset']['title']
           d[:id] = id
-          d[:columns] = (parse_anchor(dataset) + parse_attributes(dataset) + parse_facts(dataset) + parse_references(dataset))
+          d[:columns] = (parse_anchor(dataset) + parse_attributes(dataset) + parse_facts(dataset) + parse_references(dataset) + parse_bridges(dataset))
         end
       end
 
@@ -31,7 +30,6 @@ module GoodData
         model = wire_model['projectModelView']['model']['projectModel']
         datasets = model['datasets'] || []
         dims = model['dateDimensions'] || []
-
         ProjectBlueprint.new(
           include_ca: options[:include_ca],
           datasets: datasets.map { |ds| dataset_from_wire(ds) },
@@ -109,6 +107,7 @@ module GoodData
           d[:title] = date_dim['dateDimension']['title']
           d[:urn] = date_dim['dateDimension']['urn']
           d[:identifier_prefix] = date_dim['dateDimension']['identifierPrefix']
+          d[:columns] = parse_bridges(date_dim)
         end
       end
 
@@ -154,17 +153,29 @@ module GoodData
       # @return [Hash] Manifest for a particular reference
       def self.parse_references(dataset)
         references = dataset['dataset']['references'] || []
+        references.map do |ref|
+          {
+            :type => ref =~ /^dataset\./ ? :reference : :date,
+            :dataset => ref
+          }
+        end
+      end
+
+      # Converts bridges from wire format into an internal blueprint representation
+      #
+      # @param dataset [Hash] Whatever comes from wire
+      # @return [Hash] Manifest for a particular bridge
+      def self.parse_bridges(dataset)
+        references = !dataset['dataset'].nil? && !dataset['dataset']['bridges'].nil? ? dataset['dataset']['bridges'] : []
+        references = !dataset['dateDimension'].nil? && !dataset['dateDimension']['bridges'].nil? ? dataset['dateDimension']['bridges'] : references
         references.map do |ref|
           if ref =~ /^dataset\./
             {
-              :type => :reference,
+              :type => :bridge,
               :dataset => ref
             }
           else
-            {
-              :type => :date,
-              :dataset => ref
-            }
+            {}
           end
         end
       end

data/lib/gooddata/models/model.rb

@@ -188,7 +188,7 @@ module GoodData
                   end
                 end
               else
-                csv_header = File.open(path, &:gets).split(',')
+                csv_header = File.open(path, &:gets).chomp.split(',')
                 zip.add(filename, path)
               end
 

data/lib/gooddata/rest/connection.rb

@@ -488,7 +488,7 @@ module GoodData
         begin
           request.execute
         rescue => e
-          GoodData.logger.error("Error when uploading file #{filename}", e)
+          GoodData.logger.error("Error when uploading file #{filename}")
           raise e
         end
       end

data/lib/gooddata/version.rb

@@ -6,7 +6,7 @@
 
 # GoodData Module
 module GoodData
-  VERSION = '1.2.1'
+  VERSION = '1.3.0'
 
   class << self
     # Version

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gooddata
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - Pavel Kolesnikov
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-17 00:00:00.000000000 Z
+date: 2018-08-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -721,6 +721,7 @@ files:
 - lib/gooddata/lcm/dsl/type_dsl.rb
 - lib/gooddata/lcm/helpers/check_helper.rb
 - lib/gooddata/lcm/helpers/helpers.rb
+- lib/gooddata/lcm/helpers/release_table_helper.rb
 - lib/gooddata/lcm/helpers/tags_helper.rb
 - lib/gooddata/lcm/lcm.rb
 - lib/gooddata/lcm/lcm2.rb
@@ -803,6 +804,7 @@ files:
 - lib/gooddata/models/blueprint/attribute_field.rb
 - lib/gooddata/models/blueprint/blueprint.rb
 - lib/gooddata/models/blueprint/blueprint_field.rb
+- lib/gooddata/models/blueprint/bridge_field.rb
 - lib/gooddata/models/blueprint/dashboard_builder.rb
 - lib/gooddata/models/blueprint/dataset_blueprint.rb
 - lib/gooddata/models/blueprint/date_dimension.rb
@@ -916,7 +918,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A convenient Ruby wrapper around the GoodData RESTful API