gooddata 0.6.54 → 1.0.0

data/lib/gooddata/version.rb

@@ -6,7 +6,7 @@
 
 # GoodData Module
 module GoodData
-  VERSION = '0.6.54'
+  VERSION = '1.0.0'
 
   class << self
     # Version

data/spec/helpers/project_helper.rb

@@ -55,6 +55,19 @@ module GoodData
           }
           GoodData::Membership.create(opts, client: client)
         end
+
+        def load_full_project_implementation(client)
+          spec = JSON.parse(File.read("./spec/data/blueprints/test_project_model_spec.json"), :symbolize_names => true)
+          blueprint = GoodData::Model::ProjectBlueprint.new(spec)
+
+          project = client.create_project_from_blueprint(
+            blueprint,
+            token: ConnectionHelper::GD_PROJECT_TOKEN,
+            environment: ProjectHelper::ENVIRONMENT
+          )
+
+          [project, blueprint, spec]
+        end
       end
     end
   end

data/spec/integration/full_project_spec.rb

@@ -5,16 +5,14 @@
 # LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
+require 'tempfile'
 
 describe "Full project implementation", :constraint => 'slow' do
   before(:all) do
-    @spec = JSON.parse(File.read("./spec/data/blueprints/test_project_model_spec.json"), :symbolize_names => true)
     @invalid_spec = JSON.parse(File.read("./spec/data/blueprints/invalid_blueprint.json"), :symbolize_names => true)
-    @client = ConnectionHelper.create_default_connection
-    @blueprint = GoodData::Model::ProjectBlueprint.new(@spec)
     @invalid_blueprint = GoodData::Model::ProjectBlueprint.new(@invalid_spec)
-
-    @project = @client.create_project_from_blueprint(@blueprint, token: ConnectionHelper::GD_PROJECT_TOKEN, environment: ProjectHelper::ENVIRONMENT)
+    @client = ConnectionHelper.create_default_connection
+    @project, @blueprint, @spec = ProjectHelper.load_full_project_implementation(@client)
   end
 
   after(:all) do

data/spec/integration/models/metadata/report_spec.rb

@@ -0,0 +1,54 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+require 'gooddata'
+
+describe GoodData::Report, :constraint => 'slow' do
+  before(:all) do
+    @client = ConnectionHelper.create_default_connection
+    @project, @blueprint = ProjectHelper.load_full_project_implementation(@client)
+
+    m = @project.facts.first.create_metric
+    metric_name = Dir::Tmpname.make_tmpname ['metric.some_metric'], nil
+    metric_name.delete!('-')
+    m.identifier = metric_name
+    m.save
+
+    test_data = [
+      %w(lines_changed committed_on dev_id repo_id),
+      [3, "05/01/2012", 1_012, 75],
+      [2, "11/10/2014", 5_432, 23],
+      [5, "01/10/2014", 45_212, 87_163],
+      [1, "12/02/2017", 753, 11]
+    ]
+    @project.upload(test_data, @blueprint, 'dataset.commits')
+
+    m = @project.metrics.first
+    @report = @project.create_report(top: [m], title: 'Report to export')
+    @report.save
+  end
+
+  after(:all) do
+    @project.delete unless @project.nil?
+    @client.disconnect
+  end
+
+  describe 'raw export' do
+    before :each do
+      @filename = Dir::Tmpname.make_tmpname([File.join(Dir::Tmpname.tmpdir, 'test_raw_export'), '.csv'], nil)
+    end
+
+    after :each do
+      File.delete(@filename)
+    end
+
+    it "exports raw report" do
+      @report.export_raw(@filename)
+      expect(File).to exist(@filename)
+      expect(File.read(@filename)).to eq("\"sum of Lines Changed\"\r\n\"11.00\"\r\n")
+    end
+  end
+end

data/spec/unit/actions/collect_data_product_spec.rb

@@ -11,29 +11,28 @@ describe GoodData::LCM2::CollectDataProduct do
 
   let(:client) { double(:client) }
   let(:domain) { double(:domain) }
-  let(:data_product) { GoodData::DataProduct.new({}) }
   let(:gdc_logger) { double(:gdc_logger) }
+  let(:data_product) { GoodData::DataProduct.new({}) }
 
   before do
     allow(client).to receive(:domain) { domain }
-    allow(gdc_logger).to receive(:info) {}
+    allow(gdc_logger).to receive(:info)
+    allow(domain).to receive(:data_products) { data_product }
   end
 
   context 'when data_product parameter is passed' do
+    let(:data_product_id) { 'data-product' }
     let(:params) do
       params = {
         gdc_gd_client: client,
         gdc_logger: gdc_logger,
-        data_product: "data-product-#{SecureRandom.uuid}"
+        data_product: data_product_id
       }
       GoodData::LCM2.convert_to_smart_hash(params)
     end
 
-    before do
-      allow(domain).to receive(:data_products) { data_product }
-    end
-
-    it 'hydrates the data_product object into params and runs the app' do
+    it 'collects the specified data_product object' do
+      expect(domain).to receive(:data_products).with(data_product_id)
       result = subject.class.call(params)
       expect(result[:params][:data_product]).to be_a GoodData::DataProduct
     end
@@ -48,17 +47,10 @@ describe GoodData::LCM2::CollectDataProduct do
       GoodData::LCM2.convert_to_smart_hash(params)
     end
 
-    it 'fallbacks to the only data_product if only one exists in the domain' do
-      allow(domain).to receive(:data_products) { [data_product] }
-
+    it "collects the 'default' data_product" do
+      expect(domain).to receive(:data_products).with('default')
       result = subject.class.call(params)
       expect(result[:params][:data_product]).to be_a GoodData::DataProduct
     end
-
-    it 'fails when multiple data_products are available to fallback on' do
-      allow(domain).to receive(:data_products) { [data_product, GoodData::DataProduct.new({})] }
-
-      expect { subject.class.call(params) }.to raise_error
-    end
   end
 end

data/spec/unit/actions/collect_users_brick_users_spec.rb

@@ -0,0 +1,36 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
+describe GoodData::LCM2::CollectUsersBrickUsers do
+  let(:data_source) { double('data_source') }
+  let(:users_csv) do
+  end
+
+  let(:params) do
+    params = {
+      users_brick_config: {
+        input_source: {},
+        login_column: 'Email'
+      }
+    }
+    GoodData::LCM2.convert_to_smart_hash(params)
+  end
+
+  before do
+    allow(GoodData::Helpers::DataSource).to receive(:new)
+      .and_return(data_source)
+    allow(data_source).to receive(:realize)
+      .and_return('spec/data/users.csv')
+  end
+
+  it 'enriches parameters with logins' do
+    result = subject.class.call(params)
+    expect(result[:results].length).to eq(11)
+    result[:results].each do |user|
+      expect(user[:login]).not_to be_nil
+    end
+  end
+end

data/spec/unit/actions/shared_examples_for_user_actions.rb

@@ -1,4 +1,4 @@
-shared_examples 'a user action' do
+shared_examples 'a user action reading client_id' do
   before do
     allow(File).to receive(:open).and_return("client_id\n#{client_id}")
   end
@@ -8,3 +8,19 @@ shared_examples 'a user action' do
     subject.class.call(params)
   end
 end
+
+shared_examples 'a user action filtering segments' do
+  let(:organization_not_in_segment) { double('organization') }
+  let(:project_not_in_segment) { double('project') }
+
+  before do
+    allow(organization_not_in_segment).to receive(:segment_uri).and_return('another-segment-uri')
+    allow(organization_not_in_segment).to receive(:project).and_return(project_not_in_segment)
+  end
+
+  it 'does operation on project only from clients in segments in segments filter' do
+    expect(project).to receive(message_for_project)
+    expect(project_not_in_segment).not_to receive(message_for_project)
+    subject.class.call(params)
+  end
+end

data/spec/unit/actions/synchronize_user_filters_spec.rb

@@ -48,7 +48,7 @@ describe GoodData::LCM2::SynchronizeUserFilters do
         GoodData::LCM2.convert_to_smart_hash(params)
       end
 
-      it_behaves_like 'a user action' do
+      it_behaves_like 'a user action reading client_id' do
         let(:client_id) { '123456789' }
       end
 
@@ -67,6 +67,10 @@ describe GoodData::LCM2::SynchronizeUserFilters do
           result = subject.class.call(params)
           expect(result).to eq(results: [[{}]])
         end
+
+        it_behaves_like 'a user action filtering segments' do
+          let(:message_for_project) { :add_data_permissions }
+        end
       end
     end
   end

data/spec/unit/actions/synchronize_users_spec.rb

@@ -2,6 +2,13 @@ require 'active_support/core_ext/hash'
 require 'gooddata/lcm/lcm2'
 require_relative 'shared_examples_for_user_actions'
 
+shared_examples_for 'a user synchronizer' do
+  it 'does not fail and logs a warning' do
+    expect(logger).to receive(:warn).with(/not match any client ids/)
+    expect { subject.class.call(params) }.to_not raise_error
+  end
+end
+
 describe GoodData::LCM2::SynchronizeUsers do
   let(:client) { double('client') }
   let(:user) { double('user') }
@@ -10,16 +17,16 @@ describe GoodData::LCM2::SynchronizeUsers do
   let(:project) { double('project') }
   let(:organization) { double('organization') }
   let(:logger) { double('logger') }
+  let(:project_uri) { '/gdc/projects/123abc' }
 
   before do
     allow(client).to receive(:projects).and_return(project)
     allow(client).to receive(:user).and_return(user)
     allow(client).to receive(:domain).and_return(domain)
-    allow(domain).to receive(:clients).and_return(organization)
-    allow(organization).to receive(:project_uri)
+    allow(organization).to receive(:project_uri).and_return(project_uri)
     allow(project).to receive(:import_users).and_return([{}])
     allow(project).to receive(:metadata).and_return({})
-    allow(project).to receive(:uri)
+    allow(project).to receive(:uri).and_return(project_uri)
     allow(project).to receive(:pid).and_return('123456789')
     allow(data_source).to receive(:realize)
     allow(user).to receive(:login).and_return('my_login')
@@ -29,7 +36,14 @@ describe GoodData::LCM2::SynchronizeUsers do
   end
 
   context 'when multiple_projects_column not specified' do
-    context 'when mode requires client_id' do
+    context 'when mode is sync_one_project_based_on_custom_id' do
+      let(:client_id) { '123456789' }
+
+      before do
+        allow(domain).to receive(:clients).and_return([organization])
+        allow(organization).to receive(:id).and_return(client_id)
+      end
+
       let(:params) do
         params = {
           GDC_GD_CLIENT: client,
@@ -41,8 +55,20 @@ describe GoodData::LCM2::SynchronizeUsers do
         GoodData::LCM2.convert_to_smart_hash(params)
       end
 
-      it_behaves_like 'a user action' do
-        let(:client_id) { '123456789' }
+      context 'when the input set is empty' do
+        before do
+          allow(File).to receive(:open).and_return("")
+        end
+
+        it_behaves_like 'a user synchronizer'
+      end
+
+      context 'when the input set does not contain data for the current project' do
+        before do
+          allow(File).to receive(:open).and_return("client_id\ndifferent_from_123")
+        end
+
+        it_behaves_like 'a user synchronizer'
       end
     end
 
@@ -60,6 +86,7 @@ describe GoodData::LCM2::SynchronizeUsers do
 
       before do
         allow(File).to receive(:open).and_return("project_id\n123456789")
+        allow(domain).to receive(:clients).and_return(organization)
       end
 
       it 'uses project_id column' do
@@ -72,5 +99,36 @@ describe GoodData::LCM2::SynchronizeUsers do
         subject.class.call(params)
       end
     end
+
+    context 'when using mode sync_domain_client_workspaces' do
+      let(:segment) { double('segment') }
+      let(:segment_uri) { 'segment_uri' }
+      let(:params) do
+        params = {
+          GDC_GD_CLIENT: client,
+          input_source: 'foo',
+          domain: 'bar',
+          gdc_logger: logger,
+          sync_mode: 'sync_domain_client_workspaces',
+          segments: [segment]
+        }
+        GoodData::LCM2.convert_to_smart_hash(params)
+      end
+
+      before do
+        allow(File).to receive(:open).and_return("client_id\n123456789")
+        allow(domain).to receive(:clients).with(:all, nil).and_return([organization, organization_not_in_segment])
+        allow(domain).to receive(:clients).with('123456789', nil).and_return(organization)
+        allow(segment).to receive(:uri).and_return(segment_uri)
+        allow(organization).to receive(:segment_uri).and_return(segment_uri)
+        allow(organization).to receive(:project).and_return(project)
+        allow(organization).to receive(:client_id).and_return('123456789')
+        allow(project).to receive(:deleted?).and_return(false)
+      end
+
+      it_behaves_like 'a user action filtering segments' do
+        let(:message_for_project) { :import_users }
+      end
+    end
   end
 end