gooddata 0.6.23 → 0.6.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cf83961610c60c9419a174b0f54d7f9f7c1fd5b6
-  data.tar.gz: 4d29bd398cd6223a07cf0b9ab83eb17a182c795b
+  metadata.gz: 30374dd9fc0772222ad087d4c46a0e0cbf67afa7
+  data.tar.gz: ca952f77f35a66ed185d4397f2316d40e39bdb6f
 SHA512:
-  metadata.gz: ce0faaf8e3e6f8a8d44216047602e4d98d9ecd326d5a258ef641e9a2186d4ac4afa36d3c38195a46d2fc708193d6e062567b938af0a3cf7a8db7b9bc3e7beceb
-  data.tar.gz: 56e6a3495144c698801c9e006a42d7f2b2f7e3f04f79cefd71185ad7de41b476c7b603691ddaf1ff40a7011928b77ef904938795fd6016a1be42a1be260f0f62
+  metadata.gz: eab3feca7ef26f5e9b97bbc6b7878910afa7da4317b5a802327bd383fa767de654cf6466537ff34e7ee3944b76da5f858e6c5e76f8b535c29929ead8bd9e6138
+  data.tar.gz: 00491d58b885d2b11ae9364e011ec008e91aeb39777e0318619c21a20fb4bf64642f2b689e6ebb23357e1d0a64e214f374c9d342030e5201ebd4fa81a6d8cc05

data/CHANGELOG.md

@@ -1,6 +1,7 @@
 # GoodData Ruby SDK Changelog
 
 ## 0.6.23
+- Fixed typo sometimes causing crash of ReportDefinition#replace
 
 ## 0.6.22
 - Added rake task (license:add) for automatic license headers generating

data/lib/gooddata/commands/datasets.rb

@@ -131,7 +131,7 @@ module GoodData
         guesser.headers.each_with_index do |header, i|
           options = guess[header].map(&:to_s)
           options = options.select { |t| t != :connection_point.to_s } if connection_point_set
-          type = ask((question_fmt % [i + 1, header]), :answers => options) # rubocop:disable Lint/FormatParameterMismatch
+          type = ask((question_fmt % [i + 1, header]), :answers => options)
           model.push :title => header, :name => header, :type => type.upcase
           connection_point_set = true if type == :connection_point.to_s
         end

data/lib/gooddata/models/metadata/dashboard.rb

@@ -125,7 +125,7 @@ module GoodData
       tab = options[:tab] || ''
 
       req_uri = "/gdc/projects/#{project.pid}/clientexport"
-      x = client.post(req_uri, 'clientExport' => { 'url' => "https://secure.gooddata.com/dashboard.html#project=#{GoodData.project.uri}&dashboard=#{uri}&tab=#{tab}&export=1", 'name' => title })
+      x = client.post(req_uri, 'clientExport' => { 'url' => "#{client.connection.server_url}/dashboard.html#project=#{GoodData.project.uri}&dashboard=#{uri}&tab=#{tab}&export=1", 'name' => title })
       client.poll_on_code(x['asyncTask']['link']['poll'], options.merge(process: false))
     end
 

data/lib/gooddata/models/metadata/label.rb

@@ -19,7 +19,7 @@ module GoodData
     # @return [String]
     def find_value_uri(value)
       escaped_value = CGI.escape(value)
-      results = client.post("#{uri}/validElements?limit=1&offset=0&order=asc&filter=#{escaped_value}", {})
+      results = client.post("#{uri}/validElements?limit=1&offset=0&order=asc&filter=#{escaped_value}", 'validElementsRequest' => {})
       items = results['validElements']['items']
       if items.empty?
         fail(AttributeElementNotFound, value)
@@ -63,7 +63,7 @@ module GoodData
         offset = options[:offset] || 0
         page_limit = options[:limit] || 100
         loop do
-          results = client.post("#{uri}/validElements?limit=#{page_limit}&offset=#{offset}&order=asc", {})
+          results = client.post("#{uri}/validElements?limit=#{page_limit}&offset=#{offset}&order=asc", 'validElementsRequest' => {})
 
           # Implementation of polling is based on
           # https://opengrok.intgdc.com/source/xref/gdc-backend/src/test/java/com/gooddata/service/dao/ValidElementsDaoTest.java
@@ -90,8 +90,9 @@ module GoodData
     end
 
     def values_count
-      results = client.post("#{uri}/validElements?limit=1&offset=0&order=asc", {})
-      results['validElements']['paging']['total'].to_i
+      results = client.post("#{uri}/validElements?limit=1&offset=0&order=asc", 'validElementsRequest' => {})
+      count = GoodData::Helpers.get_path(results, %w(validElements paging total))
+      count && count.to_i
     end
 
     # Gives an attribute of current label

data/lib/gooddata/models/metadata/report.rb

@@ -57,6 +57,29 @@ module GoodData
         report['report']['meta']['identifier'] = options[:identifier] if options[:identifier]
         client.create(Report, report, :project => project)
       end
+
+      def data_result(result, options = {})
+        client = options[:client]
+        data_result_uri = result['execResult']['dataResult']
+        begin
+          result = client.poll_on_response(data_result_uri, options) do |body|
+            body && body['taskState'] && body['taskState']['status'] == 'WAIT'
+          end
+        rescue RestClient::BadRequest => e
+          resp = JSON.parse(e.response)
+          if GoodData::Helpers.get_path(resp, %w(error component)) == 'MD::DataResult'
+            raise GoodData::UncomputableReport
+          else
+            raise e
+          end
+        end
+
+        if result.empty?
+          ReportDataResult.new(data: [], top: 0, left: 0)
+        else
+          ReportDataResult.from_xtab(result)
+        end
+      end
     end
 
     # Add a report definition to a report. This will show on a UI as a new version.
@@ -127,17 +150,7 @@ module GoodData
     def execute(options = {})
       fail 'You have to save the report before executing. If you do not want to do that please use GoodData::ReportDefinition' unless saved?
       result = client.post '/gdc/xtab2/executor3', 'report_req' => { 'report' => uri }
-      data_result_uri = result['execResult']['dataResult']
-
-      result = client.poll_on_response(data_result_uri, options) do |body|
-        body && body['taskState'] && body['taskState']['status'] == 'WAIT'
-      end
-
-      if result.empty?
-        client.create(ReportDataResult, data: [], top: 0, left: 0, project: project)
-      else
-        ReportDataResult.from_xtab(result, client: client, project: project)
-      end
+      GoodData::Report.data_result(result, options.merge(client: client))
     end
 
     # Returns true if you can export and object

data/lib/gooddata/models/metadata/report_definition.rb

@@ -242,7 +242,7 @@ module GoodData
                  uri = "/gdc/app/projects/#{project.pid}/execute"
                  client.post(uri, data)
                end
-      data_result(result, opts)
+      GoodData::Report.data_result(result, opts.merge(client: client))
     end
 
     def filters
@@ -352,29 +352,5 @@ module GoodData
     def table?
       content['format'] == 'grid'
     end
-
-    private
-
-    def data_result(result, options = {})
-      data_result_uri = result['execResult']['dataResult']
-      begin
-        result = client.poll_on_response(data_result_uri, options) do |body|
-          body && body['taskState'] && body['taskState']['status'] == 'WAIT'
-        end
-      rescue RestClient::BadRequest => e
-        resp = JSON.parse(e.response)
-        if GoodData::Helpers.get_path(resp, %w(error component)) == 'MD::DataResult'
-          raise GoodData::UncomputableReport
-        else
-          raise e
-        end
-      end
-
-      if result.empty?
-        client.create(ReportDataResult, data: [], top: 0, left: 0, project: project)
-      else
-        ReportDataResult.from_xtab(result, client: client, project: project)
-      end
-    end
   end
 end

data/lib/gooddata/version.rb

@@ -6,7 +6,7 @@
 
 # GoodData Module
 module GoodData
-  VERSION = '0.6.23'
+  VERSION = '0.6.24'
 
   class << self
     # Version
@@ -17,7 +17,7 @@ module GoodData
     # Identifier of gem version
     # @return Formatted gem version
     def gem_version_string
-      "gooddata-gem/#{VERSION}"
+      "gooddata-gem/#{VERSION}/#{RUBY_PLATFORM}/#{RUBY_VERSION}"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gooddata
 version: !ruby/object:Gem::Version
-  version: 0.6.23
+  version: 0.6.24
 platform: ruby
 authors:
 - Pavel Kolesnikov
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-11 00:00:00.000000000 Z
+date: 2015-10-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -1030,7 +1030,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: A convenient Ruby wrapper around the GoodData RESTful API