gooddata 0.6.20 → 0.6.22

data/spec/integration/user_filters_spec.rb

@@ -1,3 +1,9 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
 require 'gooddata'
 
 describe "User filters implementation", :constraint => 'slow' do
@@ -14,7 +20,8 @@ describe "User filters implementation", :constraint => 'slow' do
       ["lines_changed","committed_on","dev_id","repo_id"],
       [1,"01/01/2014",1,1],
       [3,"01/02/2014",2,2],
-      [5,"05/02/2014",3,1]]
+      [5,"05/02/2014",3,1],
+      [6,"05/02/2014",1,2]]
     @project.upload(commits_data, blueprint, 'dataset.commits')
 
     devs_data = [
@@ -23,6 +30,13 @@ describe "User filters implementation", :constraint => 'slow' do
       [2, "petr@gooddata.com"],
       [3, "jirka@gooddata.com"]]
     @project.upload(devs_data, blueprint, 'dataset.devs')
+
+    repos_data = [
+      ["repo_id", "repo_name"],
+      [1, "goodot"],
+      [2, "bam"],
+      [3, "infra"]]
+    @project.upload(repos_data, blueprint, 'dataset.repos')
   end
 
   after(:all) do
@@ -40,25 +54,23 @@ describe "User filters implementation", :constraint => 'slow' do
     # [jirka@gooddata.com | petr@gooddata.com | tomas@gooddata.com]
     # [5.0                | 3.0               | 1.0               ]
 
-    metric.execute.should == 9
+    metric.execute.should == 15
     @project.add_data_permissions(filters)
-    metric.execute.should == 6
+    metric.execute.should == 12
     r = @project.compute_report(left: [metric], top: [@label.attribute])
-
-    r.include_column?(['tomas@gooddata.com', 1]).should == true
+    r.include_column?(['tomas@gooddata.com', 7]).should == true
     r.include_column?(['jirka@gooddata.com', 5]).should == true
     r.include_column?(['petr@gooddata.com', 3]).should == false
   end
 
-  it "should fail when asked to set a user not in project. No filters should be set up." do
+  it "should return errors when asked to set a user not in project. Some filters are set up though." do
     filters = [
       ['nonexistent_user@gooddata.com', @label.uri, "tomas@gooddata.com"],
       [ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com"]
     ]
-    expect do
-      @project.add_data_permissions(filters)
-    end.to raise_error
-    expect(@project.data_permissions.count).to eq 0
+    results = @project.add_data_permissions(filters)
+    expect(results[:results].any? { |r| r[:status] == :failed }).to be_truthy
+    expect(@project.data_permissions.count).to eq 2
   end
 
   it "should pass and set users that are in the projects" do
@@ -74,18 +86,41 @@ describe "User filters implementation", :constraint => 'slow' do
       ['nonexistent_user@gooddata.com', @label.uri, 'tomas@gooddata.com'],
       [ConnectionHelper::DEFAULT_USERNAME, @label.uri, 'tomas@gooddata.com']
     ]
+    # note that filters will be set up even for nonexistent users but they will not be assigned
     @project.add_data_permissions(filters, users_must_exist: false)
-    expect(@project.data_permissions.count).to eq 1
-    expect(@project.data_permissions.first.pretty_expression).to eq "[Dev] IN ([tomas@gooddata.com])"
+    expect(@project.data_permissions.select(&:related_uri).count).to eq 1
+    expect(@project.data_permissions.select(&:related_uri).first.pretty_expression).to eq "[Dev] IN ([tomas@gooddata.com])"
   end
 
   it "should fail when asked to set a value not in the project" do
     filters = [
-      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, '%^&*( nonexistent value', 'tomas@gooddata.com'],
-      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, 'tomas@gooddata.com']]
+      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, '%^&*( nonexistent value', 'tomas@gooddata.com']]
     expect do
       @project.add_data_permissions(filters)
     end.to raise_error
+    begin
+      @project.add_data_permissions(filters)
+    rescue GoodData::FilterMaqlizationError => e
+      expect(e.errors.count).to eq 1
+    end
+    expect(@project.data_permissions.count).to eq 0
+  end
+
+  it 'should fail but return all values if specified' do
+    domain = @client.domain(ConnectionHelper::DEFAULT_DOMAIN)
+    u = domain.users.find { |u| u.login != ConnectionHelper::DEFAULT_USERNAME }
+    filters = [
+      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, '%^&*( nonexistent value', 'tomas@gooddata.com'],
+      [u.login, @label.uri, '%^&*( other nonexistent value', 'jirka@gooddata.com']
+    ]
+    expect do
+      @project.add_data_permissions(filters, fail_early: false)
+    end.to raise_error
+    begin
+      @project.add_data_permissions(filters, fail_early: false)
+    rescue GoodData::FilterMaqlizationError => e
+      expect(e.errors.count).to eq 2
+    end
     expect(@project.data_permissions.count).to eq 0
   end
 
@@ -102,13 +137,10 @@ describe "User filters implementation", :constraint => 'slow' do
     u = domain.users.find { |u| u.login != ConnectionHelper::DEFAULT_USERNAME }
 
     filters = [[u.login, @label.uri, "tomas@gooddata.com"]]
-    expect do
-      @project.add_data_permissions(filters)
-    end.to raise_error
-    @project.add_data_permissions(filters, :domain => domain)
+    results = @project.add_data_permissions(filters)
     filters = @project.data_permissions
     expect(filters.first.related.login).to eq u.login
-    expect(filters.count).to eq 1
+    expect(filters.select(&:related_uri).count).to eq 1
     expect(filters.first.pretty_expression).to eq "[Dev] IN ([tomas@gooddata.com])"
   end
 
@@ -146,9 +178,10 @@ describe "User filters implementation", :constraint => 'slow' do
 
   it "should set up false if all values are nonexistent" do
     metric = GoodData::Fact.find_first_by_title('Lines Changed', client: @client, project: @project).create_metric
+
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, "NONEXISTENT1", "NONEXISTENT2", "NONEXISTENT3"]]
     @project.add_data_permissions(filters, ignore_missing_values: true)
-    expect(metric.execute).to eq 9
+    expect(metric.execute).to eq 15
     @project.add_data_permissions(filters, ignore_missing_values: true, restrict_if_missing_all_values: true)
     expect(metric.execute).to eq nil
   end
@@ -177,7 +210,7 @@ describe "User filters implementation", :constraint => 'slow' do
   end
 
   it "should be able to update the filter value" do
-    pending('We cannot swap filters yet')
+    skip('We cannot swap filters yet')
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com", "jirka@gooddata.com"]]
     @project.add_data_permissions(filters)
     perm = @project.data_permissions.first
@@ -185,4 +218,72 @@ describe "User filters implementation", :constraint => 'slow' do
     @project.add_data_permissions(filters)
     expect(perm.reload!.pretty_expression).to eq '[Dev] IN ([tomas@gooddata.com, jirka@gooddata.com])'
   end
+
+  it 'should not create any superfluous filters if things go well' do
+    # first create some filters. This will error out and some filters will stay there
+    filters = [
+      ['nonexistent_user@gooddata.com', @label.uri, "tomas@gooddata.com"],
+      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com"]
+    ]
+    results = @project.add_data_permissions(filters)
+
+    # now let's do a correct run
+    filters = [
+      [ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com"]
+    ]
+    results = @project.add_data_permissions(filters)
+    expect(results[:results].all? { |r| r[:status] == :successful }).to be_truthy
+    expect(results[:results].select {|r| r[:type] == :create }.count).to eq 1
+    expect(@project.data_permissions.count).to eq 1
+  end
+
+  it "should create a mandatory user filter with double filters" do
+
+    repo_label = @project.labels('some_attr_label_id')
+    metric = @project.create_metric("SELECT SUM(#\"Lines Changed\")")
+
+    # we want to compute stuff on different user than we are setting it on
+    u = @domain.users.find { |u| u.login != ConnectionHelper::DEFAULT_USERNAME }
+    password = 'abcd1234'
+    u.json['accountSetting']['password'] = password
+    @domain.update_user(u)
+    @project.add_user(u, 'admin')
+
+    computation_client = GoodData.connect(u.login, password, verify_ssl: false)
+    computation_project = computation_client.projects(@project.pid)
+
+    # verify we are set up
+    r = computation_project.compute_report(left: [metric, 'some_attr_label_id'], top: [@label])
+    expect(r.column(4)).to eq ["tomas@gooddata.com", 6, 1]
+
+    # lets restrict tomas to goodot only
+    filters = [[u.login, @label.uri, 'tomas@gooddata.com'],
+               [u.login, repo_label.uri, 'goodot']]
+    results = @project.add_data_permissions(filters)
+    expect(@project.data_permissions.pmap {|f| [f.related.login, f.pretty_expression]}).to eq [
+      [u.login, "[Dev] IN ([tomas@gooddata.com])"],
+      [u.login, "[Repository Name] IN ([goodot])"]]
+
+    r = computation_project.compute_report(left: [metric, 'some_attr_label_id'], top: [@label])
+    expect(r.column(2)).to eq ["tomas@gooddata.com", 1]
+
+    # Now lets change repo to bam
+    filters = [[u.login, @label.uri, 'tomas@gooddata.com'],
+               [u.login, repo_label.uri, 'bam']]
+    results = @project.add_data_permissions(filters)
+
+    expect(@project.data_permissions.pmap {|f| [f.related.login, f.pretty_expression]}).to eq [
+      [u.login, "[Dev] IN ([tomas@gooddata.com])"],
+      [u.login, "[Repository Name] IN ([bam])"]]
+
+    r = computation_project.compute_report(left: [metric, 'some_attr_label_id'], top: [@label])
+    expect(r.column(2)).to eq ["tomas@gooddata.com", 6]
+
+    # let's remove the repo restriction
+    filters = [[u.login, @label.uri, 'tomas@gooddata.com']]
+    results = @project.add_data_permissions(filters)
+
+    r = computation_project.compute_report(left: [metric, 'some_attr_label_id'], top: [@label])
+    expect(r.column(2)).to eq ["tomas@gooddata.com", 6, 1]
+  end
 end

data/spec/integration/variables_spec.rb

@@ -1,3 +1,9 @@
+# encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
+
 require 'gooddata'
 
 describe "Variables implementation", :constraint => 'slow' do
@@ -100,20 +106,7 @@ describe "Variables implementation", :constraint => 'slow' do
     expect(@variable.user_values.pmap {|m| m.pretty_expression}).to eq ["[Dev] IN ([jirka@gooddata.com])"]
     expect(@variable.user_values.count).to eq 1
   end
-  
-  it "should be able to add mandatory filter to a user not in the project if domain is provided" do
-    domain = @client.domain(ConnectionHelper::DEFAULT_DOMAIN)
-    u = domain.users.find { |u| u.login != ConnectionHelper::DEFAULT_USERNAME }
-    filters = [[u.login, @label.uri, "tomas@gooddata.com"]]
-    expect do
-      @project.add_variable_permissions(filters, @variable)
-    end.to raise_error
-    @project.add_variable_permissions(filters, @variable, :domain => domain)
-    filters = @variable.user_values
-    expect(filters.first.related.login).to eq u.login
-    expect(filters.count).to eq 1
-  end
-  
+
   it "should be able to print data permissions in a human readable form" do
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com"]]
     @project.add_variable_permissions(filters, @variable)
@@ -183,7 +176,7 @@ describe "Variables implementation", :constraint => 'slow' do
   end
 
   it "should be able to update the filter value in place" do
-    pending('We cannot swap filters yet')
+    skip('We cannot swap filters yet')
     filters = [[ConnectionHelper::DEFAULT_USERNAME, @label.uri, "tomas@gooddata.com", "jirka@gooddata.com"]]
     @project.add_variable_permissions(filters, @variable)
     perm = @variable.user_values.first

data/spec/logging_in_logging_out_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata'
 require 'pry'
@@ -14,6 +18,48 @@ describe GoodData::Rest::Connection, :constraint => 'slow' do
     client.disconnect
   end
 
+  it 'should be able to log in with user name and password as params' do
+    client = GoodData.connect(GoodData::Environment::ConnectionHelper::DEFAULT_USERNAME, GoodData::Environment::ConnectionHelper::DEFAULT_PASSWORD,
+                              server: GoodData::Environment::ConnectionHelper::DEFAULT_SERVER,
+                              verify_ssl: false)
+    client.disconnect
+  end
+
+  it 'should be able to log in with user name and password as hash' do
+    client = GoodData.connect(username: GoodData::Environment::ConnectionHelper::DEFAULT_USERNAME,
+                              password: GoodData::Environment::ConnectionHelper::DEFAULT_PASSWORD,
+                              server: GoodData::Environment::ConnectionHelper::DEFAULT_SERVER,
+                              verify_ssl: false)
+    client.disconnect
+  end
+
+  it 'should be able to log in with login and password as hash' do
+    client = GoodData.connect(login: GoodData::Environment::ConnectionHelper::DEFAULT_USERNAME,
+                              password: GoodData::Environment::ConnectionHelper::DEFAULT_PASSWORD,
+                              server: GoodData::Environment::ConnectionHelper::DEFAULT_SERVER,
+                              verify_ssl: false)
+    client.disconnect
+  end
+
+  it 'should be able to pass additional params in hash' do
+    client = GoodData.connect(login: GoodData::Environment::ConnectionHelper::DEFAULT_USERNAME,
+                              password: GoodData::Environment::ConnectionHelper::DEFAULT_PASSWORD,
+                              server: GoodData::Environment::ConnectionHelper::DEFAULT_SERVER,
+                              webdav_server: 'https://some_random_server/',
+                              verify_ssl: false)
+    expect(client.opts[:webdav_server]).to eq 'https://some_random_server/'
+    client.disconnect
+  end
+
+  it 'should be able to pass additional params in hash when used login/pass' do
+    client = GoodData.connect(GoodData::Environment::ConnectionHelper::DEFAULT_USERNAME, GoodData::Environment::ConnectionHelper::DEFAULT_PASSWORD,
+                              server: GoodData::Environment::ConnectionHelper::DEFAULT_SERVER,
+                              webdav_server: 'https://some_random_server/',
+                              verify_ssl: false)
+    expect(client.opts[:webdav_server]).to eq 'https://some_random_server/'
+    client.disconnect
+  end
+
   it "should log in and disconnect with SST" do
     regular_client = ConnectionHelper::create_default_connection
     sst = regular_client.connection.sst_token
@@ -25,6 +71,18 @@ describe GoodData::Rest::Connection, :constraint => 'slow' do
     regular_client.disconnect
   end
 
+  it "should log in and disconnect with SST with additional params" do
+    regular_client = ConnectionHelper::create_default_connection
+    sst = regular_client.connection.sst_token
+
+    sst_client = GoodData.connect(sst_token: sst, verify_ssl: false, webdav_server: 'https://some_random_server/')
+    expect(sst_client.projects.count).to be > 0
+    expect(sst_client.opts[:webdav_server]).to eq 'https://some_random_server/'
+    sst_client.disconnect
+
+    regular_client.disconnect
+  end
+
   it "should be able to regenerate TT" do
     regular_client = ConnectionHelper::create_default_connection
     projects = regular_client.projects

data/spec/spec_helper.rb

@@ -1,14 +1,16 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'simplecov'
 require 'pmap'
 require 'rspec'
-require 'coveralls'
 require 'pathname'
 require 'webmock/rspec'
 
 WebMock.disable!
-Coveralls.wear_merged!
 
 # Automagically include all helpers/*_helper.rb
 
@@ -23,7 +25,11 @@ end
 
 include GoodData::Helpers
 
+RSpec::Expectations.configuration.warn_about_potential_false_positives = false
+
 RSpec.configure do |config|
+  config.deprecation_stream = File.open('deprecations.txt', 'w')
+
   config.include BlueprintHelper
   config.include CliHelper
   config.include ConnectionHelper
@@ -57,7 +63,7 @@ RSpec.configure do |config|
 
   config.before(:suite) do
     # TODO: Setup test project
-    GoodData.logging_on
+    GoodData.logging_off
   end
 
   config.after(:suite) do
@@ -66,8 +72,7 @@ RSpec.configure do |config|
 end
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-  SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
+  SimpleCov::Formatter::HTMLFormatter
 ]
 
 SimpleCov.start do

data/spec/unit/bricks/bricks_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata/bricks/bricks'
 

data/spec/unit/bricks/middleware/aws_middelware_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata/bricks/brick'
 require 'gooddata/bricks/bricks'

data/spec/unit/bricks/middleware/bench_middleware_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata/bricks/brick'
 require 'gooddata/bricks/bricks'

data/spec/unit/bricks/middleware/bulk_salesforce_middleware_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata/bricks/brick'
 require 'gooddata/bricks/bricks'

data/spec/unit/bricks/middleware/gooddata_middleware_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata/bricks/brick'
 require 'gooddata/bricks/bricks'

data/spec/unit/bricks/middleware/logger_middleware_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata/bricks/brick'
 require 'gooddata/bricks/bricks'

data/spec/unit/bricks/middleware/restforce_middleware_spec.rb

@@ -1,4 +1,8 @@
 # encoding: UTF-8
+#
+# Copyright (c) 2010-2015 GoodData Corporation. All rights reserved.
+# This source code is licensed under the BSD-style license found in the
+# LICENSE file in the root directory of this source tree.
 
 require 'gooddata/bricks/brick'
 require 'gooddata/bricks/bricks'