gooddata 0.6.16 → 0.6.17

data/lib/gooddata/mixins/md_object_indexer.rb

@@ -27,9 +27,9 @@ module GoodData
         return id if id.is_a?(MdObject)
         uri = if id.is_a?(Integer) || id =~ /^\d+$/
                 "#{project.md[MD_OBJ_CTG]}/#{id}"
-              elsif id !~ /\//
+              elsif id !~ %r{/}
                 identifier_to_uri options, id
-              elsif id =~ /^\//
+              elsif id =~ %r{^/}
                 id
               else
                 fail 'Unexpected object id format: expected numeric ID, identifier with no slashes or an URI starting with a slash'

data/lib/gooddata/models/domain.rb

@@ -142,7 +142,7 @@ module GoodData
 
         # Optional sso provider
         tmp = user_data[:sso_provider]
-        data['ssoProvider'] = tmp if tmp && !tmp.empty?
+        data['ssoProvider'] = tmp if tmp
 
         # Optional timezone
         tmp = user_data[:timezone]

data/lib/gooddata/models/execution.rb

@@ -36,7 +36,7 @@ module GoodData
 
     # Timestamp when execution was finished
     def finished
-      Time.parse(json['execution']['endTime'])
+      json['execution']['endTime'] && Time.parse(json['execution']['endTime'])
     end
 
     # Log for execution
@@ -49,6 +49,26 @@ module GoodData
       status == :ok
     end
 
+    # Returns schedule URL
+    #
+    # @return [String] Schedule URL
+    def schedule_uri
+      uri = @json['execution']['links']['self'] if @json && @json['execution'] && @json['execution']['links']
+      uri.split('/')[0..-3].join('/')
+    end
+
+    # Is execution running?
+    def running?
+      status == :running
+    end
+
+    # Returns schedule
+    #
+    # @return [String] Schedule URL
+    def schedule
+      schedule_uri && project.schedules(schedule_uri)
+    end
+
     # Timestamp when execution was started
     def started
       Time.parse(json['execution']['startTime'])
@@ -77,6 +97,14 @@ module GoodData
       self
     end
 
+    def duration
+      if running?
+        Time.now - started
+      else
+        finished && finished - started
+      end
+    end
+
     # Compares two executions - based on their URI
     def ==(other)
       other.respond_to?(:uri) && other.uri == uri && other.respond_to?(:to_hash) && other.to_hash == to_hash

data/lib/gooddata/models/from_wire.rb

@@ -1,5 +1,7 @@
 # encoding: UTF-8
 
+require_relative 'from_wire_parse'
+
 module GoodData
   module Model
     module FromWire
@@ -105,6 +107,8 @@ module GoodData
             f[:type] = fact['fact']['identifier'] =~ /^dt\./ ? :date_fact : :fact
             f[:name] = fact['fact']['identifier'].split('.').last
             f[:title] = fact['fact']['title'] if fact['fact']['title'] != fact['fact']['identifier'].split('.').last.titleize
+            f[:description] = fact['fact']['description'] if fact['fact']['description']
+            f[:folder] = fact['fact']['folder'] if fact['fact']['folder']
             f[:gd_data_type] = fact['fact']['dataType'] if fact['fact'].key?('dataType')
           end
         end
@@ -120,6 +124,8 @@ module GoodData
           l[:reference] = attribute['identifier'].split('.').last if type == 'label'
           l[:name] = label['label']['identifier'].split('.').last
           l[:title] = label['label']['title'] if label['label']['title'] != label['label']['identifier'].split('.').last.titleize
+          l[:description] = attribute['description'] if %w(attribute anchor).include?(type) && attribute['description']
+          l[:folder] = attribute['folder'] if attribute['folder'] && (type == 'attribute' || type == 'anchor')
           l[:gd_data_type] = label['label']['dataType'] if label['label'].key?('dataType')
           l[:gd_type] = label['label']['type'] if label['label'].key?('type')
           l[:default_label] = true if default_label == label['label']['identifier']

data/lib/gooddata/models/from_wire_parse.rb

@@ -0,0 +1,125 @@
+# encoding: UTF-8
+
+module GoodData
+  module Model
+    module FromWire
+      # Converts anchor from wire format into an internal blueprint representation
+      #
+      # @param stuff [Hash] Whatever comes from wire
+      # @return [Hash] Manifest for a particular reference
+      def self.parse_anchor(stuff)
+        attribute = stuff['dataset']['anchor']['attribute']
+        if !attribute.key?('labels')
+          []
+        else
+          labels = attribute['labels'] || []
+          default_label = attribute['defaultLabel']
+          primary_label_name = attribute['identifier'].split('.').last
+          dataset_name = attribute['identifier'].split('.')[1]
+          primary_label_identifier = GoodData::Model.identifier_for({ name: dataset_name }, type: :primary_label, name: primary_label_name)
+          primary_labels, regular_labels = labels.partition { |x| x['label']['identifier'] == primary_label_identifier }
+          dl = primary_labels.map do |label|
+            parse_label(attribute, label, 'anchor', default_label)
+          end
+          rl = regular_labels.map do |label|
+            parse_label(attribute, label, 'label', default_label)
+          end
+          dl + rl
+        end
+      end
+
+      # Converts attrbutes from wire format into an internal blueprint representation
+      #
+      # @param stuff [Hash] Whatever comes from wire
+      # @return [Hash] Manifest for a particular reference
+      def self.parse_attributes(stuff)
+        dataset = stuff['dataset']
+        attributes = dataset['attributes'] || []
+        attributes.mapcat do |a|
+          attribute = a['attribute']
+          labels = attribute['labels'] || []
+          default_label = attribute['defaultLabel']
+          primary_label_name = attribute['identifier'].split('.').last
+          dataset_name = attribute['identifier'].split('.')[1]
+          primary_label_identifier = GoodData::Model.identifier_for({ name: dataset_name }, type: :primary_label, name: primary_label_name)
+          primary_labels, regular_labels = labels.partition { |x| x['label']['identifier'] == primary_label_identifier }
+          dl = primary_labels.map do |label|
+            parse_label(attribute, label, 'attribute', default_label)
+          end
+          rl = regular_labels.map do |label|
+            parse_label(attribute, label, 'label', default_label)
+          end
+          dl + rl
+        end
+      end
+
+      # Converts date dimensions from wire format into an internal blueprint representation
+      #
+      # @param stuff [Hash] Whatever comes from wire
+      # @return [Hash] Manifest for a particular reference
+      def self.parse_date_dimensions(stuff)
+        {}.tap do |d|
+          d[:type] = :date_dimension
+          # d[:urn] = :date_dimension
+          d[:name] = stuff['dateDimension']['name']
+          d[:title] = stuff['dateDimension']['title'] if stuff['dateDimension']['title'] != d[:name].titleize
+        end
+      end
+
+      # Converts facts from wire format into an internal blueprint representation
+      #
+      # @param stuff [Hash] Whatever comes from wire
+      # @return [Hash] Manifest for a particular reference
+      def self.parse_facts(stuff)
+        facts = stuff['dataset']['facts'] || []
+        facts.map do |fact|
+          {}.tap do |f|
+            f[:type] = fact['fact']['identifier'] =~ /^dt\./ ? :date_fact : :fact
+            f[:name] = fact['fact']['identifier'].split('.').last
+            f[:title] = fact['fact']['title'] if fact['fact']['title'] != fact['fact']['identifier'].split('.').last.titleize
+            f[:gd_data_type] = fact['fact']['dataType'] if fact['fact'].key?('dataType')
+          end
+        end
+      end
+
+      # Converts label from wire format into an internal blueprint representation
+      #
+      # @param stuff [Hash] Whatever comes from wire
+      # @return [Hash] Manifest for a particular reference
+      def self.parse_label(attribute, label, type, default_label = nil)
+        {}.tap do |l|
+          l[:type] = type
+          l[:reference] = attribute['identifier'].split('.').last if type == 'label'
+          l[:name] = label['label']['identifier'].split('.').last
+          l[:title] = label['label']['title'] if label['label']['title'] != label['label']['identifier'].split('.').last.titleize
+          l[:gd_data_type] = label['label']['dataType'] if label['label'].key?('dataType')
+          l[:gd_type] = label['label']['type'] if label['label'].key?('type')
+          l[:default_label] = true if default_label == label['label']['identifier']
+        end
+      end
+
+      # Converts label from wire format into an internal blueprint representation
+      #
+      # @param stuff [Hash] Whatever comes from wire
+      # @return [Hash] Manifest for a particular reference
+      def self.parse_references(stuff)
+        references = stuff['dataset']['references'] || []
+        references.map do |ref|
+          if ref =~ /^dataset\./
+            {
+              :type => :reference,
+              :name => ref.gsub(/^dataset\./, ''),
+              :dataset => ref.gsub(/^dataset\./, '')
+            }
+          else
+            {
+              :type => :date,
+              :name => ref.gsub(/^dataset\./, ''),
+              :dataset => ref.gsub(/^dataset\./, '')
+            }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/gooddata/models/metadata/attribute.rb

@@ -29,7 +29,7 @@ module GoodData
       # @param uri [String] Uri of the element. in the form of /gdc/md/PID/obj/OBJ_ID/elements?id=21
       # @return [String] Textual representation of a particular attribute element
       def find_element_value(uri, opts = { :client => @client, :project => @project })
-        matches = uri.match(/(.*)\/elements\?id=(\d+)$/)
+        matches = uri.match(%r{(.*)/elements\?id=(\d+)$})
         opts[:project].attributes(matches[1]).primary_label.find_element_value(uri)
       end
     end

data/lib/gooddata/models/metadata/label.rb

@@ -15,7 +15,7 @@ module GoodData
     # @return [String]
     def find_value_uri(value)
       escaped_value = CGI.escape(value)
-      results = client.post("#{uri}/validElements?limit=30&offset=0&order=asc&filter=#{escaped_value}", {})
+      results = client.post("#{uri}/validElements?limit=1&offset=0&order=asc&filter=#{escaped_value}", {})
       items = results['validElements']['items']
       if items.empty?
         fail(AttributeElementNotFound, value)
@@ -55,27 +55,28 @@ module GoodData
     # @return [Array]
     def values(options = {})
       limit = options[:limit] || 100
+      page_limit = 100
       offset = 0
       vals = []
       loop do
-        results = GoodData.post("#{uri}/validElements?limit=#{limit}&offset=#{offset}&order=asc", {})
-        x = results['validElements']['items'].map do |el|
+        results = GoodData.post("#{uri}/validElements?limit=#{page_limit}&offset=#{offset}&order=asc", {})
+        elements = results['validElements']
+        items = elements['items'].map do |el|
           v = el['element']
           {
             :value => v['title'],
             :uri => v['uri']
           }
         end
-        vals.concat(x)
-        break if vals.length < offset
-        offset += limit
+        vals.concat(items)
+        break if vals.length > limit || vals.length == elements['paging']['total'].to_i
+        offset += page_limit
       end
-      vals
+      vals.take(limit)
     end
 
-    def values_count(options = {})
-      limit = options[:limit] || 100
-      results = client.post("#{uri}/validElements?limit=#{limit}&offset=0&order=asc", {})
+    def values_count
+      results = client.post("#{uri}/validElements?limit=1&offset=0&order=asc", {})
       results['validElements']['paging']['total'].to_i
     end
 

data/lib/gooddata/models/model.rb

@@ -29,6 +29,10 @@ module GoodData
         item[:title] || item[:name].titleize
       end
 
+      def description(item)
+        item[:description]
+      end
+
       def identifier_for(dataset, column = nil, column2 = nil) # rubocop:disable UnusedMethodArgument
         return "dataset.#{dataset[:name]}" if column.nil?
         column = DatasetBlueprint.find_column_by_name(dataset, column) if column.is_a?(String)

data/lib/gooddata/models/profile.rb

@@ -59,7 +59,7 @@ module GoodData
           fail(ArgumentError, 'wrong type of argument. Should be either project ID or path')
         end
 
-        id = id.match(/[a-zA-Z\d]+$/)[0] if id =~ /\//
+        id = id.match(/[a-zA-Z\d]+$/)[0] if id =~ %r{/}
 
         c = client(opts)
         fail ArgumentError, 'No :client specified' if c.nil?
@@ -372,6 +372,15 @@ module GoodData
       (first_name || '') + (last_name || '')
     end
 
+    def sso_provider
+      @json['accountSetting']['ssoProvider']
+    end
+
+    def sso_provider=(an_sso_provider)
+      @dirty = true
+      @json['accountSetting']['ssoProvider'] = an_sso_provider
+    end
+
     def to_hash
       tmp = content.merge(uri: uri).symbolize_keys
       [
@@ -379,7 +388,8 @@ module GoodData
         [:phoneNumber, :phone],
         [:firstName, :first_name],
         [:lastName, :last_name],
-        [:authenticationModes, :authentication_modes]
+        [:authenticationModes, :authentication_modes],
+        [:ssoProvider, :sso_provider]
       ].each do |vals|
         wire, rb = vals
         tmp[rb] = tmp[wire]

data/lib/gooddata/models/project.rb

@@ -73,7 +73,7 @@ module GoodData
             fail(ArgumentError, 'wrong type of argument. Should be either project ID or path')
           end
 
-          id = id.match(/[a-zA-Z\d]+$/)[0] if id =~ /\//
+          id = id.match(/[a-zA-Z\d]+$/)[0] if id =~ %r{/}
 
           c = client(opts)
           fail ArgumentError, 'No :client specified' if c.nil?
@@ -431,8 +431,7 @@ module GoodData
     # Get WebDav directory for project data
     # @return [String]
     def project_webdav_path
-      u = URI(links['uploads'])
-      URI.join(u.to_s.chomp(u.path.to_s), '/project-uploads/', "#{pid}/")
+      client.project_webdav_path(:project => self)
     end
 
     # Gets project role by its identifier
@@ -1083,6 +1082,10 @@ module GoodData
       GoodData::Variable[id, options]
     end
 
+    def update_from_blueprint(blueprint, options = {})
+      GoodData::Model::ProjectCreator.migrate(options.merge(spec: blueprint, token: options[:auth_token], client: client, project: self))
+    end
+
     private
 
     def generate_user_payload(user_uri, status = 'ENABLED', roles_uri = nil)

data/lib/gooddata/models/project_blueprint.rb

@@ -161,7 +161,7 @@ module GoodData
         ProjectBlueprint.datasets(to_hash, options).map { |d| DatasetBlueprint.new(d) }
       end
 
-      def add_dataset(a_dataset, index = nil)
+      def add_dataset!(a_dataset, index = nil)
         if index.nil? || index > datasets.length
           data[:datasets] << a_dataset.to_hash
         else
@@ -458,10 +458,10 @@ module GoodData
             local_dataset = temp_blueprint.find_dataset(dataset.name)
             index = temp_blueprint.datasets.index(local_dataset)
             local_dataset.merge!(dataset)
-            temp_blueprint.remove_dataset(local_dataset.name)
-            temp_blueprint.add_dataset(local_dataset, index)
+            temp_blueprint.remove_dataset!(local_dataset.name)
+            temp_blueprint.add_dataset!(local_dataset, index)
           else
-            temp_blueprint.add_dataset(dataset.dup)
+            temp_blueprint.add_dataset!(dataset.dup)
           end
         end
         temp_blueprint

data/lib/gooddata/models/project_creator.rb

@@ -25,15 +25,13 @@ module GoodData
           fail('You need to specify token for project creation') if token.nil? && project.nil?
 
           begin
-            GoodData.with_project(project, opts) do |p|
-              migrate_datasets(spec, opts.merge(project: p, client: client))
-              load(p, spec)
-              migrate_metrics(p, spec[:metrics] || [])
-              migrate_reports(p, spec[:reports] || [])
-              migrate_dashboards(p, spec[:dashboards] || [])
-              execute_tests(p, spec[:assert_tests] || [])
-              p
-            end
+            migrate_datasets(spec, opts.merge(project: project, client: client))
+            load(p, spec)
+            migrate_metrics(p, spec[:metrics] || [])
+            migrate_reports(p, spec[:reports] || [])
+            migrate_dashboards(p, spec[:dashboards] || [])
+            execute_tests(p, spec[:assert_tests] || [])
+            project
           end
         end
 
@@ -46,7 +44,7 @@ module GoodData
           p = opts[:project]
           fail ArgumentError, 'No :project specified' if p.nil?
 
-          project = Project[p, { :client => client }]
+          project = client.projects(p)
           fail ArgumentError, 'Wrong :project specified' if project.nil?
 
           bp = ProjectBlueprint.new(spec)

data/lib/gooddata/models/report_data_result.rb

@@ -118,7 +118,8 @@ module GoodData
       kids = rows['tree']['children']
 
       if kids.empty? || (kids.size == 1 && kids.first['type'] == 'metric')
-        headers, size = [[nil]], 0
+        headers = [[nil]]
+        size = 0
       else
         headers = []
         size = each_level(headers, 0, rows['tree']['children'], rows['lookups'])
@@ -131,7 +132,8 @@ module GoodData
       kids = columns['tree']['children']
 
       if kids.empty? || (kids.size == 1 && kids.first['type'] == 'metric')
-        headers, size = [[nil]], 0
+        headers = [[nil]]
+        size = 0
       else
         headers = []
         size = each_level(headers, 0, columns['tree']['children'], columns['lookups'])

data/lib/gooddata/models/schedule.rb

@@ -13,11 +13,20 @@ module GoodData
 
     alias_method :data, :json
     alias_method :raw_data, :json
-    alias_method :to_hash, :json
 
     include GoodData::Mixin::RestResource
     root_key :schedule
 
+    SCHEDULE_TEMPLATE = {
+      :schedule => {
+        :type => nil,
+        :timezone => nil,
+        :params => {},
+        :hiddenParams => {},
+        :reschedule => nil
+      }
+    }
+
     class << self
       # Looks for schedule
       # @param id [String] URL, ID of schedule or :all
@@ -79,66 +88,28 @@ module GoodData
         project = GoodData::Project[p, options]
         fail ArgumentError, 'Wrong :project specified' if project.nil?
 
+        fail 'Process ID has to be provided' if process_id.blank?
+        fail 'Executable has to be provided' if executable.blank?
+
         default_opts = {
           :type => 'MSETL',
           :timezone => 'UTC',
           :params => {
-            :PROCESS_ID => process_id,
-            :EXECUTABLE => executable
+            'PROCESS_ID' => process_id,
+            'EXECUTABLE' => executable
           },
-          :hiddenParams => {},
-          :reschedule => options[:reschedule] || 0
-        }
-
-        if trigger =~ /[a-fA-Z0-9]{24}/
-          default_opts[:triggerScheduleId] = trigger
-        elsif trigger.is_a?(GoodData::Schedule)
-          default_opts[:triggerScheduleId] = trigger.obj_id
-        else
-          default_opts[:cron] = trigger
-        end
-
-        if options.key?(:hidden_params)
-          options[:hiddenParams] = options[:hidden_params]
-          options.delete :hidden_params
-        end
-
-        json = {
-          'schedule' => default_opts.deep_merge(options.except(:project, :client))
+          :reschedule => 0
         }
 
-        tmp = json['schedule'][:params][:PROCESS_ID]
-        fail 'Process ID has to be provided' if tmp.nil? || tmp.empty?
-
-        tmp = json['schedule'][:params][:EXECUTABLE]
-        fail 'Executable has to be provided' if tmp.nil? || tmp.empty?
-
-        tmp = json['schedule'][:cron] || json['schedule'][:triggerScheduleId]
-        fail 'trigger schedule has to be provided' if !tmp || tmp.nil? || tmp.empty?
+        schedule = c.create(GoodData::Schedule, GoodData::Helpers.stringify_keys_deep!(SCHEDULE_TEMPLATE.deep_dup), client: c, project: p)
 
-        tmp = json['schedule'][:timezone]
-        fail 'A timezone has to be provided' if tmp.nil? || tmp.empty?
-
-        tmp = json['schedule'][:type]
-        fail 'Schedule type has to be provided' if tmp.nil? || tmp.empty?
-
-        params = json['schedule'][:params]
-        params = GoodData::Helpers.encode_params(params, false)
-        json['schedule'][:params] = params
-
-        hidden_params = json['schedule'][:hiddenParams]
-        if hidden_params && !hidden_params.empty?
-          hidden_params = GoodData::Helpers.encode_params(json['schedule'][:hiddenParams], true)
-          json['schedule'][:hiddenParams] = hidden_params
-        end
-
-        url = "/gdc/projects/#{project.pid}/schedules"
-        res = c.post url, json
-
-        fail 'Unable to create new schedule' if res.nil?
-
-        new_obj_json = c.get res['schedule']['links']['self']
-        c.create(GoodData::Schedule, new_obj_json, client: c, project: p)
+        schedule.hidden_params = options[:hidden_params]
+        schedule.set_trigger(trigger)
+        schedule.params = default_opts[:params].merge(options[:params] || {})
+        schedule.timezone = options[:timezone] || default_opts[:timezone]
+        schedule.schedule_type = options[:type] || default_opts[:type]
+        schedule.reschedule = options[:reschedule] || default_opts[:reschedule]
+        schedule.save
       end
     end
 
@@ -147,10 +118,24 @@ module GoodData
     # @param json [Object] Raw JSON
     # @return [GoodData::Schedule] New GoodData::Schedule instance
     def initialize(json)
+      json = GoodData::Helpers.stringify_keys_deep!(json)
       super
+      GoodData::Helpers.decode_params(json['schedule']['params'] || {})
+      GoodData::Helpers.decode_params(json['schedule']['hiddenParams'] || {})
       @json = json
     end
 
+    def after
+      schedules.find { |s| s.obj_id == trigger_id }
+    end
+
+    def after=(schedule)
+      fail 'After trigger has to be a schedule object' unless schedule.is_a?(Schedule)
+      json['schedule']['triggerScheduleId'] = schedule.obj_id
+      @json['schedule']['cron'] = nil
+      @dirty = true
+    end
+
     # Deletes schedule
     def delete
       client.delete uri
@@ -260,6 +245,7 @@ module GoodData
     # @param new_cron [String] Cron settings to be set
     def cron=(new_cron)
       @json['schedule']['cron'] = new_cron
+      @json['schedule']['triggerScheduleId'] = nil
       @dirty = true
     end
 
@@ -312,7 +298,9 @@ module GoodData
       if @json # rubocop:disable Style/GuardClause
         url = @json['schedule']['links']['executions']
         res = client.get url
-        res['executions']['items']
+        res['executions']['items'].map do |e|
+          client.create(Execution, e, :project => project)
+        end
       end
     end
 
@@ -326,8 +314,12 @@ module GoodData
     # Assigns execution parameters
     #
     # @param params [String] Params to be set
-    def params=(new_param)
-      @json['schedule']['params'].merge!(new_param)
+    def params=(new_params = {})
+      default_params = {
+        'PROCESS_ID' => process_id,
+        'EXECUTABLE' => executable
+      }
+      @json['schedule']['params'] = default_params.merge(new_params || {})
       @dirty = true
     end
 
@@ -341,8 +333,8 @@ module GoodData
     # Assigns hidden parameters
     #
     # @param new_hidden_param [String] Hidden parameters to be set
-    def hidden_params=(new_hidden_param)
-      @json['schedule']['hiddenParams'] = hidden_params.merge(new_hidden_param)
+    def hidden_params=(new_hidden_params = {})
+      @json['schedule']['hiddenParams'] = new_hidden_params || {}
       @dirty = true
     end
 
@@ -350,24 +342,87 @@ module GoodData
     #
     # @return [Boolean] True if saved
     def save
+      fail 'trigger schedule has to be provided' if cron.blank? && trigger_id.blank?
+      fail 'A timezone has to be provided' if timezone.blank?
+      fail 'Schedule type has to be provided' if schedule_type.blank?
       if @dirty
         update_json = {
           'schedule' => {
+            'name' => @json['schedule']['name'],
             'type' => @json['schedule']['type'],
             'state' => @json['schedule']['state'],
             'timezone' => @json['schedule']['timezone'],
+            'reschedule' => @json['schedule']['reschedule'],
             'cron' => @json['schedule']['cron'],
-            'params' => @json['schedule']['params'],
-            'hiddenParams' => @json['schedule']['hiddenParams'],
-            'reschedule' => @json['schedule']['reschedule'] || 0
-          }
+            'triggerScheduleId' => trigger_id,
+            'params' => GoodData::Helpers.encode_params(params, false),
+            'hiddenParams' => GoodData::Helpers.encode_params(hidden_params, true)
+          }.compact
         }
-        res = client.put(uri, update_json)
-        @json = res
+        if uri
+          res = client.put(uri, update_json)
+          @json = res
+        else
+          res = client.post "/gdc/projects/#{project.pid}/schedules", update_json
+          fail 'Unable to create new schedule' if res.nil?
+          new_obj_json = client.get res['schedule']['links']['self']
+          @json = new_obj_json
+        end
         @dirty = false
-        return true
       end
-      false
+      self
+    end
+
+    def time_based?
+      cron != nil
+    end
+
+    def to_hash
+      {
+        name: name,
+        type: type,
+        state: state,
+        params: params,
+        hidden_params: hidden_params,
+        cron: cron,
+        trigger_id: trigger_id,
+        timezone: timezone,
+        uri: uri
+      }.compact
+    end
+
+    def schedule_type
+      json['schedule']['type']
+    end
+
+    def schedule_type=(type)
+      json['schedule']['type'] = type
+    end
+
+    def trigger_id
+      json['schedule']['triggerScheduleId']
+    end
+
+    def trigger_id=(a_trigger)
+      json['schedule']['triggerScheduleId'] = a_trigger
+    end
+
+    def name
+      json['schedule']['name']
+    end
+
+    def name=(name)
+      json['schedule']['name'] = name
+    end
+
+    def set_trigger(trigger) # rubocop:disable Style/AccessorMethodName
+      if trigger.is_a?(String) && trigger =~ /[a-fA-Z0-9]{24}/
+        self.trigger_id = trigger
+      elsif trigger.is_a?(GoodData::Schedule)
+        self.trigger_id = trigger.obj_id
+      else
+        self.cron = trigger
+      end
     end
 
     # Returns URL