gooddata 0.6.10 → 0.6.11

data/lib/gooddata/rest/object.rb

@@ -11,7 +11,7 @@ module GoodData
       attr_writer :client
       attr_accessor :project
 
-      def initialize(opts = {})
+      def initialize(_opts = {})
         @client = nil
       end
 

data/lib/gooddata/version.rb

@@ -2,7 +2,7 @@
 
 # GoodData Module
 module GoodData
-  VERSION = '0.6.10'
+  VERSION = '0.6.11'
 
   class << self
     # Version

data/spec/bricks/bricks_spec.rb

@@ -17,6 +17,73 @@ describe GoodData::Bricks do
     p.call({})
   end
 
+  describe "#load_defaults" do
+    context "when you define a middleware with default_loaded_call and give it some defaults file with prefix" do
+      class TestMiddleWare < GoodData::Bricks::Middleware
+        def initialize(options={})
+          @config = 'spec/bricks/default-config.json'
+          super(options)
+        end
+
+        def call(params)
+          params = super(params)
+          my_stuff = params['config']['my']['namespace']
+          puts "Now I have the defaults and runtime parameters merged and loaded: #{my_stuff['key']}"
+
+          # Doing something cool and puting it into params
+          params['something_cool'] = "#{my_stuff['key']} and also #{my_stuff['default_key']}"
+
+          @app.call(params)
+        end
+      end
+
+      class TestBrick
+        def call(params)
+          # doing something with params
+          puts "Brick: #{params['something_cool']}"
+          params
+        end
+      end
+
+      it "puts them into params" do
+        p = GoodData::Bricks::Pipeline.prepare([
+          TestMiddleWare,
+          TestBrick
+        ])
+
+        res = p.call({
+          'config' => {
+            'my' => {
+              'namespace' => {
+                'key' => 'redefined value',
+                'new_key' => 'new value'
+              }
+            },
+            'other_namespace' => {
+              'some_key' => 'some value'
+            }
+          }
+        })
+
+        res.should eq({
+          'config' => {
+            'my' => {
+              'namespace' => {
+                'key' => 'redefined value',
+                'new_key' => 'new value',
+                'default_key' => 'default value 2'
+              }
+            },
+            'other_namespace' => {
+              'some_key' => 'some value'
+            }
+          },
+          "something_cool" => "redefined value and also default value 2"
+        })
+      end
+    end
+  end
+
 
   # TODO: Better test pre and post so we are sure it is executed in right order
   it "should be possible to use instance both as middleware and app" do

data/spec/bricks/default-config.json

@@ -0,0 +1,8 @@
+{
+  "my": {
+    "namespace": {
+      "key": "default value",
+      "default_key": "default value 2"
+    }
+  }
+}

data/spec/data/gooddata_version_process/gooddata_version.rb

@@ -0,0 +1,3 @@
+require 'gooddata'
+
+puts "GoodData::VERSION - #{GoodData::VERSION}"

data/spec/data/ruby_params_process/ruby_params.rb

@@ -0,0 +1,3 @@
+require 'json'
+
+puts $SCRIPT_PARAMS.inspect

data/spec/helpers/process_helper.rb

@@ -2,6 +2,7 @@
 
 # Global requires
 require 'multi_json'
+require 'pmap'
 
 # Local requires
 require 'gooddata/models/models'
@@ -9,4 +10,15 @@ require 'gooddata/models/models'
 module ProcessHelper
   PROCESS_ID = 'dc143d80-58a1-4acd-96b6-8d11fc4571de'
   DEPLOY_NAME = 'graph'
+
+  class << self
+    def remove_old_processes(project)
+      processes = project.processes
+      processes.pmap do |process|
+        next if process.obj_id == PROCESS_ID
+        puts "Deleting #{process.inspect}"
+        process.delete
+      end
+    end
+  end
 end

data/spec/helpers/schedule_helper.rb

@@ -0,0 +1,21 @@
+# encoding: UTF-8
+
+require 'pmap'
+
+require_relative 'process_helper'
+
+module ScheduleHelper
+  SCHEDULE_ID = '53e029bde4b035034ad4abb6'
+
+  class << self
+    def remove_old_schedules(project)
+      schedules = project.schedules
+      schedules.pmap do |schedule|
+        next if schedule.obj_id == SCHEDULE_ID
+
+        puts "Deleting #{schedule.inspect}"
+        schedule.delete
+      end
+    end
+  end
+end

data/spec/integration/create_project_spec.rb

@@ -0,0 +1,19 @@
+require 'gooddata'
+
+describe 'Create project using GoodData client', :constraint => 'slow' do
+  before(:all) do
+    @client = ConnectionHelper.create_default_connection
+  end
+
+  after(:all) do
+    @client.disconnect
+  end
+
+  it 'Should create project using GoodData::Rest::Client#create_project' do
+    project_title = 'Test #create_project'
+    project = @client.create_project(:title => project_title, :auth_token => ConnectionHelper::GD_PROJECT_TOKEN)
+    expect(project.title).to eq(project_title)
+    project.delete
+  end
+
+end

data/spec/integration/full_process_schedule_spec.rb

@@ -1,6 +1,25 @@
 require 'gooddata'
 
 describe "Full process and schedule exercise", :constraint => 'slow' do
+  COMPLEX_PARAMS ||= {
+    type: 'Person',
+    model_version: 1,
+    data_version: 1.5,
+    some_true_flag: true,
+    some_false_flag: false,
+    empty_value: nil,
+    user: {
+      firstname: 'Joe',
+      lastname: 'Doe',
+      age: 42
+    },
+    address: {
+      street: '#111 Sutter St.',
+      city: 'San Francisco',
+      zip: '94133'
+    }
+  }
+
   before(:all) do
     @client = ConnectionHelper::create_default_connection
     @project = @client.create_project(title: 'Project for schedule testing', auth_token: ConnectionHelper::GD_PROJECT_TOKEN)
@@ -17,23 +36,50 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
 
   it "should be able to execute a process" do
     result = @process.execute(@process.executables.first)
-    log = @client.get(result['executionDetail']['links']['log'])
+    log = result.log
     expect(log.index('Hello Ruby executors')).not_to eq nil
     expect(log.index('Hello Ruby from the deep')).not_to eq nil
   end
 
-  it "should be able to grab executables" do 
+  it "should be able to start executing a process" do
+    result = @process.start_execution(@process.executables.first)
+    expect(result["executionTask"]).not_to be_nil
+    expect(result["executionTask"]['links']['detail']).not_to be_nil
+  end
+
+  it "should be able to grab executables" do
 
-    expect(@process.executables).to eq ['./process.rb']
+    expect(@process.executables).to eq ['process.rb']
   end
 
-  it "should have empty schedules on deploy" do 
+  it "should have empty schedules on deploy" do
     expect(@process.schedules).to eq []
   end
 
+  it "should be able to create schedule triggered by another schedule" do
+    schedule_first = @process.create_schedule('0 15 27 7 *', @process.executables.first)
+    schedule = @process.create_schedule(schedule_first, @process.executables.first)
+    res = @process.schedules
+    expect(res.count).to eq 2
+    expect(@process.schedules.map(&:uri)).to include(schedule_first.uri, schedule.uri)
+    schedule.delete
+    schedule_first.delete
+  end
+
+  it "should be able to create schedule triggered by another schedule specified by ID" do
+    schedule_first = @process.create_schedule('0 15 27 7 *', @process.executables.first)
+    schedule = @process.create_schedule(schedule_first.obj_id, @process.executables.first)
+    res = @process.schedules
+    expect(res.count).to eq 2
+    expect(@process.schedules.map(&:uri)).to include(schedule_first.uri, schedule.uri)
+    schedule.delete
+    schedule_first.delete
+  end
+
   it "should be able to delete schedule" do
     schedule = @process.create_schedule('0 15 27 7 *', @process.executables.first)
-    expect(@process.schedules.count).to eq 1
+    res = @process.schedules
+    expect(res.count).to eq 1
     expect(@process.schedules).to eq [schedule]
     schedule.delete
   end
@@ -47,7 +93,8 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
   it "should be possible to execute schedule" do
     schedule = @process.create_schedule('0 15 27 7 *', @process.executables.first)
     result = schedule.execute
-    log = @client.get(result['execution']['log'])
+    expect(result.status).to eq :ok
+    log = result.log
     expect(log.index('Hello Ruby executors')).not_to eq nil
     expect(log.index('Hello Ruby from the deep')).not_to eq nil
   end
@@ -59,7 +106,8 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
     begin
       schedule = process.create_schedule('0 15 27 7 *', process.executables.first)
       result = schedule.execute
-      log = @client.get(result['execution']['log'])
+      expect(result.status).to eq :ok
+      log = result.log
       expect(log.index('HELLO WORLD')).not_to eq nil
       expect(schedule.enabled?).to be_true
       schedule.disable
@@ -70,6 +118,7 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
       schedule.save
       expect(schedule.enabled?).to be_true
     ensure
+      schedule && schedule.delete
       process && process.delete
     end
   end
@@ -82,9 +131,81 @@ describe "Full process and schedule exercise", :constraint => 'slow' do
       expect(process.schedules.count).to eq 0
       schedule = process.create_schedule('0 15 27 7 *', process.executables.first)
       result = schedule.execute
-      log = @client.get(result['execution']['log'])
+      expect(result.status).to eq :ok
+      log = result.log
       expect(log.index('HELLO WORLD')).not_to eq nil
       expect(process.schedules.count).to eq 1
+    ensure
+      schedule && schedule.delete
+      process && process.delete
+    end
+  end
+
+  it 'should be possible to deploy and run zipped file and print GoodData::VERSION' do
+    process = @project.deploy_process('./spec/data/gooddata_version_process/gooddata_version.zip',
+                                      type: 'RUBY',
+                                      name: 'Test ETL zipped file GoodData Process')
+    begin
+      expect(process.schedules.count).to eq 0
+      schedule = process.create_schedule('0 15 27 7 *', process.executables.first)
+      result = schedule.execute
+      expect(result.status).to eq :ok
+      log = result.log
+      expect(log.index(GoodData::VERSION)).not_to eq nil
+      expect(process.schedules.count).to eq 1
+    ensure
+      schedule && schedule.delete
+      process && process.delete
+    end
+  end
+
+  it 'should be possible to deploy and run directory and use nested parameters' do
+    process = @project.deploy_process('./spec/data/ruby_params_process',
+                                      type: 'RUBY',
+                                      name: 'Test ETL dir GoodData Process')
+    begin
+      expect(process.schedules.count).to eq 0
+      schedule = process.create_schedule('0 15 27 7 *', process.executables.first, params: COMPLEX_PARAMS)
+      result = schedule.execute
+      expect(result.status).to eq :ok
+      log = result.log
+      expect(log.index('Joe')).not_to eq nil
+      expect(log.index('San Francisco')).not_to eq nil
+      expect(process.schedules.count).to eq 1
+    ensure
+      schedule && schedule.delete
+      process && process.delete
+    end
+  end
+
+  it 'should be possible to deploy and run directory and use nested hidden parameters' do
+    process = @project.deploy_process('./spec/data/ruby_params_process',
+                                      type: 'RUBY',
+                                      name: 'Test ETL dir GoodData Process')
+    begin
+      expect(process.schedules.count).to eq 0
+      schedule = process.create_schedule('0 15 27 7 *', process.executables.first, hidden_params: COMPLEX_PARAMS)
+      result = schedule.execute
+      # expect(result.status).to eq :ok
+      log = result.log
+      expect(process.schedules.count).to eq 1
+    ensure
+      schedule && schedule.delete
+      process && process.delete
+    end
+  end
+
+  it "should be possible to download deployed process" do
+    size = File.size('./spec/data/hello_world_process/hello_world.zip')
+    process = @project.deploy_process('./spec/data/hello_world_process/hello_world.zip',
+                                  type: 'RUBY',
+                                  name: 'Test ETL zipped file Process')
+    begin
+      Tempfile.open('downloaded-process') do |temp|
+        temp << process.download
+        temp.flush
+        expect(File.size(temp.path)).to eq size
+      end
     ensure
       process && process.delete
     end

data/spec/integration/full_project_spec.rb

@@ -109,6 +109,26 @@ describe "Full project implementation", :constraint => 'slow' do
     expect(result2).to eq result
   end
 
+  it "should be able to lock reports and everything underneath" do
+    m = @project.metrics.first
+    r = @project.create_report(top: [m], title: 'xy')
+    r.save
+    expect(m.locked?).to eq false
+    expect(r.locked?).to eq false
+    r.lock_with_dependencies!
+    expect(r.locked?).to eq true
+    m.reload!
+    expect(m.locked?).to eq true
+    r.unlock_with_dependencies!
+    expect(r.locked?).to eq false
+    m.reload!
+    expect(m.locked?).to eq false
+    r.lock!
+    expect(r.locked?).to eq true
+    r.unlock!
+    expect(r.locked?).to eq false
+  end
+
   it "should be able to purge report from older revisions" do
     m = @project.metrics.first
     r = @project.create_report(top: [m], title: 'xy')
@@ -121,6 +141,25 @@ describe "Full project implementation", :constraint => 'slow' do
     expect(r.definitions.count).to eq 2
   end
 
+  it "should be able to clean colors from a chart report def" do
+    f = @project.fact_by_title('Lines Changed')
+    m = @project.create_metric("SELECT SUM(#\"#{f.title}\")", title: 'test metric').save
+    r = @project.create_report(top: [m], title: 'xy')
+    rd = r.latest_report_definition
+    rd.content['chart'] = { 'styles' => { 'global' => { 'colorMapping' => 1 } } }
+    expect(GoodData::Helpers.get_path(rd.content, %w(chart styles global))).to eq ({ 'colorMapping' => 1 })
+    rd.reset_color_mapping!
+    expect(GoodData::Helpers.get_path(rd.content, %w(chart styles global))).to eq ({ 'colorMapping' => [] })
+    r.delete
+    res = m.used_by
+    res.each do |dependency|
+      @client.delete dependency['link']
+    end
+    res = m.used_by
+    expect(res.length).to eq 0
+    m.delete
+  end
+
   it "should be possible to get all metrics" do
     metrics1 = @project.metrics
     expect(metrics1.count).to be >= 0
@@ -176,10 +215,12 @@ describe "Full project implementation", :constraint => 'slow' do
     expect(fact1).not_to eq fact3
 
     metric.using(nil)
-    expect(metric.using('fact').count).to eq 1
+    res = metric.using('fact')
+    expect(res.count).to eq 1
 
     fact1.used_by(nil)
-    expect(fact1.used_by('metric').count).to eq 1
+    res = fact1.used_by('metric')
+    expect(res.count).to eq 1
 
     res = metric.using?(fact1)
     expect(res).to be(true)
@@ -362,4 +403,13 @@ describe "Full project implementation", :constraint => 'slow' do
     expect(cloned_project.facts.first.create_metric.execute).to eq nil
     cloned_project.delete
   end
+
+  it "should be able to delete report along with its definitions" do
+    m = @project.metrics.first
+    r = @project.create_report(top: [m], title: 'Report to delete')
+    r.save
+    def_uris = r.definition_uris
+    r.delete
+    expect { def_uris.each {|uri| @client.get(uri)} }.to raise_error(RestClient::ResourceNotFound)
+  end
 end

data/spec/spec_helper.rb

@@ -23,6 +23,7 @@ RSpec.configure do |config|
   config.include CsvHelper
   config.include ProcessHelper
   config.include ProjectHelper
+  config.include ScheduleHelper
   # config.include SchemaHelper
 
   config.filter_run_excluding :broken => true

data/spec/unit/core/rest_spec.rb

@@ -1,4 +1,5 @@
 # encoding: UTF-8
+require 'tempfile'
 
 require 'gooddata/core/rest'
 
@@ -18,13 +19,85 @@ describe GoodData do
     end
   end
 
+
+  def test_webdav_upload(params)
+    GoodData.with_project(@project, :client => @client) do
+      dir = Time.now.to_i.to_s
+
+      path = 'spec/data/test-ci-data.csv'
+
+      if params[:special_chars]
+        source_file = Tempfile.new('abc-16:55:29+ha#he.csv')
+        FileUtils.cp(path, source_file)
+        path = source_file.path
+      end
+
+      path = File.expand_path(path) if params[:absolute_path]
+
+      # upload it there
+      upload_method = GoodData.method(params[:upload_method])
+      upload_method.call(path, directory: dir)
+
+      # download it from there
+      file = Tempfile.new('foo.csv')
+
+      download_method = GoodData.method(params[:download_method])
+      download_method.call(File.basename(path), file, directory: dir)
+
+      expect(file.size).to be > 0
+    end
+
+  end
   describe '#upload_to_project_webdav' do
-    it 'Uploads file' do
-      pending('Research how to properly upload file')
-      @client.upload_to_project_webdav('spec/data/test-ci-data.csv', :project => @project)
+    it 'Uploads file with relative path to a dir' do
+      test_webdav_upload(
+        upload_method: 'upload_to_project_webdav',
+        download_method: 'download_from_project_webdav'
+      )
+    end
+
+    it 'Uploads file with absolute path to a dir' do
+      test_webdav_upload(
+        absolute_path: true,
+        upload_method: 'upload_to_project_webdav',
+        download_method: 'download_from_project_webdav'
+      )
+    end
+
+    it 'Uploads file with special chars in filename' do
+      test_webdav_upload(
+        special_chars: true,
+        upload_method: 'upload_to_project_webdav',
+        download_method: 'download_from_project_webdav'
+      )
     end
   end
 
+  describe '#upload_to_user_webdav' do
+    it 'Uploads file with relative path to a dir' do
+      test_webdav_upload(
+        upload_method: 'upload_to_user_webdav',
+        download_method: 'download_from_user_webdav'
+      )
+    end
+
+    it 'Uploads file with absolute path to a dir' do
+      test_webdav_upload(
+        absolute_path: true,
+        upload_method: 'upload_to_user_webdav',
+        download_method: 'download_from_user_webdav'
+      )
+    end
+    it 'Uploads file with special chars in filename' do
+      test_webdav_upload(
+        special_chars: true,
+        upload_method: 'upload_to_user_webdav',
+        download_method: 'download_from_user_webdav'
+      )
+    end
+  end
+
+
   describe '#get_user_webdav_path' do
     it 'Gets the path' do
       @client.get_user_webdav_path('test.csv', :project => @project)

data/spec/unit/helpers_spec.rb

@@ -44,4 +44,47 @@ describe GoodData::Helpers do
       result.should == expect
     end
   end
+
+  describe "#decode_params" do
+    it 'decodes the data params from json' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'gd_encoded_params' => '{"deep": {"deeper": "deep value"}}',
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        'deep' => {
+          'deeper' => 'deep value'
+        }
+      }
+      result = GoodData::Helpers.decode_params(params)
+      expect(result).to eq(expected_result)
+    end
+    it 'decodes the hidden_data in hidden params' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'gd_encoded_hidden_params' => '{"deep_secret": {"deeper_secret": "hidden value"}}'
+      }
+      expected_result = {
+        'param' => 'value',
+        'number_param' => 5,
+        "deep_secret" => {
+          "deeper_secret" => "hidden value"
+        }
+      }
+      result = GoodData::Helpers.decode_params(params)
+      expect(result).to eq(expected_result)
+    end
+    it 'throws an error when data params is not a valid json' do
+      params = {
+        'param' => 'value',
+        'number_param' => 5,
+        'gd_encoded_params' => 'This is no json.'
+      }
+      expect { GoodData::Helpers.decode_params(params) }.to raise_error(JSON::ParserError)
+    end
+  end
 end

data/spec/unit/models/metric_spec.rb

@@ -17,6 +17,7 @@ describe GoodData::Metric do
                      'identifier' => 'afo7bx1VakCz',
                      'deprecated' => '0',
                      'summary' => '',
+                     'locked' => 0,
                      'title' => 'sum of Lines changed',
                      'category' => 'metric',
                      'updated' => '2014-05-05 20:00:42',
@@ -34,6 +35,7 @@ describe GoodData::Metric do
                      'identifier' => 'afo7bx1VakCz',
                      'deprecated' => '0',
                      'summary' => '',
+                     'locked' => 1,
                      'title' => 'sum of Lines changed',
                      'category' => 'metric',
                      'updated' => '2014-05-05 20:00:42',
@@ -55,6 +57,7 @@ describe GoodData::Metric do
                     'identifier' => 'afo7bx1VakCz',
                     'deprecated' => '0',
                     'summary' => '',
+                    'locked' => 0,
                     'title' => 'sum of Lines changed',
                     'category' => 'metric',
                     'updated' => '2014-05-05 20:00:42',
@@ -89,4 +92,34 @@ describe GoodData::Metric do
       @instance.contain?(UNUSED_METRIC).should == true
     end
   end
+
+  describe "#locked?" do
+    it "should be able to say if an object is locked" do
+      expect(@instance.locked?).to eq false
+    end
+  end
+
+  describe "#unlocked?" do
+    it "should be able to say if an object is unlocked" do
+      expect(@instance.unlocked?).to eq true
+    end
+  end
+
+  describe "#lock" do
+    it "should be able to lock an object" do
+      expect(@instance.locked?).to eq false
+      @instance.lock
+      expect(@instance.locked?).to eq true
+    end
+  end
+
+  describe "#lock" do
+    it "should be able to unlock an object" do
+      @instance.lock
+      expect(@instance.locked?).to eq true
+      @instance.unlock
+      expect(@instance.locked?).to eq false
+      expect(@instance.unlocked?).to eq true
+    end
+  end
 end