gooddata 0.6.0 → 0.6.2

data/Gemfile

@@ -2,4 +2,3 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in gooddata.gemspec
 gemspec
-

data/README.md

@@ -17,8 +17,6 @@ The best documentation for the GoodData API can be found using these resources:
 [![Code Climate](https://codeclimate.com/github/gooddata/gooddata-ruby.png)](https://codeclimate.com/github/gooddata/gooddata-ruby)
 [![Build Status](https://travis-ci.org/gooddata/gooddata-ruby.png)](https://travis-ci.org/gooddata/gooddata-ruby)
 [![Coverage Status](https://coveralls.io/repos/gooddata/gooddata-ruby/badge.png)](https://coveralls.io/r/gooddata/gooddata-ruby)
-[![Build Status](https://travis-ci.org/gooddata/gooddata-ruby.png)](https://travis-ci.org/gooddata/gooddata-ruby)
-
 
 ## Install
 
@@ -44,6 +42,8 @@ If you are using gems just
   future version unintentionally.
 * Commit, do not mess with rakefile, version, or history.
   (if you want to have your own version, that is fine but bump version in a commit by itself we can ignore when we pull)
+* run `rake test` and make sure all tests passes
+* run `rake cop` and make sure you did not introduced any new coding rules issues 
 * Send us a pull request. Bonus points for topic branches.
 
 ## Credits

data/Rakefile

@@ -1,3 +1,5 @@
+# encoding: UTF-8
+
 require 'rubygems'
 
 require 'bundler/setup'
@@ -6,6 +8,7 @@ require 'bundler/gem_tasks'
 require 'coveralls/rake/task'
 
 require 'rake/testtask'
+require 'rake/notes/rake_task'
 require 'rspec/core/rake_task'
 
 require 'yard'
@@ -17,14 +20,58 @@ end
 
 Coveralls::RakeTask.new
 
-desc "Create rspec coverage"
-task :coverage do
-  ENV['COVERAGE'] = 'true'
-  Rake::Task["test:unit"].execute
+desc 'Run continuous integration test'
+task :ci do
+  Rake::Task['test:unit'].invoke
+  unless ENV['TRAVIS'] == 'true' && ENV['TRAVIS_SECURE_ENV_VARS'] == 'false'
+    Rake::Task['test:integration'].invoke
+  end
+  Rake::Task['test:cop'].invoke if RUBY_VERSION.start_with?('2.2') == false
+  Rake::Task['coveralls:push'].invoke
+end
+
+namespace :hook do
+  hook_path = File.join(File.dirname(__FILE__), '.git', 'hooks', 'pre-commit').to_s
+
+  desc 'Installs git pre-commit hook running rubocop'
+  task :install do |t|
+    if(File.exist?(hook_path))
+      puts 'Git pre-commit hook is already installed'
+    else
+      File.open(hook_path, 'w') do |file|
+        file.write("#! /usr/bin/env bash\n")
+        file.write("\n")
+        file.write("rake cop\n")
+      end
+      system "chmod 755 #{hook_path}"
+      puts 'Git commit hook was installed'
+    end
+  end
+
+  desc 'Uninstalls git pre-commit hook'
+  task :uninstall do |t|
+    res = File.exist?(hook_path)
+    if res
+      puts 'Uninstalling git pre-commit hook'
+      system "rm #{hook_path}"
+      puts 'Git pre-commit hook was uninstalled'
+    else
+      puts 'Git pre-commit hook is not installed'
+    end
+  end
+
+  desc 'Checks if is git pre-commit hook installed'
+  task :check do
+    res = File.exist?(hook_path)
+    if res
+      puts 'Git pre-commit IS installed'
+    else
+      puts 'Git pre-commit IS NOT installed'
+    end
+  end
+
 end
 
-desc 'Run tests with coveralls'
-task :coveralls => ['coverage', 'coveralls:push']
 
 RSpec::Core::RakeTask.new(:test)
 
@@ -44,7 +91,12 @@ namespace :test do
     t.pattern = 'test/**/test_*.rb'
   end
 
-  task :all => [:unit, :integration]
+  desc "Run coding style tests"
+  RSpec::Core::RakeTask.new(:cop) do |t|
+    Rake::Task['cop'].invoke
+  end
+
+  task :all => [:unit, :integration, :cop]
 end
 
 desc "Run all tests"
@@ -56,4 +108,4 @@ end
 
 YARD::Rake::YardocTask.new
 
-task :default => [:usage]
+task :default => [:usage]

data/doc/templates/default/module/setup.rb

@@ -37,7 +37,7 @@ def method_listing(include_specials = true)
   return @meths if @meths
   @meths = object.meths(:inherited => false, :included => !options.embed_mixins.empty?)
   if options.embed_mixins.size > 0
-    @meths = @meths.reject {|m| options.embed_mixins_match?(m.namespace) == false }
+    @meths = @meths.reject {|m| !options.embed_mixins_match?(m.namespace) }
   end
   @meths = sort_listing(prune_method_listing(@meths))
   @meths

data/examples.rb

@@ -1,3 +1,5 @@
+# encoding: UTF-8
+
 # This file shows how the GoodData Ruby API could be used from
 # a client code
 # 

data/gooddata

@@ -2,6 +2,8 @@
 
 require_relative "lib/gooddata/cli/cli"
 
+require_relative 'lib/gooddata/models/domain'
+
 res = GoodData::CLI.main(ARGV)
 
 exit(res)

data/gooddata.gemspec

@@ -10,7 +10,9 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = [
       "Pavel Kolesnikov",
-      "Thomas Watson Steen"
+      "Thomas Watson Steen",
+      "Tomas Svarovsky",
+      "Tomas Korcak"
   ]
 
   s.summary = %q{A convenient Ruby wrapper around the GoodData RESTful API}
@@ -27,24 +29,26 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
   s.rubygems_version = "1.3.7"
 
-  s.add_development_dependency "rake", "~> 10.2.2"
-  s.add_development_dependency "redcarpet", "~> 3.1.1"
+  s.add_development_dependency "rake", "~> 10.3.1"
+  s.add_development_dependency "rake-notes", "~> 0.2.0"
+  s.add_development_dependency "redcarpet", "~> 3.1.1" if RUBY_PLATFORM != 'java'
   s.add_development_dependency "rspec", "~> 2.14.1"
-  s.add_development_dependency "rubocop", "~> 0.20.0"
+  s.add_development_dependency "rubocop", "~> 0.20.1"
   s.add_development_dependency "simplecov", "~> 0.8.2"
   s.add_development_dependency "yard", "~> 0.8.7.3"
   s.add_development_dependency "yard-rspec", "~> 0.1"
-  s.add_development_dependency "ZenTest", "~> 4.9.5"
+  s.add_development_dependency "ZenTest", "~> 4.10.0"
   s.add_development_dependency "coveralls", "~> 0.7.0"
 
-  s.add_dependency "activesupport", "~> 4.0.3"
+  s.add_dependency "activesupport", "~> 4.1.0"
   s.add_dependency "bundler", ">= 1.6.1"
+  s.add_dependency 'docile', '~> 1.1.3'
   s.add_dependency "erubis", "~> 2.7.0"
-  s.add_dependency "gli", "~> 2.9.0"
+  s.add_dependency "gli", "~> 2.10.0"
   s.add_dependency "highline", "~> 1.6.21"
   s.add_dependency "i18n", "~> 0.6.9"
   s.add_dependency "json_pure", "~> 1.8.1"
-  s.add_dependency "multi_json", "~> 1.9.0"
+  s.add_dependency "multi_json", "~> 1.10.0"
   s.add_dependency "parseconfig", "~> 1.0.4"
   s.add_dependency "pry", "~> 0.9.12.6"
   s.add_dependency "restforce", "~> 1.4.3"

data/lib/gooddata.rb

@@ -4,8 +4,6 @@
 module GoodData
 end
 
-require 'active_support/all'
-
 # Modules
 require_relative 'gooddata/bricks/bricks'
 require_relative 'gooddata/cli/cli'

data/lib/gooddata/bricks/base_downloader.rb

@@ -1,63 +1,68 @@
 # encoding: UTF-8
 
-module GoodData::Bricks
-  class BaseDownloader
-    def initialize(params)
-      @params = params
-    end
+require 'pathname'
 
-    def pre_process(meta)
-      meta
-    end
+module GoodData
+  module Bricks
+    class BaseDownloader
+      def initialize(params)
+        @params = params
+      end
 
-    def download
-      puts 'would download data'
-      []
-    end
+      def pre_process(meta)
+        meta
+      end
 
-    def backup(meta)
-      puts 'would send a backup list of files to backup'
-      files = meta.reduce([]) do |memo, item|
-        memo << item[:filename]
+      def download
+        puts 'would download data'
+        []
       end
 
-      bucket_name = @params[:s3_backup_bucket_name]
+      def backup(meta)
+        puts 'would send a backup list of files to backup'
+        files = meta.reduce([]) do |a, e|
+          a << e[:filename]
+        end
+
+        bucket_name = @params[:s3_backup_bucket_name]
 
-      s3 = AWS::S3.new(
-        :access_key_id => @params[:aws_access_key_id],
-        :secret_access_key => @params[:aws_secret_access_key])
+        s3 = AWS::S3.new(
+          :access_key_id => @params[:aws_access_key_id],
+          :secret_access_key => @params[:aws_secret_access_key])
 
-      bucket = s3.buckets[bucket_name]
-      bucket = s3.buckets.create(bucket_name) unless bucket.exists?
+        bucket = s3.buckets[bucket_name]
+        bucket = s3.buckets.create(bucket_name) unless bucket.exists?
 
-      files.each do |file|
-        obj = bucket.objects[file]
-        obj.write(Pathname.new(file))
+        files.each do |file|
+          obj = bucket.objects[file]
+          obj.write(Pathname.new(file))
+        end
+        meta
       end
-      meta
-    end
 
-    def post_process(meta)
-      puts 'Maybe some postprocessing'
-      meta
-    end
+      def post_process(meta)
+        puts 'Maybe some postprocessing'
+        meta
+      end
+
+      # Run downloader
+      def run
+        downloaded_data = download
+        downloaded_data = pre_process(downloaded_data)
+        backup(downloaded_data)
+        downloaded_data = post_process(downloaded_data)
+
+        accumulated_state = downloaded_data.reduce([]) do |memo, item|
+          item.key?(:state) ? memo.concat(item[:state]) : memo
+        end
+        accumulated_state.each do |item|
+          key = item[:key]
+          val = item[:value]
 
-    # Run downloader
-    def run
-      downloaded_data = download
-      downloaded_data = pre_process(downloaded_data)
-      backup(downloaded_data)
-      downloaded_data = post_process(downloaded_data)
-
-      downloaded_data.reduce([]) do |memo, item|
-        item.has_key?(:state) ? memo.concat(item[:state]) : memo
-      end.each do |item|
-        key = item[:key]
-        val = item[:value]
-
-        puts "Saving metadata #{key} => #{val}"
-        GoodData::ProjectMetadata[key] = val
+          puts "Saving metadata #{key} => #{val}"
+          GoodData::ProjectMetadata[key] = val
+        end
       end
     end
   end
-end
+end

data/lib/gooddata/bricks/brick.rb

@@ -3,43 +3,32 @@
 require_relative 'base_downloader'
 require_relative 'utils'
 
-Dir[File.dirname(__FILE__) + '/commands/**/*_cmd.rb'].each do |file|
-  require file
-end
-
 require_relative 'middleware/middleware'
 
-module GoodData::Bricks
-  class Pipeline
-    def self.prepare(pipeline)
-      pipeline.reverse.reduce(nil) do |memo, app|
-        if memo.nil?
-          app.respond_to?(:new) ? (app.new) : app
-        else
-          app.respond_to?(:new) ? (app.new(:app => memo)) : (app.app = memo; app)
-        end
+module GoodData
+  module Bricks
+    # Brick base class
+    class Brick
+      def log(message)
+        logger = @params[:gdc_logger]
+        logger.info(message) unless logger.nil?
       end
-    end
-  end
-
-  # Brick base class
-  class Brick
-    def log(message)
-      logger = @params[:gdc_logger]
-      logger.info(message) unless logger.nil?
-    end
 
-    def name
-      self.class
-    end
+      # Name of the brick
+      def name
+        self.class
+      end
 
-    def version
-      fail 'Method version should be reimplemented'
-    end
+      # Version of brick, this should be implemented in subclasses
+      def version
+        fail NotImplementedError, 'Method version should be reimplemented'
+      end
 
-    def call(params={})
-      @params = params
-      ''
+      # Bricks implementation which can be 'called'
+      def call(params = {})
+        @params = params
+        ''
+      end
     end
   end
 end

data/lib/gooddata/bricks/bricks.rb

@@ -7,4 +7,4 @@ Dir.glob(base + '*.rb').each do |file|
 end
 
 # Require all middleware
-require_relative 'middleware/middleware'
+require_relative 'middleware/middleware'

data/lib/gooddata/bricks/middleware/base_middleware.rb

@@ -1,13 +1,15 @@
 # encoding: UTF-8
 
-module GoodData::Bricks
-  class Middleware
-    attr_accessor :app
+module GoodData
+  module Bricks
+    class Middleware
+      attr_accessor :app
 
-    include GoodData::Bricks::Utils
+      include Bricks::Utils
 
-    def initialize(options={})
-      @app = options[:app]
+      def initialize(options = {})
+        @app = options[:app]
+      end
     end
   end
-end
+end

data/lib/gooddata/bricks/middleware/bench_middleware.rb

@@ -3,15 +3,17 @@
 require 'benchmark'
 require_relative 'base_middleware'
 
-module GoodData::Bricks
-  class BenchMiddleware < GoodData::Bricks::Middleware
-    def call(params)
-      puts 'Starting timer'
-      result = nil
-      report = Benchmark.measure { result = @app.call(params) }
-      puts 'Stopping timer'
-      pp report
-      result
+module GoodData
+  module Bricks
+    class BenchMiddleware < Bricks::Middleware
+      def call(params)
+        puts 'Starting timer'
+        result = nil
+        report = Benchmark.measure { result = @app.call(params) }
+        puts 'Stopping timer'
+        pp report
+        result
+      end
     end
   end
-end
+end

data/lib/gooddata/bricks/middleware/bulk_salesforce_middleware.rb

@@ -4,35 +4,35 @@ require 'salesforce_bulk'
 
 require_relative 'base_middleware'
 
-module GoodData::Bricks
-  class BulkSalesforceMiddleware < GoodData::Bricks::Middleware
-    def call(params)
-      username = params[:salesforce_username]
-      password = params[:salesforce_password]
-      token = params[:salesforce_token]
-      client_id = params[:salesforce_client_id]
-      client_secret = params[:salesforce_client_secret]
-      host = params[:salesforce_host]
+module GoodData
+  module Bricks
+    class BulkSalesforceMiddleware < Bricks::Middleware
+      def call(params)
+        username = params[:salesforce_username]
+        password = params[:salesforce_password]
+        token = params[:salesforce_token]
+        client_id = params[:salesforce_client_id]
+        client_secret = params[:salesforce_client_secret]
+        host = params[:salesforce_host]
 
-      credentials = {}
+        credentials = if username && password && token
+                        {
+                          :username => username,
+                          :password => password,
+                          :security_token => token
+                        }
+                      end
 
-      credentials = if (username && password && token)
-                      {
-                        :username => username,
-                        :password => password,
-                        :security_token => token
-                      }
-                    end
-
-      client = if credentials
-                 credentials.merge!({
-                                      :client_id => client_id,
-                                      :client_secret => client_secret,
-                                    })
-                 credentials[:host] = host unless host.nil?
-                 SalesforceBulk::Api.new(credentials[:username], credentials[:password] + credentials[:security_token])
-               end
-      @app.call(params.merge(:salesforce_bulk_client => client))
+        client = if credentials
+                   credentials.merge!(
+                     :client_id => client_id,
+                     :client_secret => client_secret
+                   )
+                   credentials[:host] = host unless host.nil?
+                   SalesforceBulk::Api.new(credentials[:username], credentials[:password] + credentials[:security_token])
+                 end
+        @app.call(params.merge(:salesforce_bulk_client => client))
+      end
     end
   end
-end
+end