goodcheck 3.0.0 → 3.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa64d7f536fc7b357fbae7aa685827211236015ff9203bc7291847705e4a8189
-  data.tar.gz: bf23ca5741b3e424d064d45b9e16ccc28fbf53d299d8a4966ce7a5566c277a0f
+  metadata.gz: 9ccb42f8ae06c1c3f78fc6361de1e3074a3ea1ebf8ec1fc6216d4f076531e4fe
+  data.tar.gz: f46bde84176b92dffa679e50536221f52d1efe54a2bf6a583533a14fd8404bfb
 SHA512:
-  metadata.gz: d184c5e83feb1b656afdbb2aa71c724b33c584a674de2def35201bbd8a66275b5c2a45b466c477aee38689f53dc6e39a0ee4183a6ad61b3ba587485eeb7f3d89
-  data.tar.gz: 215b0532befa04bdbbdbb0ac24be805fde46ebe51bafda8d6193df1c3a183fbf0faad0495454b9dcfe6dec27015f817b5b52f99b4fa26936f57ac491fa923bf5
+  metadata.gz: 717e2a137f03c9b436e7ef9f88ad6c5f9d8ec33989a929cb69e327aabf09e83fdfe1565607c669928d7e3b3306cde434ab59c64ff741840c840263980856d8cd
+  data.tar.gz: c7041cb4c9d9c4b1926776a98a8c55ec59496169fdeedd8ac4277c37950d579cdb6cfa50cc9dd6215c31baa2c85cd3b9a513495ec2f82dc705696a05ef13af4b

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## HEAD
 
+## 3.0.1 (2021-06-14)
+
+* Retry HTTP GET request on importing rules [#197](https://github.com/sider/goodcheck/pull/197)
+
 ## 3.0.0 (2021-06-14)
 
 Breaking changes:

data/README.md

@@ -42,7 +42,7 @@ To release a new version, follows the steps below:
 3. Update the documentation via `bundle exec rake docs:update_version`.
 4. Commit the above changes like `git commit -m 'Version 1.2.3'`.
 5. Run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
-6. Publish the updated documentation like `GIT_USER=some_user USE_SSH=true bundle exec rake docs:publish`.
+6. Publish the updated documentation like `GIT_USER=some_user [USE_SSH=true] bundle exec rake docs:publish`.
 
 ## Contributing
 

data/lib/goodcheck/buffer.rb

@@ -1,8 +1,5 @@
 module Goodcheck
   class Buffer
-    attr_reader :path
-    attr_reader :content
-
     DISABLE_LINE_PATTERNS = [
       /\/\/ goodcheck-disable-line$/, #JS, Java, C, ...
       /# goodcheck-disable-line$/, # Ruby, Python, PHP, ...
@@ -25,10 +22,8 @@ module Goodcheck
       /' goodcheck-disable-next-line$/, # VB
     ].freeze
 
-    class << self
-        attr_accessor :DISABLE_LINE_PATTERNS
-        attr_accessor :DISABLE_NEXT_LINE_PATTERNS
-    end
+    attr_reader :path
+    attr_reader :content
 
     def initialize(path:, content:)
       @path = path

data/lib/goodcheck/import_loader.rb

@@ -18,6 +18,19 @@ module Goodcheck
       end
     end
 
+    class HTTPGetError < Error
+      attr_reader :response
+
+      def initialize(res)
+        super("HTTP GET #{res.uri} => #{res.code} #{res.message}")
+        @response = res
+      end
+
+      def error_response?
+        response.is_a?(Net::HTTPClientError) || response.is_a?(Net::HTTPServerError)
+      end
+    end
+
     attr_reader :cache_path
     attr_reader :expires_in
     attr_reader :force_download
@@ -122,15 +135,28 @@ module Goodcheck
     def http_get(uri, limit = 10)
       raise ArgumentError, "Too many HTTP redirects" if limit == 0
 
-      res = Net::HTTP.get_response URI(uri)
-      case res
-      when Net::HTTPSuccess
-        res.body
-      when Net::HTTPRedirection
-        location = res['Location']
-        http_get location, limit - 1
-      else
-        raise "Error: HTTP GET #{uri.inspect} #{res.inspect}"
+      max_retry_count = 2
+      retry_count = 0
+      begin
+        res = Net::HTTP.get_response URI(uri)
+        case res
+        when Net::HTTPSuccess
+          res.body
+        when Net::HTTPRedirection
+          location = res['Location']
+          http_get location, limit - 1
+        else
+          raise HTTPGetError.new(res)
+        end
+      rescue HTTPGetError => exn
+        if retry_count < max_retry_count && exn.error_response?
+          retry_count += 1
+          Goodcheck.logger.info "#{retry_count} retry HTTP GET #{exn.response.uri} due to '#{exn.response.code} #{exn.response.message}'..."
+          sleep 1
+          retry
+        else
+          raise
+        end
       end
     end
 

data/lib/goodcheck/version.rb

@@ -1,3 +1,3 @@
 module Goodcheck
-  VERSION = "3.0.0".freeze
+  VERSION = "3.0.1".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: goodcheck
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
 platform: ruby
 authors:
 - Sider Corporation