goodcheck 1.7.0 → 1.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 941c25a76e1e8d433dabf11a05e9881251666ea6
-  data.tar.gz: af4c6b7a6f0c7de3318efd540a9031127a6eab22
+SHA256:
+  metadata.gz: d857a24ca9b2ca50fe761dad0fa03fbeab34a7bf2c2d34eb6cdbeb349f31f53f
+  data.tar.gz: d50e1f2b04239b282eaa1a89eb8965f68de2ff681b1ba814d6695f0491cd497f
 SHA512:
-  metadata.gz: 30d772081204a902869971bded0ba16b779500d3cad31a0857b75a10979c0cacbe7ce5be45b6b4c0520bd587649394bb54cf0873ea18dccba1896cedcdd20a5a
-  data.tar.gz: a3020566b156d0a23f3ca4b1a2ac590d39182bf47597dcc6fb89bcd861198821f671967925fcf37e0e56f01c39a388e45d9237181f2d2bb4a9b1467083c2d156
+  metadata.gz: f64e084cb6b268d3d3febf63a37b811830b3ef77318e73e0f049fb4fbae2c8bec97b8e339562042b2e8029f1035bb20a86ba03086366ac8caaa57bc418521061
+  data.tar.gz: 7b8c73bd327db455afd2a61c74f0b4b6589e4c71c4c0205f60a71f3be37666f826832b608f4f0b0016fa6cdd905a62a90ab08814aa490d5e21de44a9543eee00

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## master
 
+## 1.7.1 (2019-05-29)
+
+* Fix test command error handling
+* Update strong_json
+
 ## 1.7.0 (2019-05-28)
 
 * Support a rule without `pattern` [#52](https://github.com/sider/goodcheck/pull/52)

data/goodcheck.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest-reporters", "~> 1.3.6"
 
   spec.add_runtime_dependency "activesupport", ">= 4.0", "< 6.0"
-  spec.add_runtime_dependency "strong_json", "~> 1.0.0"
+  spec.add_runtime_dependency "strong_json", "~> 1.0.1"
   spec.add_runtime_dependency "rainbow", "~> 3.0.0"
   spec.add_runtime_dependency "httpclient", "~> 2.8.3"
 end

data/lib/goodcheck/commands/check.rb

@@ -23,36 +23,24 @@ module Goodcheck
       end
 
       def run
-        issue_reported = false
+        handle_config_errors(stderr) do
+          issue_reported = false
 
-        reporter.analysis do
-          load_config!(force_download: force_download, cache_path: cache_dir_path)
-          each_check do |buffer, rule|
-            reporter.rule(rule) do
-              analyzer = Analyzer.new(rule: rule, buffer: buffer)
-              analyzer.scan do |issue|
-                issue_reported = true
-                reporter.issue(issue)
+          reporter.analysis do
+            load_config!(force_download: force_download, cache_path: cache_dir_path)
+            each_check do |buffer, rule|
+              reporter.rule(rule) do
+                analyzer = Analyzer.new(rule: rule, buffer: buffer)
+                analyzer.scan do |issue|
+                  issue_reported = true
+                  reporter.issue(issue)
+                end
               end
             end
           end
-        end
 
-        issue_reported ? 2 : 0
-      rescue Psych::Exception => exn
-        stderr.puts "Unexpected error happens while loading YAML file: #{exn.inspect}"
-        exn.backtrace.each do |trace_loc|
-          stderr.puts "  #{trace_loc}"
+          issue_reported ? 2 : 0
         end
-        1
-      rescue StrongJSON::Type::TypeError, StrongJSON::Type::UnexpectedAttributeError => exn
-        stderr.puts "Invalid config: #{exn.message}"
-        stderr.puts StrongJSON::ErrorReporter.new(path: exn.path).to_s
-
-        1
-      rescue Errno::ENOENT => exn
-        stderr.puts "#{exn}"
-        1
       end
 
       def each_check

data/lib/goodcheck/commands/config_loading.rb

@@ -9,6 +9,26 @@ module Goodcheck
         loader = ConfigLoader.new(path: config_path, content: content, stderr: stderr, import_loader: import_loader)
         @config = loader.load
       end
+
+      def handle_config_errors(stderr)
+        begin
+          yield
+
+        rescue Psych::Exception => exn
+          stderr.puts "Unexpected error happens while loading YAML file: #{exn.inspect}"
+          exn.backtrace.each do |trace_loc|
+            stderr.puts "  #{trace_loc}"
+          end
+          1
+        rescue StrongJSON::Type::TypeError, StrongJSON::Type::UnexpectedAttributeError => exn
+          stderr.puts "Invalid config: #{exn.message}"
+          stderr.puts StrongJSON::ErrorReporter.new(path: exn.path).to_s
+          1
+        rescue Errno::ENOENT => exn
+          stderr.puts "#{exn}"
+          1
+        end
+      end
     end
   end
 end

data/lib/goodcheck/commands/test.rb

@@ -19,12 +19,14 @@ module Goodcheck
       end
 
       def run
-        load_config!(cache_path: cache_dir_path, force_download: force_download)
+        handle_config_errors stderr do
+          load_config!(cache_path: cache_dir_path, force_download: force_download)
 
-        validate_rule_uniqueness or return 1
-        validate_rules or return 1
+          validate_rule_uniqueness or return 1
+          validate_rules or return 1
 
-        0
+          0
+        end
       end
 
       def validate_rule_uniqueness

data/lib/goodcheck/version.rb

@@ -1,3 +1,3 @@
 module Goodcheck
-  VERSION = "1.7.0"
+  VERSION = "1.7.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: goodcheck
 version: !ruby/object:Gem::Version
-  version: 1.7.0
+  version: 1.7.1
 platform: ruby
 authors:
 - Soutaro Matsumoto
@@ -92,14 +92,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.0.1
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -195,8 +195,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Regexp based customizable linter