good_pipeline 0.3.0 → 0.4.0

data/lib/good_pipeline/pipeline.rb

@@ -5,7 +5,16 @@ module GoodPipeline
 
   class Pipeline # rubocop:disable Metrics/ClassLength
     VALID_FAILURE_STRATEGIES = %i[halt continue ignore].freeze
-    DSL_ATTRIBUTES = %i[display_name description failure_strategy on_complete on_success on_failure].freeze
+    DSL_ATTRIBUTES = %i[
+      display_name
+      description
+      failure_strategy
+      on_complete
+      on_success
+      on_failure
+      coordination_queue_name
+      callback_queue_name
+    ].freeze
 
     # --- Class-level DSL ---
 
@@ -58,6 +67,18 @@ module GoodPipeline
         @on_failure = method_name
       end
 
+      def coordination_queue_name(name = :__unset__)
+        return @coordination_queue_name || GoodPipeline.coordination_queue_name if name == :__unset__
+
+        @coordination_queue_name = name
+      end
+
+      def callback_queue_name(name = :__unset__)
+        return @callback_queue_name || GoodPipeline.callback_queue_name if name == :__unset__
+
+        @callback_queue_name = name
+      end
+
       alias build new
 
       def run(**)
@@ -95,6 +116,8 @@ module GoodPipeline
     def on_complete_callback = self.class.on_complete
     def on_success_callback = self.class.on_success
     def on_failure_callback = self.class.on_failure
+    def coordination_queue_name = self.class.coordination_queue_name
+    def callback_queue_name = self.class.callback_queue_name
 
     def initialize(**kwargs) # rubocop:disable Metrics/MethodLength
       @params = kwargs.freeze

data/lib/good_pipeline/runner.rb

@@ -32,6 +32,7 @@ module GoodPipeline
     def create_pipeline_batch(pipeline_id)
       batch = GoodJob::Batch.new
       batch.on_finish = "GoodPipeline::PipelineReconciliationJob"
+      batch.callback_queue_name = @pipeline.coordination_queue_name
       batch.properties = { pipeline_id: pipeline_id }
       batch.save
       batch
@@ -81,9 +82,8 @@ module GoodPipeline
     end
 
     def enqueue_root_steps(step_id_by_key)
-      @pipeline.root_steps.each do |step_definition|
-        Coordinator.try_enqueue_step(step_id_by_key[step_definition.key])
-      end
+      root_step_ids = @pipeline.root_steps.map { |step_definition| step_id_by_key[step_definition.key] }
+      Coordinator.bulk_enqueue_steps(root_step_ids)
     end
 
     def resolve_job_class(step_definition)

data/lib/good_pipeline/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GoodPipeline
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/lib/good_pipeline.rb

@@ -13,10 +13,26 @@ require_relative "good_pipeline/branch_resolver"
 require_relative "good_pipeline/coordinator"
 require_relative "good_pipeline/chain_coordinator"
 require_relative "good_pipeline/runner"
+require_relative "good_pipeline/haltable"
 require_relative "good_pipeline/chain"
 require_relative "good_pipeline/engine" if defined?(Rails::Engine)
 
 module GoodPipeline
+  DEFAULT_COORDINATION_QUEUE_NAME = "good_pipeline_coordination"
+  DEFAULT_CALLBACK_QUEUE_NAME = "good_pipeline_callbacks"
+
+  class << self
+    attr_writer :coordination_queue_name, :callback_queue_name
+
+    def coordination_queue_name
+      @coordination_queue_name || DEFAULT_COORDINATION_QUEUE_NAME
+    end
+
+    def callback_queue_name
+      @callback_queue_name || DEFAULT_CALLBACK_QUEUE_NAME
+    end
+  end
+
   def self.run(*pipeline_configs)
     pipeline_records = pipeline_configs.map do |config|
       pipeline_class, pipeline_params = extract_pipeline_config(config)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: good_pipeline
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Ali Hamdi Ali Fadel
@@ -29,14 +29,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.10'
+        version: '4.14'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.10'
+        version: '4.14'
 - !ruby/object:Gem::Dependency
   name: railties
   requirement: !ruby/object:Gem::Requirement
@@ -93,6 +93,7 @@ files:
 - demo/app/jobs/cleanup_job.rb
 - demo/app/jobs/download_job.rb
 - demo/app/jobs/failing_job.rb
+- demo/app/jobs/halt_execution_job.rb
 - demo/app/jobs/publish_job.rb
 - demo/app/jobs/retryable_job.rb
 - demo/app/jobs/thumbnail_job.rb
@@ -119,6 +120,7 @@ files:
 - demo/db/seeds.rb
 - demo/docs/screenshots/definitions.png
 - demo/docs/screenshots/show.png
+- demo/test/good_pipeline/test_bulk_enqueue.rb
 - demo/test/good_pipeline/test_chain_record.rb
 - demo/test/good_pipeline/test_cleanup.rb
 - demo/test/good_pipeline/test_coordinator.rb
@@ -128,18 +130,22 @@ files:
 - demo/test/good_pipeline/test_pipeline_callback_job.rb
 - demo/test/good_pipeline/test_pipeline_reconciliation_job.rb
 - demo/test/good_pipeline/test_pipeline_record.rb
+- demo/test/good_pipeline/test_queue_configuration.rb
 - demo/test/good_pipeline/test_runner.rb
 - demo/test/good_pipeline/test_step_finished_job.rb
 - demo/test/good_pipeline/test_step_record.rb
 - demo/test/integration/test_branch_execution.rb
+- demo/test/integration/test_bulk_enqueue_end_to_end.rb
 - demo/test/integration/test_concurrent_fan_in.rb
 - demo/test/integration/test_end_to_end.rb
 - demo/test/integration/test_enqueue_atomicity.rb
+- demo/test/integration/test_halt_execution.rb
 - demo/test/integration/test_halt_ignore_chain.rb
 - demo/test/integration/test_ignore_transitive_exemption.rb
 - demo/test/integration/test_late_chain_registration.rb
 - demo/test/integration/test_missing_decision_method.rb
 - demo/test/integration/test_pipeline_chaining.rb
+- demo/test/integration/test_queue_configuration.rb
 - demo/test/integration/test_retry_scenarios.rb
 - demo/test/integration/test_sequential_branches.rb
 - demo/test/integration/test_step_finished_idempotency.rb
@@ -184,6 +190,7 @@ files:
 - lib/good_pipeline/errors.rb
 - lib/good_pipeline/failure_metadata.rb
 - lib/good_pipeline/graph_validator.rb
+- lib/good_pipeline/haltable.rb
 - lib/good_pipeline/pipeline.rb
 - lib/good_pipeline/runner.rb
 - lib/good_pipeline/step_definition.rb