good_job 4.22.0 → 4.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c3707d55ab1de17d450f3b52e30739b25350ed229e7fad992ab9f56aa01c88fc
-  data.tar.gz: 1af86ced85ba5487a1b3c13eac8e4f2988c6685153fee444fd34afa62533ef7b
+  metadata.gz: 50f42b2481a308af99413d1a89c0b7d3d4c2e07cc48cc29a323c3c42a528e610
+  data.tar.gz: a55f5f59b5758614fa38c79b603d4f6298b6e79de40931e05fc4cc4fa0e68f56
 SHA512:
-  metadata.gz: 56311442c755f60a717bc23c42f193f3bfc15f31254527320e9183cc681cc43c9a87d89fd5e9c2efe305d14f87f6c3cafa0d9a2e5443c5cad3eafa7da31f5674
-  data.tar.gz: '0875bd2051120c9cd80d11e781713b2c13a6a05d2fdfa38f54dfdb0c3a616b3cbe4d23769db811211feaf7feb49cb1d2a1bf4e72baa31a9127f10b82ce18f5fd'
+  metadata.gz: adacf056f5e11131e0bb704e5b830a11a4a64b0d0a06339c0edaa13b1d8c94bf8b7e734e0df79d3ccf0230e7ceba3da4f220d66aa4eece5dd4dd5e961af294e1
+  data.tar.gz: 7b954a6a98b208038575c4d05e6f6e18d219125daf42f66ca8d1e0223f5e18eb1250fd3c608eddeb4f8b78d94ba84f3f141805ccf24f81dedeec0a37bac808ff

data/CHANGELOG.md

@@ -1,5 +1,60 @@
 # Changelog
 
+## [v4.23.0](https://github.com/bensheldon/good_job/tree/v4.23.0) (2026-10-27)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.22.1...v4.23.0)
+
+**Implemented enhancements:**
+
+- Filter sensitive job arguments in the Dashboard [\#1881](https://github.com/bensheldon/good_job/pull/1881) ([bogdan](https://github.com/bogdan))
+
+**Fixed bugs:**
+
+- Respect enable\_listen\_notify when promoting concurrency claims [\#1892](https://github.com/bensheldon/good_job/pull/1892) ([eidam](https://github.com/eidam))
+- Downgrade lock\_type before releasing advisory lock [\#1883](https://github.com/bensheldon/good_job/pull/1883) ([jmsanders](https://github.com/jmsanders))
+
+**Closed issues:**
+
+- ConcurrencyClaim sends NOTIFY even when enable\_listen\_notify is false [\#1891](https://github.com/bensheldon/good_job/issues/1891)
+
+**Merged pull requests:**
+
+- Keep JRuby platform in Gemfile.lock when Bundler re-resolves [\#1893](https://github.com/bensheldon/good_job/pull/1893) ([bensheldon](https://github.com/bensheldon))
+- Make integration specs robust under database load; fix mixed lock strategy specs [\#1890](https://github.com/bensheldon/good_job/pull/1890) ([bensheldon](https://github.com/bensheldon))
+- Pin CI test runners to ubuntu-24.04 [\#1888](https://github.com/bensheldon/good_job/pull/1888) ([bensheldon](https://github.com/bensheldon))
+- Require the concurrent-ruby classes GoodJob uses [\#1885](https://github.com/bensheldon/good_job/pull/1885) ([czj](https://github.com/czj))
+- Add index\_good\_job\_executions\_on\_created\_at [\#1884](https://github.com/bensheldon/good_job/pull/1884) ([clinejj](https://github.com/clinejj))
+- Demo: cap YJIT memory and shrink the Rack::Attack store [\#1880](https://github.com/bensheldon/good_job/pull/1880) ([bensheldon](https://github.com/bensheldon))
+- Demo: enable rbtrace in Puma workers for heap dumps; add sheap [\#1879](https://github.com/bensheldon/good_job/pull/1879) ([bensheldon](https://github.com/bensheldon))
+- Demo: warm up Puma before forking, add Thruster, raise DB pool [\#1878](https://github.com/bensheldon/good_job/pull/1878) ([bensheldon](https://github.com/bensheldon))
+- Return 404 for GET /jobs/mass\_update instead of redirecting [\#1877](https://github.com/bensheldon/good_job/pull/1877) ([bensheldon](https://github.com/bensheldon))
+- Load execution full traces and serialized params on demand [\#1876](https://github.com/bensheldon/good_job/pull/1876) ([bensheldon](https://github.com/bensheldon))
+- Add specs for the demo's Rack::Attack rules [\#1875](https://github.com/bensheldon/good_job/pull/1875) ([bensheldon](https://github.com/bensheldon))
+- Fix demo boot: don't require rails/all in bin/rails [\#1874](https://github.com/bensheldon/good_job/pull/1874) ([bensheldon](https://github.com/bensheldon))
+- Reduce demo app memory and crawler load [\#1873](https://github.com/bensheldon/good_job/pull/1873) ([bensheldon](https://github.com/bensheldon))
+- Fix JRuby flake from inspect in wait\_until predicate expectations [\#1872](https://github.com/bensheldon/good_job/pull/1872) ([bensheldon](https://github.com/bensheldon))
+- Remove Adapter::RUNTIMES so adapters can be garbage collected [\#1870](https://github.com/bensheldon/good_job/pull/1870) ([bensheldon](https://github.com/bensheldon))
+- Add GoodJob.prune to release shut down capsules, schedulers, and notifiers [\#1869](https://github.com/bensheldon/good_job/pull/1869) ([bensheldon](https://github.com/bensheldon))
+- Use resolve\_\[property\] naming for CronEntry configuration resolvers [\#1868](https://github.com/bensheldon/good_job/pull/1868) ([bensheldon](https://github.com/bensheldon))
+- Fix inconsistencies in the Brazilian Portuguese locale [\#1867](https://github.com/bensheldon/good_job/pull/1867) ([tiagoamaro](https://github.com/tiagoamaro))
+
+## [v4.22.1](https://github.com/bensheldon/good_job/tree/v4.22.1) (2026-10-13)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.22.0...v4.22.1)
+
+**Implemented enhancements:**
+
+- Show full job labels under the job name in dashboard tables [\#1862](https://github.com/bensheldon/good_job/pull/1862) ([olivier-thatch](https://github.com/olivier-thatch))
+
+**Fixed bugs:**
+
+- Keep the process id when refresh recreates a deleted process record [\#1866](https://github.com/bensheldon/good_job/pull/1866) ([wivern-co-uk](https://github.com/wivern-co-uk))
+- Don't apply a concurrency lock when a rule's label resolves to blank [\#1864](https://github.com/bensheldon/good_job/pull/1864) ([bensheldon](https://github.com/bensheldon))
+
+**Merged pull requests:**
+
+- Support enqueuing jobs from non-main Ractors [\#1863](https://github.com/bensheldon/good_job/pull/1863) ([bensheldon](https://github.com/bensheldon))
+
 ## [v4.22.0](https://github.com/bensheldon/good_job/tree/v4.22.0) (2026-10-09)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v4.21.1...v4.22.0)

data/README.md

@@ -44,6 +44,7 @@ For more of the story of GoodJob, read the [introductory blog post](https://isla
     - [Dashboard](#dashboard)
         - [API-only Rails applications](#api-only-rails-applications)
         - [Live polling](#live-polling)
+        - [Filtering sensitive arguments](#filtering-sensitive-arguments)
         - [Extending dashboard views](#extending-dashboard-views)
     - [Job priority](#job-priority)
     - [Concurrency controls](#concurrency-controls)
@@ -479,6 +480,15 @@ end
 
 The Dashboard can be set to automatically refresh by checking "Live Poll" in the Dashboard header, or by setting `?poll=10` with the interval in seconds (default 30 seconds).
 
+#### Filtering sensitive arguments
+
+The Dashboard hides job arguments the same way Rails hides them from logs:
+
+- Hash values whose keys match `Rails.application.config.filter_parameters` (e.g. `password:`) are displayed as `[FILTERED]`.
+- All arguments are displayed as `[FILTERED]` for jobs with `log_arguments` disabled, either for every job with `config.active_job.log_arguments = false` or per job class with `self.log_arguments = false`.
+
+Filtering only applies to how arguments are displayed; arguments are still stored unfiltered in the database and are used when the job is performed or retried.
+
 #### Extending dashboard views
 
 GoodJob exposes some views that are intended to be overridden by placing views in your application:
@@ -1644,7 +1654,7 @@ end
 GOOD_JOB_LOCK_STRATEGY=skiplocked
 ```
 
-All three strategies (`:advisory`, `:skiplocked`, `:hybrid`) can coexist safely during a rolling deploy — each strategy excludes jobs that are already locked by another worker regardless of which strategy that worker uses.
+During a rolling deploy, `:hybrid` workers can safely run alongside either `:advisory` or `:skiplocked` workers. But `:advisory` and `:skiplocked` workers must not run at the same time, because neither sees the other's locks and the same job may be performed twice. To move from `:advisory` to `:skiplocked`, deploy `:hybrid` first, wait until no `:advisory` workers remain, and then deploy `:skiplocked`.
 
 #### PgBouncer configuration
 

data/app/controllers/good_job/executions_controller.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module GoodJob
+  # Renders an execution's heavier details on demand so they aren't included in every job page.
+  class ExecutionsController < GoodJob::ApplicationController
+    def show
+      @execution = Execution.find_by!(id: params[:id], active_job_id: params[:job_id])
+      render layout: false
+    end
+  end
+end

data/app/frontend/good_job/style.css

@@ -186,3 +186,8 @@
   border-top-left-radius: 0 !important;
   border-bottom-left-radius: 0 !important;
 }
+
+/* Stop a long job name from widening its cell, so label badges clip at the column edge. */
+.min-width-0 {
+  min-width: 0;
+}

data/app/helpers/good_job/application_helper.rb

@@ -27,14 +27,15 @@ module GoodJob
     # Renders a job's label as a badge. Labels on which the job has a concurrency claim
     # are colored and prefixed with an icon for the claim's state.
     # Claims are only shown when the job's +concurrency_claims+ are already loaded.
-    def job_label_badge(job, label, url: nil)
+    # With +full: true+, the badge shows the full label and CSS clips it at the container width.
+    def job_label_badge(job, label, url: nil, full: false)
       claim = job.concurrency_claims.find { |job_claim| job_claim.label == label } if job.association(:concurrency_claims).loaded?
       state_name = claim&.state_name
-      truncated_label = truncate(label, length: 15)
+      truncated_label = full ? label : truncate(label, length: 15)
       state_text = t(state_name, scope: "good_job.concurrency_claims.states") if state_name
-      title = [(label if truncated_label != label), state_text].compact.join(" · ")
+      title = [(label if full || truncated_label != label), state_text].compact.join(" · ")
 
-      options = { class: "badge font-monospace text-decoration-none #{CONCURRENCY_CLAIM_BADGE_CLASSES.fetch(state_name)}" }
+      options = { class: "badge font-monospace text-decoration-none #{'text-truncate mw-100 ' if full}#{CONCURRENCY_CLAIM_BADGE_CLASSES.fetch(state_name)}" }
       if title.present?
         options[:title] = title
         options[:data] = { bs_toggle: "tooltip" }

data/app/models/concerns/good_job/advisory_lockable.rb

@@ -62,8 +62,22 @@ module GoodJob
     # require additional synchronization.
     #
     # Per-key structure: [session_count, xact_txns, cte]
-    #   xact_txns: Array of WeakRefs to AR transaction objects
+    #   xact_txns: Array of TransactionRefs to AR transaction objects
     class AdvisoryLockCounter
+      # A weak reference to an Active Record transaction. Unlike +WeakRef+,
+      # which uses a class variable, this can be used from non-main Ractors.
+      class TransactionRef
+        def initialize(transaction)
+          @ref = ObjectSpace::WeakMap.new
+          @ref[:transaction] = transaction
+        end
+
+        def open?
+          transaction = @ref[:transaction]
+          !transaction.nil? && transaction.open?
+        end
+      end
+
       def initialize
         if defined?(ObjectSpace::WeakKeyMap)
           # WeakKeyMap (Ruby 3.3+) holds weak keys with strong values:
@@ -144,13 +158,13 @@ module GoodJob
 
       # Record a lock acquisition.
       # Per-key structure: [session_count, xact_txns, cte]
-      #   xact_txns is an Array of WeakRefs to transaction objects
+      #   xact_txns is an Array of TransactionRefs
       def record_lock(conn, key, cte: false, xact: false)
         prune(conn)
         counts = self[conn] || (self[conn] = {})
         session_count, xact_txns, was_cte = counts[key] || [0, [], false]
         if xact
-          xact_txns += [WeakRef.new(conn.current_transaction)]
+          xact_txns += [TransactionRef.new(conn.current_transaction)]
         else
           session_count += 1
         end
@@ -191,11 +205,7 @@ module GoodJob
         return unless counts
 
         counts.each do |key, (session_count, xact_txns, cte)|
-          live_txns = xact_txns.select do |ref|
-            ref.weakref_alive? && ref.open?
-          rescue WeakRef::RefError
-            false
-          end
+          live_txns = xact_txns.select(&:open?)
 
           if session_count.zero? && live_txns.empty?
             counts.delete(key)
@@ -206,8 +216,14 @@ module GoodJob
       end
     end
 
-    ADVISORY_LOCK_COUNTS = AdvisoryLockCounter.new
-    private_constant :ADVISORY_LOCK_COUNTS
+    # Lock counts are tracked per connection, and connections are not shared
+    # across Ractors, so each Ractor has its own counter.
+    # @api private
+    # @return [AdvisoryLockCounter]
+    def self.advisory_lock_counts
+      GoodJob::Ractors.local(:good_job_advisory_lock_counts) { AdvisoryLockCounter.new }
+    end
+
     AREL_TABLE_NEW_KWARGS = Arel::Table.instance_method(:initialize).parameters.any? { |type, name| type == :key && name == :name }
 
     included do
@@ -447,7 +463,7 @@ module GoodJob
       # @return [Boolean] whether the lock was released.
       def advisory_unlock_key(key, function: advisory_unlockable_function, connection: nil)
         conn = connection || lease_connection
-        session_count, _xact_count, cte = ADVISORY_LOCK_COUNTS.counts_for(conn, key)
+        session_count, _xact_count, cte = AdvisoryLockable.advisory_lock_counts.counts_for(conn, key)
 
         if session_count <= 1 && cte
           advisory_unlock_key!(key, function: function, connection: conn)
@@ -474,7 +490,7 @@ module GoodJob
       # @return [void]
       def advisory_unlock_key!(key, function: advisory_unlockable_function, connection: nil)
         conn = connection || lease_connection
-        _, xact_count, = ADVISORY_LOCK_COUNTS.counts_for(conn, key)
+        _, xact_count, = AdvisoryLockable.advisory_lock_counts.counts_for(conn, key)
 
         if xact_count.positive?
           # An active xact lock on the same key means owns_advisory_lock_key? will
@@ -617,15 +633,15 @@ module GoodJob
       end
 
       def record_advisory_lock(conn, key, cte: false, xact: false)
-        ADVISORY_LOCK_COUNTS.record_lock(conn, key, cte: cte, xact: xact)
+        AdvisoryLockable.advisory_lock_counts.record_lock(conn, key, cte: cte, xact: xact)
       end
 
       def record_advisory_unlock(conn, key)
-        ADVISORY_LOCK_COUNTS.record_unlock(conn, key)
+        AdvisoryLockable.advisory_lock_counts.record_unlock(conn, key)
       end
 
       def prune_advisory_locks(conn)
-        ADVISORY_LOCK_COUNTS.prune(conn)
+        AdvisoryLockable.advisory_lock_counts.prune(conn)
       end
 
       # Postgres advisory unlocking function for the class
@@ -643,7 +659,7 @@ module GoodJob
       # @return [void]
       def advisory_unlock_session(connection: nil)
         conn = connection || lease_connection
-        ADVISORY_LOCK_COUNTS.clear_session_locks(conn)
+        AdvisoryLockable.advisory_lock_counts.clear_session_locks(conn)
         conn.exec_query("SELECT pg_advisory_unlock_all()::text AS unlocked", 'GoodJob::Lockable Unlock Session').first[:unlocked]
       end
 
@@ -745,7 +761,7 @@ module GoodJob
     def advisory_lock_active_on?(connection, key: lockable_key)
       return false unless connection&.active?
 
-      ADVISORY_LOCK_COUNTS.counts_for(connection, key).first.positive?
+      AdvisoryLockable.advisory_lock_counts.counts_for(connection, key).first.positive?
     end
 
     # Releases all advisory locks on the record that are held by the current

data/app/models/concerns/good_job/filtered_arguments.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module GoodJob
+  # Hides sensitive Active Job arguments when displaying Job/Execution records in the Dashboard.
+  module FilteredArguments
+    # Active Job arguments with sensitive values replaced by +[FILTERED]+.
+    # Every argument is filtered when the job class has +log_arguments+ disabled
+    # (e.g. +config.active_job.log_arguments = false+); otherwise hash values whose
+    # keys match +Rails.application.config.filter_parameters+ are filtered.
+    # @return [Array]
+    def display_arguments
+      arguments = serialized_params.fetch("arguments", [])
+      return arguments.map { ActiveSupport::ParameterFilter::FILTERED } unless log_arguments?
+
+      parameter_filter = ActiveSupport::ParameterFilter.new(Rails.application.config.filter_parameters)
+      parameter_filter.filter("arguments" => arguments)["arguments"]
+    end
+
+    private
+
+    def log_arguments?
+      active_job_class = job_class&.safe_constantize
+      active_job_class = ActiveJob::Base unless active_job_class.respond_to?(:log_arguments?)
+      active_job_class.log_arguments?
+    end
+  end
+end

data/app/models/good_job/batch_record.rb

@@ -11,7 +11,6 @@ module GoodJob
     self.implicit_order_column = 'created_at'
 
     has_many :jobs, class_name: 'GoodJob::Job', inverse_of: :batch, foreign_key: :batch_id, dependent: nil
-    has_many :executions, class_name: 'GoodJob::Execution', foreign_key: :batch_id, inverse_of: :batch, dependent: nil
     has_many :callback_jobs, class_name: 'GoodJob::Job', foreign_key: :batch_callback_id, dependent: nil # rubocop:disable Rails/InverseOf
 
     scope :finished, -> { where.not(finished_at: nil) }

data/app/models/good_job/concurrency_claim.rb

@@ -127,7 +127,7 @@ module GoodJob
       def upsert_claim(key:, job_id:, locked_by_id:, state:)
         # Raw SQL because `upsert(update_only:)` requires Rails 7.0+
         now = Time.current
-        lease_connection.exec_update(sanitize_sql_array([<<~SQL.squish, key, job_id, locked_by_id, state, now, now]))
+        lease_connection.update(sanitize_sql_array([<<~SQL.squish, key, job_id, locked_by_id, state, now, now]))
           INSERT INTO #{quoted_table_name} (key, job_id, locked_by_id, state, created_at, updated_at)
           VALUES (?, ?, ?, ?, ?, ?)
           ON CONFLICT (key, job_id)
@@ -172,6 +172,8 @@ module GoodJob
       end
 
       def notify(job_id)
+        return unless GoodJob.configuration.enable_listen_notify
+
         queue_name = GoodJob::Job.where(id: job_id).pick(:queue_name)
         GoodJob::Notifier.notify({ queue_name: queue_name }) if queue_name
       end

data/app/models/good_job/cron_entry.rb

@@ -139,8 +139,10 @@ module GoodJob # :nodoc:
           job_klass = resolve_job_class
           next unless job_klass.is_a?(Class)
 
-          configured_job = job_klass.set(set_value)
-          kwargs_value.present? ? configured_job.perform_later(*args_value, **kwargs_value) : configured_job.perform_later(*args_value)
+          configured_job = job_klass.set(resolve_set)
+          job_args = resolve_args
+          job_kwargs = resolve_kwargs
+          job_kwargs.present? ? configured_job.perform_later(*job_args, **job_kwargs) : configured_job.perform_later(*job_args)
         end
       end
     end
@@ -213,7 +215,8 @@ module GoodJob # :nodoc:
     end
 
     def resolve_job_class
-      value = job_class_value
+      value = job_class
+      value = value.call if value.respond_to?(:call)
       value.is_a?(String) ? value.constantize : value
     end
 
@@ -236,22 +239,17 @@ module GoodJob # :nodoc:
       schedule if schedule.instance_of?(Fugit::Cron)
     end
 
-    def job_class_value
-      value = job_class || nil
-      value.respond_to?(:call) ? value.call : value
-    end
-
-    def set_value
+    def resolve_set
       value = set || {}
       value.respond_to?(:call) ? value.call : value
     end
 
-    def args_value
+    def resolve_args
       value = args || []
       value.respond_to?(:call) ? value.call : value
     end
 
-    def kwargs_value
+    def resolve_kwargs
       value = kwargs || nil
       value.respond_to?(:call) ? value.call : value
     end

data/app/models/good_job/execution.rb

@@ -3,6 +3,7 @@
 module GoodJob # :nodoc:
   class Execution < BaseRecord
     include ErrorEvents
+    include FilteredArguments
 
     self.table_name = 'good_job_executions'
     self.implicit_order_column = 'created_at'
@@ -63,6 +64,7 @@ module GoodJob # :nodoc:
 
     def display_serialized_params
       serialized_params.merge({
+                                "arguments" => display_arguments,
                                 _good_job_execution: attributes.except('serialized_params'),
                               })
     end

data/app/models/good_job/job.rb

@@ -6,6 +6,7 @@ module GoodJob
     include AdvisoryLockable
     include Job::Lockable
     include ErrorEvents
+    include FilteredArguments
     include Filterable
     include Reportable
 
@@ -622,6 +623,7 @@ module GoodJob
     # @return [Hash]
     def display_serialized_params
       serialized_params.merge({
+                                "arguments" => display_arguments,
                                 _good_job: attributes.except('serialized_params', 'locktype', 'owns_advisory_lock'),
                               })
     end

data/app/models/good_job/process.rb

@@ -137,6 +137,7 @@ module GoodJob # :nodoc:
     rescue ActiveRecord::RecordNotFound
       @new_record = true
       self.created_at = self.updated_at = nil
+      id_will_change!
       state_will_change!
       save
     end

data/app/views/good_job/batches/_jobs.erb

@@ -2,10 +2,9 @@
     <div class="list-group list-group-flush text-nowrap table-jobs" role="table">
       <header class="list-group-item bg-body-tertiary">
         <div class="row small text-muted text-uppercase align-items-center">
-        <div class="col-4"><%= t("good_job.models.batch.jobs") %></div>
+        <div class="col-5"><%= t("good_job.models.batch.jobs") %></div>
           <div class="d-none d-lg-block col-lg-1 text-lg-center"><%= t "good_job.models.job.queue" %></div>
           <div class="d-none d-lg-block col-lg-1 text-lg-end"><%= t "good_job.models.job.priority" %></div>
-          <div class="d-none d-lg-block col-lg-1 text-lg-end"><%= t "good_job.models.job.labels" %></div>
           <div class="d-none d-lg-block col-lg-1 text-lg-end"><%= t "good_job.models.job.attempts" %></div>
           <div class="col text-end">
             <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
@@ -22,9 +21,16 @@
         <% jobs.each do |job| %>
           <div role="row" class="list-group-item list-group-item-action py-3">
             <div class="row align-items-center">
-              <div class="col-lg-4">
+              <div class="col-lg-5">
                 <%= tag.code link_to(job.id, job_path(job), class: "small text-muted text-decoration-none") %>
                 <%= tag.h5 tag.code(link_to(job.display_name, job_path(job), class: "text-reset text-decoration-none")), class: "text-reset mb-0" %>
+                <% if job.labels.present? %>
+                  <div class="mt-1 d-flex flex-wrap gap-1" aria-label="<%= t "good_job.models.job.labels" %>" role="group">
+                    <% job.labels.each do |label| %>
+                      <%= job_label_badge(job, label, full: true) %>
+                    <% end %>
+                  </div>
+                <% end %>
               </div>
               <div class="col-4 col-lg-1 text-lg-center">
                 <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.queue" %></div>
@@ -34,12 +40,6 @@
                 <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.priority" %></div>
                 <span class="font-monospace fw-bold"><%= job.priority %></span>
               </div>
-              <div class="col-4 col-lg-1 text-lg-end">
-                <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.labels" %></div>
-                <% job.labels&.each do |label| %>
-                  <%= job_label_badge(job, label) %>
-                <% end %>
-              </div>
               <div class="col-4 col-lg-1 text-lg-end">
                 <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.attempts" %></div>
                 <% if job.error %>

data/app/views/good_job/executions/show.html.erb

@@ -0,0 +1,11 @@
+<%= content_tag "turbo-frame", id: dom_id(@execution, :full_trace) do %>
+  <div class="small">
+    <code class="text-wrap text-break m-0 text-secondary-emphasis">
+      <%= safe_join(@execution.error_backtrace || [], tag.br) %>
+    </code>
+  </div>
+<% end %>
+
+<%= content_tag "turbo-frame", id: dom_id(@execution, :serialized_params) do %>
+  <%= tag.pre JSON.pretty_generate(truncate_display_value(@execution.display_serialized_params)) %>
+<% end %>

data/app/views/good_job/jobs/_executions.erb

@@ -58,11 +58,7 @@
                 </div>
               <% end %>
               <%= tag.div class: "tab-pane fade", id: dom_id(execution, :full_pane), role: "tabpane", aria: { labelledby: dom_id(execution, :full) }, tabindex: 0 do %>
-                <div class="small">
-                  <code class="text-wrap text-break m-0 text-secondary-emphasis">
-                    <%= safe_join(execution.error_backtrace, tag.br) %>
-                  </code>
-                </div>
+                <%= content_tag "turbo-frame", "", id: dom_id(execution, :full_trace), src: job_execution_path(@job.id, execution.id), loading: "lazy" %>
               <% end %>
             <% end %>
           <% end %>
@@ -70,7 +66,7 @@
       <% end %>
       <%= render 'good_job/custom_execution_details', execution: execution, job: @job %>
       <%= tag.div id: dom_id(execution, "params"), class: "list-group-item collapse small bg-dark text-light" do %>
-        <%= tag.pre JSON.pretty_generate(truncate_display_value(execution.display_serialized_params)) %>
+        <%= content_tag "turbo-frame", "", id: dom_id(execution, :serialized_params), src: job_execution_path(@job.id, execution.id), loading: "lazy" %>
       <% end %>
     <% end %>
   </div>

data/app/views/good_job/jobs/_table.erb

@@ -6,7 +6,7 @@
     <div class="list-group list-group-flush text-nowrap table-jobs" role="table">
       <header class="list-group-item bg-body-tertiary">
         <div class="row small text-muted text-uppercase align-items-center">
-          <div class="col-lg-4 d-flex gap-2 flex-wrap">
+          <div class="col-lg-5 d-flex gap-2 flex-wrap">
             <div class="form-check d-flex flex-row px-0 mb-0">
               <%= check_box_tag('toggle_job_ids', "1", false, data: { "checkbox-toggle-target": "all", action: "change->checkbox-toggle#toggleAll" }) %>
               <%= label_tag('toggle_job_ids', t(".toggle_all_jobs"), class: "visually-hidden") %>
@@ -53,7 +53,6 @@
           </div>
           <div class="d-none d-lg-block col-lg-1 text-lg-center"><%= t "good_job.models.job.queue" %></div>
           <div class="d-none d-lg-block col-lg-1 text-lg-end"><%= t "good_job.models.job.priority" %></div>
-          <div class="d-none d-lg-block col-lg-1 text-lg-end"><%= t "good_job.models.job.labels" %></div>
           <div class="d-none d-lg-block col-lg-1 text-lg-end"><%= t "good_job.models.job.attempts" %></div>
           <div class="col text-end">
             <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
@@ -80,11 +79,18 @@
         <% jobs.each do |job| %>
           <%= label_tag dom_id(job, :checkbox), id: dom_id(job), role: "row", class: "list-group-item list-group-item-action py-3" do %>
             <div class="row align-items-center">
-              <div class="col-lg-4 d-flex">
+              <div class="col-lg-5 d-flex">
                 <%= check_box_tag 'job_ids[]', job.id, false, id: dom_id(job, :checkbox), data: { "checkbox-toggle-target": "each", action: "change->checkbox-toggle#syncAll" } %>
-                <div class="ms-2">
+                <div class="ms-2 min-width-0">
                   <%= tag.code link_to(job.id, job_path(job), class: "small text-muted text-decoration-none") %>
                   <%= tag.h5 tag.code(link_to(job.display_name, job_path(job), class: "text-reset text-decoration-none")), class: "text-reset mb-0" %>
+                  <% if job.labels.present? %>
+                    <div class="mt-1 d-flex flex-wrap gap-1" aria-label="<%= t "good_job.models.job.labels" %>" role="group">
+                      <% job.labels.each do |label| %>
+                        <%= job_label_badge(job, label, url: filter.to_params(label: label), full: true) %>
+                      <% end %>
+                    </div>
+                  <% end %>
                   <% if job.error %>
                     <div class="mt-1 small">
                       <strong class="small text-danger"><%= t "good_job.shared.error" %>:</strong>
@@ -101,12 +107,6 @@
                 <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.priority" %></div>
                 <%= job.priority %>
               </div>
-              <div class="col-4 col-lg-1 text-wrap text-lg-end">
-                <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.labels" %></div>
-                <% job.labels&.each do |label| %>
-                  <%= job_label_badge(job, label, url: filter.to_params(label: label)) %>
-                <% end %>
-              </div>
               <div class="col-4 col-lg-1 text-lg-end">
                 <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.attempts" %></div>
                 <% if job.error %>

data/app/views/good_job/jobs/show.html.erb

@@ -85,7 +85,7 @@
     <% end %>
   </h5>
 </div>
-<%= tag.pre @job.serialized_params["arguments"].map { |argument| truncate_display_value(argument).inspect }.join(', '), class: 'text-wrap text-break' %>
+<%= tag.pre @job.display_arguments.map { |argument| truncate_display_value(argument).inspect }.join(', '), class: 'text-wrap text-break' %>
 
 <%= tag.div id: dom_id(@job, "params"), class: "list-group-item collapse small bg-dark text-light" do %>
   <%= tag.pre JSON.pretty_generate(truncate_display_value(@job.display_serialized_params)) %>

data/config/brakeman.ignore

@@ -49,13 +49,13 @@
     {
       "warning_type": "Dangerous Eval",
       "warning_code": 13,
-      "fingerprint": "54b7ac445eea2aa1735ae97fab1d841e15405a747ba0fdb577cf779286647534",
+      "fingerprint": "f7e62770ef61ea7bb2b3a0a8c19b3fa6f869fbaa51322cb56eb86f21b384ba5a",
       "check_name": "Evaluation",
       "message": "Dynamic string evaluated as code",
       "file": "lib/good_job/log_subscriber.rb",
-      "line": 356,
+      "line": 365,
       "link": "https://brakemanscanner.org/docs/warning_types/dangerous_eval/",
-      "code": "class_eval(\"        def #{level}(progname = nil, tags: [], &block)   # def info(progname = nil, tags: [], &block)\\n          return unless logger                           #   return unless logger\\n                                                         #\\n          tag_logger(*tags) do                           #   tag_logger(*tags) do\\n            logger.#{level}(progname, &block)            #     logger.info(progname, &block)\\n          end                                            #   end\\n        end                                              #\\n\", \"lib/good_job/log_subscriber.rb\", (356 + 1))",
+      "code": "class_eval(\"        def #{level}(progname = nil, tags: [], &block)   # def info(progname = nil, tags: [], &block)\\n          return unless logger                           #   return unless logger\\n                                                         #\\n          tag_logger(*tags) do                           #   tag_logger(*tags) do\\n            logger.#{level}(progname, &block)            #     logger.info(progname, &block)\\n          end                                            #   end\\n        end                                              #\\n\", \"lib/good_job/log_subscriber.rb\", (365 + 1))",
       "render_path": null,
       "location": {
         "type": "method",