good_job 4.19.0 → 4.19.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d91dd892cc8a4110a371e8539b48200a20bb34bdbb08c3f5adc19ae96d2a9374
-  data.tar.gz: bea93501defb6c13acb563afced0a7ac340ce58f0567ad12143a7e82fbfd282f
+  metadata.gz: 7afb27ab67bbbe17bf951784355a40adf87515486c7fd28c5cb12af3e2135005
+  data.tar.gz: 9f1da0f02768f9131a3c75ff1d181170a169662f631a83f05862608c579a30e6
 SHA512:
-  metadata.gz: 2e4b30ddb0ef27b8409325dc98b775a46cb8398d5422c6387917f7d22df81ef5b5206ea4c23c9f8c2d9fd4e56b8ed0c27a46d26a021296e5f7c656ecb9ada865
-  data.tar.gz: 316857dc028b6d98db33e26fd68e5246659f0e79a92ae6fd923726e84770f8c069ef80ee73efdf608d478d4ed107f85a4afd4a0a45deb8145ed1147e43a9bf8a
+  metadata.gz: 4e9e6c72eba0c338334e2acb94cc87e2b5f433ac2b36fd2ec05a1a58656dc5c6ff7d5f4d22f218aeaa04b0f432a44d908654ab0c25dd7c82194acb505539952f
+  data.tar.gz: 912da2530fec05469474232f8246f9370dd1da24e822bcf6bcb37b6f649b43ab6d0836d5999a6105eb06f999cc26bde9e94601280093451becf34c2daeb76598

data/CHANGELOG.md

@@ -1,8 +1,21 @@
 # Changelog
 
+## [v4.19.1](https://github.com/bensheldon/good_job/tree/v4.19.1) (2026-06-25)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.19.0...v4.19.1)
+
+**Fixed bugs:**
+
+- Support Rails Edge version of Arel::Table [\#1783](https://github.com/bensheldon/good_job/pull/1783) ([luizkowalski](https://github.com/luizkowalski))
+- Emit ActiveSupport::Notifications for concurrency-aborted enqueues [\#1779](https://github.com/bensheldon/good_job/pull/1779) ([bdewater-thatch](https://github.com/bdewater-thatch))
+
+**Closed issues:**
+
+- The probe server doesn't handle SIGINT/SIGTERM [\#1632](https://github.com/bensheldon/good_job/issues/1632)
+
 ## [v4.19.0](https://github.com/bensheldon/good_job/tree/v4.19.0) (2026-05-27)
 
-[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.18.2...v4.19.0)
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.18.3...v4.19.0)
 
 **Implemented enhancements:**
 
@@ -18,6 +31,17 @@
 - Make execution state completely Fiber-safe via Rails isolated execution state [\#1765](https://github.com/bensheldon/good_job/pull/1765) ([ollym](https://github.com/ollym))
 - Handle nil updated\_at in stale? method [\#1764](https://github.com/bensheldon/good_job/pull/1764) ([gavinballard](https://github.com/gavinballard))
 
+**Merged pull requests:**
+
+- Prune CI test matrix to boundary Ruby versions per Rails version [\#1777](https://github.com/bensheldon/good_job/pull/1777) ([bensheldon](https://github.com/bensheldon))
+- Refactor Concurrency::Rule to use explicit ivars instead of options hash [\#1776](https://github.com/bensheldon/good_job/pull/1776) ([bensheldon](https://github.com/bensheldon))
+- Fix typo in README.md [\#1773](https://github.com/bensheldon/good_job/pull/1773) ([NobodysNightmare](https://github.com/NobodysNightmare))
+- Use explicit keyword arguments for concurrency controls [\#1770](https://github.com/bensheldon/good_job/pull/1770) ([bdewater-thatch](https://github.com/bdewater-thatch))
+
+## [v4.18.3](https://github.com/bensheldon/good_job/tree/v4.18.3) (2026-05-27)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.18.2...v4.18.3)
+
 **Closed issues:**
 
 - enable\_pauses ENV var check has singular/plural mismatch [\#1771](https://github.com/bensheldon/good_job/issues/1771)
@@ -27,13 +51,6 @@
 - Job runner process enters a loop on create\_listen\_task - stale check fails [\#1649](https://github.com/bensheldon/good_job/issues/1649)
 - Set a default queue\_select\_limit [\#1596](https://github.com/bensheldon/good_job/issues/1596)
 
-**Merged pull requests:**
-
-- Prune CI test matrix to boundary Ruby versions per Rails version [\#1777](https://github.com/bensheldon/good_job/pull/1777) ([bensheldon](https://github.com/bensheldon))
-- Refactor Concurrency::Rule to use explicit ivars instead of options hash [\#1776](https://github.com/bensheldon/good_job/pull/1776) ([bensheldon](https://github.com/bensheldon))
-- Fix typo in README.md [\#1773](https://github.com/bensheldon/good_job/pull/1773) ([NobodysNightmare](https://github.com/NobodysNightmare))
-- Use explicit keyword arguments for concurrency controls [\#1770](https://github.com/bensheldon/good_job/pull/1770) ([bdewater-thatch](https://github.com/bdewater-thatch))
-
 ## [v4.18.2](https://github.com/bensheldon/good_job/tree/v4.18.2) (2026-04-20)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v4.18.1...v4.18.2)

data/app/models/concerns/good_job/advisory_lockable.rb

@@ -207,6 +207,7 @@ module GoodJob
     end
 
     ADVISORY_LOCK_COUNTS = AdvisoryLockCounter.new
+    AREL_TABLE_NEW_KWARGS = Arel::Table.instance_method(:initialize).parameters.any? { |type, name| type == :key && name == :name }
 
     included do
       # Default column to be used when creating Advisory Locks
@@ -357,7 +358,7 @@ module GoodJob
           primary_key_for_select = primary_key.to_sym
           column_for_select = column.to_sym
 
-          cte_table = Arel::Table.new(:rows)
+          cte_table = arel_table_for(:rows)
           cte_query = original_query.except(:limit)
           cte_query = if primary_key_for_select == column_for_select
                         cte_query.select(primary_key_for_select)
@@ -485,6 +486,13 @@ module GoodJob
 
       private
 
+      # Arel::Table.new has different parameters depending on Rails version.
+      # New version expects keyword arguments for the name while the old version expects a positional argument.
+      # This method creates a new Arel::Table instance with the correct parameters.
+      def arel_table_for(name)
+        AREL_TABLE_NEW_KWARGS ? Arel::Table.new(name: name) : Arel::Table.new(name)
+      end
+
       # Executes a single pg_advisory_unlock call and updates bookkeeping.
       # Used by {.advisory_unlock_key} and {.advisory_unlock_key!} to avoid
       # mutual recursion when CTE-aware cleanup is needed.

data/config/brakeman.ignore

@@ -66,13 +66,13 @@
     {
       "warning_type": "Dangerous Eval",
       "warning_code": 13,
-      "fingerprint": "c4c3e1b8b28ebbfd4672cf3e8f0022a27aff3c12dc4fea750b412de1387f91e6",
+      "fingerprint": "c01ff32ee40cc694540aaa76e3fdab8f330babd9d6dbf2564c32aef1cfd877fa",
       "check_name": "Evaluation",
       "message": "Dynamic string evaluated as code",
       "file": "lib/good_job/log_subscriber.rb",
-      "line": 256,
+      "line": 278,
       "link": "https://brakemanscanner.org/docs/warning_types/dangerous_eval/",
-      "code": "class_eval(\"        def #{level}(progname = nil, tags: [], &block)   # def info(progname = nil, tags: [], &block)\\n          return unless logger                           #   return unless logger\\n                                                         #\\n          tag_logger(*tags) do                           #   tag_logger(*tags) do\\n            logger.#{level}(progname, &block)            #     logger.info(progname, &block)\\n          end                                            #   end\\n        end                                              #\\n\", \"lib/good_job/log_subscriber.rb\", (256 + 1))",
+      "code": "class_eval(\"        def #{level}(progname = nil, tags: [], &block)   # def info(progname = nil, tags: [], &block)\\n          return unless logger                           #   return unless logger\\n                                                         #\\n          tag_logger(*tags) do                           #   tag_logger(*tags) do\\n            logger.#{level}(progname, &block)            #     logger.info(progname, &block)\\n          end                                            #   end\\n        end                                              #\\n\", \"lib/good_job/log_subscriber.rb\", (278 + 1))",
       "render_path": null,
       "location": {
         "type": "method",

data/lib/good_job/active_job_extensions/concurrency.rb

@@ -120,7 +120,10 @@ module GoodJob
                                       end
 
                 if (enqueue_concurrency + 1) > limit
-                  job.logger.info "Aborted enqueue of #{job.class.name} (Job ID: #{job.job_id}) because the concurrency key '#{key}' has reached its enqueue limit of #{limit} #{'job'.pluralize(limit)}"
+                  ActiveSupport::Notifications.instrument(
+                    "enqueue_concurrency_limit_exceeded.good_job",
+                    { job: job, key: key, limit: limit }
+                  )
                   exceeded = :limit
                   next
                 end
@@ -134,7 +137,10 @@ module GoodJob
                                          .count
 
                 if (enqueued_within_period + 1) > throttle_limit
-                  job.logger.info "Aborted enqueue of #{job.class.name} (Job ID: #{job.job_id}) because the concurrency key '#{key}' has reached its throttle limit of #{throttle_limit} #{'job'.pluralize(throttle_limit)}"
+                  ActiveSupport::Notifications.instrument(
+                    "enqueue_concurrency_throttle_exceeded.good_job",
+                    { job: job, key: key, limit: throttle_limit }
+                  )
                   exceeded = :throttle
                   next
                 end

data/lib/good_job/log_subscriber.rb

@@ -153,6 +153,28 @@ module GoodJob
       end
     end
 
+    # @!macro notification_responder
+    def enqueue_concurrency_limit_exceeded(event)
+      job = event.payload[:job]
+      key = event.payload[:key]
+      limit = event.payload[:limit]
+
+      info do
+        "Aborted enqueue of #{job.class.name} (Job ID: #{job.job_id}) because the concurrency key '#{key}' has reached its enqueue limit of #{limit} #{'job'.pluralize(limit)}"
+      end
+    end
+
+    # @!macro notification_responder
+    def enqueue_concurrency_throttle_exceeded(event)
+      job = event.payload[:job]
+      key = event.payload[:key]
+      limit = event.payload[:limit]
+
+      info do
+        "Aborted enqueue of #{job.class.name} (Job ID: #{job.job_id}) because the concurrency key '#{key}' has reached its throttle limit of #{limit} #{'job'.pluralize(limit)}"
+      end
+    end
+
     # @!macro notification_responder
     def systemd_watchdog_start(event)
       interval = event.payload[:interval]

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '4.19.0'
+  VERSION = '4.19.1'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 4.19.0
+  version: 4.19.1
 platform: ruby
 authors:
 - Ben Sheldon