good_job 4.11.1 → 4.12.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c69e8c15dd5fb5a07db3dd7bba0c71d9a519dd493c81510cb5ff8ff2cc3aa511
-  data.tar.gz: 7d6c2e2b36b732bdef7d1176f9c56c1f2846f9c8eb3f919af80c039cbf5b4fce
+  metadata.gz: f8d2230721300457a34764edf4b7b05a7c2e1e58931186a594b505f13c3a35f0
+  data.tar.gz: 9330aa1ed9b6fea281bbe9cf95c6a46d96f6eb670b12041d113fb56c89228d87
 SHA512:
-  metadata.gz: 1a02075581a2d702880e99804db959c67d40d06d946a4392961d635c3b57c484c54755c2fe2cc024e9ca0eac5c9d40a164181dc515e07d6b48672553f907cf75
-  data.tar.gz: 19db6c5195211f4fd0c1eda703d4cf6444ae4afcb4cb8b5388e44d9c0fa21ca5007c97c438b8821b8871a304842c4ad536ae8878eb4b29fdf585b08c78a983da
+  metadata.gz: a545269af550ef4a99d353d2fa0f08c60c002651682dc58b831a85a63aff0703506c19047230d09572de99810c4754e184ec2fcb852429f84330fdde70e855ba
+  data.tar.gz: cc75f90006b8e24237759f5648ff78a3799c5a67b055df61c73dcc1f71f2cc7b40e3a60f7898f7688609ec677587fe7fd11762a7dbcaa3af75d33319e8f08c58

data/CHANGELOG.md

@@ -1,5 +1,56 @@
 # Changelog
 
+## [v4.12.0](https://github.com/bensheldon/good_job/tree/v4.12.0) (2025-09-22)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.11.2...v4.12.0)
+
+**Implemented enhancements:**
+
+- Allow `GoodJob::Cli.log_to_stdout =` to be set by the parent application [\#1680](https://github.com/bensheldon/good_job/pull/1680) ([bensheldon](https://github.com/bensheldon))
+- Optimize job\_class scope performance by using column instead of JSON extraction [\#1672](https://github.com/bensheldon/good_job/pull/1672) ([ScotterC](https://github.com/ScotterC))
+- Add state column to cron entries table [\#1652](https://github.com/bensheldon/good_job/pull/1652) ([gregplumbly](https://github.com/gregplumbly))
+
+**Fixed bugs:**
+
+- Reorganize Dashboard header, ensure favicon svg is encoded; fix double mt-auto [\#1668](https://github.com/bensheldon/good_job/pull/1668) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- GoodJob Cron unique index [\#1678](https://github.com/bensheldon/good_job/issues/1678)
+- params\_job\_class JSON extraction causing performance issues - why not use job\_class column? [\#1671](https://github.com/bensheldon/good_job/issues/1671)
+- Good Job process stalling and CPU at 100% [\#1669](https://github.com/bensheldon/good_job/issues/1669)
+
+**Merged pull requests:**
+
+- Update sorbet/tapioca [\#1681](https://github.com/bensheldon/good_job/pull/1681) ([bensheldon](https://github.com/bensheldon))
+- Remove obsolete property from tests [\#1676](https://github.com/bensheldon/good_job/pull/1676) ([RDIL](https://github.com/RDIL))
+- Bump actions/checkout from 4 to 5 [\#1673](https://github.com/bensheldon/good_job/pull/1673) ([dependabot[bot]](https://github.com/apps/dependabot))
+
+## [v4.11.2](https://github.com/bensheldon/good_job/tree/v4.11.2) (2025-08-06)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.11.1...v4.11.2)
+
+**Implemented enhancements:**
+
+- Add a favicon [\#1664](https://github.com/bensheldon/good_job/pull/1664) ([itsalongstory](https://github.com/itsalongstory))
+
+**Fixed bugs:**
+
+- UI: Add `.text-wrap` to the Cron Entry key [\#1667](https://github.com/bensheldon/good_job/pull/1667) ([seanpdoyle](https://github.com/seanpdoyle))
+- Fix duplicate parameters [\#1648](https://github.com/bensheldon/good_job/pull/1648) ([itsalongstory](https://github.com/itsalongstory))
+
+**Closed issues:**
+
+- проблема с вб [\#1665](https://github.com/bensheldon/good_job/issues/1665)
+
+**Merged pull requests:**
+
+- Docufix: correct connects\_to statement for multiple databases setup [\#1663](https://github.com/bensheldon/good_job/pull/1663) ([amo13](https://github.com/amo13))
+- Update development dependencies and Rubocop [\#1662](https://github.com/bensheldon/good_job/pull/1662) ([bensheldon](https://github.com/bensheldon))
+- Remove circular dependency of requiring good\_job in engine [\#1655](https://github.com/bensheldon/good_job/pull/1655) ([bensheldon](https://github.com/bensheldon))
+- Render the current time according to the Rails application's time zone setting. [\#1650](https://github.com/bensheldon/good_job/pull/1650) ([itsalongstory](https://github.com/itsalongstory))
+- Make the processes page more responsive by extracting queues and max\_threads [\#1647](https://github.com/bensheldon/good_job/pull/1647) ([luizkowalski](https://github.com/luizkowalski))
+
 ## [v4.11.1](https://github.com/bensheldon/good_job/tree/v4.11.1) (2025-06-30)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v4.11.0...v4.11.1)
@@ -999,7 +1050,7 @@
 
 **Fixed bugs:**
 
-- Skip `RecordAlreadyAdvisoryLockedError` during mass-update action [\#1158](https://github.com/bensheldon/good_job/pull/1158) ([jmarsh24](https://github.com/jmarsh24))
+- Skip `RecordAlreadyAdvisoryLockedError` during mass-update action [\#1158](https://github.com/bensheldon/good_job/pull/1158) ([justinallenmarsh](https://github.com/justinallenmarsh))
 
 **Closed issues:**
 

data/README.md

@@ -358,7 +358,7 @@ Good Job’s general behavior can also be configured via attributes directly on
     ```ruby
     # config/initializers/good_job.rb
     GoodJob.configure_active_record do
-      connects_to database: :special_database
+      connects_to database: { writing: :special_database }
       self.table_name_prefix = "special_application_"
     end
     ```

data/app/controllers/good_job/jobs_controller.rb

@@ -97,7 +97,8 @@ module GoodJob
     def redirect_to_index
       # Redirect to the jobs page, maintaining query parameters. This is
       # necessary to support the `?poll=1` parameter that enables live polling.
-      redirect_to jobs_path(request.query_parameters)
+      # But `locale` will be set by `default_url_options`.
+      redirect_to jobs_path(request.query_parameters.except("locale"))
     end
 
     private

data/app/filters/good_job/base_filter.rb

@@ -30,7 +30,7 @@ module GoodJob
 
     def queues
       base_query.group(:queue_name).count
-                .sort_by { |name, _count| name.to_s || EMPTY }
+                .sort_by { |name, _count| name.presence || EMPTY }
                 .to_h
     end
 

data/app/models/good_job/batch_record.rb

@@ -67,14 +67,14 @@ module GoodJob
               on_discard.constantize.set(priority: callback_priority, queue: callback_queue_name).perform_later(to_batch, { event: :discard }) if on_discard.present?
             end
 
-            if enqueued_at && !(self.class.jobs_finished_at_migrated? ? jobs_finished_at : finished_at) && jobs.where(finished_at: nil).count.zero?
+            if enqueued_at && !(self.class.jobs_finished_at_migrated? ? jobs_finished_at : finished_at) && jobs.where(finished_at: nil).none?
               self.class.jobs_finished_at_migrated? ? update(jobs_finished_at: Time.current) : update(finished_at: Time.current)
 
               on_success.constantize.set(priority: callback_priority, queue: callback_queue_name).perform_later(to_batch, { event: :success }) if !discarded_at && on_success.present?
               on_finish.constantize.set(priority: callback_priority, queue: callback_queue_name).perform_later(to_batch, { event: :finish }) if on_finish.present?
             end
 
-            update(finished_at: Time.current) if !finished_at && self.class.jobs_finished_at_migrated? && jobs_finished? && callback_jobs.where(finished_at: nil).count.zero?
+            update(finished_at: Time.current) if !finished_at && self.class.jobs_finished_at_migrated? && jobs_finished? && callback_jobs.where(finished_at: nil).none?
           end
         end
       end

data/app/models/good_job/job.rb

@@ -239,7 +239,7 @@ module GoodJob
       end
 
       def params_job_class
-        json_string(arel_table['serialized_params'], 'job_class')
+        arel_table[:job_class]
       end
 
       def params_execution_count
@@ -250,8 +250,8 @@ module GoodJob
         )
       end
 
-      def concurrency_key_created_at_index_migrated?
-        return true if connection.index_name_exists?(:good_jobs, :index_good_jobs_on_concurrency_key_and_created_at)
+      def job_class_index_migrated?
+        return true if connection.index_name_exists?(:good_jobs, :index_good_jobs_on_job_class)
 
         migration_pending_warning!
         false

data/app/models/good_job/setting.rb

@@ -50,7 +50,7 @@ module GoodJob
     end
 
     def self.pause(queue: nil, job_class: nil, label: nil)
-      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].count(&:present?) == 1
+      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].one?(&:present?)
 
       setting = find_or_initialize_by(key: PAUSES) do |record|
         record.value = { "queues" => [], "job_classes" => [], "labels" => [] }
@@ -70,7 +70,7 @@ module GoodJob
     end
 
     def self.unpause(queue: nil, job_class: nil, label: nil)
-      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].count(&:present?) == 1
+      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].one?(&:present?)
 
       setting = find_by(key: PAUSES)
       return unless setting
@@ -92,7 +92,7 @@ module GoodJob
     end
 
     def self.paused?(queue: nil, job_class: nil, label: nil)
-      raise ArgumentError, "Must provide at most one of queue, job_class, or label" if [queue, job_class, label].count(&:present?) > 1
+      raise ArgumentError, "Must provide at most one of queue, job_class, or label" if [queue, job_class, label].many?(&:present?)
 
       if queue
         queue.in? paused(:queues)

data/app/views/good_job/cron_entries/index.html.erb

@@ -6,12 +6,13 @@
   <div class="list-group list-group-flush text-nowrap" role="table">
     <header class="list-group-item body-secondary">
       <div class="row small text-muted text-uppercase align-items-center">
-        <div class="col-12 col-lg-2"></div>
-        <div class="col-6 col-lg-2 d-none d-lg-block"><%= t "good_job.models.cron.class" %></div>
-        <div class="col-6 col-lg-2 d-none d-lg-block"><%= t "good_job.models.cron.schedule" %></div>
-        <div class="col-6 col-lg-2 d-none d-lg-block"><%= t "good_job.models.cron.next_scheduled" %></div>
-        <div class="col-6 col-lg-2 d-none d-lg-block"><%= t "good_job.models.cron.last_run" %></div>
-        <div class="col text-end">
+        <div class="col-lg-2"></div>
+        <div class="col-lg-2 d-none d-lg-block"><%= t "good_job.models.cron.class" %></div>
+        <div class="col-lg-2 d-none d-lg-block"><%= t "good_job.models.cron.schedule" %></div>
+        <div class="col-lg-2 d-none d-lg-block"><%= t "good_job.models.cron.next_scheduled" %></div>
+        <div class="col-lg-1 d-none d-lg-block"><%= t "good_job.models.cron.last_run" %></div>
+        <div class="col-lg-1 d-none d-lg-block"><%= t "good_job.models.cron.status" %></div>
+        <div class="col-lg-2 text-end">
           <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
                          data: { bs_toggle: "collapse", bs_target: ".cron-entry-properties" },
                          aria: { expanded: false, controls: @cron_entries.map { |cron_entry| "##{dom_id(cron_entry, 'properties')}" }.join(" ") } do %>
@@ -25,7 +26,7 @@
       <div id="<%= dom_id(cron_entry) %>" class="list-group-item py-3" role="row">
         <div class="row align-items-center">
           <div class="col-12 col-lg-2">
-            <div class="small font-monospace"><%= cron_entry.key %></div>
+            <div class="small font-monospace text-wrap"><%= cron_entry.key %></div>
             <div class="small text-muted text-wrap"><%= cron_entry.description %></div>
           </div>
           <div class="col-12 col-lg-2 text-wrap"><%= tag.span tag.code(cron_entry.job_class), class: "fs-5 mb-0" %></div>
@@ -37,13 +38,21 @@
             <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.cron.next_scheduled" %></div>
             <%= relative_time cron_entry.next_at %>
           </div>
-          <div class="col-6 col-lg-2 text-wrap small">
+          <div class="col-6 col-lg-1 text-wrap small">
             <% if cron_entry.last_job.present? %>
               <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.cron.last_run" %></div>
               <%= link_to relative_time(cron_entry.last_job_at), cron_entry_path(cron_entry), title: "Job #{cron_entry.last_job.id}" %>
             <% end %>
           </div>
-          <div class="col d-flex gap-3 justify-content-end">
+          <div class="col-6 col-lg-1 text-wrap small">
+            <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.cron.status" %></div>
+            <% if cron_entry.enabled? %>
+              <span class="text-success"><%= t "good_job.models.cron.states.active" %></span>
+            <% else %>
+              <span class="text-muted"><%= t "good_job.models.cron.states.paused" %></span>
+            <% end %>
+          </div>
+          <div class="col-lg-2 d-flex gap-3 justify-content-end">
             <%= button_to enqueue_cron_entry_path(cron_entry), method: :post, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: t("good_job.cron_entries.actions.enqueue") }, title: t("good_job.cron_entries.actions.enqueue"), data: { confirm: t("good_job.cron_entries.actions.confirm_enqueue") } do %>
               <%= render_icon "skip_forward" %>
             <% end %>

data/app/views/good_job/processes/index.html.erb

@@ -3,7 +3,7 @@
 </div>
 
 <div class="card my-3" data-live-poll-region="processes">
-  <div class="list-group list-group-flush text-nowrap" role="table">
+  <div class="list-group list-group-flush" role="table">
     <header class="list-group-item bg-body-tertiary">
       <div class="row small text-muted text-uppercase align-items-center">
         <div class="col"><%= t ".process" %></div>
@@ -41,9 +41,9 @@
               <span class="badge rounded-pill bg-body-secondary text-secondary"><%= (process.state["memory"] / 1024).to_i %> MB</span>
             </div>
           </div>
-          <div class="col">
-            <% process.schedulers.each do |scheduler| %>
-              <pre class="mb-0"><%= scheduler.is_a?(Hash) ? scheduler['name'] : scheduler %></pre>
+          <div class="col mw-100">
+            <% process.schedulers.each do |scheduler_data| %>
+              <pre class="mb-0" title="<%= scheduler_data %>">queues=<%= scheduler_data["queues"] %> max_threads=<%= scheduler_data["max_threads"] %></pre>
             <% end %>
           </div>
           <div class="col-2 small"><%= t(ActiveModel::Type::Boolean.new.cast(process.state["cron_enabled"]), scope: "good_job.shared.boolean") %></div>

data/app/views/good_job/shared/_secondary_navbar.erb

@@ -1,10 +1,10 @@
-<nav class="navbar p-1 shadow-sm mt-auto border-bottom text-muted small" id="secondary-navbar" data-live-poll-region="secondary-navbar">
+<nav class="navbar p-1 shadow-sm border-bottom text-muted small" id="secondary-navbar" data-live-poll-region="secondary-navbar">
   <div class="container-fluid">
     <div class="flex-fill d-none d-sm-block ">
       <%= t(".inspiration") %>
     </div>
     <div class="flex-fill text-end">
-      <% last_updated_at = Time.current.utc.iso8601 %>
+      <% last_updated_at = Time.current.to_s %>
       <%= t(".last_updated") %>&nbsp;<time id="page-updated-at" datetime="<%= last_updated_at %>"><%= last_updated_at %></time>
     </div>
   </div>

data/app/views/layouts/good_job/application.html.erb

@@ -1,24 +1,21 @@
 <!DOCTYPE html>
 <html lang="<%= I18n.locale %>" data-bs-theme="auto">
   <head>
-    <title>Good Job Dashboard</title>
     <meta charset="utf-8">
     <meta content="width=device-width, initial-scale=1, shrink-to-fit=no" name="viewport">
-    <%= csrf_meta_tags %>
-    <%= csp_meta_tag %>
 
     <%# Bootstrap Color Modes
       "It is suggested to include the JavaScript at the top of your page
       to reduce potential screen flickering during reloading of your site."
       https://getbootstrap.com/docs/5.3/customize/color-modes/#javascript
     %>
-   <script nonce="<%= content_security_policy_nonce %>">
+    <script nonce="<%= content_security_policy_nonce %>">
       let theme = localStorage.getItem('good_job-theme');
       if (!["light", "dark"].includes(theme)) {
         theme = window.matchMedia('(prefers-color-scheme: dark)').matches ? 'dark' : 'light';
       }
       document.documentElement.setAttribute('data-bs-theme', theme);
-   </script>
+    </script>
 
     <%# Do not use asset tag helpers to avoid paths being overriden by config.asset_host %>
     <%= tag.link rel: "stylesheet", href: frontend_static_path(:bootstrap, format: :css, locale: nil), nonce: content_security_policy_nonce %>
@@ -30,6 +27,11 @@
     <% importmaps = GoodJob::FrontendsController.js_modules.keys.index_with { |module_name| frontend_module_path(module_name, format: :js, locale: nil) } %>
     <%= tag.script({ imports: importmaps }.to_json.html_safe, type: "importmap", nonce: content_security_policy_nonce) %>
     <%= tag.script "", type: "module", nonce: content_security_policy_nonce do %> import "application"; <% end %>
+
+    <title>Good Job Dashboard</title>
+    <%= tag.link rel: "icon", href: 'data:image/svg+xml,<svg xmlns="http://www.w3.org/2000/svg" viewBox="10 0 100 100"><text y=".90em" font-size="90">👍</text></svg>' %>
+    <%= csrf_meta_tags %>
+    <%= csp_meta_tag %>
   </head>
   <body>
     <div class="d-flex flex-column min-vh-100">

data/config/brakeman.ignore

@@ -46,6 +46,30 @@
       ],
       "note": "Files are explicitly enumerated in the array"
     },
+    {
+      "warning_type": "Dangerous Eval",
+      "warning_code": 13,
+      "fingerprint": "c4c3e1b8b28ebbfd4672cf3e8f0022a27aff3c12dc4fea750b412de1387f91e6",
+      "check_name": "Evaluation",
+      "message": "Dynamic string evaluated as code",
+      "file": "lib/good_job/log_subscriber.rb",
+      "line": 256,
+      "link": "https://brakemanscanner.org/docs/warning_types/dangerous_eval/",
+      "code": "class_eval(\"        def #{level}(progname = nil, tags: [], &block)   # def info(progname = nil, tags: [], &block)\\n          return unless logger                           #   return unless logger\\n                                                         #\\n          tag_logger(*tags) do                           #   tag_logger(*tags) do\\n            logger.#{level}(progname, &block)            #     logger.info(progname, &block)\\n          end                                            #   end\\n        end                                              #\\n\", \"lib/good_job/log_subscriber.rb\", (256 + 1))",
+      "render_path": null,
+      "location": {
+        "type": "method",
+        "class": "LogSubscriber",
+        "method": null
+      },
+      "user_input": null,
+      "confidence": "Weak",
+      "cwe_id": [
+        913,
+        95
+      ],
+      "note": ""
+    },
     {
       "warning_type": "SQL Injection",
       "warning_code": 0,
@@ -53,7 +77,7 @@
       "check_name": "SQL",
       "message": "Possible SQL injection",
       "file": "app/models/good_job/job.rb",
-      "line": 135,
+      "line": 162,
       "link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
       "code": "Arel.sql(\"(CASE #{queues.map.with_index do\n sanitize_sql_array([\"WHEN queue_name = ? THEN ?\", queue_name, index])\n end.join(\" \")} ELSE #{queues.size} END)\")",
       "render_path": null,
@@ -93,6 +117,5 @@
       "note": ""
     }
   ],
-  "updated": "2024-11-16 17:00:20 -0600",
-  "brakeman_version": "6.2.1"
+  "brakeman_version": "7.0.2"
 }

data/config/locales/de.yml

@@ -191,6 +191,10 @@ de:
         last_run: Letzter Lauf
         next_scheduled: Als nächstes geplant
         schedule: Zeitplan
+        states:
+          active: Aktiv
+          paused: Pausiert
+        status: Status
       job:
         arguments: Argumente
         attempts: Versuche

data/config/locales/en.yml

@@ -191,6 +191,10 @@ en:
         last_run: Last run
         next_scheduled: Next scheduled
         schedule: Schedule
+        states:
+          active: Active
+          paused: Paused
+        status: Status
       job:
         arguments: Arguments
         attempts: Attempts

data/config/locales/es.yml

@@ -191,6 +191,10 @@ es:
         last_run: Última ejecución
         next_scheduled: Próxima ejecución
         schedule: Cronograma
+        states:
+          active: Activo
+          paused: Pausado
+        status: Estado
       job:
         arguments: Argumentos
         attempts: Intentos

data/config/locales/fr.yml

@@ -191,6 +191,10 @@ fr:
         last_run: Dernière exécution
         next_scheduled: Prochaine exécution
         schedule: Planification
+        states:
+          active: Actif
+          paused: En pause
+        status: État
       job:
         arguments: Paramètres
         attempts: Tentatives

data/config/locales/it.yml

@@ -191,6 +191,10 @@ it:
         last_run: Ultima esecuzione
         next_scheduled: Prossima pianificazione
         schedule: Pianificazione
+        states:
+          active: Attivo
+          paused: In pausa
+        status: Stato
       job:
         arguments: Argomenti
         attempts: Tentativi

data/config/locales/ja.yml

@@ -191,6 +191,10 @@ ja:
         last_run: 前回実行日時
         next_scheduled: 次回予定日時
         schedule: スケジュール
+        states:
+          active: アクティブ
+          paused: 一時停止
+        status: 状態
       job:
         arguments: 引数
         attempts: 試行回数

data/config/locales/ko.yml

@@ -191,6 +191,10 @@ ko:
         last_run: 마지막 실행 일시
         next_scheduled: 다음 예정 일시
         schedule: 스케줄
+        states:
+          active: 활성
+          paused: 일시정지
+        status: 상태
       job:
         arguments: 인수
         attempts: 시도 횟수

data/config/locales/nl.yml

@@ -191,6 +191,10 @@ nl:
         last_run: Laatste ronde
         next_scheduled: Volgende gepland
         schedule: Schema
+        states:
+          active: Actief
+          paused: Gepauzeerd
+        status: Status
       job:
         arguments: Argumenten
         attempts: Pogingen

data/config/locales/pt-BR.yml

@@ -191,6 +191,10 @@ pt-BR:
         last_run: Última execução
         next_scheduled: Próximo agendamento
         schedule: Agendamento
+        states:
+          active: Ativo
+          paused: Pausado
+        status: Estado
       job:
         arguments: Argumentos
         attempts: Tentativas

data/config/locales/ru.yml

@@ -217,6 +217,10 @@ ru:
         last_run: Последний запуск
         next_scheduled: Следующий по расписанию
         schedule: Расписание
+        states:
+          active: Активно
+          paused: Приостановлено
+        status: Состояние
       job:
         arguments: Параметры
         attempts: Попытки

data/config/locales/tr.yml

@@ -191,6 +191,10 @@ tr:
         last_run: Son çalıştırma
         next_scheduled: Sonraki planlama
         schedule: Program
+        states:
+          active: Aktif
+          paused: Duraklatıldı
+        status: Durum
       job:
         arguments: Argümanlar
         attempts: Denemeler

data/config/locales/uk.yml

@@ -217,6 +217,10 @@ uk:
         last_run: Останній запуск
         next_scheduled: Наступне заплановане
         schedule: Розклад
+        states:
+          active: Активний
+          paused: Призупинено
+        status: Стан
       job:
         arguments: Аргументи
         attempts: Спроби

data/exe/good_job

@@ -4,5 +4,4 @@
 require 'good_job/cli'
 
 GoodJob::CLI.within_exe = true
-GoodJob::CLI.log_to_stdout = true
 GoodJob::CLI.start(ARGV)

data/lib/generators/good_job/templates/install/migrations/create_good_jobs.rb.erb

@@ -92,6 +92,7 @@ class CreateGoodJobs < ActiveRecord::Migration<%= migration_version %>
       where: "finished_at IS NULL", name: :index_good_job_jobs_for_candidate_lookup
     add_index :good_jobs, [:batch_id], where: "batch_id IS NOT NULL"
     add_index :good_jobs, [:batch_callback_id], where: "batch_callback_id IS NOT NULL"
+    add_index :good_jobs, :job_class, name: :index_good_jobs_on_job_class
     add_index :good_jobs, :labels, using: :gin, where: "(labels IS NOT NULL)", name: :index_good_jobs_on_labels
 
     add_index :good_job_executions, [:active_job_id, :created_at], name: :index_good_job_executions_on_active_job_id_and_created_at

data/lib/generators/good_job/templates/update/migrations/04_add_index_good_jobs_job_class.rb.erb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class AddIndexGoodJobsJobClass < ActiveRecord::Migration<%= migration_version %>
+  disable_ddl_transaction!
+
+  def change
+    reversible do |dir|
+      dir.up do
+        # Ensure this incremental update migration is idempotent
+        # with monolithic install migration.
+        return if connection.index_exists? :good_jobs, :job_class
+      end
+    end
+
+    add_index :good_jobs, :job_class, algorithm: :concurrently
+  end
+end

data/lib/good_job/capsule.rb

@@ -109,9 +109,7 @@ module GoodJob
 
     # UUID for this capsule; to be used for inspection (not directly for locking jobs).
     # @return [String]
-    def process_id
-      @tracker.process_id
-    end
+    delegate :process_id, to: :@tracker
 
     def lower_thread_priority=(value)
       @lower_thread_priority = value

data/lib/good_job/cli.rb

@@ -29,10 +29,15 @@ module GoodJob
       attr_accessor :within_exe
       alias within_exe? within_exe
 
-      # Whether to log to STDOUT
+      # Whether the CLI's default logger should log to STDOUT.
       # @return [Boolean, nil]
       attr_accessor :log_to_stdout
-      alias log_to_stdout? log_to_stdout
+
+      # Whether the CLI's default logger logs to STDOUT.
+      # @return [Boolean, nil]
+      def log_to_stdout?
+        GoodJob::CLI.log_to_stdout.nil? ? GoodJob::CLI.within_exe? : GoodJob::CLI.log_to_stdout
+      end
 
       # @!visibility private
       def exit_on_failure?

data/lib/good_job/engine.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "rails"
-require "good_job"
 
 module GoodJob
   # Ruby on Rails integration.

data/lib/good_job/log_subscriber.rb

@@ -175,9 +175,7 @@ module GoodJob
 
     # Get the logger associated with this {LogSubscriber} instance.
     # @return [Logger]
-    def logger
-      GoodJob::LogSubscriber.logger
-    end
+    delegate :logger, to: :'GoodJob::LogSubscriber'
 
     class << self
       # Tracks all loggers that {LogSubscriber} is writing to. You can write to

data/lib/good_job/scheduler.rb

@@ -340,9 +340,7 @@ module GoodJob # :nodoc:
     class TimerSet < ::Concurrent::TimerSet
       # Number of scheduled jobs in the queue
       # @return [Integer]
-      def length
-        @queue.length
-      end
+      delegate :length, to: :@queue
 
       # Clear the queue
       # @return [void]

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '4.11.1'
+  VERSION = '4.12.0'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

data/lib/good_job.rb

@@ -290,7 +290,7 @@ module GoodJob
   # For use in tests/CI to validate GoodJob is up-to-date.
   # @return [Boolean]
   def self.migrated?
-    GoodJob::Job.concurrency_key_created_at_index_migrated?
+    GoodJob::Job.job_class_index_migrated?
   end
 
   # Pause job execution for a given queue or job class.

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 4.11.1
+  version: 4.12.0
 platform: ruby
 authors:
 - Ben Sheldon
 bindir: exe
 cert_chain: []
-date: 2025-06-30 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -240,9 +240,9 @@ executables:
 - good_job
 extensions: []
 extra_rdoc_files:
-- README.md
 - CHANGELOG.md
 - LICENSE.txt
+- README.md
 files:
 - CHANGELOG.md
 - LICENSE.txt
@@ -349,6 +349,7 @@ files:
 - lib/generators/good_job/templates/update/migrations/01_create_good_jobs.rb.erb
 - lib/generators/good_job/templates/update/migrations/02_add_jobs_finished_at_to_good_job_batches.rb.erb
 - lib/generators/good_job/templates/update/migrations/03_add_index_good_jobs_concurrency_key_created_at.rb.erb
+- lib/generators/good_job/templates/update/migrations/04_add_index_good_jobs_job_class.rb.erb
 - lib/generators/good_job/update_generator.rb
 - lib/good_job.rb
 - lib/good_job/active_job_extensions/batches.rb
@@ -421,7 +422,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.7.2
 specification_version: 4
 summary: A multithreaded, Postgres-based ActiveJob backend for Ruby on Rails
 test_files: []