good_job 4.11.1 → 4.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c69e8c15dd5fb5a07db3dd7bba0c71d9a519dd493c81510cb5ff8ff2cc3aa511
-  data.tar.gz: 7d6c2e2b36b732bdef7d1176f9c56c1f2846f9c8eb3f919af80c039cbf5b4fce
+  metadata.gz: 5de7dadf0496603de0b1b38fbb1df12745078c8cb529f615f2495c6ff926caca
+  data.tar.gz: 94a0e727f0523e64ceb63cec668cd532c25e55cb0257a2f5c4328762aacef6cd
 SHA512:
-  metadata.gz: 1a02075581a2d702880e99804db959c67d40d06d946a4392961d635c3b57c484c54755c2fe2cc024e9ca0eac5c9d40a164181dc515e07d6b48672553f907cf75
-  data.tar.gz: 19db6c5195211f4fd0c1eda703d4cf6444ae4afcb4cb8b5388e44d9c0fa21ca5007c97c438b8821b8871a304842c4ad536ae8878eb4b29fdf585b08c78a983da
+  metadata.gz: 44614cb9f776531726c775baf89e8433306c4cad9f477099fb4c752ef6ba6e9504e8001f95ec37db1ce366925da183a530d7c3ba259b070d4b24a6a617379d30
+  data.tar.gz: d4eac5bbaf7b13f7431fdeb550f4390215df86cd02cb063da24aaab058e5e70dda336aa5543cd71bb20690292d7da8a6ccf5a24c438dbb30b5b99e353fbbe01f

data/CHANGELOG.md

@@ -1,5 +1,30 @@
 # Changelog
 
+## [v4.11.2](https://github.com/bensheldon/good_job/tree/v4.11.2) (2025-08-06)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.11.1...v4.11.2)
+
+**Implemented enhancements:**
+
+- Add a favicon [\#1664](https://github.com/bensheldon/good_job/pull/1664) ([itsalongstory](https://github.com/itsalongstory))
+
+**Fixed bugs:**
+
+- UI: Add `.text-wrap` to the Cron Entry key [\#1667](https://github.com/bensheldon/good_job/pull/1667) ([seanpdoyle](https://github.com/seanpdoyle))
+- Fix duplicate parameters [\#1648](https://github.com/bensheldon/good_job/pull/1648) ([itsalongstory](https://github.com/itsalongstory))
+
+**Closed issues:**
+
+- проблема с вб [\#1665](https://github.com/bensheldon/good_job/issues/1665)
+
+**Merged pull requests:**
+
+- Docufix: correct connects\_to statement for multiple databases setup [\#1663](https://github.com/bensheldon/good_job/pull/1663) ([amo13](https://github.com/amo13))
+- Update development dependencies and Rubocop [\#1662](https://github.com/bensheldon/good_job/pull/1662) ([bensheldon](https://github.com/bensheldon))
+- Remove circular dependency of requiring good\_job in engine [\#1655](https://github.com/bensheldon/good_job/pull/1655) ([bensheldon](https://github.com/bensheldon))
+- Render the current time according to the Rails application's time zone setting. [\#1650](https://github.com/bensheldon/good_job/pull/1650) ([itsalongstory](https://github.com/itsalongstory))
+- Make the processes page more responsive by extracting queues and max\_threads [\#1647](https://github.com/bensheldon/good_job/pull/1647) ([luizkowalski](https://github.com/luizkowalski))
+
 ## [v4.11.1](https://github.com/bensheldon/good_job/tree/v4.11.1) (2025-06-30)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v4.11.0...v4.11.1)

data/README.md

@@ -358,7 +358,7 @@ Good Job’s general behavior can also be configured via attributes directly on
     ```ruby
     # config/initializers/good_job.rb
     GoodJob.configure_active_record do
-      connects_to database: :special_database
+      connects_to database: { writing: :special_database }
       self.table_name_prefix = "special_application_"
     end
     ```

data/app/controllers/good_job/jobs_controller.rb

@@ -97,7 +97,8 @@ module GoodJob
     def redirect_to_index
       # Redirect to the jobs page, maintaining query parameters. This is
       # necessary to support the `?poll=1` parameter that enables live polling.
-      redirect_to jobs_path(request.query_parameters)
+      # But `locale` will be set by `default_url_options`.
+      redirect_to jobs_path(request.query_parameters.except("locale"))
     end
 
     private

data/app/filters/good_job/base_filter.rb

@@ -30,7 +30,7 @@ module GoodJob
 
     def queues
       base_query.group(:queue_name).count
-                .sort_by { |name, _count| name.to_s || EMPTY }
+                .sort_by { |name, _count| name.presence || EMPTY }
                 .to_h
     end
 

data/app/models/good_job/batch_record.rb

@@ -67,14 +67,14 @@ module GoodJob
               on_discard.constantize.set(priority: callback_priority, queue: callback_queue_name).perform_later(to_batch, { event: :discard }) if on_discard.present?
             end
 
-            if enqueued_at && !(self.class.jobs_finished_at_migrated? ? jobs_finished_at : finished_at) && jobs.where(finished_at: nil).count.zero?
+            if enqueued_at && !(self.class.jobs_finished_at_migrated? ? jobs_finished_at : finished_at) && jobs.where(finished_at: nil).none?
               self.class.jobs_finished_at_migrated? ? update(jobs_finished_at: Time.current) : update(finished_at: Time.current)
 
               on_success.constantize.set(priority: callback_priority, queue: callback_queue_name).perform_later(to_batch, { event: :success }) if !discarded_at && on_success.present?
               on_finish.constantize.set(priority: callback_priority, queue: callback_queue_name).perform_later(to_batch, { event: :finish }) if on_finish.present?
             end
 
-            update(finished_at: Time.current) if !finished_at && self.class.jobs_finished_at_migrated? && jobs_finished? && callback_jobs.where(finished_at: nil).count.zero?
+            update(finished_at: Time.current) if !finished_at && self.class.jobs_finished_at_migrated? && jobs_finished? && callback_jobs.where(finished_at: nil).none?
           end
         end
       end

data/app/models/good_job/setting.rb

@@ -50,7 +50,7 @@ module GoodJob
     end
 
     def self.pause(queue: nil, job_class: nil, label: nil)
-      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].count(&:present?) == 1
+      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].one?(&:present?)
 
       setting = find_or_initialize_by(key: PAUSES) do |record|
         record.value = { "queues" => [], "job_classes" => [], "labels" => [] }
@@ -70,7 +70,7 @@ module GoodJob
     end
 
     def self.unpause(queue: nil, job_class: nil, label: nil)
-      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].count(&:present?) == 1
+      raise ArgumentError, "Must provide exactly one of queue, job_class, or label" unless [queue, job_class, label].one?(&:present?)
 
       setting = find_by(key: PAUSES)
       return unless setting
@@ -92,7 +92,7 @@ module GoodJob
     end
 
     def self.paused?(queue: nil, job_class: nil, label: nil)
-      raise ArgumentError, "Must provide at most one of queue, job_class, or label" if [queue, job_class, label].count(&:present?) > 1
+      raise ArgumentError, "Must provide at most one of queue, job_class, or label" if [queue, job_class, label].many?(&:present?)
 
       if queue
         queue.in? paused(:queues)

data/app/views/good_job/cron_entries/index.html.erb

@@ -25,7 +25,7 @@
       <div id="<%= dom_id(cron_entry) %>" class="list-group-item py-3" role="row">
         <div class="row align-items-center">
           <div class="col-12 col-lg-2">
-            <div class="small font-monospace"><%= cron_entry.key %></div>
+            <div class="small font-monospace text-wrap"><%= cron_entry.key %></div>
             <div class="small text-muted text-wrap"><%= cron_entry.description %></div>
           </div>
           <div class="col-12 col-lg-2 text-wrap"><%= tag.span tag.code(cron_entry.job_class), class: "fs-5 mb-0" %></div>

data/app/views/good_job/processes/index.html.erb

@@ -3,7 +3,7 @@
 </div>
 
 <div class="card my-3" data-live-poll-region="processes">
-  <div class="list-group list-group-flush text-nowrap" role="table">
+  <div class="list-group list-group-flush" role="table">
     <header class="list-group-item bg-body-tertiary">
       <div class="row small text-muted text-uppercase align-items-center">
         <div class="col"><%= t ".process" %></div>
@@ -41,9 +41,9 @@
               <span class="badge rounded-pill bg-body-secondary text-secondary"><%= (process.state["memory"] / 1024).to_i %> MB</span>
             </div>
           </div>
-          <div class="col">
-            <% process.schedulers.each do |scheduler| %>
-              <pre class="mb-0"><%= scheduler.is_a?(Hash) ? scheduler['name'] : scheduler %></pre>
+          <div class="col mw-100">
+            <% process.schedulers.each do |scheduler_data| %>
+              <pre class="mb-0" title="<%= scheduler_data %>">queues=<%= scheduler_data["queues"] %> max_threads=<%= scheduler_data["max_threads"] %></pre>
             <% end %>
           </div>
           <div class="col-2 small"><%= t(ActiveModel::Type::Boolean.new.cast(process.state["cron_enabled"]), scope: "good_job.shared.boolean") %></div>

data/app/views/good_job/shared/_secondary_navbar.erb

@@ -4,7 +4,7 @@
       <%= t(".inspiration") %>
     </div>
     <div class="flex-fill text-end">
-      <% last_updated_at = Time.current.utc.iso8601 %>
+      <% last_updated_at = Time.current.to_s %>
       <%= t(".last_updated") %>&nbsp;<time id="page-updated-at" datetime="<%= last_updated_at %>"><%= last_updated_at %></time>
     </div>
   </div>

data/app/views/layouts/good_job/application.html.erb

@@ -4,6 +4,7 @@
     <title>Good Job Dashboard</title>
     <meta charset="utf-8">
     <meta content="width=device-width, initial-scale=1, shrink-to-fit=no" name="viewport">
+    <link rel="icon" href="data:image/svg+xml,<svg xmlns=%22http://www.w3.org/2000/svg%22 viewBox=%2210 0 100 100%22><text y=%22.90em%22 font-size=%2290%22>👍</text></svg>">
     <%= csrf_meta_tags %>
     <%= csp_meta_tag %>
 

data/config/brakeman.ignore

@@ -46,6 +46,30 @@
       ],
       "note": "Files are explicitly enumerated in the array"
     },
+    {
+      "warning_type": "Dangerous Eval",
+      "warning_code": 13,
+      "fingerprint": "c4c3e1b8b28ebbfd4672cf3e8f0022a27aff3c12dc4fea750b412de1387f91e6",
+      "check_name": "Evaluation",
+      "message": "Dynamic string evaluated as code",
+      "file": "lib/good_job/log_subscriber.rb",
+      "line": 256,
+      "link": "https://brakemanscanner.org/docs/warning_types/dangerous_eval/",
+      "code": "class_eval(\"        def #{level}(progname = nil, tags: [], &block)   # def info(progname = nil, tags: [], &block)\\n          return unless logger                           #   return unless logger\\n                                                         #\\n          tag_logger(*tags) do                           #   tag_logger(*tags) do\\n            logger.#{level}(progname, &block)            #     logger.info(progname, &block)\\n          end                                            #   end\\n        end                                              #\\n\", \"lib/good_job/log_subscriber.rb\", (256 + 1))",
+      "render_path": null,
+      "location": {
+        "type": "method",
+        "class": "LogSubscriber",
+        "method": null
+      },
+      "user_input": null,
+      "confidence": "Weak",
+      "cwe_id": [
+        913,
+        95
+      ],
+      "note": ""
+    },
     {
       "warning_type": "SQL Injection",
       "warning_code": 0,
@@ -53,7 +77,7 @@
       "check_name": "SQL",
       "message": "Possible SQL injection",
       "file": "app/models/good_job/job.rb",
-      "line": 135,
+      "line": 162,
       "link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
       "code": "Arel.sql(\"(CASE #{queues.map.with_index do\n sanitize_sql_array([\"WHEN queue_name = ? THEN ?\", queue_name, index])\n end.join(\" \")} ELSE #{queues.size} END)\")",
       "render_path": null,
@@ -93,6 +117,5 @@
       "note": ""
     }
   ],
-  "updated": "2024-11-16 17:00:20 -0600",
-  "brakeman_version": "6.2.1"
+  "brakeman_version": "7.0.2"
 }

data/lib/good_job/capsule.rb

@@ -109,9 +109,7 @@ module GoodJob
 
     # UUID for this capsule; to be used for inspection (not directly for locking jobs).
     # @return [String]
-    def process_id
-      @tracker.process_id
-    end
+    delegate :process_id, to: :@tracker
 
     def lower_thread_priority=(value)
       @lower_thread_priority = value

data/lib/good_job/engine.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "rails"
-require "good_job"
 
 module GoodJob
   # Ruby on Rails integration.

data/lib/good_job/log_subscriber.rb

@@ -175,9 +175,7 @@ module GoodJob
 
     # Get the logger associated with this {LogSubscriber} instance.
     # @return [Logger]
-    def logger
-      GoodJob::LogSubscriber.logger
-    end
+    delegate :logger, to: :'GoodJob::LogSubscriber'
 
     class << self
       # Tracks all loggers that {LogSubscriber} is writing to. You can write to

data/lib/good_job/scheduler.rb

@@ -340,9 +340,7 @@ module GoodJob # :nodoc:
     class TimerSet < ::Concurrent::TimerSet
       # Number of scheduled jobs in the queue
       # @return [Integer]
-      def length
-        @queue.length
-      end
+      delegate :length, to: :@queue
 
       # Clear the queue
       # @return [void]

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '4.11.1'
+  VERSION = '4.11.2'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 4.11.1
+  version: 4.11.2
 platform: ruby
 authors:
 - Ben Sheldon
 bindir: exe
 cert_chain: []
-date: 2025-06-30 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -240,9 +240,9 @@ executables:
 - good_job
 extensions: []
 extra_rdoc_files:
-- README.md
 - CHANGELOG.md
 - LICENSE.txt
+- README.md
 files:
 - CHANGELOG.md
 - LICENSE.txt
@@ -421,7 +421,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A multithreaded, Postgres-based ActiveJob backend for Ruby on Rails
 test_files: []