good_job 4.10.1 → 4.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3393f8a982a0d97722270c3c564db24bb73f173efeaf36495609e40bc21a495
-  data.tar.gz: fef9ab12503e8d81126811246a3f35aecf5c64808cc1fb0b0aefab76f91a556b
+  metadata.gz: 3ea0d288f72729d06fa912bb31fc26fdb95be09488347ae1f2e1de091f9517b3
+  data.tar.gz: f613ddf4c9eb310f2e7f382309c3084cf283b62681a38c57446a3816855dbe14
 SHA512:
-  metadata.gz: f543c672d6d24b8b70c4e23180f15fc01d3c51e484815c9e87d2f296040d4c56213f3a2b82a13bfc6600dd395a2db1fda02278a6e1252c874f7d21fb940ec549
-  data.tar.gz: 9e22965243e674f6429beb718423e3d19cfcd26442d0190e352497fb59e884df937f92f14ec8576ab1d9129d98977259f898d8e6f7acdd9144d9c90390bb5f5e
+  metadata.gz: 1eb544531de26bf4f483b0b3d19d9f035e198343da429c97ad3db94c604da29d3d5f74c0cdf50a6712e02bf97bbede278ac48dc0c6572b5d6c447d27dd5e2760
+  data.tar.gz: 8ad6d26f2bf94c545e3630cd3e06f7fc7975943233dd49468358f252c2ad827c6871c65a8cec3bd6f19d430a472a5a84b820d84be17e195e07e6dd3fe5033b45

data/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## [v4.11.0](https://github.com/bensheldon/good_job/tree/v4.11.0) (2025-06-30)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.10.2...v4.11.0)
+
+**Implemented enhancements:**
+
+- Add GoodJob::Adapter\#stopping to support Active Job continuations feature [\#1646](https://github.com/bensheldon/good_job/pull/1646) ([bensheldon](https://github.com/bensheldon))
+
+**Merged pull requests:**
+
+- Fix Probe Server handling server shutdown on SIGINT when daemonized [\#1644](https://github.com/bensheldon/good_job/pull/1644) ([bensheldon](https://github.com/bensheldon))
+
+## [v4.10.2](https://github.com/bensheldon/good_job/tree/v4.10.2) (2025-05-29)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.10.1...v4.10.2)
+
+**Fixed bugs:**
+
+- Fix Dashboard retries by wrapping in original/application locale [\#1643](https://github.com/bensheldon/good_job/pull/1643) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- I18n::InvalidLocale in GoodJob::JobsController\#mass\_update [\#1641](https://github.com/bensheldon/good_job/issues/1641)
+
+**Merged pull requests:**
+
+- Fix the path for the extended dashboard views in README.md [\#1638](https://github.com/bensheldon/good_job/pull/1638) ([zarembas](https://github.com/zarembas))
+
 ## [v4.10.1](https://github.com/bensheldon/good_job/tree/v4.10.1) (2025-05-20)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v4.10.0...v4.10.1)

data/README.md

@@ -470,8 +470,8 @@ The Dashboard can be set to automatically refresh by checking "Live Poll" in the
 
 GoodJob exposes some views that are intended to be overriden by placing views in your application:
 
-- [`app/views/good_job/jobs/_custom_job_details.html.erb`](app/views/good_job/_custom_job_details.html.erb): content added to this partial will be displayed above the argument list on the good_job/jobs#show page.
-- [`app/views/good_job/jobs/_custom_execution_details.html.erb`](app/views/good_job/_custom_execution_details.html.erb): content added to this partial will be displayed above each execution on the good_job/jobs#show page.
+- [`app/views/good_job/_custom_job_details.html.erb`](app/views/good_job/_custom_job_details.html.erb): content added to this partial will be displayed above the argument list on the good_job/jobs#show page.
+- [`app/views/good_job/_custom_execution_details.html.erb`](app/views/good_job/_custom_execution_details.html.erb): content added to this partial will be displayed above each execution on the good_job/jobs#show page.
 
 **Warning:** these partials expose classes (such as `GoodJob::Job`) that are considered internal implementation details of GoodJob. You should always test your custom partials after upgrading GoodJob.
 

data/app/controllers/good_job/jobs_controller.rb

@@ -38,7 +38,7 @@ module GoodJob
         when :reschedule
           job.reschedule_job
         when :retry
-          job.retry_job
+          use_original_locale { job.retry_job }
         when :destroy
           job.destroy_job
         end
@@ -84,7 +84,7 @@ module GoodJob
 
     def retry
       @job = Job.find(params[:id])
-      @job.retry_job
+      use_original_locale { @job.retry_job }
       redirect_back(fallback_location: jobs_path, notice: t(".notice"))
     end
 

data/lib/good_job/adapter.rb

@@ -173,6 +173,15 @@ module GoodJob
       end
     end
 
+    # Whether the current job execution thread is shutting down.
+    # This is intended to be called from within the context of a performing job.
+    # Jobs can call this while performing via `queue_adapter.stopping?` to support
+    # job continuations/iterations.
+    # @return [Boolean]
+    def stopping?
+      GoodJob.current_thread_shutting_down?
+    end
+
     # Shut down the thread pool executors.
     # @param timeout [nil, Numeric, NONE] Seconds to wait for active threads.
     #   * +nil+ trigger a shutdown but not wait for it to complete.

data/lib/good_job/probe_server/simple_handler.rb

@@ -33,7 +33,7 @@ module GoodJob
         start_server
         handle_connections if @running.true?
       rescue StandardError => e
-        @logger.error "Server encountered an error: #{e}"
+        @logger.error "Server encountered an error: #{e.class} - #{e}"
       ensure
         stop
       end
@@ -60,8 +60,14 @@ module GoodJob
             end
 
             client.close
-          rescue IO::WaitReadable, Errno::EINTR, Errno::EPIPE
-            retry
+          rescue IO::WaitReadable, Errno::EINTR
+            retry # on transient errors
+          rescue Errno::EPIPE
+            next # Client disconnected - continue
+          rescue Errno::EBADF
+            break if @server&.closed? # Server shut down - stop
+
+            raise
           end
         end
       end

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '4.10.1'
+  VERSION = '4.11.0'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 4.10.1
+  version: 4.11.0
 platform: ruby
 authors:
 - Ben Sheldon
 bindir: exe
 cert_chain: []
-date: 1980-01-02 00:00:00.000000000 Z
+date: 2025-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -240,9 +240,9 @@ executables:
 - good_job
 extensions: []
 extra_rdoc_files:
+- README.md
 - CHANGELOG.md
 - LICENSE.txt
-- README.md
 files:
 - CHANGELOG.md
 - LICENSE.txt
@@ -421,7 +421,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.8
+rubygems_version: 3.6.2
 specification_version: 4
 summary: A multithreaded, Postgres-based ActiveJob backend for Ruby on Rails
 test_files: []