good_job 4.1.0 → 4.2.0

data/app/models/good_job/job.rb

@@ -2,7 +2,23 @@
 
 module GoodJob
   # Active Record model that represents an +ActiveJob+ job.
-  class Job < BaseExecution
+  class Job < BaseRecord
+    include AdvisoryLockable
+    include ErrorEvents
+    include Filterable
+    include Reportable
+
+    # Raised if something attempts to execute a previously completed Execution again.
+    PreviouslyPerformedError = Class.new(StandardError)
+
+    # String separating Error Class from Error Message
+    ERROR_MESSAGE_SEPARATOR = ": "
+
+    # ActiveJob jobs without a +queue_name+ attribute are placed on this queue.
+    DEFAULT_QUEUE_NAME = 'default'
+    # ActiveJob jobs without a +priority+ attribute are given this priority.
+    DEFAULT_PRIORITY = 0
+
     # Raised when an inappropriate action is applied to a Job based on its state.
     ActionForStateMismatchError = Class.new(StandardError)
     # Raised when GoodJob is not configured as the Active Job Queue Adapter
@@ -15,12 +31,17 @@ module GoodJob
     self.table_name = 'good_jobs'
     self.advisory_lockable_column = 'id'
     self.implicit_order_column = 'created_at'
+    self.ignored_columns += %w[is_discrete retried_good_job_id]
+
+    define_model_callbacks :perform
+    define_model_callbacks :perform_unlocked, only: :after
+
+    set_callback :perform, :around, :reset_batch_values
+    set_callback :perform_unlocked, :after, :continue_discard_or_finish_batch
 
     belongs_to :batch, class_name: 'GoodJob::BatchRecord', inverse_of: :jobs, optional: true
     belongs_to :locked_by_process, class_name: "GoodJob::Process", foreign_key: :locked_by_id, inverse_of: :locked_jobs, optional: true
-    has_many :executions, -> { order(created_at: :asc) }, class_name: 'GoodJob::Execution', foreign_key: 'active_job_id', primary_key: :active_job_id, inverse_of: :job, dependent: :delete_all
-    # TODO: rename callers of discrete_execution to executions, but after v4 has some time to bake for cleaner diffs/patches
-    has_many :discrete_executions, -> { order(created_at: :asc) }, class_name: 'GoodJob::Execution', foreign_key: 'active_job_id', primary_key: :active_job_id, inverse_of: :job, dependent: :delete_all
+    has_many :executions, class_name: 'GoodJob::Execution', foreign_key: 'active_job_id', primary_key: "id", inverse_of: :job, dependent: :delete_all
 
     before_create -> { self.id = active_job_id }, if: -> { active_job_id.present? }
 
@@ -36,16 +57,328 @@ module GoodJob
     # Execution errored, will run in the future
     scope :retried, -> { where(finished_at: nil).where(coalesce_scheduled_at_created_at.gt(bind_value('coalesce', Time.current, ActiveRecord::Type::DateTime))).where(params_execution_count.gt(1)) }
     # Immediate/Scheduled time to run has passed, waiting for an available thread run
-    scope :queued, -> { where(finished_at: nil).where(coalesce_scheduled_at_created_at.lteq(bind_value('coalesce', Time.current, ActiveRecord::Type::DateTime))).joins_advisory_locks.where(pg_locks: { locktype: nil }) }
+    scope :queued, -> { where(performed_at: nil, finished_at: nil).where(coalesce_scheduled_at_created_at.lteq(bind_value('coalesce', Time.current, ActiveRecord::Type::DateTime))) }
     # Advisory locked and executing
-    scope :running, -> { where(finished_at: nil).joins_advisory_locks.where.not(pg_locks: { locktype: nil }) }
+    scope :running, -> { where.not(performed_at: nil).where(finished_at: nil) }
     # Finished executing (succeeded or discarded)
-    scope :finished, -> { where.not(finished_at: nil).where(retried_good_job_id: nil) }
+    scope :finished, -> { where.not(finished_at: nil) }
     # Completed executing successfully
     scope :succeeded, -> { finished.where(error: nil) }
     # Errored but will not be retried
     scope :discarded, -> { finished.where.not(error: nil) }
 
+    # With a given class name
+    # @!method job_class(name)
+    # @!scope class
+    # @param name [String] Job class name
+    # @return [ActiveRecord::Relation]
+    scope :job_class, ->(name) { where(params_job_class.eq(name)) }
+
+    # Get jobs with given ActiveJob ID
+    # @!method active_job_id(active_job_id)
+    # @!scope class
+    # @param active_job_id [String]
+    #   ActiveJob ID
+    # @return [ActiveRecord::Relation]
+    scope :active_job_id, ->(active_job_id) { where(active_job_id: active_job_id) }
+
+    # Get jobs that have not yet finished (succeeded or discarded).
+    # @!method unfinished
+    # @!scope class
+    # @return [ActiveRecord::Relation]
+    scope :unfinished, -> { where(finished_at: nil) }
+
+    # Get jobs that are not scheduled for a later time than now (i.e. jobs that
+    # are not scheduled or scheduled for earlier than the current time).
+    # @!method only_scheduled
+    # @!scope class
+    # @return [ActiveRecord::Relation]
+    scope :only_scheduled, -> { where(arel_table['scheduled_at'].lteq(bind_value('scheduled_at', DateTime.current, ActiveRecord::Type::DateTime))).or(where(scheduled_at: nil)) }
+
+    # Order jobs by priority (highest priority first).
+    # @!method priority_ordered
+    # @!scope class
+    # @return [ActiveRecord::Relation]
+    scope :priority_ordered, -> { order('priority ASC NULLS LAST') }
+
+    # Order jobs by created_at, for first-in first-out
+    # @!method creation_ordered
+    # @!scope class
+    # @return [ActiveRecord:Relation]
+    scope :creation_ordered, -> { order(created_at: :asc) }
+
+    # Order jobs for de-queueing
+    # @!method dequeueing_ordered(parsed_queues)
+    # @!scope class
+    # @param parsed_queues [Hash]
+    #   optional output of .queue_parser, parsed queues, will be used for
+    #   ordered queues.
+    # @return [ActiveRecord::Relation]
+    scope :dequeueing_ordered, (lambda do |parsed_queues|
+      relation = self
+      relation = relation.queue_ordered(parsed_queues[:include]) if parsed_queues && parsed_queues[:ordered_queues] && parsed_queues[:include]
+      relation = relation.priority_ordered.creation_ordered
+
+      relation
+    end)
+
+    # Order jobs in order of queues in array param
+    # @!method queue_ordered(queues)
+    # @!scope class
+    # @param queues [Array<string] ordered names of queues
+    # @return [ActiveRecord::Relation]
+    scope :queue_ordered, (lambda do |queues|
+      clauses = queues.map.with_index do |queue_name, index|
+        sanitize_sql_array(["WHEN queue_name = ? THEN ?", queue_name, index])
+      end
+      order(Arel.sql("(CASE #{clauses.join(' ')} ELSE #{queues.size} END)"))
+    end)
+
+    # Order jobs by scheduled or created (oldest first).
+    # @!method schedule_ordered
+    # @!scope class
+    # @return [ActiveRecord::Relation]
+    scope :schedule_ordered, -> { order(coalesce_scheduled_at_created_at.asc) }
+
+    # Get Jobs on queues that match the given queue string.
+    # @!method queue_string(string)
+    # @!scope class
+    # @param string [String]
+    #   A string expression describing what queues to select. See
+    #   {Job.queue_parser} or
+    #   {file:README.md#optimize-queues-threads-and-processes} for more details
+    #   on the format of the string. Note this only handles individual
+    #   semicolon-separated segments of that string format.
+    # @return [ActiveRecord::Relation]
+    scope :queue_string, (lambda do |string|
+      parsed = queue_parser(string)
+
+      if parsed[:all]
+        all
+      elsif parsed[:exclude]
+        where.not(queue_name: parsed[:exclude]).or where(queue_name: nil)
+      elsif parsed[:include]
+        where(queue_name: parsed[:include])
+      end
+    end)
+
+    class << self
+      # Parse a string representing a group of queues into a more readable data
+      # structure.
+      # @param string [String] Queue string
+      # @return [Hash]
+      #   How to match a given queue. It can have the following keys and values:
+      #   - +{ all: true }+ indicates that all queues match.
+      #   - +{ exclude: Array<String> }+ indicates the listed queue names should
+      #     not match.
+      #   - +{ include: Array<String> }+ indicates the listed queue names should
+      #     match.
+      #   - +{ include: Array<String>, ordered_queues: true }+ indicates the listed
+      #     queue names should match, and dequeue should respect queue order.
+      # @example
+      #   GoodJob::Execution.queue_parser('-queue1,queue2')
+      #   => { exclude: [ 'queue1', 'queue2' ] }
+      def queue_parser(string)
+        string = string.strip.presence || '*'
+
+        case string.first
+        when '-'
+          exclude_queues = true
+          string = string[1..]
+        when '+'
+          ordered_queues = true
+          string = string[1..]
+        end
+
+        queues = string.split(',').map(&:strip)
+
+        if queues.include?('*')
+          { all: true }
+        elsif exclude_queues
+          { exclude: queues }
+        elsif ordered_queues
+          {
+            include: queues,
+            ordered_queues: true,
+          }
+        else
+          { include: queues }
+        end
+      end
+
+      def json_string(json, attr)
+        Arel::Nodes::Grouping.new(Arel::Nodes::InfixOperation.new('->>', json, Arel::Nodes.build_quoted(attr)))
+      end
+
+      def params_job_class
+        json_string(arel_table['serialized_params'], 'job_class')
+      end
+
+      def params_execution_count
+        Arel::Nodes::InfixOperation.new(
+          '::',
+          json_string(arel_table['serialized_params'], 'executions'),
+          Arel.sql('integer')
+        )
+      end
+
+      def coalesce_scheduled_at_created_at
+        arel_table.coalesce(arel_table['scheduled_at'], arel_table['created_at'])
+      end
+    end
+
+    def self.build_for_enqueue(active_job, scheduled_at: nil)
+      new(**enqueue_args(active_job, scheduled_at: scheduled_at))
+    end
+
+    # Construct arguments for GoodJob::Execution from an ActiveJob instance.
+    def self.enqueue_args(active_job, scheduled_at: nil)
+      execution_args = {
+        id: active_job.job_id,
+        active_job_id: active_job.job_id,
+        job_class: active_job.class.name,
+        queue_name: active_job.queue_name.presence || DEFAULT_QUEUE_NAME,
+        priority: active_job.priority || DEFAULT_PRIORITY,
+        serialized_params: active_job.serialize,
+        created_at: Time.current,
+      }
+
+      execution_args[:scheduled_at] = if scheduled_at
+                                        scheduled_at
+                                      elsif active_job.scheduled_at
+                                        Time.zone.at(active_job.scheduled_at)
+                                      else
+                                        execution_args[:created_at]
+                                      end
+
+      execution_args[:concurrency_key] = active_job.good_job_concurrency_key if active_job.respond_to?(:good_job_concurrency_key)
+
+      if active_job.respond_to?(:good_job_labels) && active_job.good_job_labels.any?
+        labels = active_job.good_job_labels.dup
+        labels.map! { |label| label.to_s.strip.presence }
+        labels.tap(&:compact!).tap(&:uniq!)
+        execution_args[:labels] = labels
+      end
+
+      reenqueued_current_job = CurrentThread.active_job_id && CurrentThread.active_job_id == active_job.job_id
+      current_job = CurrentThread.job
+
+      if reenqueued_current_job
+        execution_args[:batch_id] = current_job.batch_id
+        execution_args[:batch_callback_id] = current_job.batch_callback_id
+        execution_args[:cron_key] = current_job.cron_key
+      else
+        execution_args[:batch_id] = GoodJob::Batch.current_batch_id
+        execution_args[:batch_callback_id] = GoodJob::Batch.current_batch_callback_id
+        execution_args[:cron_key] = CurrentThread.cron_key
+        execution_args[:cron_at] = CurrentThread.cron_at
+      end
+
+      execution_args
+    end
+
+    # Finds the next eligible Execution, acquire an advisory lock related to it, and
+    # executes the job.
+    # @yield [Execution, nil] The next eligible Execution, or +nil+ if none found, before it is performed.
+    # @return [ExecutionResult, nil]
+    #   If a job was executed, returns an array with the {Execution} record, the
+    #   return value for the job's +#perform+ method, and the exception the job
+    #   raised, if any (if the job raised, then the second array entry will be
+    #   +nil+). If there were no jobs to execute, returns +nil+.
+    def self.perform_with_advisory_lock(lock_id:, parsed_queues: nil, queue_select_limit: nil)
+      job = nil
+      result = nil
+
+      unfinished.dequeueing_ordered(parsed_queues).only_scheduled.limit(1).with_advisory_lock(select_limit: queue_select_limit) do |jobs|
+        job = jobs.first
+
+        if job&.executable?
+          yield(job) if block_given?
+
+          result = job.perform(lock_id: lock_id)
+        else
+          job = nil
+          yield(nil) if block_given?
+        end
+      end
+
+      job&.run_callbacks(:perform_unlocked)
+      result
+    end
+
+    # Fetches the scheduled execution time of the next eligible Execution(s).
+    # @param after [DateTime]
+    # @param limit [Integer]
+    # @param now_limit [Integer, nil]
+    # @return [Array<DateTime>]
+    def self.next_scheduled_at(after: nil, limit: 100, now_limit: nil)
+      query = advisory_unlocked.unfinished.schedule_ordered
+
+      after ||= Time.current
+      after_bind = bind_value('scheduled_at', after, ActiveRecord::Type::DateTime)
+      after_query = query.where(arel_table['scheduled_at'].gt(after_bind)).or query.where(scheduled_at: nil).where(arel_table['created_at'].gt(after_bind))
+      after_at = after_query.limit(limit).pluck(:scheduled_at, :created_at).map { |timestamps| timestamps.compact.first }
+
+      if now_limit&.positive?
+        now_query = query.where(arel_table['scheduled_at'].lt(bind_value('scheduled_at', Time.current, ActiveRecord::Type::DateTime))).or query.where(scheduled_at: nil)
+        now_at = now_query.limit(now_limit).pluck(:scheduled_at, :created_at).map { |timestamps| timestamps.compact.first }
+      end
+
+      Array(now_at) + after_at
+    end
+
+    # Places an ActiveJob job on a queue by creating a new {Execution} record.
+    # @param active_job [ActiveJob::Base]
+    #   The job to enqueue.
+    # @param scheduled_at [Float]
+    #   Epoch timestamp when the job should be executed, if blank will delegate to the ActiveJob instance
+    # @param create_with_advisory_lock [Boolean]
+    #   Whether to establish a lock on the {Execution} record after it is created.
+    # @return [Execution]
+    #   The new {Execution} instance representing the queued ActiveJob job.
+    def self.enqueue(active_job, scheduled_at: nil, create_with_advisory_lock: false)
+      ActiveSupport::Notifications.instrument("enqueue_job.good_job", { active_job: active_job, scheduled_at: scheduled_at, create_with_advisory_lock: create_with_advisory_lock }) do |instrument_payload|
+        current_job = CurrentThread.job
+
+        retried = current_job && current_job.active_job_id == active_job.job_id
+        if retried
+          job = current_job
+          job.assign_attributes(enqueue_args(active_job, scheduled_at: scheduled_at))
+          job.scheduled_at ||= Time.current
+          # TODO: these values ideally shouldn't be persisted until the current_job is finished
+          #   which will require handling `retry_job` being called from outside the job context.
+          job.performed_at = nil
+          job.finished_at = nil
+        else
+          job = build_for_enqueue(active_job, scheduled_at: scheduled_at)
+        end
+
+        if create_with_advisory_lock
+          if job.persisted?
+            job.advisory_lock
+          else
+            job.create_with_advisory_lock = true
+          end
+        end
+
+        instrument_payload[:job] = job
+        job.save!
+
+        CurrentThread.retried_job = job if retried
+
+        active_job.provider_job_id = job.id
+        raise "These should be equal" if active_job.provider_job_id != active_job.job_id
+
+        job
+      end
+    end
+
+    def self.format_error(error)
+      raise ArgumentError unless error.is_a?(Exception)
+
+      [error.class.to_s, ERROR_MESSAGE_SEPARATOR, error.message].join
+    end
+
     # TODO: it would be nice to enforce these values at the model
     # validates :active_job_id, presence: true
     # validates :scheduled_at, presence: true
@@ -101,7 +434,7 @@ module GoodJob
     # Tests whether the job has finished (succeeded or discarded).
     # @return [Boolean]
     def finished?
-      finished_at.present? && retried_good_job_id.nil?
+      finished_at.present?
     end
 
     # Tests whether the job has finished but with an error.
@@ -193,10 +526,191 @@ module GoodJob
       end
     end
 
-    # Utility method to determine which execution record is used to represent this job
-    # @return [String]
-    def _execution_id
-      attributes['id']
+    # Build an ActiveJob instance and deserialize the arguments, using `#active_job_data`.
+    #
+    # @param ignore_deserialization_errors [Boolean]
+    #   Whether to ignore ActiveJob::DeserializationError and NameError when deserializing the arguments.
+    #   This is most useful if you aren't planning to use the arguments directly.
+    def active_job(ignore_deserialization_errors: false)
+      ActiveJob::Base.deserialize(active_job_data).tap do |aj|
+        aj.send(:deserialize_arguments_if_needed)
+      rescue ActiveJob::DeserializationError
+        raise unless ignore_deserialization_errors
+      end
+    rescue NameError
+      raise unless ignore_deserialization_errors
+    end
+
+    # Execute the ActiveJob job this {Execution} represents.
+    # @return [ExecutionResult]
+    #   An array of the return value of the job's +#perform+ method and the
+    #   exception raised by the job, if any. If the job completed successfully,
+    #   the second array entry (the exception) will be +nil+ and vice versa.
+    def perform(lock_id:)
+      run_callbacks(:perform) do
+        raise PreviouslyPerformedError, 'Cannot perform a job that has already been performed' if finished_at
+
+        job_performed_at = Time.current
+        monotonic_start = ::Process.clock_gettime(::Process::CLOCK_MONOTONIC)
+        execution = nil
+        result = GoodJob::CurrentThread.within do |current_thread|
+          current_thread.reset
+          current_thread.job = self
+
+          existing_performed_at = performed_at
+          if existing_performed_at
+            current_thread.execution_interrupted = existing_performed_at
+
+            interrupt_error_string = self.class.format_error(GoodJob::InterruptError.new("Interrupted after starting perform at '#{existing_performed_at}'"))
+            self.error = interrupt_error_string
+            self.error_event = :interrupted
+            monotonic_duration = (::Process.clock_gettime(::Process::CLOCK_MONOTONIC) - monotonic_start).seconds
+
+            execution_attrs = {
+              error: interrupt_error_string,
+              finished_at: job_performed_at,
+              error_event: :interrupted,
+              duration: monotonic_duration,
+            }
+            executions.where(finished_at: nil).where.not(performed_at: nil).update_all(execution_attrs) # rubocop:disable Rails/SkipsModelValidations
+          end
+
+          transaction do
+            execution_attrs = {
+              job_class: job_class,
+              queue_name: queue_name,
+              serialized_params: serialized_params,
+              scheduled_at: scheduled_at || created_at,
+              created_at: job_performed_at,
+              process_id: lock_id,
+            }
+            job_attrs = {
+              performed_at: job_performed_at,
+              executions_count: ((executions_count || 0) + 1),
+              locked_by_id: lock_id,
+              locked_at: Time.current,
+            }
+
+            execution = executions.create!(execution_attrs)
+            update!(job_attrs)
+          end
+
+          ActiveSupport::Notifications.instrument("perform_job.good_job", { job: self, execution: execution, process_id: current_thread.process_id, thread_name: current_thread.thread_name }) do |instrument_payload|
+            value = ActiveJob::Base.execute(active_job_data)
+
+            if value.is_a?(Exception)
+              handled_error = value
+              value = nil
+            end
+            handled_error ||= current_thread.error_on_retry || current_thread.error_on_discard
+
+            error_event = if handled_error == current_thread.error_on_discard
+                            :discarded
+                          elsif handled_error == current_thread.error_on_retry
+                            :retried
+                          elsif handled_error == current_thread.error_on_retry_stopped
+                            :retry_stopped
+                          elsif handled_error
+                            :handled
+                          end
+
+            instrument_payload.merge!(
+              value: value,
+              handled_error: handled_error,
+              retried: current_thread.retried_job.present?,
+              error_event: error_event
+            )
+            ExecutionResult.new(value: value, handled_error: handled_error, error_event: error_event, retried_job: current_thread.retried_job)
+          rescue StandardError => e
+            error_event = if e.is_a?(GoodJob::InterruptError)
+                            :interrupted
+                          elsif e == current_thread.error_on_retry_stopped
+                            :retry_stopped
+                          else
+                            :unhandled
+                          end
+
+            instrument_payload[:unhandled_error] = e
+            ExecutionResult.new(value: nil, unhandled_error: e, error_event: error_event)
+          end
+        end
+
+        job_attributes = { locked_by_id: nil, locked_at: nil }
+
+        job_error = result.handled_error || result.unhandled_error
+        if job_error
+          error_string = self.class.format_error(job_error)
+
+          job_attributes[:error] = error_string
+          job_attributes[:error_event] = result.error_event
+
+          execution.error = error_string
+          execution.error_event = result.error_event
+          execution.error_backtrace = job_error.backtrace
+        else
+          job_attributes[:error] = nil
+          job_attributes[:error_event] = nil
+        end
+
+        job_finished_at = Time.current
+        monotonic_duration = (::Process.clock_gettime(::Process::CLOCK_MONOTONIC) - monotonic_start).seconds
+        job_attributes[:finished_at] = job_finished_at
+
+        execution.finished_at = job_finished_at
+        execution.duration = monotonic_duration
+
+        retry_unhandled_error = result.unhandled_error && GoodJob.retry_on_unhandled_error
+        reenqueued = result.retried? || retry_unhandled_error
+        if reenqueued
+          job_attributes[:performed_at] = nil
+          job_attributes[:finished_at] = nil
+        end
+
+        assign_attributes(job_attributes)
+        preserve_unhandled = result.unhandled_error && (GoodJob.retry_on_unhandled_error || GoodJob.preserve_job_records == :on_unhandled_error)
+        if finished_at.blank? || GoodJob.preserve_job_records == true || reenqueued || preserve_unhandled || cron_key.present?
+          transaction do
+            execution.save!
+            save!
+          end
+        else
+          destroy!
+        end
+
+        result
+      end
+    end
+
+    # Tests whether this job is safe to be executed by this thread.
+    # @return [Boolean]
+    def executable?
+      reload.finished_at.blank?
+    rescue ActiveRecord::RecordNotFound
+      false
+    end
+
+    def number
+      serialized_params.fetch('executions', 0) + 1
+    end
+
+    # Time between when this job was expected to run and when it started running
+    def queue_latency
+      now = Time.zone.now
+      expected_start = scheduled_at || created_at
+      actual_start = performed_at || finished_at || now
+
+      actual_start - expected_start unless expected_start >= now
+    end
+
+    # Time between when this job started and finished
+    def runtime_latency
+      (finished_at || Time.zone.now) - performed_at if performed_at
+    end
+
+    def job_state
+      state = { queue_name: queue_name }
+      state[:scheduled_at] = scheduled_at if scheduled_at
+      state
     end
 
     private
@@ -222,6 +736,23 @@ module GoodJob
         update_record.call
       end
     end
+
+    def reset_batch_values(&block)
+      GoodJob::Batch.within_thread(batch_id: nil, batch_callback_id: nil, &block)
+    end
+
+    def continue_discard_or_finish_batch
+      batch._continue_discard_or_finish(self) if batch.present?
+    end
+
+    def active_job_data
+      serialized_params.deep_dup
+                       .tap do |job_data|
+        job_data["provider_job_id"] = id
+        job_data["good_job_concurrency_key"] = concurrency_key if concurrency_key
+        job_data["good_job_labels"] = Array(labels) if labels.present?
+      end
+    end
   end
 end
 

data/app/models/good_job/process.rb

@@ -20,9 +20,9 @@ module GoodJob # :nodoc:
       advisory: 0,
     }
     if Gem::Version.new(Rails.version) >= Gem::Version.new('7.1.0.a')
-      enum :lock_type, lock_type_enum, validate: { allow_nil: true }
+      enum :lock_type, lock_type_enum, validate: { allow_nil: true }, scopes: false
     else
-      enum lock_type: lock_type_enum
+      enum lock_type: lock_type_enum, _scopes: false
     end
 
     has_many :locked_jobs, class_name: "GoodJob::Job", foreign_key: :locked_by_id, inverse_of: :locked_by_process, dependent: nil
@@ -56,7 +56,7 @@ module GoodJob # :nodoc:
       end
     end
 
-    def self.create_record(id:, with_advisory_lock: false)
+    def self.find_or_create_record(id:, with_advisory_lock: false)
       attributes = {
         id: id,
         state: process_state,
@@ -66,6 +66,17 @@ module GoodJob # :nodoc:
         attributes[:lock_type] = :advisory
       end
       create!(attributes)
+    rescue ActiveRecord::RecordNotUnique
+      find_by(id: id).tap do |existing_record|
+        next unless existing_record
+
+        if with_advisory_lock
+          existing_record.advisory_lock!
+          existing_record.update(lock_type: :advisory, state: process_state, updated_at: Time.current)
+        else
+          existing_record.update(lock_type: nil, state: process_state, updated_at: Time.current)
+        end
+      end
     end
 
     def self.process_state

data/app/views/good_job/batches/_jobs.erb

@@ -30,7 +30,7 @@
                 <span class="badge bg-primary text-dark font-monospace"><%= job.queue_name %></span>
               </div>
               <div class="col-4 col-lg-1 text-lg-end">
-                <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.priority" %>Priority</div>
+                <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.job.priority" %></div>
                 <span class="font-monospace fw-bold"><%= job.priority %></span>
               </div>
               <div class="col-4 col-lg-1 text-lg-end">

data/app/views/good_job/batches/_table.erb

@@ -56,9 +56,15 @@
               </div>
               <div class="col-6 col-lg-1">
                 <div class="d-lg-none small text-muted mt-1"><%= t "good_job.models.batch.jobs" %></div>
-                <%= batch.jobs.count %>
+                <%= batch.jobs.size %>
               </div>
               <div class="col text-end">
+                <% if batch.discarded? %>
+                  <%= link_to retry_batch_path(batch), method: :put, class: "btn btn-sm btn-outline-primary", title: t("good_job.batches.actions.retry"), data: { confirm: t("good_job.batches.actions.confirm_retry") } do %>
+                    <%= render_icon "arrow_clockwise" %>
+                    <%= t "good_job.batches.actions.retry" %>
+                  <% end %>
+                <% end %>
                 <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
                                title: t("good_job.actions.inspect"),
                                data: { bs_toggle: "collapse", bs_target: "##{dom_id(batch, 'properties')}" },

data/app/views/good_job/batches/show.html.erb

@@ -10,6 +10,14 @@
           <h2 class="h5 mt-2"><%= @batch.description %></h2>
         </nav>
       </div>
+      <div class="col text-end">
+        <% if @batch.discarded? %>
+          <%= button_to retry_batch_path(@batch), method: :put, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: t("good_job.batches.actions.retry") }, title: t("good_job.batches.actions.retry"), data: { confirm: t("good_job.batches.actions.confirm_retry") } do %>
+            <%= render_icon "arrow_clockwise" %>
+            <%= t "good_job.actions.retry" %>
+          <% end %>
+        <% end %>
+      </div>
     </div>
   </div>
 </div>