good_job 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a4006c920a731f763e36a964e7eb161a292e8a4b34bffa4b60b95b75145c28c
-  data.tar.gz: f54b107db6ac1e2304a4ee9e2d34fa65032dc2b1ab0425e0be5ea42d39e5590b
+  metadata.gz: 5725006ff1eae761677d25b8f89d55903532b80c6850a8a58ad6506823316763
+  data.tar.gz: fe91ce725bd86202334c86c308443a3c5e5b0c71b680be4d5086b87b0349fe8a
 SHA512:
-  metadata.gz: 4474aaa0540dc5ff1bba65e8807a6fa69a9901f2e68051c57cf954e30270e9e6d7eaf52a3ce8ec7de6f48b16fc60fa05e796f595f14dfda41a76cbeb5b042543
-  data.tar.gz: cf8103c84fceffe91e4f7b0f5083c3989d2312a17ce96b1db01d7726a99b651c7d850f83fe23075c5a01628a825ef71d335d0eb42e91a478a62dd7772ee95e54
+  metadata.gz: 96ca288be634ed11773a66da6e3cad2f60c6cf8736cd33b41f5ce85681160d3a26e283f63f15914e480b5e8587b257ba95e9baed8f08c08c084c28c961320a29
+  data.tar.gz: d7d6fee108acbfd3743a6520b9f6283bb3cb999a7ce51f87c4d3ae80864d8b0cfe1e34bbb0517c42c8b807145dae315f60f8907bbc601d2aade905b8ff37fa53

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## [v4.0.1](https://github.com/bensheldon/good_job/tree/v4.0.1) (2024-07-08)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v4.0.0...v4.0.1)
+
+**Fixed bugs:**
+
+- Actually change `smaller_number_is_higher_priority` for v4 [\#1402](https://github.com/bensheldon/good_job/pull/1402) ([Earlopain](https://github.com/Earlopain))
+
+**Merged pull requests:**
+
+- Bump prism/rbi dev dependency [\#1403](https://github.com/bensheldon/good_job/pull/1403) ([Earlopain](https://github.com/Earlopain))
+- Use index action for the performance controller [\#1398](https://github.com/bensheldon/good_job/pull/1398) ([Earlopain](https://github.com/Earlopain))
+
 ## [v4.0.0](https://github.com/bensheldon/good_job/tree/v4.0.0) (2024-07-07)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.99.0...v4.0.0)

data/app/controllers/good_job/{performances_controller.rb → performance_controller.rb}

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 module GoodJob
-  class PerformancesController < ApplicationController
-    def show
+  class PerformanceController < ApplicationController
+    def index
       @performances = GoodJob::DiscreteExecution
                       .where.not(job_class: nil)
                       .group(:job_class)

data/app/views/good_job/shared/_navbar.erb

@@ -40,8 +40,8 @@
           <% end %>
         </li>
         <li class="nav-item">
-          <%= link_to performance_path, class: ["nav-link", ("active" if controller_name == 'performances')] do %>
-            <%= t(".performances") %>
+          <%= link_to performance_index_path, class: ["nav-link", ("active" if controller_name == 'performance')] do %>
+            <%= t(".performance") %>
           <% end %>
         </li>
       </ul>

data/config/locales/de.yml

@@ -194,8 +194,8 @@ de:
             thousand: K
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Durchschnittliche Dauer
         executions: Hinrichtungen
         job_class: Berufsklasse
@@ -231,7 +231,7 @@ de:
         jobs: Jobs
         live_poll: Live Poll
         name: "GoodJob 👍"
-        performances: Leistung
+        performance: Leistung
         processes: Prozesse
         theme:
           auto: Auto

data/config/locales/en.yml

@@ -194,8 +194,8 @@ en:
             thousand: K
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Average duration
         executions: Executions
         job_class: Job class
@@ -231,7 +231,7 @@ en:
         jobs: Jobs
         live_poll: Live Poll
         name: "GoodJob 👍"
-        performances: Performance
+        performance: Performance
         processes: Processes
         theme:
           auto: Auto

data/config/locales/es.yml

@@ -194,8 +194,8 @@ es:
             thousand: k
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Duración promedio
         executions: Ejecuciones
         job_class: clase de trabajo
@@ -231,7 +231,7 @@ es:
         jobs: Tareas
         live_poll: En vivo
         name: "GoodJob 👍"
-        performances: Actuación
+        performance: Actuación
         processes: Procesos
         theme:
           auto: Auto

data/config/locales/fr.yml

@@ -194,8 +194,8 @@ fr:
             thousand: k
             trillion: J
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Durée moyenne
         executions: Exécutions
         job_class: Catégorie d'emplois
@@ -231,7 +231,7 @@ fr:
         jobs: Jobs
         live_poll: En direct
         name: "GoodJob 👍"
-        performances: Performance
+        performance: Performance
         processes: Processus
         theme:
           auto: Auto

data/config/locales/it.yml

@@ -194,8 +194,8 @@ it:
             thousand: K
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Durata media
         executions: Esecuzioni
         job_class: Classe di lavoro
@@ -231,7 +231,7 @@ it:
         jobs: Job
         live_poll: Live Poll
         name: "GoodJob 👍"
-        performances: Prestazione
+        performance: Prestazione
         processes: Processi
         theme:
           auto: Auto

data/config/locales/ja.yml

@@ -194,8 +194,8 @@ ja:
             thousand: K
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: 平均所要時間
         executions: 処刑
         job_class: 職種
@@ -231,7 +231,7 @@ ja:
         jobs: ジョブ
         live_poll: リアルタイム更新
         name: "GoodJob 👍"
-        performances: パフォーマンス
+        performance: パフォーマンス
         processes: プロセス
         theme:
           auto: 自動

data/config/locales/ko.yml

@@ -194,8 +194,8 @@ ko:
             thousand: K
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: 평균 지속 시간
         executions: 처형
         job_class: 직업군
@@ -231,7 +231,7 @@ ko:
         jobs: 작업
         live_poll: 실시간 업데이트
         name: "GoodJob 👍"
-        performances: 성능
+        performance: 성능
         processes: 프로세스
         theme:
           auto: 자동

data/config/locales/nl.yml

@@ -194,8 +194,8 @@ nl:
             thousand: K
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Gemiddelde duur
         executions: Executies
         job_class: Functie klasse
@@ -231,7 +231,7 @@ nl:
         jobs: Taken
         live_poll: Live Poll
         name: "GoodJob 👍"
-        performances: Prestatie
+        performance: Prestatie
         processes: Processen
         theme:
           auto: Auto

data/config/locales/pt-BR.yml

@@ -194,8 +194,8 @@ pt-BR:
             thousand: K
             trillion: T
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Duração média
         executions: Execuções
         job_class: Classe de trabalho
@@ -231,7 +231,7 @@ pt-BR:
         jobs: Tarefas
         live_poll: Acompanhamento ao Vivo
         name: "GoodJob 👍"
-        performances: Desempenho
+        performance: Desempenho
         processes: Processos
         theme:
           auto: Automático

data/config/locales/ru.yml

@@ -220,8 +220,8 @@ ru:
             thousand: К
             trillion: Т
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Средняя продолжительность
         executions: Казни
         job_class: Класс работы
@@ -257,7 +257,7 @@ ru:
         jobs: Задания
         live_poll: Обновления в реальном времени
         name: "GoodJob 👍"
-        performances: Производительность
+        performance: Производительность
         processes: Процессы
         theme:
           auto: Авто

data/config/locales/tr.yml

@@ -194,8 +194,8 @@ tr:
             thousand: Bin
             trillion: Trilyon
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Ortalama süre
         executions: İnfazlar
         job_class: İş sınıfı
@@ -231,7 +231,7 @@ tr:
         jobs: İşler
         live_poll: Anlık Güncelleme
         name: "GoodJob 👍"
-        performances: Verim
+        performance: Verim
         processes: Süreçler
         theme:
           auto: Oto

data/config/locales/uk.yml

@@ -220,8 +220,8 @@ uk:
             thousand: Тис
             trillion: Трлн
             unit: ''
-    performances:
-      show:
+    performance:
+      index:
         average_duration: Середня тривалість
         executions: Страти
         job_class: Клас роботи
@@ -257,7 +257,7 @@ uk:
         jobs: Задачі
         live_poll: Живе Опитування
         name: "GoodJob 👍"
-        performances: Продуктивність
+        performance: Продуктивність
         processes: Процеси
         theme:
           auto: Авто

data/config/routes.rb

@@ -31,7 +31,7 @@ GoodJob::Engine.routes.draw do
 
   resources :processes, only: %i[index]
 
-  resource :performance, only: %i[show]
+  resources :performance, only: %i[index]
 
   scope :frontend, controller: :frontends do
     get "modules/:name", action: :module, as: :frontend_module, constraints: { format: 'js' }

data/lib/good_job/configuration.rb

@@ -35,6 +35,8 @@ module GoodJob
     DEFAULT_DASHBOARD_LIVE_POLL_ENABLED = true
     # Default enqueue_after_transaction_commit
     DEFAULT_ENQUEUE_AFTER_TRANSACTION_COMMIT = false
+    # Default smaller_number_is_higher_priority
+    DEFAULT_SMALLER_NUMBER_IS_HIGHER_PRIORITY = true
 
     def self.validate_execution_mode(execution_mode)
       raise ArgumentError, "GoodJob execution mode must be one of #{EXECUTION_MODES.join(', ')}. It was '#{execution_mode}' which is not valid." unless execution_mode.in?(EXECUTION_MODES)
@@ -378,7 +380,9 @@ module GoodJob
     end
 
     def smaller_number_is_higher_priority
-      rails_config[:smaller_number_is_higher_priority]
+      return rails_config[:smaller_number_is_higher_priority] unless rails_config[:smaller_number_is_higher_priority].nil?
+
+      DEFAULT_SMALLER_NUMBER_IS_HIGHER_PRIORITY
     end
 
     def dashboard_default_locale

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '4.0.0'
+  VERSION = '4.0.1'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-07-07 00:00:00.000000000 Z
+date: 2024-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -255,7 +255,7 @@ files:
 - app/controllers/good_job/frontends_controller.rb
 - app/controllers/good_job/jobs_controller.rb
 - app/controllers/good_job/metrics_controller.rb
-- app/controllers/good_job/performances_controller.rb
+- app/controllers/good_job/performance_controller.rb
 - app/controllers/good_job/processes_controller.rb
 - app/filters/good_job/base_filter.rb
 - app/filters/good_job/batches_filter.rb
@@ -307,7 +307,7 @@ files:
 - app/views/good_job/jobs/_table.erb
 - app/views/good_job/jobs/index.html.erb
 - app/views/good_job/jobs/show.html.erb
-- app/views/good_job/performances/show.html.erb
+- app/views/good_job/performance/index.html.erb
 - app/views/good_job/processes/index.html.erb
 - app/views/good_job/shared/_alert.erb
 - app/views/good_job/shared/_chart.erb