good_job 3.7.1 → 3.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 79ee8980f9408a7e530f6dbc4037f742033e3dbe9919442f08e854314730ef31
-  data.tar.gz: bf17a0b7e1fe8cb4d4f7bdfd20b333e2f9e1ce67504e34a9195e1e0921827284
+  metadata.gz: 98b02fbefa1bdf43b80628d2995e19295c7051f6ed8d8367c2ddb511fef90aeb
+  data.tar.gz: 92b755dd24a410c0785320c0ca891d4809a286737d46160fc425e3ef8eb42e3c
 SHA512:
-  metadata.gz: 955afa8f3f3a224afb58824525a1b230abecbdbfd395e4e31a8dad5498fb32618c77d1e3c70a1503a3228c8e8ea3bdfdb4dccb9238ff0554ad43005e325a64c5
-  data.tar.gz: '029ba620af1d42c78b5b0d61524ac5338f501383b7ed166ff559cff4f0505a81485bef07b8aa04179ab17ab9fa6fca96a84b2a61694e7da18832b365fde8e1a1'
+  metadata.gz: d790addce3a69b2977ce8ab18cd97a2b5ea8f12aade94bead97ff08722ce6245767636450a35dfa76678a0d6f03ddd9a89aa363f338e95d8a45cba05286a9475
+  data.tar.gz: 6c2c63b2aa72b82ef661c4b0edbfd8346d0c30a2a3caac614761686daad00e7dbff1279e2835576615f511e24f14a343521d0300cf90ae16ef4d65d6b6d7b979

data/CHANGELOG.md

@@ -1,5 +1,43 @@
 # Changelog
 
+## [v3.7.3](https://github.com/bensheldon/good_job/tree/v3.7.3) (2023-01-09)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.7.2...v3.7.3)
+
+**Implemented enhancements:**
+
+- Provide clearer values/deprecation notices for `cleanup_interval_jobs` and `cleanup_interval_seconds`; setting `0` disables, `-1` always [\#776](https://github.com/bensheldon/good_job/pull/776) ([zarqman](https://github.com/zarqman))
+
+**Closed issues:**
+
+- Demo page shows Application Error [\#787](https://github.com/bensheldon/good_job/issues/787)
+- Configuration for PG Schema Other Than Public [\#774](https://github.com/bensheldon/good_job/issues/774)
+
+**Merged pull requests:**
+
+- Avoid including unnecessary pg\_locks references when counting jobs [\#789](https://github.com/bensheldon/good_job/pull/789) ([mkrfowler](https://github.com/mkrfowler))
+- Add net-\* gems to Gemfile for Heroku [\#788](https://github.com/bensheldon/good_job/pull/788) ([bensheldon](https://github.com/bensheldon))
+- Add Ruby 3.2 to test matrix [\#786](https://github.com/bensheldon/good_job/pull/786) ([bensheldon](https://github.com/bensheldon))
+- Bump rubocop from 1.41.1 to 1.42.0 [\#781](https://github.com/bensheldon/good_job/pull/781) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Bump rubocop from 1.40.0 to 1.41.1 [\#779](https://github.com/bensheldon/good_job/pull/779) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Bump rubocop-performance from 1.15.1 to 1.15.2 [\#777](https://github.com/bensheldon/good_job/pull/777) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Bump rubocop-rspec from 2.15.0 to 2.16.0 [\#775](https://github.com/bensheldon/good_job/pull/775) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Bump rails-html-sanitizer from 1.4.3 to 1.4.4 [\#773](https://github.com/bensheldon/good_job/pull/773) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Bump loofah from 2.19.0 to 2.19.1 [\#772](https://github.com/bensheldon/good_job/pull/772) ([dependabot[bot]](https://github.com/apps/dependabot))
+
+## [v3.7.2](https://github.com/bensheldon/good_job/tree/v3.7.2) (2022-12-12)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.7.1...v3.7.2)
+
+**Closed issues:**
+
+- Unable to discard failed jobs which crashed with `ActiveJob::DeserializationError` [\#770](https://github.com/bensheldon/good_job/issues/770)
+
+**Merged pull requests:**
+
+- Ignore ActiveJob::DeserializationError when discarding jobs [\#771](https://github.com/bensheldon/good_job/pull/771) ([nickcampbell18](https://github.com/nickcampbell18))
+- Bump rubocop from 1.39.0 to 1.40.0 [\#769](https://github.com/bensheldon/good_job/pull/769) ([dependabot[bot]](https://github.com/apps/dependabot))
+
 ## [v3.7.1](https://github.com/bensheldon/good_job/tree/v3.7.1) (2022-12-12)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.7.0...v3.7.1)

data/README.md

@@ -273,8 +273,8 @@ Available configuration options are:
 - `cron` (hash) cron configuration. Defaults to `{}`. You can also set this as a JSON string with the environment variable `GOOD_JOB_CRON`
 - `cleanup_discarded_jobs` (boolean) whether to destroy discarded jobs when cleaning up preserved jobs using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `true`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_DISCARDED_JOBS`. _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
 - `cleanup_preserved_jobs_before_seconds_ago` (integer) number of seconds to preserve jobs when using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `1209600` (14 days). Can also be set with  the environment variable `GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO`.  _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
-- `cleanup_interval_jobs` (integer) Number of jobs a Scheduler will execute before cleaning up preserved jobs. Defaults to `1000`. Disable with `nil`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_JOBS`.
-- `cleanup_interval_seconds` (integer) Number of seconds a Scheduler will wait before cleaning up preserved jobs. Defaults to `600` (10 minutes). Disable with `nil`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_SECONDS`.
+- `cleanup_interval_jobs` (integer) Number of jobs a Scheduler will execute before cleaning up preserved jobs. Defaults to `1000`. Disable with `false`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_JOBS` and disabled with `0`).
+- `cleanup_interval_seconds` (integer) Number of seconds a Scheduler will wait before cleaning up preserved jobs. Defaults to `600` (10 minutes). Disable with `false`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_SECONDS` and disabled with `0`).
 - `inline_execution_respects_schedule` (boolean) Opt-in to future behavior of inline execution respecting scheduled jobs. Defaults to `false`.
 - `logger` ([Rails Logger](https://api.rubyonrails.org/classes/ActiveSupport/Logger.html)) lets you set a custom logger for GoodJob. It should be an instance of a Rails `Logger` (Default: `Rails.logger`).
 - `preserve_job_records` (boolean) keeps job records in your database even after jobs are completed. (Default: `true`)

data/app/filters/good_job/base_filter.rb

@@ -14,7 +14,7 @@ module GoodJob
     def records
       after_scheduled_at = params[:after_scheduled_at].present? ? Time.zone.parse(params[:after_scheduled_at]) : nil
 
-      filtered_query.display_all(
+      query_for_records.display_all(
         after_scheduled_at: after_scheduled_at,
         after_id: params[:after_id]
       ).limit(params.fetch(:limit, DEFAULT_LIMIT))
@@ -62,6 +62,10 @@ module GoodJob
 
     private
 
+    def query_for_records
+      raise NotImplementedError
+    end
+
     def default_base_query
       raise NotImplementedError
     end

data/app/filters/good_job/jobs_filter.rb

@@ -2,7 +2,7 @@
 module GoodJob
   class JobsFilter < BaseFilter
     def states
-      query = filtered_query(params.except(:state)).unscope(:select)
+      query = filtered_query(params.except(:state))
       {
         'scheduled' =>  query.scheduled.count,
         'retried' => query.retried.count,
@@ -14,7 +14,7 @@ module GoodJob
     end
 
     def filtered_query(filter_params = params)
-      query = base_query.includes(:executions).includes_advisory_locks
+      query = base_query
 
       query = query.job_class(filter_params[:job_class]) if filter_params[:job_class].present?
       query = query.where(queue_name: filter_params[:queue_name]) if filter_params[:queue_name].present?
@@ -47,6 +47,10 @@ module GoodJob
 
     private
 
+    def query_for_records
+      filtered_query.includes(:executions).includes_advisory_locks
+    end
+
     def default_base_query
       GoodJob::Job.all
     end

data/app/models/good_job/execution.rb

@@ -316,9 +316,16 @@ module GoodJob
       self.class.unscoped.unfinished.owns_advisory_locked.exists?(id: id)
     end
 
-    def active_job
+    # Build an ActiveJob instance and deserialize the arguments, using `#active_job_data`.
+    #
+    # @param ignore_deserialization_errors [Boolean]
+    #   Whether to ignore ActiveJob::DeserializationError when deserializing the arguments.
+    #   This is most useful if you aren't planning to use the arguments directly.
+    def active_job(ignore_deserialization_errors: false)
       ActiveJob::Base.deserialize(active_job_data).tap do |aj|
         aj.send(:deserialize_arguments_if_needed)
+      rescue ActiveJob::DeserializationError
+        raise unless ignore_deserialization_errors
       end
     end
 

data/app/models/good_job/job.rb

@@ -206,7 +206,7 @@ module GoodJob
     def discard_job(message)
       with_advisory_lock do
         execution = head_execution(reload: true)
-        active_job = execution.active_job
+        active_job = execution.active_job(ignore_deserialization_errors: true)
 
         raise ActionForStateMismatchError if execution.finished_at.present?
 

data/lib/good_job/cleanup_tracker.rb

@@ -7,7 +7,9 @@ module GoodJob # :nodoc:
                   :job_count,
                   :last_at
 
-    def initialize(cleanup_interval_seconds: nil, cleanup_interval_jobs: nil)
+    def initialize(cleanup_interval_seconds: false, cleanup_interval_jobs: false)
+      raise ArgumentError, "Do not use `0`. Use `false` to disable, or -1 to always run" if cleanup_interval_seconds == 0 || cleanup_interval_jobs == 0 # rubocop:disable Style/NumericPredicate
+
       self.cleanup_interval_seconds = cleanup_interval_seconds
       self.cleanup_interval_jobs = cleanup_interval_jobs
 

data/lib/good_job/configuration.rb

@@ -242,29 +242,72 @@ module GoodJob
     end
 
     # Number of jobs a {Scheduler} will execute before automatically cleaning up preserved jobs.
+    # Positive values will clean up after that many jobs have run, false or 0 will disable, and -1 will clean up after every job.
     # @return [Integer, nil]
     def cleanup_interval_jobs
-      value = if rails_config.key?(:cleanup_interval_jobs)
-                rails_config[:cleanup_interval_jobs]
-              elsif env.key?('GOOD_JOB_CLEANUP_INTERVAL_JOBS')
-                env['GOOD_JOB_CLEANUP_INTERVAL_JOBS']
-              else
-                DEFAULT_CLEANUP_INTERVAL_JOBS
-              end
-      value.present? ? value.to_i : nil
+      if rails_config.key?(:cleanup_interval_jobs)
+        value = rails_config[:cleanup_interval_jobs]
+        if value.nil?
+          ActiveSupport::Deprecation.warn(
+            %(Setting `config.good_job.cleanup_interval_jobs` to `nil` will no longer disable count-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
+          )
+          value = false
+        elsif value == 0 # rubocop:disable Style/NumericPredicate
+          ActiveSupport::Deprecation.warn(
+            %(Setting `config.good_job.cleanup_interval_jobs` to `0` will disable count-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
+          )
+          value = -1
+        end
+      elsif env.key?('GOOD_JOB_CLEANUP_INTERVAL_JOBS')
+        value = env['GOOD_JOB_CLEANUP_INTERVAL_JOBS']
+        if value.blank?
+          ActiveSupport::Deprecation.warn(
+            %(Setting `GOOD_JOB_CLEANUP_INTERVAL_JOBS` to `""` will no longer disable count-based cleanups in GoodJob v4. Set to `0` to disable, or `-1` to run every time.)
+          )
+          value = false
+        elsif value == '0'
+          value = false
+        end
+      else
+        value = DEFAULT_CLEANUP_INTERVAL_JOBS
+      end
+
+      value ? value.to_i : false
     end
 
     # Number of seconds a {Scheduler} will wait before automatically cleaning up preserved jobs.
+    # Positive values will clean up after that many jobs have run, false or 0 will disable, and -1 will clean up after every job.
     # @return [Integer, nil]
     def cleanup_interval_seconds
-      value = if rails_config.key?(:cleanup_interval_seconds)
-                rails_config[:cleanup_interval_seconds]
-              elsif env.key?('GOOD_JOB_CLEANUP_INTERVAL_SECONDS')
-                env['GOOD_JOB_CLEANUP_INTERVAL_SECONDS']
-              else
-                DEFAULT_CLEANUP_INTERVAL_SECONDS
-              end
-      value.present? ? value.to_i : nil
+      if rails_config.key?(:cleanup_interval_seconds)
+        value = rails_config[:cleanup_interval_seconds]
+
+        if value.nil?
+          ActiveSupport::Deprecation.warn(
+            %(Setting `config.good_job.cleanup_interval_seconds` to `nil` will no longer disable time-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
+          )
+          value = false
+        elsif value == 0 # rubocop:disable Style/NumericPredicate
+          ActiveSupport::Deprecation.warn(
+            %(Setting `config.good_job.cleanup_interval_seconds` to `0` will disable time-based cleanups in GoodJob v4. Set to `false` to disable, or `-1` to run every time.)
+          )
+          value = -1
+        end
+      elsif env.key?('GOOD_JOB_CLEANUP_INTERVAL_SECONDS')
+        value = env['GOOD_JOB_CLEANUP_INTERVAL_SECONDS']
+        if value.blank?
+          ActiveSupport::Deprecation.warn(
+            %(Setting `GOOD_JOB_CLEANUP_INTERVAL_SECONDS` to `""` will no longer disable time-based cleanups in GoodJob v4. Set to `0` to disable, or `-1` to run every time.)
+          )
+          value = false
+        elsif value == '0'
+          value = false
+        end
+      else
+        value = DEFAULT_CLEANUP_INTERVAL_SECONDS
+      end
+
+      value ? value.to_i : false
     end
 
     # Tests whether to daemonize the process.

data/lib/good_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.7.1'
+  VERSION = '3.7.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.7.1
+  version: 3.7.3
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-12-12 00:00:00.000000000 Z
+date: 2023-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob