good_job 3.4.4 → 3.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c54a7908e5803c8f247421375b0ca4a09f97d5b0d21131ef2bfc54e91a4c7eed
-  data.tar.gz: 8a616c9407d2844ee89e2f12fa71c197ddb60e693983c66ce664ac413d0676f0
+  metadata.gz: 9f6f46bc81c3d161377238784c24c81deb1f06480b4fd49cd87192bff37bed60
+  data.tar.gz: a7e1d948e9bd98a94128f61fc8b12b32627ec2b828d36e7b06baa272c304a00e
 SHA512:
-  metadata.gz: 0040cd9afa69d73d4c9bf09da90bd7c1e4c73d4dc4251faff13fd495e2c39d081d099163482edb332a392be1dd560ac056705a5261363e8172d2ae7eab20be55
-  data.tar.gz: c4e41bd8da8e2afd309fceb2c0c5eb4b042d85234c4d34f4a687bcb2fe63f9e2f7d0c442c07bf68a248201d5e9c42c2e84dc8022c9f3eace8ea0b97c3995e004
+  metadata.gz: 69db268ef55985004f348fa62d7c07e82e10d961b9667a16367fec4a5af11ff05daf9e1ac9a064946e6d41434a9fabf9ea3bce7ced52a8bca342c876e1168d8e
+  data.tar.gz: 234f79a1ee23c7609f5e22b3a0c4e3d883e67011ed28f68befae868b9ac252adb6869e8261ef9af3a754da105edf93701fc8525cc81e487b8e30b6d94c636850

data/CHANGELOG.md

@@ -1,5 +1,36 @@
 # Changelog
 
+## [v3.4.6](https://github.com/bensheldon/good_job/tree/v3.4.6) (2022-09-26)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.4.5...v3.4.6)
+
+**Fixed bugs:**
+
+- Support SemanticLogger logging with improve stdout logic and tagged logs [\#715](https://github.com/bensheldon/good_job/pull/715) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- Unable to Replace GoodJob's Logger [\#667](https://github.com/bensheldon/good_job/issues/667)
+- Jobs never get run... [\#516](https://github.com/bensheldon/good_job/issues/516)
+
+## [v3.4.5](https://github.com/bensheldon/good_job/tree/v3.4.5) (2022-09-12)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.4.4...v3.4.5)
+
+**Fixed bugs:**
+
+- Dashboard: Remove translation\_missing red highlighting; remove number\_to\_human.hundreds; add form labels [\#708](https://github.com/bensheldon/good_job/pull/708) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- pg\_xact No Such File error in logs [\#709](https://github.com/bensheldon/good_job/issues/709)
+- Broken upgrade to v3. [\#703](https://github.com/bensheldon/good_job/issues/703)
+
+**Merged pull requests:**
+
+- Sentry integration Docs [\#711](https://github.com/bensheldon/good_job/pull/711) ([remy727](https://github.com/remy727))
+- Add an `Execution` `after_perform_unlocked` callback [\#706](https://github.com/bensheldon/good_job/pull/706) ([bensheldon](https://github.com/bensheldon))
+
 ## [v3.4.4](https://github.com/bensheldon/good_job/tree/v3.4.4) (2022-08-20)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.4.3...v3.4.4)
@@ -138,7 +169,6 @@
 
 **Closed issues:**
 
-- Unable to Replace GoodJob's Logger [\#667](https://github.com/bensheldon/good_job/issues/667)
 - Readme should consistently encourage usage of `config.good_job....` instead of `GoodJob.` configuration [\#628](https://github.com/bensheldon/good_job/issues/628)
 - Improve the "Gem development" section of README? [\#551](https://github.com/bensheldon/good_job/issues/551)
 - Simplify Rails initialization to only be a mountable Engine [\#543](https://github.com/bensheldon/good_job/issues/543)
@@ -192,7 +222,6 @@
 - UI engine does not work without explicit require [\#646](https://github.com/bensheldon/good_job/issues/646)
 - Should `:inline` adapter mode retry jobs? [\#611](https://github.com/bensheldon/good_job/issues/611)
 - Error Job Not Preserved  [\#594](https://github.com/bensheldon/good_job/issues/594)
-- Jobs never get run... [\#516](https://github.com/bensheldon/good_job/issues/516)
 - Release GoodJob 3.0 [\#507](https://github.com/bensheldon/good_job/issues/507)
 - Improve security of Gem releases [\#422](https://github.com/bensheldon/good_job/issues/422)
 

data/README.md

@@ -232,7 +232,7 @@ Rails.application.configure do
   # Configure options individually...
   config.good_job.preserve_job_records = true
   config.good_job.retry_on_unhandled_error = false
-  config.good_job.on_thread_error = -> (exception) { Raven.capture_exception(exception) }
+  config.good_job.on_thread_error = -> (exception) { Sentry.capture_exception(exception) }
   config.good_job.execution_mode = :async
   config.good_job.queues = '*'
   config.good_job.max_threads = 5
@@ -245,7 +245,7 @@ Rails.application.configure do
   config.good_job = {
     preserve_job_records: true,
     retry_on_unhandled_error: false,
-    on_thread_error: -> (exception) { Raven.capture_exception(exception) },
+    on_thread_error: -> (exception) { Sentry.capture_exception(exception) },
     execution_mode: :async,
     queues: '*',
     max_threads: 5,
@@ -287,7 +287,7 @@ Available configuration options are:
 - `on_thread_error` (proc, lambda, or callable) will be called when an Exception. It can be useful for logging errors to bug tracking services, like Sentry or Airbrake. Example:
 
     ```ruby
-    config.good_job.on_thread_error = -> (exception) { Raven.capture_exception(exception) }
+    config.good_job.on_thread_error = -> (exception) { Sentry.capture_exception(exception) }
     ```
 
 By default, GoodJob configures the following execution modes per environment:
@@ -567,7 +567,7 @@ If errors do reach GoodJob, you can assign a callable to `GoodJob.on_thread_erro
 
 ```ruby
 # config/initializers/good_job.rb
-GoodJob.on_thread_error = -> (exception) { Raven.capture_exception(exception) }
+GoodJob.on_thread_error = -> (exception) { Sentry.capture_exception(exception) }
 ```
 
 #### Retries
@@ -601,13 +601,13 @@ class ApplicationJob < ActiveJob::Base
   retry_on StandardError, wait: :exponentially_longer, attempts: Float::INFINITY
 
   retry_on SpecialError, attempts: 5 do |_job, exception|
-    Raven.capture_exception(exception)
+    Sentry.capture_exception(exception)
   end
 
   around_perform do |_job, block|
     block.call
   rescue StandardError => e
-    Raven.capture_exception(e)
+    Sentry.capture_exception(e)
     raise
   end
   # ...
@@ -630,7 +630,7 @@ ActionMailer::MailDeliveryJob.retry_on StandardError, wait: :exponentially_longe
 ActionMailer::MailDeliveryJob.around_perform do |_job, block|
   block.call
 rescue StandardError => e
-  Raven.capture_exception(e)
+  Sentry.capture_exception(e)
   raise
 end
 ```

data/app/assets/good_job/style.css

@@ -35,11 +35,6 @@
   z-index: 1;
 }
 
-.translation_missing {
-  background-color: red;
-  color: white;
-}
-
 .btn-outline-secondary {
   border-color: #ced4da; /* $gray-400 */
 }

data/app/models/good_job/execution.rb

@@ -20,6 +20,8 @@ module GoodJob
     self.table_name = 'good_jobs'
     self.advisory_lockable_column = 'active_job_id'
 
+    define_model_callbacks :perform_unlocked, only: :after
+
     # Parse a string representing a group of queues into a more readable data
     # structure.
     # @param string [String] Queue string
@@ -202,13 +204,18 @@ module GoodJob
     #   raised, if any (if the job raised, then the second array entry will be
     #   +nil+). If there were no jobs to execute, returns +nil+.
     def self.perform_with_advisory_lock(parsed_queues: nil)
+      execution = nil
+      result = nil
       unfinished.dequeueing_ordered(parsed_queues).only_scheduled.limit(1).with_advisory_lock(unlock_session: true) do |executions|
         execution = executions.first
         break if execution.blank?
         break :unlocked unless execution&.executable?
 
-        execution.perform
+        result = execution.perform
       end
+      execution&.run_callbacks(:perform_unlocked)
+
+      result
     end
 
     # Fetches the scheduled execution time of the next eligible Execution(s).

data/app/views/good_job/jobs/_table.erb

@@ -4,6 +4,7 @@
     <header class="list-group-item bg-light">
       <div class="row small text-muted text-uppercase align-items-center">
         <div class="col-auto">
+          <%= label_tag('toggle_job_ids', "Toggle all jobs", class: "visually-hidden") %>
           <%= check_box_tag('toggle_job_ids', "1", false, data: { "checkbox-toggle-all": "job_ids" }) %>
         </div>
         <div class="col-4">

data/app/views/good_job/shared/_filter.erb

@@ -8,6 +8,7 @@
       <%= hidden_field_tag :locale, params[:locale] if params[:locale] %>
       <div class="d-flex flex-row w-100">
         <div class="me-2">
+          <%= label_tag "job_queue_filter", "Queue name", class: "visually-hidden" %>
           <select name="queue_name" id="job_queue_filter" class="form-select form-select-sm">
             <option value="" <%= "selected='selected'" if params[:queue_name].blank? %>>All queues</option>
 
@@ -18,6 +19,7 @@
         </div>
 
         <div class="me-2">
+          <%= label_tag "job_class_filter", "Job name", class: "visually-hidden" %>
           <select name="job_class" id="job_class_filter" class="form-select form-select-sm">
             <option value="" <%= "selected='selected'" if params[:job_class].blank? %>>All jobs</option>
 
@@ -28,6 +30,7 @@
         </div>
 
         <div class="me-2 flex-fill">
+          <%= label_tag "query", "Search", class: "visually-hidden" %>
           <%= search_field_tag "query", params[:query], class: "form-control form-control-sm", placeholder: "Search by class, job id, job params, and error text." %>
         </div>
 

data/config/locales/en.yml

@@ -72,7 +72,6 @@ en:
         format: "%n%u"
         units:
           billion: B
-          hundred: ''
           million: M
           quadrillion: Q
           thousand: K

data/config/locales/es.yml

@@ -72,7 +72,6 @@ es:
         format: "%n%u"
         units:
           billion: B
-          hundred: ''
           million: M
           quadrillion: q
           thousand: k

data/config/locales/nl.yml

@@ -72,7 +72,6 @@ nl:
         format: "%n%u"
         units:
           billion: B
-          hundred: ''
           million: M
           quadrillion: Q
           thousand: K

data/config/locales/ru.yml

@@ -96,7 +96,6 @@ ru:
         format: "%n%u"
         units:
           billion: Б
-          hundred: ''
           million: М
           quadrillion: Q
           thousand: К

data/lib/good_job/adapter.rb

@@ -60,6 +60,7 @@ module GoodJob
           result = execution.perform
         ensure
           execution.advisory_unlock
+          execution.run_callbacks(:perform_unlocked)
         end
         raise result.unhandled_error if result.unhandled_error
       else

data/lib/good_job/cli.rb

@@ -156,7 +156,7 @@ module GoodJob
       # Rails or from the application can be set up here.
       def set_up_application!
         require RAILS_ENVIRONMENT_RB
-        return unless GoodJob::CLI.log_to_stdout? && !ActiveSupport::Logger.logger_outputs_to?(GoodJob.logger, $stdout)
+        return if !GoodJob::CLI.log_to_stdout? || ActiveSupport::Logger.logger_outputs_to?(GoodJob.logger, $stdout)
 
         GoodJob::LogSubscriber.loggers << ActiveSupport::TaggedLogging.new(ActiveSupport::Logger.new($stdout))
         GoodJob::LogSubscriber.reset_logger

data/lib/good_job/log_subscriber.rb

@@ -206,7 +206,7 @@ module GoodJob
       good_job_tag = ["ActiveJob"].freeze
 
       self.class.loggers.inject(block) do |inner, each_logger|
-        if each_logger.respond_to?(:tagged) && each_logger.formatter
+        if each_logger.respond_to?(:tagged) && each_logger.try(:formatter).try(:current_tags).respond_to?(:include?)
           tags_for_logger = if each_logger.formatter.current_tags.include?("ActiveJob")
                               good_job_tag + tags
                             else

data/lib/good_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.4.4'
+  VERSION = '3.4.6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.4.4
+  version: 3.4.6
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-08-20 00:00:00.000000000 Z
+date: 2022-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob