good_job 3.3.1 → 3.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cabb124450eb5e88a460635fb4aa70f3e5a53406ded6554bb32018fa2aa890bc
-  data.tar.gz: 0d83085806f8a1f30eff6136df4995f7982064b90a497ee56a4f8b9d922f4fbb
+  metadata.gz: 7b5dad621ffb6df8e754cc906eb748605d14525e7286f163f536c577d70f287c
+  data.tar.gz: 2f2973f6e21b7cf55ceb569cfff1bbf9fa1a579e544c7b96cae15c56cb890ce4
 SHA512:
-  metadata.gz: 7f17d4379517d9909ac771c9920b3472b1d5bbb18ce45bd78b160f76eba6b6a1169e6b89ec044cd8f3c5ad93a311be45174bd43b99468c5ff9a5c4bad088263f
-  data.tar.gz: 27f6aa3048d4035feb1e55b7cd4a3ba8410deb74ec9268fba23bac9a75c9db26bc3599d1f140bf68182b2f2307183013bc6601927a6eec19cab6051fcf03a927
+  metadata.gz: dbc0e6fe97519eabaee2f82f0de69cfbce24a928ba579ac57fd1b0c38b9693269a7b7bb69042d621a84fca224f2ec335bf9a5c2c7420a9e3e4cf9bbdf0f34460
+  data.tar.gz: b237d93f4741900bcc7263a754155328d31452cc040ee047d5bdca1dc0d0dbd9dfa416563dd70482d3d56f0bc73ef7d57b91a256760895a8ed9127cef2fb8127

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [v3.3.2](https://github.com/bensheldon/good_job/tree/v3.3.2) (2022-07-27)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.3.1...v3.3.2)
+
+**Fixed bugs:**
+
+- Defer setting Adapter's execution mode until Rails initializes [\#683](https://github.com/bensheldon/good_job/pull/683) ([bensheldon](https://github.com/bensheldon))
+
 ## [v3.3.1](https://github.com/bensheldon/good_job/tree/v3.3.1) (2022-07-26)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.3.0...v3.3.1)

data/lib/good_job/adapter.rb

@@ -10,8 +10,6 @@ module GoodJob
     #   @return [Array<GoodJob::Adapter>, nil]
     cattr_reader :instances, default: [], instance_reader: false
 
-    attr_reader :execution_mode
-
     # @param execution_mode [Symbol, nil] specifies how and where jobs should be executed. You can also set this with the environment variable +GOOD_JOB_EXECUTION_MODE+.
     #
     #  - +:inline+ executes jobs immediately in whatever process queued them (usually the web server process). This should only be used in test and development environments.
@@ -27,10 +25,10 @@ module GoodJob
     #  - +production+ and all other environments: +:external+
     #
     def initialize(execution_mode: nil)
-      @execution_mode = (execution_mode || GoodJob.configuration.execution_mode).to_sym
-      GoodJob::Configuration.validate_execution_mode(@execution_mode)
-      self.class.instances << self
+      @_execution_mode_override = execution_mode
+      GoodJob::Configuration.validate_execution_mode(@_execution_mode_override) if @_execution_mode_override
 
+      self.class.instances << self
       start_async if GoodJob.async_ready?
     end
 
@@ -94,6 +92,12 @@ module GoodJob
       @_async_started = false
     end
 
+    # This adapter's execution mode
+    # @return [Symbol, nil]
+    def execution_mode
+      @_execution_mode_override || GoodJob.configuration.execution_mode
+    end
+
     # Whether in +:async+ execution mode.
     # @return [Boolean]
     def execute_async?
@@ -104,7 +108,8 @@ module GoodJob
     # Whether in +:external+ execution mode.
     # @return [Boolean]
     def execute_externally?
-      execution_mode == :external ||
+      execution_mode.nil? ||
+        execution_mode == :external ||
         (execution_mode.in?([:async, :async_server]) && !in_server_process?)
     end
 

data/lib/good_job/enqueuing.rb

@@ -0,0 +1,4 @@
+module GoodJob
+  module Enqueing
+  end
+end

data/lib/good_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.3.1'
+  VERSION = '3.3.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.3.1
+  version: 3.3.2
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-26 00:00:00.000000000 Z
+date: 2022-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -426,6 +426,7 @@ files:
 - lib/good_job/daemon.rb
 - lib/good_job/dependencies.rb
 - lib/good_job/engine.rb
+- lib/good_job/enqueuing.rb
 - lib/good_job/job_performer.rb
 - lib/good_job/log_subscriber.rb
 - lib/good_job/multi_scheduler.rb