good_job 3.29.5 → 3.30.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 26e3887930fc0f923edca0286d1d6c2fff51466f5b395eb122a56f6dd4ec9171
-  data.tar.gz: 79a670cab496050ddf9cee105be9eab503a4d18f4786ac4a5b04dd3f93e3814a
+  metadata.gz: 5ca44ad0fbf6d55478287f58fb49c9295ebcbbb5875ec8c3c2e94859dec23393
+  data.tar.gz: ded000fbd60a45e9028a97bda6f1dc0240310a7b9281708d15543331a8a19706
 SHA512:
-  metadata.gz: a8f938f53fc9d1e2334b25fb9311f30abffa47fe26b9968d1d7de5f354337c1aeca217cf70fcfc2e5ab15ceba992f9a4edbc7430d5b09733a90221a970fbdebc
-  data.tar.gz: ad97c2abf1d88cab58898f983991e599b8b55e2f20cc5931b0b2d7ee08292ca9c20652452ebbf853a3f09e96c2134dd7167f158c5a0629390d94c48383a2b436
+  metadata.gz: 4d09ea0dcb8801f3ca577b349e9f671bdf70c4df38ace8b96e9b5bda8f22bc2bc4791a261c4816e2beca82aa17f188c9521f89be4460f4097d5e8a03a4f2c281
+  data.tar.gz: 73ab002472752c47682c508b4828dfd359e9aebebc997b76f69c91f6cf5dd0ab12a4bc171fbc6f3d967e17b2a4b26a52f6afe311d43dbc90331c565a79443e25

data/CHANGELOG.md

@@ -1,5 +1,37 @@
 # Changelog
 
+## [v3.30.1](https://github.com/bensheldon/good_job/tree/v3.30.1) (2024-07-06)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.30.0...v3.30.1)
+
+**Fixed bugs:**
+
+- Fix Performance table formatting, change url from `performances` to singular `performance` [\#1393](https://github.com/bensheldon/good_job/pull/1393) ([bensheldon](https://github.com/bensheldon))
+- Add a version check for Rails whether to use pg interval or calculate float [\#1389](https://github.com/bensheldon/good_job/pull/1389) ([bensheldon](https://github.com/bensheldon))
+
+**Merged pull requests:**
+
+- Add missing newline after frozen string literal for migrations [\#1392](https://github.com/bensheldon/good_job/pull/1392) ([Earlopain](https://github.com/Earlopain))
+- Temporarily remove JRuby builds [\#1391](https://github.com/bensheldon/good_job/pull/1391) ([bensheldon](https://github.com/bensheldon))
+- Add initial Performance panel to dashboard [\#1388](https://github.com/bensheldon/good_job/pull/1388) ([bensheldon](https://github.com/bensheldon))
+- Move job execution logic from Execution to BaseExecution to simplify v4 changes [\#1357](https://github.com/bensheldon/good_job/pull/1357) ([bensheldon](https://github.com/bensheldon))
+
+## [v3.30.0](https://github.com/bensheldon/good_job/tree/v3.30.0) (2024-07-05)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.29.5...v3.30.0)
+
+**Implemented enhancements:**
+
+- Added GoodJob::DiscreteExecution\#duration column [\#1374](https://github.com/bensheldon/good_job/pull/1374) ([SebouChu](https://github.com/SebouChu))
+
+**Closed issues:**
+
+- Job retried infinitely  [\#1384](https://github.com/bensheldon/good_job/issues/1384)
+
+**Merged pull requests:**
+
+- Use newer syntax in documentation for `wait` config on `retry` [\#1380](https://github.com/bensheldon/good_job/pull/1380) ([benoittgt](https://github.com/benoittgt))
+
 ## [v3.29.5](https://github.com/bensheldon/good_job/tree/v3.29.5) (2024-06-24)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.29.4...v3.29.5)

data/README.md

@@ -933,7 +933,7 @@ Active Job can be configured to retry an infinite number of times, with a polyno
 
 ```ruby
 class ApplicationJob < ActiveJob::Base
-  retry_on StandardError, wait: :exponentially_longer, attempts: Float::INFINITY
+  retry_on StandardError, wait: :polynomially_longer, attempts: Float::INFINITY
   # ...
 end
 ```
@@ -953,7 +953,7 @@ When using `retry_on` with an infinite number of retries, exceptions will never
 
 ```ruby
 class ApplicationJob < ActiveJob::Base
-  retry_on StandardError, wait: :exponentially_longer, attempts: Float::INFINITY
+  retry_on StandardError, wait: :polynomially_longer, attempts: Float::INFINITY
 
   retry_on SpecialError, attempts: 5 do |_job, exception|
     Rails.error.report(exception)
@@ -979,7 +979,7 @@ You can use an initializer to configure `ActionMailer::MailDeliveryJob`, for exa
 
 ```ruby
 # config/initializers/good_job.rb
-ActionMailer::MailDeliveryJob.retry_on StandardError, wait: :exponentially_longer, attempts: Float::INFINITY
+ActionMailer::MailDeliveryJob.retry_on StandardError, wait: :polynomially_longer, attempts: Float::INFINITY
 
 # With Sentry (or Bugsnag, Airbrake, Honeybadger, etc.)
 ActionMailer::MailDeliveryJob.around_perform do |_job, block|

data/app/controllers/good_job/performances_controller.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module GoodJob
+  class PerformancesController < ApplicationController
+    def show
+      if GoodJob::DiscreteExecution.duration_interval_migrated?
+        @performances = GoodJob::DiscreteExecution
+                        .where.not(job_class: nil)
+                        .group(:job_class)
+                        .select("
+                            job_class,
+                            COUNT(*) AS executions_count,
+                            AVG(duration) AS avg_duration,
+                            MIN(duration) AS min_duration,
+                            MAX(duration) AS max_duration
+                          ")
+                        .order("job_class")
+      else
+        @needs_upgrade = true
+      end
+    end
+  end
+end

data/app/filters/good_job/base_filter.rb

@@ -33,7 +33,7 @@ module GoodJob
 
     def job_classes
       filtered_query(params.slice(:queue_name)).unscope(:select)
-                                               .group(GoodJob::BaseExecution.params_job_class).count
+                                               .group(GoodJob::Job.params_job_class).count
                                                .sort_by { |name, _count| name.to_s }
                                                .to_h
     end

data/app/helpers/good_job/application_helper.rb

@@ -9,6 +9,7 @@ module GoodJob
 
     def format_duration(sec)
       return unless sec
+      return "" if sec.is_a?(String) # pg interval support added in Rails 6.1
 
       if sec < 1
         t 'good_job.duration.milliseconds', ms: (sec * 1000).floor

data/app/models/concerns/good_job/error_events.rb

@@ -27,7 +27,7 @@ module GoodJob
     def error_event
       return unless self.class.columns_hash['error_event']
 
-      enum = super
+      enum = read_attribute(:error_event)
       return unless enum
 
       ERROR_EVENT_ENUMS.key(enum)
@@ -39,7 +39,7 @@ module GoodJob
       enum = ERROR_EVENT_ENUMS[event]
       raise(ArgumentError, "Invalid error_event: #{event}") if event && !enum
 
-      super(enum)
+      write_attribute(:error_event, enum)
     end
   end
 end