good_job 3.29.2 → 3.29.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '035847331e792e45f5ecc5c94f6038bd9955e022fc3dcdf27263be0bf1e3c02d'
-  data.tar.gz: 7068ca56d21b29509841b37386e74ef9b0d3f761e0ce454b3d46522a685ffaa4
+  metadata.gz: dc61f98ee52126091970de8db6c13269794a13d5f17d87fc20bd821eb77fa50a
+  data.tar.gz: 99ccfe1fcbaaf4ca5a7c052fdb7c14687a3a41410996e1b03d55ced4ba22ccec
 SHA512:
-  metadata.gz: 0a3bd5801bcc975e25ac1586b7b392ec3d4e6113338ac18d89c29296a4e28c746c54f9e7c4e4e1343a0ba2f033e5debffb337b4bb54e576f05812d9d7751315d
-  data.tar.gz: 8b004560dc95421b474e5ec129b5a0dc2ef2ec20d7ee419d141d591bf29998eb5aaca585cb8a94b146ed9ecd691819062d2faffb66a247b0287488e3e0a62943
+  metadata.gz: 556115969cd40fb508c74443aa5663aef443206a34f4c39801501a4eded43511be02fbb29620907e99444a51b1059dca218fb15fab25c174f6aec6f05edd9e02
+  data.tar.gz: 69703ccbbd7a9deedd0bc905455ac5ee9db5f82958279b854dde01578113ad370723ed53c7aed0aa1e7b4bc4e4146f9859b6bcb2596953151fc275c0a8306702

data/CHANGELOG.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## [v3.29.4](https://github.com/bensheldon/good_job/tree/v3.29.4) (2024-06-18)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.29.3...v3.29.4)
+
+**Fixed bugs:**
+
+- Fix display of empty array in flash messages [\#1377](https://github.com/bensheldon/good_job/pull/1377) ([andynu](https://github.com/andynu))
+- Fix counts in tab links with filters [\#1373](https://github.com/bensheldon/good_job/pull/1373) ([SebouChu](https://github.com/SebouChu))
+
+## [v3.29.3](https://github.com/bensheldon/good_job/tree/v3.29.3) (2024-06-06)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.29.2...v3.29.3)
+
+**Fixed bugs:**
+
+- Synchronize `CapsuleTracker#renew` [\#1369](https://github.com/bensheldon/good_job/pull/1369) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- docs: Basic auth route mount example improvement [\#1368](https://github.com/bensheldon/good_job/issues/1368)
+- Tips for debugging/optimizing slow dashboard? \(45 second response time\) [\#1366](https://github.com/bensheldon/good_job/issues/1366)
+
 ## [v3.29.2](https://github.com/bensheldon/good_job/tree/v3.29.2) (2024-05-23)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.29.1...v3.29.2)

data/README.md

@@ -404,7 +404,7 @@ GoodJob includes a Dashboard as a mountable `Rails::Engine`.
     ```ruby
     # config/initializers/good_job.rb
     GoodJob::Engine.middleware.use(Rack::Auth::Basic) do |username, password|
-      ActiveSupport::SecurityUtils.secure_compare(Rails.application.credentials.good_job_username, username) &&
+      ActiveSupport::SecurityUtils.secure_compare(Rails.application.credentials.good_job_username, username) &
         ActiveSupport::SecurityUtils.secure_compare(Rails.application.credentials.good_job_password, password)
     end
     ```

data/app/models/good_job/process.rb

@@ -101,7 +101,8 @@ module GoodJob # :nodoc:
 
     def refresh
       self.state = self.class.process_state
-      reload.update(state: state, updated_at: Time.current)
+      reload # verify the record still exists in the database
+      update(state: state, updated_at: Time.current)
     rescue ActiveRecord::RecordNotFound
       @new_record = true
       self.created_at = self.updated_at = nil

data/app/views/good_job/shared/_alert.erb

@@ -1,5 +1,5 @@
 <div class="toast-container position-fixed p-3 start-50 translate-middle-x">
-  <% if notice %>
+  <% if notice.present? %>
     <div class="toast" role="alert" aria-live="assertive" aria-atomic="true">
       <div class="toast-body d-flex align-items-center gap-2">
         <%= render_icon "check", class: "flex-shrink-0 text-success" %>
@@ -8,7 +8,7 @@
       </div>
     </div>
   <% end %>
-  <% if alert %>
+  <% if alert.present? %>
     <div class="toast" role="alert" aria-live="assertive" aria-atomic="true">
       <div class="toast-body d-flex align-items-center gap-2">
         <%= render_icon "exclamation", class: "flex-shrink-0 text-danger" %>

data/app/views/good_job/shared/_filter.erb

@@ -47,7 +47,7 @@
       </div>
     <% end %>
 
-    <ul data-controller="async-values" data-async-values-url-value="<%= metrics_job_status_path %>" data-live-poll-region="filter-tabs" class="nav nav-tabs my-3">
+    <ul data-controller="async-values" data-async-values-url-value="<%= metrics_job_status_path(filter.to_params) %>" data-live-poll-region="filter-tabs" class="nav nav-tabs my-3">
       <li class="nav-item">
         <%= link_to t(".all"), filter.to_params(state: nil), class: "nav-link #{'active' if params[:state].blank?}" %>
       </li>

data/lib/good_job/capsule_tracker.rb

@@ -143,8 +143,10 @@ module GoodJob # :nodoc:
     # @param silent [Boolean] Whether to silence logging.
     # @return [void]
     def renew(silent: false)
-      GoodJob::Process.with_logger_silenced(silent: silent) do
-        @record&.refresh_if_stale(cleanup: true)
+      synchronize do
+        GoodJob::Process.with_logger_silenced(silent: silent) do
+          @record&.refresh_if_stale(cleanup: true)
+        end
       end
     end
 

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.29.2'
+  VERSION = '3.29.4'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.29.2
+  version: 3.29.4
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-05-23 00:00:00.000000000 Z
+date: 2024-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob