good_job 3.27.2 → 3.27.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f1caf94daea82b4e273aeaa01d2a44def87934a36275fbe5ca007a27bfceb4d
-  data.tar.gz: ad46d59cc2166d6386a17a3d0924f27f81c16e1670121b7f252ec9515da4b011
+  metadata.gz: fa73a0d9ffc1feb2548c525af767537d79a8b6fdf4e03092c4963d91041eb73a
+  data.tar.gz: 41365ce2085788ff587d85a96d6bf1568fb5861ea025e98c87990ae65485ffc8
 SHA512:
-  metadata.gz: 0c2be38cdbbfc7bb63f65451efc85ac51519f1ebabe7f9324ff5a652344b2e06fb75e93a0f0db0cda5038cf562ea793cf5eab6022cc219a304cab5be42b8dd0c
-  data.tar.gz: fe5e5d39d0f02a071d8906b155bac1b9467167565544595c38932870e85aff88569b5c9194ea20cf8ea403c134b3a8833e5075e3c8c0bda51982ddea31e6c406
+  metadata.gz: a300b98ed92353715dff14d18940f0e9fa2896e1cda56428c026e62b162e3f7a2f5a07eba2a9501af2d0c1f4fa51f3c225a4ecc103f73e8eac862ec343902e6e
+  data.tar.gz: 25241155b1d5e375a903cbeec98e88ecaaca2fc46b1134c92ed400fbf2b024a637744db072fe42fb9af486e7ce43cec5262c6c31adceb2f948af3aacb7cc9584

data/CHANGELOG.md

@@ -1,5 +1,35 @@
 # Changelog
 
+## [v3.27.4](https://github.com/bensheldon/good_job/tree/v3.27.4) (2024-04-04)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.27.3...v3.27.4)
+
+**Fixed bugs:**
+
+- Fix status tabs for Spanish translation [\#1307](https://github.com/bensheldon/good_job/pull/1307) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- Adapter to implement `enqueue_after_transaction_commit` [\#1310](https://github.com/bensheldon/good_job/issues/1310)
+- PG::SyntaxError: ERROR from timestamp [\#1305](https://github.com/bensheldon/good_job/issues/1305)
+- Spanish translation while on the dashboard displays hashes instead of the job status name [\#1304](https://github.com/bensheldon/good_job/issues/1304)
+- Exception raised during asset precompilation when no `config/database.yml` [\#1302](https://github.com/bensheldon/good_job/issues/1302)
+- Good job is running with standalone action cable server [\#1299](https://github.com/bensheldon/good_job/issues/1299)
+- Growing memory usage [\#1276](https://github.com/bensheldon/good_job/issues/1276)
+
+**Merged pull requests:**
+
+- Implement enqueue\_after\_transaction\_commit? [\#1311](https://github.com/bensheldon/good_job/pull/1311) ([luizkowalski](https://github.com/luizkowalski))
+- Fix localization formatting of `confirm_force_discard` [\#1309](https://github.com/bensheldon/good_job/pull/1309) ([bensheldon](https://github.com/bensheldon))
+
+## [v3.27.3](https://github.com/bensheldon/good_job/tree/v3.27.3) (2024-03-29)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.27.2...v3.27.3)
+
+**Merged pull requests:**
+
+- Revert "Start async adapters `after_initialize` instead of once Active Job and Active Record are loaded and Rails initialized?" [\#1303](https://github.com/bensheldon/good_job/pull/1303) ([bensheldon](https://github.com/bensheldon))
+
 ## [v3.27.2](https://github.com/bensheldon/good_job/tree/v3.27.2) (2024-03-27)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.27.1...v3.27.2)

data/config/locales/de.yml

@@ -111,9 +111,7 @@ de:
       actions:
         confirm_destroy: Sind Sie sicher, dass Sie den Job zerstören wollen?
         confirm_discard: Sind Sie sicher, dass Sie den Job verwerfen wollen?
-        confirm_force_discard: 'Sind Sie sicher, dass Sie das Verwerfen dieses Jobs erzwingen möchten? Der Job wird als verworfen markiert, aber der laufende Job wird nicht gestoppt – er wird jedoch bei Fehlern nicht erneut versucht.
-
-          '
+        confirm_force_discard: Sind Sie sicher, dass Sie das Verwerfen dieses Jobs erzwingen möchten? Der Job wird als verworfen markiert, aber der laufende Job wird nicht gestoppt – er wird jedoch bei Fehlern nicht erneut versucht.
         confirm_reschedule: Möchten Sie den Auftrag wirklich verschieben?
         confirm_retry: Möchten Sie den Job wirklich wiederholen?
         destroy: Arbeit vernichten

data/config/locales/en.yml

@@ -111,9 +111,7 @@ en:
       actions:
         confirm_destroy: Are you sure you want to destroy the job?
         confirm_discard: Are you usure you want to discard the job?
-        confirm_force_discard: 'Are you sure you want to force discard this job? The job will be marked as discarded but the running job will not be stopped - it will, however, not be retried on failures.
-
-          '
+        confirm_force_discard: Are you sure you want to force discard this job? The job will be marked as discarded but the running job will not be stopped - it will, however, not be retried on failures.
         confirm_reschedule: Are you sure you want to reschedule the job?
         confirm_retry: Are you sure you want to retry the job?
         destroy: Destroy job

data/config/locales/es.yml

@@ -233,19 +233,9 @@ es:
         inspiration: "¡Recuerda, también tú estás haciendo un buen trabajo!"
         last_updated: Última actualización
     status:
-      discarded:
-        one: Descartada
-        other: Descartadas
-      queued:
-        one: Encolada
-        other: Encoladas
-      retried:
-        one: Reintentada
-        other: Reintentadas
-      running: Corriendo
-      scheduled:
-        one: Programada
-        other: Programadas
-      succeeded:
-        one: Exitosa
-        other: Exitosas
+      discarded: Descartado
+      queued: Encolado
+      retried: Reintentado
+      running: Ejecutando
+      scheduled: Programado
+      succeeded: Exitoso

data/config/locales/fr.yml

@@ -33,9 +33,9 @@ fr:
         no_batches_found: Aucun lot trouvé.
     cron_entries:
       actions:
-        confirm_disable: Voulez-vous vraiment désactiver cette entrée cron?
-        confirm_enable: Voulez-vous vraiment activer cette entrée cron?
-        confirm_enqueue: Voulez-vous vraiment mettre en file d'attente cette entrée cron?
+        confirm_disable: Voulez-vous vraiment désactiver cette entrée cron ?
+        confirm_enable: Voulez-vous vraiment activer cette entrée cron ?
+        confirm_enqueue: Voulez-vous vraiment mettre en file d'attente cette entrée cron ?
         disable: Désactiver l'entrée cron
         enable: Activer l'entrée cron
         enqueue: Mettre en file d'attente l'entrée cron maintenant
@@ -111,9 +111,7 @@ fr:
       actions:
         confirm_destroy: Voulez-vous vraiment détruire le job ?
         confirm_discard: Voulez-vous vraiment mettre au rebut le job ?
-        confirm_force_discard: 'Êtes-vous sûr de vouloir forcer l''abandon de cette tâche ? Le travail sera marqué comme abandonné mais le travail en cours d''exécution ne sera pas arrêté - il ne sera cependant pas réessayé en cas d''échec.
-
-          '
+        confirm_force_discard: Êtes-vous sûr de vouloir forcer l'abandon du travail? Le travail sera marqué comme abandonné mais le travail en cours ne sera pas arrêté - cependant, il ne sera pas réessayé en cas d'échec.
         confirm_reschedule: Voulez-vous vraiment replanifier le job ?
         confirm_retry: Voulez-vous vraiment réessayer le job ?
         destroy: Détruire le job
@@ -146,7 +144,7 @@ fr:
             one: Appliquer à ce job
             other: Appliquer aux %{count} jobs
           confirm_destroy_all: Voulez-vous vraiment détruire les jobs sélectionnés ?
-          confirm_discard_all: Voulez-vous vraiment mettre au rebut les jobs sélectionnés?
+          confirm_discard_all: Voulez-vous vraiment mettre au rebut les jobs sélectionnés ?
           confirm_reschedule_all: Voulez-vous vraiment replanifier les jobs sélectionnées ?
           confirm_retry_all: Voulez-vous vraiment réessayer les jobs sélectionnées ?
           destroy_all: Tout détruire

data/config/locales/it.yml

@@ -111,9 +111,7 @@ it:
       actions:
         confirm_destroy: Sei sicuro di voler eliminare il job?
         confirm_discard: Sei sicuro di voler scartare il job?
-        confirm_force_discard: 'Sei sicuro di voler forzare lo scarto di questo job? Il job verrà contrassegnato come scartato ma il job in esecuzione non verrà interrotto - tuttavia, non verrà riprovato in caso di fallimento.
-
-          '
+        confirm_force_discard: Sei sicuro di voler forzare lo scarto di questo job? Il job verrà contrassegnato come scartato ma il job in esecuzione non verrà interrotto - tuttavia, non verrà riprovato in caso di fallimento.
         confirm_reschedule: Sei sicuro di voler riprogrammare il job?
         confirm_retry: Sei sicuro di voler riprovare il job?
         destroy: Elimina job

data/config/locales/ja.yml

@@ -111,9 +111,7 @@ ja:
       actions:
         confirm_destroy: ジョブを削除してもよろしいですか？
         confirm_discard: ジョブを破棄してもよろしいですか？
-        confirm_force_discard: 'このジョブを強制的に破棄してもよろしいですか?ジョブは破棄済みとしてマークされますが、実行中のジョブは停止されません。ただし、失敗した場合は再試行されません。
-
-          '
+        confirm_force_discard: このジョブを強制的に破棄してもよろしいですか?ジョブは破棄済みとしてマークされますが、実行中のジョブは停止されません。ただし、失敗した場合は再試行されません。
         confirm_reschedule: ジョブを再スケジュールしてもよろしいですか？
         confirm_retry: ジョブを再試行してもよろしいですか？
         destroy: ジョブを削除

data/config/locales/ko.yml

@@ -111,9 +111,7 @@ ko:
       actions:
         confirm_destroy: 해당 작업을 삭제하시겠습니까?
         confirm_discard: 해당 작업을 폐기하시겠습니까?
-        confirm_force_discard: '이 작업을 강제로 폐기하시겠습니까? 작업은 폐기로 표시되지만, 실행 중인 작업은 중지되지 않습니다. 그러나 실패한 경우 재시도되지 않습니다.
-
-          '
+        confirm_force_discard: 이 작업을 강제로 폐기하시겠습니까? 작업은 폐기로 표시되지만, 실행 중인 작업은 중지되지 않습니다. 그러나 실패한 경우 재시도되지 않습니다.
         confirm_reschedule: 해당 작업을 재예약하시겠습니까?
         confirm_retry: 해당 작업을 다시 시도하시겠습니까?
         destroy: 작업 삭제

data/config/locales/nl.yml

@@ -111,9 +111,7 @@ nl:
       actions:
         confirm_destroy: Weet je zeker dat je de baan wilt vernietigen?
         confirm_discard: Wilt u de baan afwijzen?
-        confirm_force_discard: 'Weet u zeker dat u deze taak geforceerd wilt weggooien? De taak wordt gemarkeerd als verwijderd, maar de lopende taak wordt niet gestopt. Bij fouten wordt deze echter niet opnieuw geprobeerd.
-
-          '
+        confirm_force_discard: Weet u zeker dat u deze taak geforceerd wilt weggooien? De taak wordt gemarkeerd als verwijderd, maar de lopende taak wordt niet gestopt. Bij fouten wordt deze echter niet opnieuw geprobeerd.
         confirm_reschedule: Weet u zeker dat u de taak opnieuw wilt inplannen?
         confirm_retry: Weet u zeker dat u de taak opnieuw wilt proberen?
         destroy: Baan vernietigen

data/config/locales/pt-BR.yml

@@ -111,9 +111,7 @@ pt-BR:
       actions:
         confirm_destroy: Tem certeza de que deseja excluir a tarefa?
         confirm_discard: Tem certeza de que deseja descartar a tarefa?
-        confirm_force_discard: 'Tem certeza de que deseja forçar o descarte desta tarefa? A tarefa será marcada como descartada, mas a tarefa em execução não será interrompida - no entanto, ela não será tentada novamente em falhas.
-
-          '
+        confirm_force_discard: Tem certeza de que deseja forçar o descarte desta tarefa? A tarefa será marcada como descartada, mas a tarefa em execução não será interrompida - no entanto, ela não será tentada novamente em falhas.
         confirm_reschedule: Tem certeza de que deseja reagendar a tarefa?
         confirm_retry: Tem certeza de que deseja tentar novamente a tarefa?
         destroy: Excluir tarefa

data/config/locales/tr.yml

@@ -111,9 +111,7 @@ tr:
       actions:
         confirm_destroy: Bu işi silmek istediğinizden emin misiniz?
         confirm_discard: Bu işi iptal etmek istediğinizden emin misiniz?
-        confirm_force_discard: 'Bu işi zorla iptal etmek istediğinizden emin misiniz? İş atıldı olarak işaretlenecek ancak devam eden iş durdurulmayacak; ancak başarısızlık durumunda yeniden denenmeyecek.
-
-          '
+        confirm_force_discard: Bu işi zorla iptal etmek istediğinizden emin misiniz? İş atıldı olarak işaretlenecek ancak devam eden iş durdurulmayacak; ancak başarısızlık durumunda yeniden denenmeyecek.
         confirm_reschedule: Bu işi yeniden planlamak istediğinizden emin misiniz?
         confirm_retry: Bu işi tekrar denemek istediğinizden emin misiniz?
         destroy: İşi Sil

data/config/locales/uk.yml

@@ -135,9 +135,7 @@ uk:
       actions:
         confirm_destroy: Ви впевнені, що хочете видалити завдання?
         confirm_discard: Ви впевнені, що хочете відхилити завдання?
-        confirm_force_discard: 'Ви впевнені, що хочете примусово скасувати цю роботу? Завдання буде позначено як відхилене, але виконуване завдання не буде зупинено – однак його не буде повторено у випадку помилок.
-
-          '
+        confirm_force_discard: Ви впевнені, що хочете примусово скасувати цю роботу? Завдання буде позначено як відхилене, але виконуване завдання не буде зупинено – однак його не буде повторено у випадку помилок.
         confirm_reschedule: Ви впевнені, що хочете перепланувати завдання?
         confirm_retry: Ви впевнені, що хочете повторити завдання?
         destroy: Видалити завдання

data/lib/good_job/adapter.rb

@@ -30,7 +30,7 @@ module GoodJob
       GoodJob::Configuration.validate_execution_mode(@_execution_mode_override) if @_execution_mode_override
       @capsule = _capsule
 
-      start_async if GoodJob._async_ready?
+      start_async if GoodJob.async_ready?
       self.class.instances << self
     end
 
@@ -42,6 +42,12 @@ module GoodJob
       enqueue_at(active_job, nil)
     end
 
+    # Defines if enqueueing this job from inside an Active Record transaction
+    # automatically defers the enqueue to after the transaction commit.
+    def enqueue_after_transaction_commit?
+      GoodJob.configuration.enqueue_after_transaction_commit
+    end
+
     # Enqueues multiple ActiveJob instances at once
     # @param active_jobs [Array<ActiveJob::Base>] jobs to be enqueued
     # @return [Integer] number of jobs that were successfully enqueued

data/lib/good_job/bulk.rb

@@ -14,7 +14,7 @@ module GoodJob
 
     # Capture jobs to a buffer. Pass either a block, or specific Active Jobs to be buffered.
     # @param active_jobs [Array<ActiveJob::Base>] Active Jobs to be buffered.
-    # @param queue_adapter Override the jobs implict queue adapter with an explicit one.
+    # @param queue_adapter Override the jobs implicit queue adapter with an explicit one.
     # @return [nil, Array<ActiveJob::Base>] The ActiveJob instances that have been buffered; nil if no active buffer
     def self.capture(active_jobs = nil, queue_adapter: nil, &block)
       raise(ArgumentError, "Use either the block form or the argument form, not both") if block && active_jobs

data/lib/good_job/configuration.rb

@@ -33,6 +33,8 @@ module GoodJob
     DEFAULT_DASHBOARD_DEFAULT_LOCALE = :en
     # Default Dashboard Live Poll button enabled
     DEFAULT_DASHBOARD_LIVE_POLL_ENABLED = true
+    # Default enqueue_after_transaction_commit
+    DEFAULT_ENQUEUE_AFTER_TRANSACTION_COMMIT = false
 
     def self.validate_execution_mode(execution_mode)
       raise ArgumentError, "GoodJob execution mode must be one of #{EXECUTION_MODES.join(', ')}. It was '#{execution_mode}' which is not valid." unless execution_mode.in?(EXECUTION_MODES)
@@ -389,6 +391,14 @@ module GoodJob
       DEFAULT_DASHBOARD_LIVE_POLL_ENABLED
     end
 
+    # Whether the Adapter should have Active Job enqueue jobs after the transaction has committed.
+    # @return [Boolean]
+    def enqueue_after_transaction_commit
+      return options[:enqueue_after_transaction_commit] unless options[:enqueue_after_transaction_commit].nil?
+
+      DEFAULT_ENQUEUE_AFTER_TRANSACTION_COMMIT
+    end
+
     # Whether running in a web server process.
     # @return [Boolean, nil]
     def in_webserver?

data/lib/good_job/dependencies.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+module GoodJob # :nodoc:
+  # Extends GoodJob module to track Rails boot dependencies.
+  module Dependencies
+    extend ActiveSupport::Concern
+
+    included do
+      mattr_accessor :_framework_ready, default: false
+    end
+
+    class_methods do
+      # Whether Rails framework has sufficiently initialized to enable Async execution.
+      def async_ready?
+        Rails.application.initialized? || _framework_ready
+      end
+
+      def _start_async_adapters
+        return unless async_ready?
+
+        ActiveJob::Base.queue_adapter # Ensure Active Job is initialized
+        GoodJob::Adapter.instances
+                        .select(&:execute_async?)
+                        .reject(&:async_started?)
+                        .each(&:start_async)
+      end
+    end
+  end
+end

data/lib/good_job/engine.rb

@@ -49,17 +49,22 @@ module GoodJob
     end
 
     initializer "good_job.start_async" do
+      # This hooks into the hookable places during Rails boot, which is unfortunately not Rails.application.initialized?
+      # If an Adapter is initialized during boot, we want to want to start async executors once the framework dependencies have loaded.
+      # When exactly that happens is out of our control because gems or application code may touch things earlier than expected.
+      # For example, as of Rails 6.1, if an ActiveRecord model is touched during boot, that triggers ActiveRecord to load,
+      # which touches DestroyAssociationAsyncJob, which loads ActiveJob, which may initialize a GoodJob::Adapter, all of which
+      # happens _before_ ActiveRecord finishes loading. GoodJob will deadlock if an async executor is started in the middle of
+      # ActiveRecord loading.
       config.after_initialize do
-        GoodJob._async_ready = true
-
-        # Ensure Active Record and Active Job are fully loaded
-        ActiveRecord::Base # rubocop:disable Lint/Void
-        ActiveJob::Base.queue_adapter
-
-        GoodJob::Adapter.instances
-                        .select(&:execute_async?)
-                        .reject(&:async_started?)
-                        .each(&:start_async)
+        ActiveSupport.on_load(:active_record) do
+          ActiveSupport.on_load(:active_job) do
+            GoodJob._framework_ready = true
+            GoodJob._start_async_adapters
+          end
+          GoodJob._start_async_adapters
+        end
+        GoodJob._start_async_adapters
       end
     end
   end

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.27.2'
+  VERSION = '3.27.4'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

data/lib/good_job.rb

@@ -25,6 +25,7 @@ require_relative "good_job/configuration"
 require_relative "good_job/cron_manager"
 require_relative "good_job/current_thread"
 require_relative "good_job/daemon"
+require_relative "good_job/dependencies"
 require_relative "good_job/job_performer"
 require_relative "good_job/job_performer/metrics"
 require_relative "good_job/log_subscriber"
@@ -45,6 +46,7 @@ require_relative "good_job/thread_status"
 #
 # +GoodJob+ is the top-level namespace and exposes configuration attributes.
 module GoodJob
+  include GoodJob::Dependencies
   include GoodJob::ThreadStatus
 
   # Default, null, blank value placeholder.
@@ -112,11 +114,6 @@ module GoodJob
   #   @return [GoodJob::Capsule, nil]
   mattr_accessor :capsule, default: GoodJob::Capsule.new(configuration: configuration)
 
-  mattr_accessor :_async_ready, default: false
-  def self._async_ready?
-    _async_ready
-  end
-
   # Called with exception when a GoodJob thread raises an exception
   # @param exception [Exception] Exception that was raised
   # @return [void]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.27.2
+  version: 3.27.4
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-27 00:00:00.000000000 Z
+date: 2024-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -404,6 +404,7 @@ files:
 - lib/good_job/cron_manager.rb
 - lib/good_job/current_thread.rb
 - lib/good_job/daemon.rb
+- lib/good_job/dependencies.rb
 - lib/good_job/engine.rb
 - lib/good_job/interrupt_error.rb
 - lib/good_job/job_performer.rb