good_job 3.21.3 → 3.21.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2b769f6444bb3572bd5739f046469179945f8fc6f13c9fa5bd3de03b25e8e43
-  data.tar.gz: c7b0cd19944dea29a8cb75dce00ed92434879d08f07718781d91123a295f6a11
+  metadata.gz: fa13b9d970c63760bc8264906c0aeccf1f71f0b6e678338cca21778956fdba0a
+  data.tar.gz: cd4d0e5be595b266396a2ffa0d9da0955940f1afe7639a2456b9a8f67e9d205b
 SHA512:
-  metadata.gz: fff83dabf6211e76b3439bd1a6486ba2009bb5fc9ae689673deefbf5728de44245e1a982e9d56c524dc07780d6c831328765e2c3c8b3aaef950f7969ffdb1a15
-  data.tar.gz: 289f6573c18d539a7ca6918d8288fdf6f510732df036138f44a816e1bebae53529695f766146488fda2967aa120b97e4d938ea0453a69b91c636286064dbec61
+  metadata.gz: '0871dcec35bfe62dbc59f07e81aa048cd04300316e859080a7f61f1666e61a1641a52ce76e6d827d2bf6e7524dd3893cacda66d94fb7ec994d88ae2e7b616ead'
+  data.tar.gz: 7171bf22d85558b2f48bbecc80fbe5a57cea331be996b6324e266bc1e8a1da9a3a13f9ab191d5dac167797be5e2b64c0a7bb9ebb05e4937b2946de9bafc17193

data/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## [v3.21.5](https://github.com/bensheldon/good_job/tree/v3.21.5) (2023-12-12)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.21.4...v3.21.5)
+
+**Fixed bugs:**
+
+- Fix conditional index migration to be rollbackable [\#1176](https://github.com/bensheldon/good_job/pull/1176) ([bensheldon](https://github.com/bensheldon))
+
+## [v3.21.4](https://github.com/bensheldon/good_job/tree/v3.21.4) (2023-12-11)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.21.3...v3.21.4)
+
+**Fixed bugs:**
+
+- Fix latest migration not affecting `GoodJob.migrated?` [\#1175](https://github.com/bensheldon/good_job/pull/1175) ([Earlopain](https://github.com/Earlopain))
+- Fix no method error in systemd service [\#1173](https://github.com/bensheldon/good_job/pull/1173) ([tagrudev](https://github.com/tagrudev))
+
 ## [v3.21.3](https://github.com/bensheldon/good_job/tree/v3.21.3) (2023-12-10)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.21.2...v3.21.3)

data/app/models/good_job/base_execution.rb

@@ -49,6 +49,13 @@ module GoodJob
         migration_pending_warning!
         false
       end
+
+      def cron_indices_migrated?
+        return true if connection.index_name_exists?(:good_jobs, :index_good_jobs_on_cron_key_and_created_at_cond)
+
+        migration_pending_warning!
+        false
+      end
     end
 
     # The ActiveJob job class, as a string

data/lib/generators/good_job/templates/update/migrations/07_recreate_good_job_cron_indexes_with_conditional.rb.erb

@@ -25,11 +25,11 @@ class RecreateGoodJobCronIndexesWithConditional < ActiveRecord::Migration<%= mig
 
       dir.down do
         unless connection.index_name_exists?(:good_jobs, :index_good_jobs_on_cron_key_and_created_at)
-          add_index :good_jobs, [:cron_key, :created_at], where: "(cron_key IS NOT NULL)",
+          add_index :good_jobs, [:cron_key, :created_at],
                     name: :index_good_jobs_on_cron_key_and_created_at, algorithm: :concurrently
         end
         unless connection.index_name_exists?(:good_jobs, :index_good_jobs_on_cron_key_and_cron_at)
-          add_index :good_jobs, [:cron_key, :cron_at], where: "(cron_key IS NOT NULL)", unique: true,
+          add_index :good_jobs, [:cron_key, :cron_at], unique: true,
                     name: :index_good_jobs_on_cron_key_and_cron_at, algorithm: :concurrently
         end
 

data/lib/good_job/systemd_service.rb

@@ -11,10 +11,10 @@ module GoodJob # :nodoc:
   #
   class SystemdService
     def self.task_observer(_time, _output, thread_error) # :nodoc:
-      return if thread_error.is_a? Concurrent::CancelledOperationError
+      return if !thread_error || thread_error.is_a?(Concurrent::CancelledOperationError)
 
       ActiveSupport::Notifications.instrument("systemd_watchdog_error.good_job", { error: thread_error })
-      GoodJob._on_thread_error(thread_error) if thread_error
+      GoodJob._on_thread_error(thread_error)
     end
 
     # Indicates whether the service is actively notifying systemd's watchdog.

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.21.3'
+  VERSION = '3.21.5'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

data/lib/good_job.rb

@@ -272,7 +272,7 @@ module GoodJob
   def self.migrated?
     # Always update with the most recent migration check
     GoodJob::Execution.reset_column_information
-    GoodJob::Execution.error_event_migrated?
+    GoodJob::Execution.cron_indices_migrated?
   end
 
   ActiveSupport.run_load_hooks(:good_job, self)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.21.3
+  version: 3.21.5
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-12-10 00:00:00.000000000 Z
+date: 2023-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob