good_job 3.21.3 → 3.21.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2b769f6444bb3572bd5739f046469179945f8fc6f13c9fa5bd3de03b25e8e43
-  data.tar.gz: c7b0cd19944dea29a8cb75dce00ed92434879d08f07718781d91123a295f6a11
+  metadata.gz: b9e4ef5306eec4101ebed1018da4202479324823721d34e51bfb16e1809ee4ba
+  data.tar.gz: 848574c70fb834dfa2bea8339bb7373466975fb84717c75ee51d7b4dd502235c
 SHA512:
-  metadata.gz: fff83dabf6211e76b3439bd1a6486ba2009bb5fc9ae689673deefbf5728de44245e1a982e9d56c524dc07780d6c831328765e2c3c8b3aaef950f7969ffdb1a15
-  data.tar.gz: 289f6573c18d539a7ca6918d8288fdf6f510732df036138f44a816e1bebae53529695f766146488fda2967aa120b97e4d938ea0453a69b91c636286064dbec61
+  metadata.gz: d18fb332702f5c9deed1806cc370991a2c42dc18dc81627a2e2688571967771fa0bb503268e142095ed82a97a387dbca9989070b91bdc34652a65716b1919df0
+  data.tar.gz: 988194bd1f4ffb95a0f41aae78bc5a3ecb2d2de1c8179dee58c7b0bed4ca01f4562adcd34b7e0986c75f1e80e081c78f6726d8328445df03d528ec1d680aad2f

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [v3.21.4](https://github.com/bensheldon/good_job/tree/v3.21.4) (2023-12-11)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.21.3...v3.21.4)
+
+**Fixed bugs:**
+
+- Fix latest migration not affecting `GoodJob.migrated?` [\#1175](https://github.com/bensheldon/good_job/pull/1175) ([Earlopain](https://github.com/Earlopain))
+- Fix no method error in systemd service [\#1173](https://github.com/bensheldon/good_job/pull/1173) ([tagrudev](https://github.com/tagrudev))
+
 ## [v3.21.3](https://github.com/bensheldon/good_job/tree/v3.21.3) (2023-12-10)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.21.2...v3.21.3)

data/app/models/good_job/base_execution.rb

@@ -49,6 +49,13 @@ module GoodJob
         migration_pending_warning!
         false
       end
+
+      def cron_indices_migrated?
+        return true if connection.index_name_exists?(:good_jobs, :index_good_jobs_on_cron_key_and_created_at_cond)
+
+        migration_pending_warning!
+        false
+      end
     end
 
     # The ActiveJob job class, as a string

data/lib/good_job/systemd_service.rb

@@ -11,10 +11,10 @@ module GoodJob # :nodoc:
   #
   class SystemdService
     def self.task_observer(_time, _output, thread_error) # :nodoc:
-      return if thread_error.is_a? Concurrent::CancelledOperationError
+      return if !thread_error || thread_error.is_a?(Concurrent::CancelledOperationError)
 
       ActiveSupport::Notifications.instrument("systemd_watchdog_error.good_job", { error: thread_error })
-      GoodJob._on_thread_error(thread_error) if thread_error
+      GoodJob._on_thread_error(thread_error)
     end
 
     # Indicates whether the service is actively notifying systemd's watchdog.

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.21.3'
+  VERSION = '3.21.4'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

data/lib/good_job.rb

@@ -272,7 +272,7 @@ module GoodJob
   def self.migrated?
     # Always update with the most recent migration check
     GoodJob::Execution.reset_column_information
-    GoodJob::Execution.error_event_migrated?
+    GoodJob::Execution.cron_indices_migrated?
   end
 
   ActiveSupport.run_load_hooks(:good_job, self)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.21.3
+  version: 3.21.4
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-12-10 00:00:00.000000000 Z
+date: 2023-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob