good_job 3.2.0 → 3.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ecbb75f2764a72686acb96367389abb1900321b5cf1292d6522aa8094c68451
-  data.tar.gz: 43a5305a9f2610c1544d6e52c61f0b338771b07d92d6493fed0058ad33bbc045
+  metadata.gz: 7b5dad621ffb6df8e754cc906eb748605d14525e7286f163f536c577d70f287c
+  data.tar.gz: 2f2973f6e21b7cf55ceb569cfff1bbf9fa1a579e544c7b96cae15c56cb890ce4
 SHA512:
-  metadata.gz: 0e637579c190a3f3d1aba6c02f6a71e2193d9e5c4bb449a3d4d9571093150a25a1c293ac3f5c541d2fae09aeffff771692fa7ef58bc8ed672f61a2c9d35a7e74
-  data.tar.gz: bc669b4d1628f7ff4b885787c65a38a57ad020aa168c3ae85f0c6bb26c9f0e19b64947682b0c99cf3eb28c2d660e1d79ee6095000a72340f09229d1679fa5dfe
+  metadata.gz: dbc0e6fe97519eabaee2f82f0de69cfbce24a928ba579ac57fd1b0c38b9693269a7b7bb69042d621a84fca224f2ec335bf9a5c2c7420a9e3e4cf9bbdf0f34460
+  data.tar.gz: b237d93f4741900bcc7263a754155328d31452cc040ee047d5bdca1dc0d0dbd9dfa416563dd70482d3d56f0bc73ef7d57b91a256760895a8ed9127cef2fb8127

data/CHANGELOG.md

@@ -1,10 +1,66 @@
 # Changelog
 
+## [v3.3.2](https://github.com/bensheldon/good_job/tree/v3.3.2) (2022-07-27)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.3.1...v3.3.2)
+
+**Fixed bugs:**
+
+- Defer setting Adapter's execution mode until Rails initializes [\#683](https://github.com/bensheldon/good_job/pull/683) ([bensheldon](https://github.com/bensheldon))
+
+## [v3.3.1](https://github.com/bensheldon/good_job/tree/v3.3.1) (2022-07-26)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.3.0...v3.3.1)
+
+**Implemented enhancements:**
+
+- Show basename of proctitle [\#679](https://github.com/bensheldon/good_job/pull/679) ([bkeepers](https://github.com/bkeepers))
+
+**Fixed bugs:**
+
+- Only count \_active\_ processes in the Navbar [\#680](https://github.com/bensheldon/good_job/pull/680) ([bensheldon](https://github.com/bensheldon))
+- Remove Zeitwerk and use explicit requires to be more like an engine [\#677](https://github.com/bensheldon/good_job/pull/677) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- Dashboard UI Invalid count of running process  [\#678](https://github.com/bensheldon/good_job/issues/678)
+
+**Merged pull requests:**
+
+- Lock to dotenv 2.7.x for Ruby 2.5 compatibility [\#682](https://github.com/bensheldon/good_job/pull/682) ([bensheldon](https://github.com/bensheldon))
+- Create global GoodJob.configuration object [\#681](https://github.com/bensheldon/good_job/pull/681) ([bensheldon](https://github.com/bensheldon))
+
+## [v3.3.0](https://github.com/bensheldon/good_job/tree/v3.3.0) (2022-07-24)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.2.0...v3.3.0)
+
+**Implemented enhancements:**
+
+- Dashboard: Update cron and processes to match jobs listing [\#676](https://github.com/bensheldon/good_job/pull/676) ([bkeepers](https://github.com/bkeepers))
+- Dashboard: improvements to jobs index and show pages [\#672](https://github.com/bensheldon/good_job/pull/672) ([bkeepers](https://github.com/bkeepers))
+
+**Fixed bugs:**
+
+- Replace "timestamp" column-type in migrations with "datetime" [\#671](https://github.com/bensheldon/good_job/pull/671) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- Calculating database connections [\#669](https://github.com/bensheldon/good_job/issues/669)
+- Unable to Replace GoodJob's Logger [\#667](https://github.com/bensheldon/good_job/issues/667)
+- Readme should consistently encourage usage of `config.good_job....` instead of `GoodJob.` configuration [\#628](https://github.com/bensheldon/good_job/issues/628)
+- Improve the "Gem development" section of README? [\#551](https://github.com/bensheldon/good_job/issues/551)
+- Simplify Rails initialization to only be a mountable Engine [\#543](https://github.com/bensheldon/good_job/issues/543)
+
+**Merged pull requests:**
+
+- Improve Readme description of v3 job preservation defaults [\#670](https://github.com/bensheldon/good_job/pull/670) ([bensheldon](https://github.com/bensheldon))
+- update Gemfile.lock to latest dependencies [\#647](https://github.com/bensheldon/good_job/pull/647) ([jrochkind](https://github.com/jrochkind))
+
 ## [v3.2.0](https://github.com/bensheldon/good_job/tree/v3.2.0) (2022-07-12)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.1.0...v3.2.0)
 
-**Merged pull requests:**
+**Implemented enhancements:**
 
 - Ordered queue handling by workers [\#665](https://github.com/bensheldon/good_job/pull/665) ([jrochkind](https://github.com/jrochkind))
 
@@ -14,7 +70,9 @@
 
 **Implemented enhancements:**
 
+- Show job/cron/process counts in the Navbar [\#663](https://github.com/bensheldon/good_job/pull/663) ([bensheldon](https://github.com/bensheldon))
 - Improve Dashboard display of parameters \(CronEntry kwargs; Process configuration; Job and Execution database values\) [\#662](https://github.com/bensheldon/good_job/pull/662) ([bensheldon](https://github.com/bensheldon))
+- Dequeing should be first-in first-out [\#651](https://github.com/bensheldon/good_job/pull/651) ([jrochkind](https://github.com/jrochkind))
 
 **Fixed bugs:**
 
@@ -27,11 +85,6 @@
 - Cron schedule page in dashboard not showing kwargs [\#608](https://github.com/bensheldon/good_job/issues/608)
 - Paralelism x database connections [\#569](https://github.com/bensheldon/good_job/issues/569)
 
-**Merged pull requests:**
-
-- Show job/cron/process counts in the Navbar [\#663](https://github.com/bensheldon/good_job/pull/663) ([bensheldon](https://github.com/bensheldon))
-- Dequeing should be first-in first-out [\#651](https://github.com/bensheldon/good_job/pull/651) ([jrochkind](https://github.com/jrochkind))
-
 ## [v3.0.2](https://github.com/bensheldon/good_job/tree/v3.0.2) (2022-07-10)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.0.1...v3.0.2)
@@ -61,13 +114,16 @@
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.0.0...v3.0.1)
 
+**Fixed bugs:**
+
+- Fix `GoodJob.cleanup_preserved_jobs` to use `delete_all` instead of `destroy_all` [\#652](https://github.com/bensheldon/good_job/pull/652) ([bensheldon](https://github.com/bensheldon))
+
 **Closed issues:**
 
 - ERROR:  relation "good\_jobs" does not exist at character 454 [\#308](https://github.com/bensheldon/good_job/issues/308)
 
 **Merged pull requests:**
 
-- Fix `GoodJob.cleanup_preserved_jobs` to use `delete_all` instead of `destroy_all` [\#652](https://github.com/bensheldon/good_job/pull/652) ([bensheldon](https://github.com/bensheldon))
 - Create codeql-analysis.yml [\#648](https://github.com/bensheldon/good_job/pull/648) ([bensheldon](https://github.com/bensheldon))
 
 ## [v3.0.0](https://github.com/bensheldon/good_job/tree/v3.0.0) (2022-06-26)
@@ -1055,7 +1111,6 @@
 - PgBouncer and prepared statements [\#269](https://github.com/bensheldon/good_job/issues/269)
 - Question about locking internals [\#212](https://github.com/bensheldon/good_job/issues/212)
 - Encoding::UndefinedConversionError \("\xE2" from ASCII-8BIT to UTF-8\) [\#198](https://github.com/bensheldon/good_job/issues/198)
-- tools for managing a 'fleet' of processes [\#150](https://github.com/bensheldon/good_job/issues/150)
 
 **Merged pull requests:**
 

data/README.md

@@ -117,7 +117,7 @@ For more of the story of GoodJob, read the [introductory blog post](https://isla
     YourJob.set(queue: :some_queue, wait: 5.minutes, priority: 10).perform_later
     ```
 
-1. In development, GoodJob executes jobs immediately in a separate thread (async mode). In production, GoodJob provides different options:
+1. In development, GoodJob executes jobs immediately in a separate thread ("async" mode). In production, GoodJob provides different options:
 
     - By default, GoodJob separates job enqueuing from job execution so that jobs can be scaled independently of the web server.  Use the GoodJob command-line tool to execute jobs:
 
@@ -199,7 +199,7 @@ Usage:
   good_job cleanup_preserved_jobs
 
 Options:
-  [--before-seconds-ago=SECONDS] # Destroy records finished more than this many seconds ago (env var:  GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO, default: 86400)
+  [--before-seconds-ago=SECONDS] # Destroy records finished more than this many seconds ago (env var:  GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO, default: 1209600 (14 days))
 
 Destroys preserved job records.
 
@@ -226,6 +226,8 @@ GoodJob configuration can be placed within Rails `config` directory for all envi
 Configuration examples:
 
 ```ruby
+# config/initializers/good_job.rb OR config/application.rb OR config/environments/{RAILS_ENV}.rb
+
 Rails.application.configure do
   # Configure options individually...
   config.good_job.preserve_job_records = true
@@ -275,9 +277,9 @@ Available configuration options are:
 - `enable_cron` (boolean) whether to run cron process. Defaults to `false`. You can also set this with the environment variable `GOOD_JOB_ENABLE_CRON`.
 - `cron` (hash) cron configuration. Defaults to `{}`. You can also set this as a JSON string with the environment variable `GOOD_JOB_CRON`
 - `cleanup_discarded_jobs` (boolean) whether to destroy discarded jobs when cleaning up preserved jobs using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `true`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_DISCARDED_JOBS`. _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
-- `cleanup_preserved_jobs_before_seconds_ago` (integer) number of seconds to preserve jobs when using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `86400` (1 day). Can also be set with  the environment variable `GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO`.  _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
-- `cleanup_interval_jobs` (integer) Number of jobs a Scheduler will execute before cleaning up preserved jobs. Defaults to `nil`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_JOBS`.
-- `cleanup_interval_seconds` (integer) Number of seconds a Scheduler will wait before cleaning up preserved jobs. Defaults to `nil`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_SECONDS`.
+- `cleanup_preserved_jobs_before_seconds_ago` (integer) number of seconds to preserve jobs when using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `1209600` (14 days). Can also be set with  the environment variable `GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO`.  _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
+- `cleanup_interval_jobs` (integer) Number of jobs a Scheduler will execute before cleaning up preserved jobs. Defaults to `1000`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_JOBS`.
+- `cleanup_interval_seconds` (integer) Number of seconds a Scheduler will wait before cleaning up preserved jobs. Defaults to `600` (10 minutes). Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_SECONDS`.
 - `inline_execution_respects_schedule` (boolean) Opt-in to future behavior of inline execution respecting scheduled jobs. Defaults to `false`.
 - `logger` ([Rails Logger](https://api.rubyonrails.org/classes/ActiveSupport/Logger.html)) lets you set a custom logger for GoodJob. It should be an instance of a Rails `Logger` (Default: `Rails.logger`).
 - `preserve_job_records` (boolean) keeps job records in your database even after jobs are completed. (Default: `true`)
@@ -310,21 +312,21 @@ config.good_job.execution_mode = :external
 Good Job’s general behavior can also be configured via attributes directly on the `GoodJob` module:
 
 - **`GoodJob.active_record_parent_class`** (string) The ActiveRecord parent class inherited by GoodJob's ActiveRecord model `GoodJob::Job` (defaults to `"ActiveRecord::Base"`). Configure this when using [multiple databases with ActiveRecord](https://guides.rubyonrails.org/active_record_multiple_databases.html) or when other custom configuration is necessary for the ActiveRecord model to connect to the Postgres database. _The value must be a String to avoid premature initialization of ActiveRecord._
-- **`GoodJob.logger`** ([Rails Logger](https://api.rubyonrails.org/classes/ActiveSupport/Logger.html)) lets you set a custom logger for GoodJob. It should be an instance of a Rails `Logger`.
-- **`GoodJob.preserve_job_records`** (boolean) keeps job records in your database even after jobs are completed. (Default: `true`)
-- **`GoodJob.retry_on_unhandled_error`** (boolean) causes jobs to be re-queued and retried if they raise an instance of `StandardError`. Be advised this may lead to jobs being repeated infinitely ([see below for more on retries](#retries)). Instances of `Exception`, like SIGINT, will *always* be retried, regardless of this attribute’s value. (Default: `false`)
-- **`GoodJob.on_thread_error`** (proc, lambda, or callable) will be called when an Exception. It can be useful for logging errors to bug tracking services, like Sentry or Airbrake.
 
 You’ll generally want to configure these in `config/initializers/good_job.rb`, like so:
 
 ```ruby
 # config/initializers/good_job.rb
 GoodJob.active_record_parent_class = "ApplicationRecord"
-GoodJob.preserve_job_records = true
-GoodJob.retry_on_unhandled_error = false
-GoodJob.on_thread_error = -> (exception) { Raven.capture_exception(exception) }
 ```
 
+The following options are also configurable via accessors, but you are encouraged to use the configuration attributes instead because these may be deprecated and removed in the future:
+
+- **`GoodJob.logger`** ([Rails Logger](https://api.rubyonrails.org/classes/ActiveSupport/Logger.html)) lets you set a custom logger for GoodJob. It should be an instance of a Rails `Logger`.
+- **`GoodJob.preserve_job_records`** (boolean) keeps job records in your database even after jobs are completed. (Default: `true`)
+- **`GoodJob.retry_on_unhandled_error`** (boolean) causes jobs to be re-queued and retried if they raise an instance of `StandardError`. Be advised this may lead to jobs being repeated infinitely ([see below for more on retries](#retries)). Instances of `Exception`, like SIGINT, will *always* be retried, regardless of this attribute’s value. (Default: `false`)
+- **`GoodJob.on_thread_error`** (proc, lambda, or callable) will be called when an Exception. It can be useful for logging errors to bug tracking services, like Sentry or Airbrake.
+
 ### Dashboard
 
 ![Dashboard UI](https://github.com/bensheldon/good_job/raw/main/SCREENSHOT.png)
@@ -361,14 +363,7 @@ GoodJob includes a Dashboard as a mountable `Rails::Engine`.
     end
     ```
 
-1. If you want to see finished (successful) and discarded (failed) jobs on the dashboard, you will have to configure job records to be preserved:
-
-    ```ruby
-    # eg in config/initializers/good_job.rb
-    GoodJob.preserve_job_records = true
-    ```
-
-    See more at [Monitor and preserve worked jobs](#monitor-and-preserve-worked-jobs)
+_To view finished (successful) and discarded (failed) jobs on the Dashboard, GoodJob must be configured to preserve job records. Preservation is enabled by default._
 
 **Troubleshooting the Dashboard:** Some applications are unable to autoload the Goodjob Engine. To work around this, explicitly require the Engine at the top of your `config/application.rb` file, immediately after Rails is required and before Bundler requires the Rails' groups.
 
@@ -878,25 +873,24 @@ If your application is already using an ActiveJob backend, you will need to inst
 
 GoodJob is fully instrumented with [`ActiveSupport::Notifications`](https://edgeguides.rubyonrails.org/active_support_instrumentation.html#introduction-to-instrumentation).
 
-By default, GoodJob will preserve job records for 14 days after they are run, regardless of whether they succeed or not (raising a kind of `StandardError`), unless they are interrupted (raising a kind of `Exception`).
+By default, GoodJob will preserve job records for 14 days after they are run, regardless of whether they succeed or raised an exception.
 
-To not preserve job records for later inspection, set an initializer:
+To instead delete job records immediately after they are finished:
 
 ```ruby
 # config/initializers/good_job.rb
-GoodJob.preserve_job_records = false # defaults to true, or `false` or `:on_unhandled_error`
+config.good_job.preserve_job_records = false # defaults to true; can also be `false` or `:on_unhandled_error`
 ```
 
-GoodJob will automatically delete these job records after 14 days. The retention period, as well as the frequency GoodJob checks for deletable records can be configured:
+GoodJob will automatically delete preserved job records after 14 days. The retention period, as well as the frequency GoodJob checks for deletable records can be configured:
 
 ```ruby
-
-config.cleanup_preserved_jobs_before_seconds_ago = 14.days.to_i
-config.cleanup_interval_jobs = 1_000 # Number of executed jobs between deletion sweeps.
-config.cleanup_interval_seconds = 10.minutes.to_i # Number of seconds between deletion sweeps.
+config.good_job.cleanup_preserved_jobs_before_seconds_ago = 14.days.to_i
+config.good_job.cleanup_interval_jobs = 1_000 # Number of executed jobs between deletion sweeps.
+config.good_job.cleanup_interval_seconds = 10.minutes.to_i # Number of seconds between deletion sweeps.
 ```
 
-It is also possible to manually trigger a cleanup:
+It is also possible to manually trigger a cleanup of preserved job records:
 
 - For example, in a Rake task:
 
@@ -1041,7 +1035,7 @@ For gem development and debugging information, please review the [README's Gem D
 # Clone the repository locally
 git clone git@github.com:bensheldon/good_job.git
 
-# Set up the local environment
+# Set up the gem development environment
 bin/setup
 ```
 
@@ -1080,6 +1074,10 @@ bundle install
 Tests can be run against the primary development environment:
 
 ```bash
+# Set up the gem development environment
+bin/setup
+
+# Run the tests
 bin/rspec
 ```
 

data/app/assets/good_job/modules/application.js

@@ -4,11 +4,13 @@ import renderCharts from "charts";
 import checkboxToggle from "checkbox_toggle";
 import documentReady from "document_ready";
 import showToasts from "toasts";
+import setupPopovers from "popovers";
 import LivePoll from "live_poll";
 
 documentReady(function() {
   renderCharts();
   showToasts();
+  setupPopovers();
   checkboxToggle();
 
   const livePoll = new LivePoll

data/app/assets/good_job/modules/popovers.js

@@ -0,0 +1,7 @@
+export default function() {
+  document.querySelectorAll('[data-bs-toggle="popover"]').forEach((el) => {
+    new bootstrap.Popover(el, {
+      template: '<div class="popover" role="tooltip"><div class="popover-arrow"></div><h3 class="popover-header"></h3><pre class="popover-body text-wrap text-break"></pre></div>'
+    })
+  })
+}

data/app/assets/good_job/style.css

@@ -39,3 +39,7 @@
   background-color: red;
   color: white;
 }
+
+.btn-outline-secondary {
+  border-color: #ced4da; /* $gray-400 */
+}

data/app/helpers/good_job/application_helper.rb

@@ -34,8 +34,8 @@ module GoodJob
     STATUS_COLOR = {
       discarded: "danger",
       finished: "success",
-      queued: "warning",
-      retried: "secondary",
+      queued: "secondary",
+      retried: "warning",
       running: "primary",
       scheduled: "secondary",
     }.freeze

data/app/models/concerns/good_job/reportable.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+module GoodJob
+  module Reportable
+    # There are 3 buckets of non-overlapping statuses:
+    #   1. The job will be executed
+    #     - queued: The job will execute immediately when an execution thread becomes available.
+    #     - scheduled: The job is scheduled to execute in the future.
+    #     - retried: The job previously errored on execution and will be re-executed in the future.
+    #   2. The job is being executed
+    #     - running: the job is actively being executed by an execution thread
+    #   3. The job will not execute
+    #     - finished: The job executed successfully
+    #     - discarded: The job previously errored on execution and will not be re-executed in the future.
+    #
+    # @return [Symbol]
+    def status
+      if finished_at.present?
+        if error.present? && retried_good_job_id.present?
+          :retried
+        elsif error.present? && retried_good_job_id.nil?
+          :discarded
+        else
+          :finished
+        end
+      elsif (scheduled_at || created_at) > DateTime.current
+        if serialized_params.fetch('executions', 0) > 1
+          :retried
+        else
+          :scheduled
+        end
+      elsif running?
+        :running
+      else
+        :queued
+      end
+    end
+
+    # The last relevant timestamp for this execution
+    def last_status_at
+      finished_at || performed_at || scheduled_at || created_at
+    end
+  end
+end

data/{lib → app}/models/good_job/cron_entry.rb

@@ -13,7 +13,7 @@ module GoodJob # :nodoc:
     attr_reader :params
 
     def self.all(configuration: nil)
-      configuration ||= GoodJob::Configuration.new({})
+      configuration ||= GoodJob.configuration
       configuration.cron_entries
     end
 

data/{lib → app}/models/good_job/execution.rb

@@ -4,6 +4,7 @@ module GoodJob
   class Execution < BaseRecord
     include Lockable
     include Filterable
+    include Reportable
 
     # Raised if something attempts to execute a previously completed Execution again.
     PreviouslyPerformedError = Class.new(StandardError)
@@ -312,40 +313,6 @@ module GoodJob
       end
     end
 
-    # There are 3 buckets of non-overlapping statuses:
-    #   1. The job will be executed
-    #     - queued: The job will execute immediately when an execution thread becomes available.
-    #     - scheduled: The job is scheduled to execute in the future.
-    #     - retried: The job previously errored on execution and will be re-executed in the future.
-    #   2. The job is being executed
-    #     - running: the job is actively being executed by an execution thread
-    #   3. The job will not execute
-    #     - finished: The job executed successfully
-    #     - discarded: The job previously errored on execution and will not be re-executed in the future.
-    #
-    # @return [Symbol]
-    def status
-      if finished_at.present?
-        if error.present? && retried_good_job_id.present?
-          :retried
-        elsif error.present? && retried_good_job_id.nil?
-          :discarded
-        else
-          :finished
-        end
-      elsif (scheduled_at || created_at) > DateTime.current
-        if serialized_params.fetch('executions', 0) > 1
-          :retried
-        else
-          :scheduled
-        end
-      elsif running?
-        :running
-      else
-        :queued
-      end
-    end
-
     # Return formatted serialized_params for display in the dashboard
     # @return [Hash]
     def display_serialized_params
@@ -366,11 +333,6 @@ module GoodJob
       serialized_params.fetch('executions', 0) + 1
     end
 
-    # The last relevant timestamp for this execution
-    def last_status_at
-      finished_at || performed_at || scheduled_at || created_at
-    end
-
     # Time between when this job was expected to run and when it started running
     def queue_latency
       now = Time.zone.now

data/{lib → app}/models/good_job/job.rb

@@ -8,6 +8,7 @@ module GoodJob
   class Job < BaseRecord
     include Filterable
     include Lockable
+    include Reportable
 
     # Raised when an inappropriate action is applied to a Job based on its state.
     ActionForStateMismatchError = Class.new(StandardError)
@@ -27,7 +28,7 @@ module GoodJob
     self.primary_key = 'active_job_id'
     self.advisory_lockable_column = 'active_job_id'
 
-    has_many :executions, -> { order(created_at: :asc) }, class_name: 'GoodJob::Execution', foreign_key: 'active_job_id', inverse_of: :job
+    has_many :executions, -> { order(created_at: :asc) }, class_name: 'GoodJob::Execution', foreign_key: 'active_job_id', inverse_of: :job # rubocop:disable Rails/HasManyOrHasOneDependent
 
     # Only the most-recent unretried execution represents a "Job"
     default_scope { where(retried_good_job_id: nil) }
@@ -73,32 +74,6 @@ module GoodJob
       serialized_params['job_class']
     end
 
-    def last_status_at
-      finished_at || performed_at || scheduled_at || created_at
-    end
-
-    def status
-      if finished_at.present?
-        if error.present? && retried_good_job_id.present?
-          :retried
-        elsif error.present? && retried_good_job_id.nil?
-          :discarded
-        else
-          :finished
-        end
-      elsif (scheduled_at || created_at) > DateTime.current
-        if serialized_params.fetch('executions', 0) > 1
-          :retried
-        else
-          :scheduled
-        end
-      elsif running?
-        :running
-      else
-        :queued
-      end
-    end
-
     # Override #reload to add a custom scope to ensure the reloaded record is the head execution
     # @return [Job]
     def reload(options = nil)

data/{lib → app}/models/good_job/process.rb

@@ -71,5 +71,9 @@ module GoodJob # :nodoc:
       destroy!
       advisory_unlock
     end
+
+    def basename
+      File.basename(state["proctitle"])
+    end
   end
 end

data/app/views/good_job/cron_entries/index.html.erb

@@ -1,61 +1,64 @@
-<div class="my-3 flex">
-  <h2>Cron Schedules</h2>
+<div class="bg-light break-out border-bottom">
+  <h2 class="container-fluid pt-3 pb-2">Cron Schedules</h2>
 </div>
 
-<% if @cron_entries.present? %>
-  <div class="card my-3">
-    <div class="table-responsive">
-      <table class="table card-table table-bordered table-hover table-sm mb-0">
-        <thead>
-          <th>Key</th>
-          <th>Schedule</th>
-          <th>
-            Properties
-            <%= tag.button "Toggle", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
-                           data: { bs_toggle: "collapse", bs_target: ".cron-entry-properties" },
-                           aria: { expanded: false, controls: @cron_entries.map { |cron_entry| "##{dom_id(cron_entry, 'properties')}" }.join(" ") }
-            %>
-          </th>
-          <th>Description</th>
-          <th>Next scheduled</th>
-          <th>Last run</th>
-          <th>Actions</th>
-        </thead>
-        <tbody>
-          <% @cron_entries.each do |cron_entry| %>
-            <tr id="<%= dom_id(cron_entry) %>">
-              <td class="font-monospace"><%= cron_entry.key %></td>
-              <td class="font-monospace"><%= cron_entry.schedule %></td>
-              <td>
-                <%= tag.button("Inspect", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
-                        data: { bs_toggle: "collapse", bs_target: "##{dom_id(cron_entry, 'properties')}" },
-                        aria: { expanded: false, controls: dom_id(cron_entry, 'properties') }) %>
-                <%= tag.pre(JSON.pretty_generate(cron_entry.display_properties), id: dom_id(cron_entry, 'properties'), class: "collapse cron-entry-properties") %>
-              </td>
-              <td><%= cron_entry.description %></td>
-              <td><%= cron_entry.next_at %></td>
-              <td>
-                <% if cron_entry.last_job.present? %>
-                  <%= link_to cron_entry.last_at, cron_entry_path(cron_entry), title: "Job #{cron_entry.last_job.id}" %>
-                <% end %>
-              </td>
-              <td>
-                <%= button_to enqueue_cron_entry_path(cron_entry.id), method: :post, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Run cron entry now" }, title: "Run cron entry now", data: { confirm: "Confirm run cron entry now" } do %>
-                  <%= render "good_job/shared/icons/play" %>
-                <% end %>
-              </td>
-            </tr>
+<div class="card my-3">
+  <div class="list-group list-group-flush text-nowrap" role="table">
+    <header class="list-group-item bg-light">
+      <div class="row small text-muted text-uppercase align-items-center">
+        <div class="col"></div>
+        <div class="col">Class</div>
+        <div class="col">Schedule</div>
+        <div class="col">Next scheduled</div>
+        <div class="col">Last run</div>
+        <div class="col text-end">
+          <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
+                         data: { bs_toggle: "collapse", bs_target: ".cron-entry-properties" },
+                         aria: { expanded: false, controls: @cron_entries.map { |cron_entry| "##{dom_id(cron_entry, 'properties')}" }.join(" ") } do %>
+            <%= render_icon "info" %>
+            <span class="visually-hidden">Inspect</span>
           <% end %>
-        </tbody>
-      </table>
-    </div>
+        </div>
+      </div>
+    </header>
+    <% @cron_entries.each do |cron_entry| %>
+      <div id="<%= dom_id(cron_entry) %>" class="list-group-item py-3" role="row">
+        <div class="row align-items-center">
+          <div class="col">
+            <div class="small font-monospace"><%= cron_entry.key %></div>
+            <div class="small text-muted"><%= cron_entry.description %></div>
+          </div>
+          <div class="col"><%= tag.span tag.code(cron_entry.job_class), class: "fs-5 mb-0" %></div>
+          <div class="col font-monospace fw-bold"><%= cron_entry.schedule %></div>
+          <div class="col small"><%= relative_time cron_entry.next_at %></div>
+          <div class="col small">
+            <% if cron_entry.last_job.present? %>
+              <%= link_to relative_time(cron_entry.last_at), cron_entry_path(cron_entry), title: "Job #{cron_entry.last_job.id}" %>
+            <% end %>
+          </div>
+          <div class="col d-flex gap-3 justify-content-end">
+            <%= button_to enqueue_cron_entry_path(cron_entry.id), method: :post, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Run cron entry now" }, title: "Run cron entry now", data: { confirm: "Confirm run cron entry now" } do %>
+              <%= render "good_job/shared/icons/play" %>
+              Run Now
+            <% end %>
+            <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
+                           title: "Inspect",
+                           data: { bs_toggle: "collapse", bs_target: "##{dom_id(cron_entry, 'properties')}" },
+                           aria: { expanded: false, controls: dom_id(cron_entry, "properties") } do %>
+              <%= render_icon "info" %>
+              <span class="visually-hidden">Inspect</span>
+            <% end %>
+          </div>
+        </div>
+      </div>
+      <%= tag.div id: dom_id(cron_entry, 'properties'), class: "collapse cron-entry-properties list-group-item collapse small bg-dark text-light" do %>
+        <%= tag.pre JSON.pretty_generate(cron_entry.display_properties) %>
+      <% end %>
+    <% end %>
+    <% if @cron_entries.empty? %>
+      <div class="list-group-item py-4 text-center text-muted">
+        No cron schedules found.
+      </div>
+    <% end %>
   </div>
-<% else %>
-  <div class="card my-3">
-    <div class="card-body">
-      <p class="card-text">
-        <em>No cron schedules found.</em>
-      </p>
-    </div>
-  </div>
-<% end %>
+</div>