good_job 3.2.0 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9ecbb75f2764a72686acb96367389abb1900321b5cf1292d6522aa8094c68451
-  data.tar.gz: 43a5305a9f2610c1544d6e52c61f0b338771b07d92d6493fed0058ad33bbc045
+  metadata.gz: 2225caa419c57cd76c9acba358fa94e2fd2d29c914d25459093a5a65b785087d
+  data.tar.gz: 2c6af031bb80859108ed847a7d891a2066b06004edb518fa8921b01b3c9b662a
 SHA512:
-  metadata.gz: 0e637579c190a3f3d1aba6c02f6a71e2193d9e5c4bb449a3d4d9571093150a25a1c293ac3f5c541d2fae09aeffff771692fa7ef58bc8ed672f61a2c9d35a7e74
-  data.tar.gz: bc669b4d1628f7ff4b885787c65a38a57ad020aa168c3ae85f0c6bb26c9f0e19b64947682b0c99cf3eb28c2d660e1d79ee6095000a72340f09229d1679fa5dfe
+  metadata.gz: 00bfcfcf22a4f3e5138bc2d85a172bbf4c74515c38759af561567c42f5464825fd47aa3f5c369f91196ede2b73211c9e1b3422f5d555bcff439e7fd32fc9db1a
+  data.tar.gz: cc28292dd555ddd951ab465534302f0775784074e456bb181eb2f5efc07f4281bcd49783fa38e4a205591fb05daa19f88ff013995fe06fe3761e675b1e84e0ba

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## [v3.3.0](https://github.com/bensheldon/good_job/tree/v3.3.0) (2022-07-24)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.2.0...v3.3.0)
+
+**Closed issues:**
+
+- Calculating database connections [\#669](https://github.com/bensheldon/good_job/issues/669)
+- Unable to Replace GoodJob's Logger [\#667](https://github.com/bensheldon/good_job/issues/667)
+- Readme should consistently encourage usage of `config.good_job....` instead of `GoodJob.` configuration [\#628](https://github.com/bensheldon/good_job/issues/628)
+- Improve the "Gem development" section of README? [\#551](https://github.com/bensheldon/good_job/issues/551)
+- Simplify Rails initialization to only be a mountable Engine [\#543](https://github.com/bensheldon/good_job/issues/543)
+
+**Merged pull requests:**
+
+- Dashboard: Update cron and processes to match jobs listing [\#676](https://github.com/bensheldon/good_job/pull/676) ([bkeepers](https://github.com/bkeepers))
+- Dashboard: improvements to jobs index and show pages [\#672](https://github.com/bensheldon/good_job/pull/672) ([bkeepers](https://github.com/bkeepers))
+- Replace "timestamp" column-type in migrations with "datetime" [\#671](https://github.com/bensheldon/good_job/pull/671) ([bensheldon](https://github.com/bensheldon))
+- Improve Readme description of v3 job preservation defaults [\#670](https://github.com/bensheldon/good_job/pull/670) ([bensheldon](https://github.com/bensheldon))
+- update Gemfile.lock to latest dependencies [\#647](https://github.com/bensheldon/good_job/pull/647) ([jrochkind](https://github.com/jrochkind))
+
 ## [v3.2.0](https://github.com/bensheldon/good_job/tree/v3.2.0) (2022-07-12)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.1.0...v3.2.0)
@@ -1055,7 +1075,6 @@
 - PgBouncer and prepared statements [\#269](https://github.com/bensheldon/good_job/issues/269)
 - Question about locking internals [\#212](https://github.com/bensheldon/good_job/issues/212)
 - Encoding::UndefinedConversionError \("\xE2" from ASCII-8BIT to UTF-8\) [\#198](https://github.com/bensheldon/good_job/issues/198)
-- tools for managing a 'fleet' of processes [\#150](https://github.com/bensheldon/good_job/issues/150)
 
 **Merged pull requests:**
 

data/README.md

@@ -117,7 +117,7 @@ For more of the story of GoodJob, read the [introductory blog post](https://isla
     YourJob.set(queue: :some_queue, wait: 5.minutes, priority: 10).perform_later
     ```
 
-1. In development, GoodJob executes jobs immediately in a separate thread (async mode). In production, GoodJob provides different options:
+1. In development, GoodJob executes jobs immediately in a separate thread ("async" mode). In production, GoodJob provides different options:
 
     - By default, GoodJob separates job enqueuing from job execution so that jobs can be scaled independently of the web server.  Use the GoodJob command-line tool to execute jobs:
 
@@ -199,7 +199,7 @@ Usage:
   good_job cleanup_preserved_jobs
 
 Options:
-  [--before-seconds-ago=SECONDS] # Destroy records finished more than this many seconds ago (env var:  GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO, default: 86400)
+  [--before-seconds-ago=SECONDS] # Destroy records finished more than this many seconds ago (env var:  GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO, default: 1209600 (14 days))
 
 Destroys preserved job records.
 
@@ -226,6 +226,8 @@ GoodJob configuration can be placed within Rails `config` directory for all envi
 Configuration examples:
 
 ```ruby
+# config/initializers/good_job.rb OR config/application.rb OR config/environments/{RAILS_ENV}.rb
+
 Rails.application.configure do
   # Configure options individually...
   config.good_job.preserve_job_records = true
@@ -275,9 +277,9 @@ Available configuration options are:
 - `enable_cron` (boolean) whether to run cron process. Defaults to `false`. You can also set this with the environment variable `GOOD_JOB_ENABLE_CRON`.
 - `cron` (hash) cron configuration. Defaults to `{}`. You can also set this as a JSON string with the environment variable `GOOD_JOB_CRON`
 - `cleanup_discarded_jobs` (boolean) whether to destroy discarded jobs when cleaning up preserved jobs using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `true`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_DISCARDED_JOBS`. _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
-- `cleanup_preserved_jobs_before_seconds_ago` (integer) number of seconds to preserve jobs when using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `86400` (1 day). Can also be set with  the environment variable `GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO`.  _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
-- `cleanup_interval_jobs` (integer) Number of jobs a Scheduler will execute before cleaning up preserved jobs. Defaults to `nil`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_JOBS`.
-- `cleanup_interval_seconds` (integer) Number of seconds a Scheduler will wait before cleaning up preserved jobs. Defaults to `nil`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_SECONDS`.
+- `cleanup_preserved_jobs_before_seconds_ago` (integer) number of seconds to preserve jobs when using the `$ good_job cleanup_preserved_jobs` CLI command or calling `GoodJob.cleanup_preserved_jobs`. Defaults to `1209600` (14 days). Can also be set with  the environment variable `GOOD_JOB_CLEANUP_PRESERVED_JOBS_BEFORE_SECONDS_AGO`.  _This configuration is only used when {GoodJob.preserve_job_records} is `true`._
+- `cleanup_interval_jobs` (integer) Number of jobs a Scheduler will execute before cleaning up preserved jobs. Defaults to `1000`. Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_JOBS`.
+- `cleanup_interval_seconds` (integer) Number of seconds a Scheduler will wait before cleaning up preserved jobs. Defaults to `600` (10 minutes). Can also be set with  the environment variable `GOOD_JOB_CLEANUP_INTERVAL_SECONDS`.
 - `inline_execution_respects_schedule` (boolean) Opt-in to future behavior of inline execution respecting scheduled jobs. Defaults to `false`.
 - `logger` ([Rails Logger](https://api.rubyonrails.org/classes/ActiveSupport/Logger.html)) lets you set a custom logger for GoodJob. It should be an instance of a Rails `Logger` (Default: `Rails.logger`).
 - `preserve_job_records` (boolean) keeps job records in your database even after jobs are completed. (Default: `true`)
@@ -310,21 +312,21 @@ config.good_job.execution_mode = :external
 Good Job’s general behavior can also be configured via attributes directly on the `GoodJob` module:
 
 - **`GoodJob.active_record_parent_class`** (string) The ActiveRecord parent class inherited by GoodJob's ActiveRecord model `GoodJob::Job` (defaults to `"ActiveRecord::Base"`). Configure this when using [multiple databases with ActiveRecord](https://guides.rubyonrails.org/active_record_multiple_databases.html) or when other custom configuration is necessary for the ActiveRecord model to connect to the Postgres database. _The value must be a String to avoid premature initialization of ActiveRecord._
-- **`GoodJob.logger`** ([Rails Logger](https://api.rubyonrails.org/classes/ActiveSupport/Logger.html)) lets you set a custom logger for GoodJob. It should be an instance of a Rails `Logger`.
-- **`GoodJob.preserve_job_records`** (boolean) keeps job records in your database even after jobs are completed. (Default: `true`)
-- **`GoodJob.retry_on_unhandled_error`** (boolean) causes jobs to be re-queued and retried if they raise an instance of `StandardError`. Be advised this may lead to jobs being repeated infinitely ([see below for more on retries](#retries)). Instances of `Exception`, like SIGINT, will *always* be retried, regardless of this attribute’s value. (Default: `false`)
-- **`GoodJob.on_thread_error`** (proc, lambda, or callable) will be called when an Exception. It can be useful for logging errors to bug tracking services, like Sentry or Airbrake.
 
 You’ll generally want to configure these in `config/initializers/good_job.rb`, like so:
 
 ```ruby
 # config/initializers/good_job.rb
 GoodJob.active_record_parent_class = "ApplicationRecord"
-GoodJob.preserve_job_records = true
-GoodJob.retry_on_unhandled_error = false
-GoodJob.on_thread_error = -> (exception) { Raven.capture_exception(exception) }
 ```
 
+The following options are also configurable via accessors, but you are encouraged to use the configuration attributes instead because these may be deprecated and removed in the future:
+
+- **`GoodJob.logger`** ([Rails Logger](https://api.rubyonrails.org/classes/ActiveSupport/Logger.html)) lets you set a custom logger for GoodJob. It should be an instance of a Rails `Logger`.
+- **`GoodJob.preserve_job_records`** (boolean) keeps job records in your database even after jobs are completed. (Default: `true`)
+- **`GoodJob.retry_on_unhandled_error`** (boolean) causes jobs to be re-queued and retried if they raise an instance of `StandardError`. Be advised this may lead to jobs being repeated infinitely ([see below for more on retries](#retries)). Instances of `Exception`, like SIGINT, will *always* be retried, regardless of this attribute’s value. (Default: `false`)
+- **`GoodJob.on_thread_error`** (proc, lambda, or callable) will be called when an Exception. It can be useful for logging errors to bug tracking services, like Sentry or Airbrake.
+
 ### Dashboard
 
 ![Dashboard UI](https://github.com/bensheldon/good_job/raw/main/SCREENSHOT.png)
@@ -361,14 +363,7 @@ GoodJob includes a Dashboard as a mountable `Rails::Engine`.
     end
     ```
 
-1. If you want to see finished (successful) and discarded (failed) jobs on the dashboard, you will have to configure job records to be preserved:
-
-    ```ruby
-    # eg in config/initializers/good_job.rb
-    GoodJob.preserve_job_records = true
-    ```
-
-    See more at [Monitor and preserve worked jobs](#monitor-and-preserve-worked-jobs)
+_To view finished (successful) and discarded (failed) jobs on the Dashboard, GoodJob must be configured to preserve job records. Preservation is enabled by default._
 
 **Troubleshooting the Dashboard:** Some applications are unable to autoload the Goodjob Engine. To work around this, explicitly require the Engine at the top of your `config/application.rb` file, immediately after Rails is required and before Bundler requires the Rails' groups.
 
@@ -878,25 +873,24 @@ If your application is already using an ActiveJob backend, you will need to inst
 
 GoodJob is fully instrumented with [`ActiveSupport::Notifications`](https://edgeguides.rubyonrails.org/active_support_instrumentation.html#introduction-to-instrumentation).
 
-By default, GoodJob will preserve job records for 14 days after they are run, regardless of whether they succeed or not (raising a kind of `StandardError`), unless they are interrupted (raising a kind of `Exception`).
+By default, GoodJob will preserve job records for 14 days after they are run, regardless of whether they succeed or raised an exception.
 
-To not preserve job records for later inspection, set an initializer:
+To instead delete job records immediately after they are finished:
 
 ```ruby
 # config/initializers/good_job.rb
-GoodJob.preserve_job_records = false # defaults to true, or `false` or `:on_unhandled_error`
+config.good_job.preserve_job_records = false # defaults to true; can also be `false` or `:on_unhandled_error`
 ```
 
-GoodJob will automatically delete these job records after 14 days. The retention period, as well as the frequency GoodJob checks for deletable records can be configured:
+GoodJob will automatically delete preserved job records after 14 days. The retention period, as well as the frequency GoodJob checks for deletable records can be configured:
 
 ```ruby
-
-config.cleanup_preserved_jobs_before_seconds_ago = 14.days.to_i
-config.cleanup_interval_jobs = 1_000 # Number of executed jobs between deletion sweeps.
-config.cleanup_interval_seconds = 10.minutes.to_i # Number of seconds between deletion sweeps.
+config.good_job.cleanup_preserved_jobs_before_seconds_ago = 14.days.to_i
+config.good_job.cleanup_interval_jobs = 1_000 # Number of executed jobs between deletion sweeps.
+config.good_job.cleanup_interval_seconds = 10.minutes.to_i # Number of seconds between deletion sweeps.
 ```
 
-It is also possible to manually trigger a cleanup:
+It is also possible to manually trigger a cleanup of preserved job records:
 
 - For example, in a Rake task:
 
@@ -1041,7 +1035,7 @@ For gem development and debugging information, please review the [README's Gem D
 # Clone the repository locally
 git clone git@github.com:bensheldon/good_job.git
 
-# Set up the local environment
+# Set up the gem development environment
 bin/setup
 ```
 
@@ -1080,6 +1074,10 @@ bundle install
 Tests can be run against the primary development environment:
 
 ```bash
+# Set up the gem development environment
+bin/setup
+
+# Run the tests
 bin/rspec
 ```
 

data/app/assets/good_job/modules/application.js

@@ -4,11 +4,13 @@ import renderCharts from "charts";
 import checkboxToggle from "checkbox_toggle";
 import documentReady from "document_ready";
 import showToasts from "toasts";
+import setupPopovers from "popovers";
 import LivePoll from "live_poll";
 
 documentReady(function() {
   renderCharts();
   showToasts();
+  setupPopovers();
   checkboxToggle();
 
   const livePoll = new LivePoll

data/app/assets/good_job/modules/popovers.js

@@ -0,0 +1,7 @@
+export default function() {
+  document.querySelectorAll('[data-bs-toggle="popover"]').forEach((el) => {
+    new bootstrap.Popover(el, {
+      template: '<div class="popover" role="tooltip"><div class="popover-arrow"></div><h3 class="popover-header"></h3><pre class="popover-body text-wrap text-break"></pre></div>'
+    })
+  })
+}

data/app/assets/good_job/style.css

@@ -39,3 +39,7 @@
   background-color: red;
   color: white;
 }
+
+.btn-outline-secondary {
+  border-color: #ced4da; /* $gray-400 */
+}

data/app/helpers/good_job/application_helper.rb

@@ -34,8 +34,8 @@ module GoodJob
     STATUS_COLOR = {
       discarded: "danger",
       finished: "success",
-      queued: "warning",
-      retried: "secondary",
+      queued: "secondary",
+      retried: "warning",
       running: "primary",
       scheduled: "secondary",
     }.freeze

data/app/views/good_job/cron_entries/index.html.erb

@@ -1,61 +1,64 @@
-<div class="my-3 flex">
-  <h2>Cron Schedules</h2>
+<div class="bg-light break-out border-bottom">
+  <h2 class="container-fluid pt-3 pb-2">Cron Schedules</h2>
 </div>
 
-<% if @cron_entries.present? %>
-  <div class="card my-3">
-    <div class="table-responsive">
-      <table class="table card-table table-bordered table-hover table-sm mb-0">
-        <thead>
-          <th>Key</th>
-          <th>Schedule</th>
-          <th>
-            Properties
-            <%= tag.button "Toggle", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
-                           data: { bs_toggle: "collapse", bs_target: ".cron-entry-properties" },
-                           aria: { expanded: false, controls: @cron_entries.map { |cron_entry| "##{dom_id(cron_entry, 'properties')}" }.join(" ") }
-            %>
-          </th>
-          <th>Description</th>
-          <th>Next scheduled</th>
-          <th>Last run</th>
-          <th>Actions</th>
-        </thead>
-        <tbody>
-          <% @cron_entries.each do |cron_entry| %>
-            <tr id="<%= dom_id(cron_entry) %>">
-              <td class="font-monospace"><%= cron_entry.key %></td>
-              <td class="font-monospace"><%= cron_entry.schedule %></td>
-              <td>
-                <%= tag.button("Inspect", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
-                        data: { bs_toggle: "collapse", bs_target: "##{dom_id(cron_entry, 'properties')}" },
-                        aria: { expanded: false, controls: dom_id(cron_entry, 'properties') }) %>
-                <%= tag.pre(JSON.pretty_generate(cron_entry.display_properties), id: dom_id(cron_entry, 'properties'), class: "collapse cron-entry-properties") %>
-              </td>
-              <td><%= cron_entry.description %></td>
-              <td><%= cron_entry.next_at %></td>
-              <td>
-                <% if cron_entry.last_job.present? %>
-                  <%= link_to cron_entry.last_at, cron_entry_path(cron_entry), title: "Job #{cron_entry.last_job.id}" %>
-                <% end %>
-              </td>
-              <td>
-                <%= button_to enqueue_cron_entry_path(cron_entry.id), method: :post, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Run cron entry now" }, title: "Run cron entry now", data: { confirm: "Confirm run cron entry now" } do %>
-                  <%= render "good_job/shared/icons/play" %>
-                <% end %>
-              </td>
-            </tr>
+<div class="card my-3">
+  <div class="list-group list-group-flush text-nowrap" role="table">
+    <header class="list-group-item bg-light">
+      <div class="row small text-muted text-uppercase align-items-center">
+        <div class="col"></div>
+        <div class="col">Class</div>
+        <div class="col">Schedule</div>
+        <div class="col">Next scheduled</div>
+        <div class="col">Last run</div>
+        <div class="col text-end">
+          <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
+                         data: { bs_toggle: "collapse", bs_target: ".cron-entry-properties" },
+                         aria: { expanded: false, controls: @cron_entries.map { |cron_entry| "##{dom_id(cron_entry, 'properties')}" }.join(" ") } do %>
+            <%= render_icon "info" %>
+            <span class="visually-hidden">Inspect</span>
           <% end %>
-        </tbody>
-      </table>
-    </div>
+        </div>
+      </div>
+    </header>
+    <% @cron_entries.each do |cron_entry| %>
+      <div id="<%= dom_id(cron_entry) %>" class="list-group-item py-3" role="row">
+        <div class="row align-items-center">
+          <div class="col">
+            <div class="small font-monospace"><%= cron_entry.key %></div>
+            <div class="small text-muted"><%= cron_entry.description %></div>
+          </div>
+          <div class="col"><%= tag.span tag.code(cron_entry.job_class), class: "fs-5 mb-0" %></div>
+          <div class="col font-monospace fw-bold"><%= cron_entry.schedule %></div>
+          <div class="col small"><%= relative_time cron_entry.next_at %></div>
+          <div class="col small">
+            <% if cron_entry.last_job.present? %>
+              <%= link_to relative_time(cron_entry.last_at), cron_entry_path(cron_entry), title: "Job #{cron_entry.last_job.id}" %>
+            <% end %>
+          </div>
+          <div class="col d-flex gap-3 justify-content-end">
+            <%= button_to enqueue_cron_entry_path(cron_entry.id), method: :post, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Run cron entry now" }, title: "Run cron entry now", data: { confirm: "Confirm run cron entry now" } do %>
+              <%= render "good_job/shared/icons/play" %>
+              Run Now
+            <% end %>
+            <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
+                           title: "Inspect",
+                           data: { bs_toggle: "collapse", bs_target: "##{dom_id(cron_entry, 'properties')}" },
+                           aria: { expanded: false, controls: dom_id(cron_entry, "properties") } do %>
+              <%= render_icon "info" %>
+              <span class="visually-hidden">Inspect</span>
+            <% end %>
+          </div>
+        </div>
+      </div>
+      <%= tag.div id: dom_id(cron_entry, 'properties'), class: "collapse cron-entry-properties list-group-item collapse small bg-dark text-light" do %>
+        <%= tag.pre JSON.pretty_generate(cron_entry.display_properties) %>
+      <% end %>
+    <% end %>
+    <% if @cron_entries.empty? %>
+      <div class="list-group-item py-4 text-center text-muted">
+        No cron schedules found.
+      </div>
+    <% end %>
   </div>
-<% else %>
-  <div class="card my-3">
-    <div class="card-body">
-      <p class="card-text">
-        <em>No cron schedules found.</em>
-      </p>
-    </div>
-  </div>
-<% end %>
+</div>

data/app/views/good_job/jobs/_executions.erb

@@ -3,43 +3,46 @@
   <div class="list-group list-group-flush">
     <% executions.each do |execution| %>
       <%= tag.div id: dom_id(execution), class: "list-group-item py-3" do %>
-        <div class="d-md-flex">
-          <div class="flex-fill">
-            <div class="small text-muted">
-              #<%= execution.number %>:
-              <%= tag.code link_to(execution.id, "##{dom_id(execution)}", class: "text-muted text-decoration-none") %>
-            </div>
-            <div class="d-flex gap-2 align-items-center text-muted mt-1">
+        <div class="row align-items-center text-nowrap">
+          <div class="col-5 d-flex gap-2">
+            <%= tag.span execution.number, class: "badge bg-secondary bg-opacity-50 rounded-pill" %>
+            <%= tag.code link_to(execution.id, "##{dom_id(execution)}", class: "text-muted text-decoration-none small") %>
+          </div>
+          <div class="col-2 small">
+            <% if execution.queue_latency %>
+              <%= format_duration execution.queue_latency %> <span class="text-muted">in queue</span>
+            <% end %>
+          </div>
+          <div class="col-2 small">
+            <% if execution.runtime_latency %>
+              <%= format_duration execution.runtime_latency %> <span class="text-muted">runtime</span>
+            <% end %>
+          </div>
+          <div class="col">
+            <div class="d-flex gap-3 align-items-center justify-content-end">
+              <%= tag.span relative_time(execution.last_status_at, include_seconds: true), class: "small" %>
               <%= status_badge execution.status %>
-              <%= relative_time execution.last_status_at, include_seconds: true %>
-
-              <% if execution.runtime_latency %>
-                • <div><%= format_duration execution.runtime_latency %> runtime</div>
-              <% end %>
-              <% if execution.queue_latency %>
-                • <div><%= format_duration execution.queue_latency %> in queue</div>
-              <% end %>
             </div>
           </div>
-          <div>
-            <div class="mt-4 d-flex gap-2">
-              <%= tag.button type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
-                data: { bs_toggle: "collapse", bs_target: "##{dom_id(execution, 'params')}" },
-                aria: { expanded: false, controls: dom_id(execution, "params") } do %>
-                Inspect
-              <% end %>
-            </div>
+          <div class="col-auto">
+            <%= tag.button type: "button", class: "btn btn-sm text-muted ms-auto", role: "button",
+              title: "Inspect",
+              data: { bs_toggle: "collapse", bs_target: "##{dom_id(execution, 'params')}" },
+              aria: { expanded: false, controls: dom_id(execution, "params") } do %>
+              <%= render_icon "info" %>
+              <span class="visually-hidden">Inspect</span>
+            <% end %>
           </div>
         </div>
         <% if execution.error %>
-          <div class="mt-3">
+          <div class="mt-3 small">
             <strong class="small">Error:</strong>
-            <pre class="text-wrap text-break m-0"><%= execution.error %></pre>
+            <code class="text-wrap text-break m-0 text-black"><%= execution.error %></code>
           </div>
         <% end %>
-        <div>
-          <%= tag.pre JSON.pretty_generate(execution.display_serialized_params), id: dom_id(execution, "params"), class: "collapse bg-light card card-body p-3 my-3" %>
-        </div>
+      <% end %>
+      <%= tag.div id: dom_id(execution, "params"), class: "list-group-item collapse small bg-dark text-light" do %>
+        <%= tag.pre JSON.pretty_generate(execution.display_serialized_params) %>
       <% end %>
     <% end %>
   </div>

data/app/views/good_job/jobs/_table.erb

@@ -1,122 +1,151 @@
-<div class="my-3">
-  <div class="table-responsive">
-    <%= form_with(url: mass_update_jobs_path(filter.to_params), method: :put, local: true, data: { "checkbox-toggle": "job_ids" }) do |form| %>
-      <table class="table table-hover table-sm mb-0 table-jobs">
-        <thead>
-          <tr>
-            <th><%= check_box_tag('toggle_job_ids', "1", false, data: { "checkbox-toggle-all": "job_ids" }) %></th>
-            <th>ActiveJob ID</th>
-            <th>State</th>
-            <th>Job Class</th>
-            <th>Queue</th>
-            <th>Scheduled At</th>
-            <th>Executions</th>
-            <th>Error</th>
-            <th>
-              Parameters&nbsp;
-              <%= tag.button "Toggle", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
-                             data: { bs_toggle: "collapse", bs_target: ".job-params" },
-                             aria: { expanded: false, controls: jobs.map { |job| "##{dom_id(job, "params")}" }.join(" ") }
-              %>
-            </th>
-            <th>
-              Actions<br>
+<%= form_with(url: mass_update_jobs_path(filter.to_params), method: :put, local: true, data: { "checkbox-toggle": "job_ids" }) do |form| %>
+<div class="my-3 card" data-gj-poll-replace id="jobs-table">
+  <div class="list-group list-group-flush text-nowrap table-jobs" role="table">
+    <header class="list-group-item bg-light">
+      <div class="row small text-muted text-uppercase align-items-center">
+        <div class="col-auto">
+          <%= check_box_tag('toggle_job_ids', "1", false, data: { "checkbox-toggle-all": "job_ids" }) %>
+        </div>
+        <div class="col-4">
+          <%= form.button type: 'submit', name: 'mass_action', value: 'reschedule', class: 'btn btn-sm btn-outline-secondary', title: "Reschedule all", data: { confirm: "Are you sure you want to reschedule the selected jobs?", disable: true } do %>
+            <span class="me-1"><%= render_icon "skip_forward" %></span> Reschedule
+          <% end %>
 
-              <div class="d-inline text-nowrap">
-                <%= form.button type: 'submit', name: 'mass_action', value: 'reschedule', class: 'btn btn-sm btn-outline-primary', title: "Reschedule all", data: { confirm: "Confirm reschedule all", disable: true } do %>
-                  <%= render_icon "skip_forward" %> All
-                <% end %>
+          <%= form.button type: 'submit', name: 'mass_action', value: 'retry', class: 'btn btn-sm btn-outline-secondary', title: "Retry all", data: { confirm: "Are you sure you want to retry the selected jobs?", disable: true } do %>
+            <span class="me-1"><%= render_icon "arrow_clockwise" %></span> Retry
+          <% end %>
 
-                <%= form.button type: 'submit', name: 'mass_action', value: 'discard', class: 'btn btn-sm btn-outline-primary', title: "Discard all", data: { confirm: "Confirm discard all", disable: true } do %>
-                  <%= render_icon "stop" %> All
+          <div class="btn-group" role="group">
+            <%= form.button type: 'submit', name: 'mass_action', value: 'discard', class: 'btn btn-sm btn-outline-secondary', title: "Discard all", data: { confirm: "Are you usure you want to discard the selected jobs?", disable: true } do %>
+              <span class="me-1"><%= render_icon "stop" %></span> Discard
+            <% end %>
+            <button id="destroy-dropdown-toggle" type="button" class="btn btn-sm btn-outline-secondary dropdown-toggle dropdown-toggle-split" data-bs-toggle="dropdown" aria-expanded="false">
+              <span class="visually-hidden">Toggle Actions</span>
+            </button>
+            <div class="dropdown-menu" aria-labelledby="destroy-dropdown-toggle">
+              <li>
+                <%= form.button type: 'submit', name: 'mass_action', value: 'destroy', class: 'btn', title: "Destroy all", data: { confirm: "Are you sure you want to destroy the selected jobs?", disable: true } do %>
+                  <span class="me-1"><%= render_icon "trash" %></span> Destroy
                 <% end %>
+              </li>
+            </div>
+          </div>
 
-                <%= form.button type: 'submit', name: 'mass_action', value: 'retry', class: 'btn btn-sm btn-outline-primary', title: "Retry all", data: { confirm: "Confirm retry all", disable: true } do %>
-                  <%= render_icon "arrow_clockwise" %> All
-                <% end %>
+        </div>
+        <div class="col-1">Queue</div>
+        <div class="col-1">Priority</div>
+        <div class="col-1 text-end">Attempts</div>
+        <div class="col text-end">
+          <%= tag.button type: "button", class: "btn btn-sm text-muted", role: "button",
+                  data: { bs_toggle: "collapse", bs_target: ".job-params" },
+                  aria: { expanded: false, controls: jobs.map { |job| "##{dom_id(job, "params")}" }.join(" ") } do %>
+              <%= render_icon "info" %>
+              <span class="visually-hidden">Inspect</span>
+          <% end %>
+        </div>
+      </div>
+    </header>
+    <label role="row" class="list-group-item list-group-item-warning list-group-item-action py-3 d-none" data-checkbox-toggle-show="job_ids">
+      <div class="row">
+        <div class="col-auto">
+          <%= check_box_tag "all_job_ids", 1, false, disabled: true, data: { "checkbox-toggle-show": "job_ids"} %>
+        </div>
+        <div class="col-auto">
+          Apply to all <%= filter.filtered_count %> <%= "job".pluralize(filter.filtered_count) %>.
+        </div>
+      </div>
+    </label>
 
-                <%= form.button type: 'submit', name: 'mass_action', value: 'destroy', class: 'btn btn-sm btn-outline-primary', title: "Destroy all", data: { confirm: "Confirm destroy all", disable: true } do %>
-                  <%= render_icon "trash" %> All
-                <% end %>
-              </div>
-            </th>
-          </tr>
-          <tr class="d-none" data-checkbox-toggle-show="job_ids">
-            <td class="text-center table-warning" colspan="10">
-              <label>
-                <%= check_box_tag "all_job_ids", 1, false, disabled: true, data: { "checkbox-toggle-show": "job_ids"} %>
-                Apply to all <%= filter.filtered_count %> <%= "job".pluralize(filter.filtered_count) %>.
-              </label>
-            </td>
-          </tr>
-        </thead>
-        <tbody>
-          <% if jobs.present? %>
-            <% jobs.each do |job| %>
-              <tr class="<%= dom_class(job) %>" id="<%= dom_id(job) %>">
-                <td><%= check_box_tag 'job_ids[]', job.id, false, data: { "checkbox-toggle-each": "job_ids" } %></td>
-                <td>
-                  <%= link_to job_path(job.id) do %>
-                    <code><%= job.id %></code>
-                  <% end %>
-                </td>
-                <td><%= status_badge(job.status) %></td>
-                <td><%= job.job_class %></td>
-                <td><%= job.queue_name %></td>
-                <td><%= relative_time(job.scheduled_at || job.created_at) %></td>
-                <td><%= job.executions_count %></td>
-                <td class="text-break"><%= truncate(job.recent_error, length: 1_000) %></td>
-                <td>
-                  <%= tag.button "Inspect", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
-                                 data: { bs_toggle: "collapse", bs_target: "##{dom_id(job, 'params')}" },
-                                 aria: { expanded: false, controls: dom_id(job, "params") }
-                  %>
-                  <%= tag.pre JSON.pretty_generate(job.display_serialized_params), id: dom_id(job, "params"), class: "collapse job-params" %>
-                </td>
-                <td>
-                  <div class="text-nowrap">
-                    <% if job.status.in? [:scheduled, :retried, :queued] %>
-                      <%= link_to reschedule_job_path(job.id), method: :put, class: "btn btn-sm btn-outline-primary", title: "Reschedule job", data: { confirm: "Confirm reschedule", disable: true } do %>
-                        <%= render_icon "skip_forward" %>
-                      <% end %>
-                    <% else %>
-                      <button class="btn btn-sm btn-outline-secondary" disabled><%= render_icon "skip_forward" %></button>
+    <% if jobs.present? %>
+      <% jobs.each do |job| %>
+        <%= label_tag dom_id(job, :checkbox), id: dom_id(job), role: "row", class: "list-group-item list-group-item-action py-3" do %>
+          <div class="row align-items-center">
+            <div class="col-auto">
+              <%= check_box_tag 'job_ids[]', job.id, false, id: dom_id(job, :checkbox), data: { "checkbox-toggle-each": "job_ids" } %>
+            </div>
+            <div class="col-4">
+              <%= tag.code link_to(job.id, job_path(job), class: "small text-muted text-decoration-none") %>
+              <%= tag.h5 tag.code(link_to(job.job_class, job_path(job), class: "text-reset text-decoration-none")), class: "text-reset mb-0" %>
+            </div>
+            <div class="col-1">
+              <span class="badge bg-primary bg-opacity-25 text-dark font-monospace"><%= job.queue_name %></span>
+            </div>
+            <div class="col-1 small text-center">
+              <span class="font-monospace fw-bold"><%= job.priority %></span>
+            </div>
+            <div class="col-1 text-center">
+              <% if job.executions_count > 0 && job.status != :finished %>
+                <%= tag.span job.executions_count, class: "badge rounded-pill bg-danger", data: {
+                      bs_toggle: "popover",
+                      bs_trigger: "hover focus click",
+                      bs_placement: "bottom",
+                      bs_content: job.recent_error
+                } %>
+              <% else %>
+                <span class="badge bg-secondary bg-opacity-50 rounded-pill"><%= job.executions_count %></span>
+              <% end %>
+            </div>
+            <div class="col d-flex gap-3 align-items-center justify-content-end">
+              <%= tag.span relative_time(job.last_status_at), class: "small" %>
+              <%= status_badge job.status %>
+            </div>
+            <div class="col-auto">
+              <div class="dropdown float-end">
+                <button class="d-flex align-items-center btn btn-sm" type="button" id="<%= dom_id(job, :actions) %>" data-bs-toggle="dropdown" aria-expanded="false">
+                  <%= render "good_job/shared/icons/dots" %>
+                  <span class="visually-hidden">Actions</span>
+                </button>
+                <ul class="dropdown-menu shadow" aria-labelledby="<%= dom_id(job, :actions) %>">
+                  <li>
+                    <% job_reschedulable = job.status.in? [:scheduled, :retried, :queued] %>
+                    <%= link_to reschedule_job_path(job.id), method: :put, class: "dropdown-item #{'disabled' unless job_reschedulable}", title: "Reschedule job", data: { confirm: "Confirm reschedule", disable: true } do %>
+                      <%= render "good_job/shared/icons/skip_forward" %>
+                      Reschedule
                     <% end %>
-
-                    <% if job.status.in? [:scheduled, :retried, :queued] %>
-                      <%= link_to discard_job_path(job.id), method: :put, class: "btn btn-sm btn-outline-primary", title: "Discard job", data: { confirm: "Confirm discard", disable: true } do %>
-                        <%= render_icon "stop" %>
-                      <% end %>
-                    <% else %>
-                      <button class="btn btn-sm btn-outline-secondary" disabled><%= render_icon "stop" %></button>
+                  </li>
+                  <li>
+                    <% job_discardable = job.status.in? [:scheduled, :retried, :queued] %>
+                    <%= link_to discard_job_path(job.id), method: :put, class: "dropdown-item #{'disabled' unless job_discardable}", title: "Discard job", data: { confirm: "Confirm discard", disable: true } do %>
+                      <%= render "good_job/shared/icons/stop" %>
+                      Discard
                     <% end %>
-
-                    <% if job.status == :discarded %>
-                      <%= link_to retry_job_path(job.id), method: :put, class: "btn btn-sm btn-outline-primary", title: "Retry job", data: { confirm: "Confirm retry", disable: true } do %>
-                        <%= render_icon "arrow_clockwise" %>
-                      <% end %>
-                    <% else %>
-                      <button class="btn btn-sm btn-outline-secondary" disabled><%= render_icon "arrow_clockwise" %></button>
+                  </li>
+                  <li>
+                    <%= link_to retry_job_path(job.id), method: :put, class: "dropdown-item #{'disabled' unless job.status == :discarded}", title: "Retry job", data: { confirm: "Confirm retry", disable: true } do %>
+                      <%= render "good_job/shared/icons/arrow_clockwise" %>
+                      Retry
+                    <% end %>
+                  </li>
+                  <li>
+                    <%= link_to job_path(job.id), method: :delete, class: "dropdown-item #{'disabled' unless job.status.in? [:discarded, :finished]}", title: "Destroy job", data: { confirm: "Confirm destroy", disable: true } do %>
+                      <%= render_icon "trash" %>
+                      Destroy
                     <% end %>
+                  </li>
 
-                    <% if job.status.in? [:discarded, :finished] %>
-                      <%= link_to job_path(job.id), method: :delete, class: "btn btn-sm btn-outline-primary", title: "Destroy job", data: { confirm: "Confirm destroy", disable: true } do %>
-                        <%= render_icon "trash" %>
-                      <% end %>
-                    <% else %>
-                      <button class="btn btn-sm btn-outline-secondary" disabled><%= render_icon "trash" %></button>
+                  <li>
+                    <%= link_to "##{dom_id(job, 'params')}",
+                      class: "dropdown-item",
+                      data: { bs_toggle: "collapse" },
+                      aria: { expanded: false, controls: dom_id(job, "params") } do %>
+                      <%= render_icon "info" %>
+                      Inspect
                     <% end %>
-                  </div>
-                </td>
-              </tr>
-            <% end %>
-          <% else %>
-            <tr>
-              <td colspan="10" class="py-2 text-center text-muted">No jobs found.</td>
-            </tr>
-          <% end %>
-        </tbody>
-      </table>
+                  </li>
+                </ul>
+              </div>
+            </div>
+          </div>
+        <% end %>
+        <%= tag.div id: dom_id(job, "params"), class: "job-params list-group-item collapse small bg-dark text-light" do %>
+          <%= tag.pre JSON.pretty_generate(job.display_serialized_params) %>
+        <% end %>
+      <% end %>
+    <% else %>
+      <div class="list-group-item py-4 text-center text-muted">
+        No jobs found.
+      </div>
     <% end %>
   </div>
 </div>
+<% end %>

data/app/views/good_job/jobs/show.html.erb

@@ -1,48 +1,57 @@
 <div class="break-out bg-light border-bottom py-2 mb-3">
   <div class="container-fluid pt-2">
-    <div class="d-flex align-items-center">
-      <div class="flex-fill">
+    <div class="row align-items-center">
+      <div class="col-5">
         <nav aria-label="breadcrumb">
           <ol class="breadcrumb small mb-0">
             <li class="breadcrumb-item"><%= link_to "Jobs", jobs_path %></li>
-            <li class="breadcrumb-item active" aria-current="page">ActiveJob ID: <%= tag.code @job.id %></li>
+            <li class="breadcrumb-item active" aria-current="page"><%= tag.code @job.id, class: "text-muted" %></li>
           </ol>
         </nav>
-        <h2 class="mb-1"><%= tag.code @job.job_class %></h2>
-        <div class="text-muted small d-flex gap-2">
-            <div>Queue: <%= tag.strong @job.queue_name %></div>
-            •
-            <div>Priority: <%= tag.strong @job.priority %></div>
+        <h2 class="mb-0"><%= tag.code @job.job_class %></h2>
+      </div>
+      <div class="col-2">
+        <div class="small text-muted text-uppercase">Queue</div>
+        <div class="badge bg-primary bg-opacity-25 text-dark font-monospace my-2">
+          <%= tag.strong @job.queue_name %>
         </div>
       </div>
-      <div>
-        <% job_reschedulable = @job.status.in? [:scheduled, :retried, :queued] %>
-        <%= button_to reschedule_job_path(@job.id), method: :put,
-            class: "btn btn-sm #{job_reschedulable ? 'btn-outline-primary' : 'btn-outline-secondary'}",
-            form_class: "d-inline-block",
-            disabled: !job_reschedulable,
-            aria: { label: "Reschedule job" },
-            title: "Reschedule job",
-            data: { confirm: "Confirm reschedule" } do %>
-          <%= render_icon "skip_forward" %>
-          Reschedule
+      <div class="col-2">
+        <div class="small text-muted text-uppercase">Priority</div>
+        <div class="font-monospace fw-bold small my-2"><%= tag.strong @job.priority %></div>
+      </div>
+      <div class="col text-end">
+        <% if @job.status.in? [:scheduled, :retried, :queued] %>
+          <%= button_to reschedule_job_path(@job.id), method: :put,
+              class: "btn btn-sm btn-outline-primary",
+              form_class: "d-inline-block",
+              aria: { label: "Reschedule job" },
+              title: "Reschedule job",
+              data: { confirm: "Confirm reschedule" } do %>
+            <%= render_icon "skip_forward" %>
+            Reschedule
+          <% end %>
         <% end %>
 
-        <% job_discardable = @job.status.in? [:scheduled, :retried, :queued] %>
-        <%= button_to discard_job_path(@job.id), method: :put, class: "btn btn-sm #{job_discardable ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: !job_discardable, aria: { label: "Discard job" }, title: "Discard job", data: { confirm: "Confirm discard" } do %>
-          <%= render_icon "stop" %>
-          Discard
+        <% if @job.status.in? [:scheduled, :retried, :queued] %>
+          <%= button_to discard_job_path(@job.id), method: :put, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Discard job" }, title: "Discard job", data: { confirm: "Confirm discard" } do %>
+            <%= render_icon "stop" %>
+            Discard
+          <% end %>
         <% end %>
 
-        <%= button_to retry_job_path(@job.id), method: :put, class: "btn btn-sm #{@job.status == :discarded ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: @job.status != :discarded, aria: { label: "Retry job" }, title: "Retry job", data: { confirm: "Confirm retry" } do %>
-          <%= render_icon "arrow_clockwise" %>
-          Retry
+        <% if @job.status == :discarded %>
+          <%= button_to retry_job_path(@job.id), method: :put, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Retry job" }, title: "Retry job", data: { confirm: "Confirm retry" } do %>
+            <%= render_icon "arrow_clockwise" %>
+            Retry
+          <% end %>
         <% end %>
 
-        <% job_destroyable = @job.status.in? [:discarded, :finished] %>
-        <%= button_to job_path(@job.id), method: :delete, class: "btn btn-sm #{job_destroyable ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: !job_destroyable, aria: { label: "Destroy job" }, title: "Destroy job", data: { confirm: "Confirm destroy" } do %>
-          <%= render_icon "trash" %>
-          Destroy
+        <% if @job.status.in? [:discarded, :finished] %>
+          <%= button_to job_path(@job.id), method: :delete, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Destroy job" }, title: "Destroy job", data: { confirm: "Confirm destroy" } do %>
+            <%= render_icon "trash" %>
+            Destroy
+          <% end %>
         <% end %>
       </div>
     </div>
@@ -51,7 +60,7 @@
 
 <div class="my-4">
   <h5>Arguments</h5>
-  <%= tag.pre @job.serialized_params["arguments"].map(&:inspect).join(', ') %>
+  <%= tag.pre @job.serialized_params["arguments"].map(&:inspect).join(', '), class: 'text-wrap text-break' %>
 </div>
 
 <%= render 'executions', executions: @job.executions.includes_advisory_locks.reverse %>

data/app/views/good_job/processes/index.html.erb

@@ -1,38 +1,66 @@
-<div class="my-3 flex">
-  <h2>Processes</h2>
+<div class="bg-light break-out border-bottom">
+  <h2 class="container-fluid pt-3 pb-2">Processes</h2>
 </div>
 
-<div data-live-poll-region="processes">
-  <% if @processes.present? %>
-    <div class="card my-3">
-      <div class="table-responsive">
-        <table class="table card-table table-bordered table-hover table-sm mb-0">
-          <thead>
-          <tr>
-            <th>Process UUID</th>
-            <th>Created At</th></th>
-            <th>State</th>
-          </tr>
-          </thead>
-          <tbody>
-          <% @processes.each do |process| %>
-            <tr class="<%= dom_class(process) %>" id="<%= dom_id(process) %>">
-              <td><%= process.id %></td>
-              <td><%= relative_time(process.created_at) %></td>
-              <td><%= tag.pre JSON.pretty_generate(process.state) %></td>
-            </tr>
+<div class="card my-3" data-live-poll-region="processes">
+  <div class="list-group list-group-flush text-nowrap" role="table">
+    <header class="list-group-item bg-light">
+      <div class="row small text-muted text-uppercase align-items-center">
+        <div class="col">Process</div>
+        <div class="col">Schedulers</div>
+        <div class="col-2 d-flex gap-2">
+          <span>Started</span>
+        </div>
+        <div class="col-auto">
+          <%= tag.button type: "button", class: "btn btn-sm text-muted ms-auto", role: "button",
+                         data: { bs_toggle: "collapse", bs_target: ".process-state" },
+                         aria: { expanded: false, controls: @processes.map { |process| "##{dom_id(process, 'state')}" }.join(" ") } do %>
+              <%= render_icon "info" %>
+              <span class="visually-hidden">Inspect</span>
           <% end %>
-          </tbody>
-        </table>
+        </div>
       </div>
-    </div>
-  <% else %>
-    <div class="card my-3">
-      <div class="card-body">
-        <p class="card-text">
-          <em>No GoodJob processes found.</em>
-        </p>
+    </header>
+    <% @processes.each do |process| %>
+      <div id="<%= dom_id(process) %>" class="<%= dom_class(process) %> list-group-item py-3" role="row">
+        <div class="row align-items-center">
+          <div class="col">
+            <code class="font-monospace">
+              <span class="text-muted opacity-50">$</span>
+              <%= process.state["proctitle"] %>
+            </code>
+            <div>
+              <span class="text-muted small">PID</span>
+              <span class="badge rounded-pill bg-light text-dark"><%= process.state["pid"] %></span>
+              <span class="text-muted small">@</span>
+              <span class="badge rounded-pill bg-light text-dark"><%= process.state["hostname"] %></span>
+            </div>
+          </div>
+          <div class="col">
+            <% process.state["schedulers"].each do |scheduler| %>
+              <pre class="mb-0"><%= scheduler %></pre>
+            <% end %>
+          </div>
+          <div class="col-2 small"><%= relative_time(process.created_at) %></div>
+          <div class="col-auto">
+            <%= tag.button type: "button", class: "btn btn-sm text-muted ms-auto", role: "button",
+                           title: "Inspect",
+                           data: { bs_toggle: "collapse", bs_target: "##{dom_id(process, 'state')}" },
+                           aria: { expanded: false, controls: dom_id(process, "state") } do %>
+              <%= render_icon "info" %>
+              <span class="visually-hidden">Inspect</span>
+            <% end %>
+          </div>
+        </div>
       </div>
-    </div>
-  <% end %>
+      <%= tag.div id: dom_id(process, "state"), class: "process-state list-group-item collapse small bg-dark text-light" do %>
+        <%= tag.pre JSON.pretty_generate(process.state) %>
+      <% end %>
+    <% end %>
+    <% if @processes.empty? %>
+      <div class="list-group-item py-4 text-center text-muted">
+        No GoodJob processes found.
+      </div>
+    <% end %>
+  </div>
 </div>

data/app/views/good_job/shared/icons/_dots.html.erb

@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-three-dots" viewBox="0 0 16 16">
+  <path d="M3 9.5a1.5 1.5 0 1 1 0-3 1.5 1.5 0 0 1 0 3zm5 0a1.5 1.5 0 1 1 0-3 1.5 1.5 0 0 1 0 3zm5 0a1.5 1.5 0 1 1 0-3 1.5 1.5 0 0 1 0 3z" />
+</svg>

data/app/views/good_job/shared/icons/_info.html.erb

@@ -0,0 +1,4 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-info-circle" viewBox="0 0 16 16">
+  <path d="M8 15A7 7 0 1 1 8 1a7 7 0 0 1 0 14zm0 1A8 8 0 1 0 8 0a8 8 0 0 0 0 16z" />
+  <path d="m8.93 6.588-2.29.287-.082.38.45.083c.294.07.352.176.288.469l-.738 3.468c-.194.897.105 1.319.808 1.319.545 0 1.178-.252 1.465-.598l.088-.416c-.2.176-.492.246-.686.246-.275 0-.375-.193-.304-.533L8.93 6.588zM9 4.5a1 1 0 1 1-2 0 1 1 0 0 1 2 0z" />
+</svg>

data/lib/generators/good_job/templates/install/migrations/create_good_jobs.rb.erb

@@ -7,9 +7,9 @@ class CreateGoodJobs < ActiveRecord::Migration<%= migration_version %>
       t.text :queue_name
       t.integer :priority
       t.jsonb :serialized_params
-      t.timestamp :scheduled_at
-      t.timestamp :performed_at
-      t.timestamp :finished_at
+      t.datetime :scheduled_at
+      t.datetime :performed_at
+      t.datetime :finished_at
       t.text :error
 
       t.timestamps
@@ -18,7 +18,7 @@ class CreateGoodJobs < ActiveRecord::Migration<%= migration_version %>
       t.text :concurrency_key
       t.text :cron_key
       t.uuid :retried_good_job_id
-      t.timestamp :cron_at
+      t.datetime :cron_at
     end
 
     create_table :good_job_processes, id: :uuid do |t|

data/lib/generators/good_job/templates/update/migrations/01_create_good_jobs.rb.erb

@@ -7,9 +7,9 @@ class CreateGoodJobs < ActiveRecord::Migration<%= migration_version %>
       t.text :queue_name
       t.integer :priority
       t.jsonb :serialized_params
-      t.timestamp :scheduled_at
-      t.timestamp :performed_at
-      t.timestamp :finished_at
+      t.datetime :scheduled_at
+      t.datetime :performed_at
+      t.datetime :finished_at
       t.text :error
 
       t.timestamps
@@ -18,7 +18,7 @@ class CreateGoodJobs < ActiveRecord::Migration<%= migration_version %>
       t.text :concurrency_key
       t.text :cron_key
       t.uuid :retried_good_job_id
-      t.timestamp :cron_at
+      t.datetime :cron_at
     end
 
     create_table :good_job_processes, id: :uuid do |t|

data/lib/good_job/daemon.rb

@@ -26,7 +26,7 @@ module GoodJob
     # @return [void]
     def write_pid
       File.open(pidfile, ::File::CREAT | ::File::EXCL | ::File::WRONLY) { |f| f.write(::Process.pid.to_s) }
-      at_exit { File.delete(pidfile) if File.exist?(pidfile) }
+      at_exit { File.delete(pidfile) if File.exist?(pidfile) } # rubocop:disable Lint/NonAtomicFileOperation
     rescue Errno::EEXIST
       check_pid
       retry
@@ -34,7 +34,7 @@ module GoodJob
 
     # @return [void]
     def delete_pid
-      File.delete(pidfile) if File.exist?(pidfile)
+      File.delete(pidfile) if File.exist?(pidfile) # rubocop:disable Lint/NonAtomicFileOperation
     end
 
     # @return [void]

data/lib/good_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.2.0'
+  VERSION = '3.3.0'
 end

data/lib/models/good_job/execution.rb

@@ -4,6 +4,7 @@ module GoodJob
   class Execution < BaseRecord
     include Lockable
     include Filterable
+    include Reportable
 
     # Raised if something attempts to execute a previously completed Execution again.
     PreviouslyPerformedError = Class.new(StandardError)
@@ -312,40 +313,6 @@ module GoodJob
       end
     end
 
-    # There are 3 buckets of non-overlapping statuses:
-    #   1. The job will be executed
-    #     - queued: The job will execute immediately when an execution thread becomes available.
-    #     - scheduled: The job is scheduled to execute in the future.
-    #     - retried: The job previously errored on execution and will be re-executed in the future.
-    #   2. The job is being executed
-    #     - running: the job is actively being executed by an execution thread
-    #   3. The job will not execute
-    #     - finished: The job executed successfully
-    #     - discarded: The job previously errored on execution and will not be re-executed in the future.
-    #
-    # @return [Symbol]
-    def status
-      if finished_at.present?
-        if error.present? && retried_good_job_id.present?
-          :retried
-        elsif error.present? && retried_good_job_id.nil?
-          :discarded
-        else
-          :finished
-        end
-      elsif (scheduled_at || created_at) > DateTime.current
-        if serialized_params.fetch('executions', 0) > 1
-          :retried
-        else
-          :scheduled
-        end
-      elsif running?
-        :running
-      else
-        :queued
-      end
-    end
-
     # Return formatted serialized_params for display in the dashboard
     # @return [Hash]
     def display_serialized_params
@@ -366,11 +333,6 @@ module GoodJob
       serialized_params.fetch('executions', 0) + 1
     end
 
-    # The last relevant timestamp for this execution
-    def last_status_at
-      finished_at || performed_at || scheduled_at || created_at
-    end
-
     # Time between when this job was expected to run and when it started running
     def queue_latency
       now = Time.zone.now

data/lib/models/good_job/job.rb

@@ -8,6 +8,7 @@ module GoodJob
   class Job < BaseRecord
     include Filterable
     include Lockable
+    include Reportable
 
     # Raised when an inappropriate action is applied to a Job based on its state.
     ActionForStateMismatchError = Class.new(StandardError)
@@ -73,32 +74,6 @@ module GoodJob
       serialized_params['job_class']
     end
 
-    def last_status_at
-      finished_at || performed_at || scheduled_at || created_at
-    end
-
-    def status
-      if finished_at.present?
-        if error.present? && retried_good_job_id.present?
-          :retried
-        elsif error.present? && retried_good_job_id.nil?
-          :discarded
-        else
-          :finished
-        end
-      elsif (scheduled_at || created_at) > DateTime.current
-        if serialized_params.fetch('executions', 0) > 1
-          :retried
-        else
-          :scheduled
-        end
-      elsif running?
-        :running
-      else
-        :queued
-      end
-    end
-
     # Override #reload to add a custom scope to ensure the reloaded record is the head execution
     # @return [Job]
     def reload(options = nil)

data/lib/models/good_job/reportable.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+module GoodJob
+  module Reportable
+    # There are 3 buckets of non-overlapping statuses:
+    #   1. The job will be executed
+    #     - queued: The job will execute immediately when an execution thread becomes available.
+    #     - scheduled: The job is scheduled to execute in the future.
+    #     - retried: The job previously errored on execution and will be re-executed in the future.
+    #   2. The job is being executed
+    #     - running: the job is actively being executed by an execution thread
+    #   3. The job will not execute
+    #     - finished: The job executed successfully
+    #     - discarded: The job previously errored on execution and will not be re-executed in the future.
+    #
+    # @return [Symbol]
+    def status
+      if finished_at.present?
+        if error.present? && retried_good_job_id.present?
+          :retried
+        elsif error.present? && retried_good_job_id.nil?
+          :discarded
+        else
+          :finished
+        end
+      elsif (scheduled_at || created_at) > DateTime.current
+        if serialized_params.fetch('executions', 0) > 1
+          :retried
+        else
+          :scheduled
+        end
+      elsif running?
+        :running
+      else
+        :queued
+      end
+    end
+
+    # The last relevant timestamp for this execution
+    def last_status_at
+      finished_at || performed_at || scheduled_at || created_at
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.0
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-07-12 00:00:00.000000000 Z
+date: 2022-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -365,6 +365,7 @@ files:
 - app/assets/good_job/modules/checkbox_toggle.js
 - app/assets/good_job/modules/document_ready.js
 - app/assets/good_job/modules/live_poll.js
+- app/assets/good_job/modules/popovers.js
 - app/assets/good_job/modules/toasts.js
 - app/assets/good_job/scripts.js
 - app/assets/good_job/style.css
@@ -398,7 +399,9 @@ files:
 - app/views/good_job/shared/icons/_check.html.erb
 - app/views/good_job/shared/icons/_clock.html.erb
 - app/views/good_job/shared/icons/_dash_circle.html.erb
+- app/views/good_job/shared/icons/_dots.html.erb
 - app/views/good_job/shared/icons/_exclamation.html.erb
+- app/views/good_job/shared/icons/_info.html.erb
 - app/views/good_job/shared/icons/_play.html.erb
 - app/views/good_job/shared/icons/_skip_forward.html.erb
 - app/views/good_job/shared/icons/_stop.html.erb
@@ -446,6 +449,7 @@ files:
 - lib/models/good_job/job.rb
 - lib/models/good_job/lockable.rb
 - lib/models/good_job/process.rb
+- lib/models/good_job/reportable.rb
 homepage: https://github.com/bensheldon/good_job
 licenses:
 - MIT