good_job 3.17.3 → 3.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46ab9513d6943173f1c0c81f0755ac6870581595e2962ca0e438b32cdb9eec6e
-  data.tar.gz: 0aeebddc6f1ad80fc1d0cba1c4d923b17c6d9bae2fcafdd3282fc9d6cf4ec57f
+  metadata.gz: cb40c03312f09c2cb91e77bce2ab3aacf87c62a18125d62b50bdc92b312d34f5
+  data.tar.gz: c1c73c9264b8bd6454aad7685d326d082c00d5c3f14667ab89e1f77cce9059ea
 SHA512:
-  metadata.gz: 2c5491f403270ee5029dd1032d42421a721c996c35491198ee46901073dbc40fa3974e2d91d757905a474b524a3a3d8c8b27bae1d1ad661f0559d553df97dd7c
-  data.tar.gz: 26d55dec3a1a9c5bcef140f612a391ee14688f686ffc9300ab7ed98309e692de21c6ef5c623794545fb9f754656d731dbc3146e8264ff060f902837b8ba379b8
+  metadata.gz: 9825b6d3c5a496c7fdee3aec3f0b5653a6c68d40b15487bb43d21b48817ae077052b3c3520b6ac0dd54354cc68b1157800270e95119240260ef68ab55046b293
+  data.tar.gz: a903a5cac7a8b753e457d7e98018ca575825dcb1be515702cd30bd92494f3fc22740e09e48c4b3a8312fae2824021e86d6f6d9e431d0b10f39c05ea97457baca

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## [v3.18.0](https://github.com/bensheldon/good_job/tree/v3.18.0) (2023-08-30)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.17.4...v3.18.0)
+
+**Implemented enhancements:**
+
+- Support configuring cron schedule dynamically with a block [\#1051](https://github.com/bensheldon/good_job/pull/1051) ([DanielHeath](https://github.com/DanielHeath))
+
+## [v3.17.4](https://github.com/bensheldon/good_job/tree/v3.17.4) (2023-08-24)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.17.3...v3.17.4)
+
+**Fixed bugs:**
+
+- Handle edge case of logger not responding to silence [\#1049](https://github.com/bensheldon/good_job/pull/1049) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- An idea for better .silence handling [\#1046](https://github.com/bensheldon/good_job/issues/1046)
+
 ## [v3.17.3](https://github.com/bensheldon/good_job/tree/v3.17.3) (2023-08-19)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.17.2...v3.17.3)

data/README.md

@@ -504,6 +504,10 @@ config.good_job.cron = {
     cron: "0 0,12 * * *",
     class: "AnotherJob",
   },
+  complex_schedule: {
+    class: "ComplexScheduleJob",
+    cron: -> (last_ran) { (last_ran.blank? ? Time.now : last_ran + 14.hours).at_beginning_of_minute }
+  }
   # etc.
 }
 ```

data/app/models/good_job/base_record.rb

@@ -33,7 +33,7 @@ module GoodJob
     def self.with_logger_silenced(&block)
       # Assign to a local variable, just in case it's modified in another thread concurrently
       logger = self.logger
-      if logger
+      if logger.respond_to? :silence
         logger.silence(&block)
       else
         yield

data/app/models/good_job/cron_entry.rb

@@ -27,6 +27,7 @@ module GoodJob # :nodoc:
     def initialize(params = {})
       @params = params
 
+      return if cron_proc?
       raise ArgumentError, "Invalid cron format: '#{cron}'" unless fugit.instance_of?(Fugit::Cron)
     end
 
@@ -41,10 +42,6 @@ module GoodJob # :nodoc:
       params.fetch(:class)
     end
 
-    def cron
-      params.fetch(:cron)
-    end
-
     def set
       params[:set]
     end
@@ -61,16 +58,21 @@ module GoodJob # :nodoc:
       params[:description]
     end
 
-    def next_at
+    def next_at(previously_at: nil)
+      if cron_proc?
+        result = Rails.application.executor.wrap { cron.call(previously_at || last_at) }
+        return Fugit.parse(result).next_time.to_t if result.is_a?(String)
+
+        return result
+
+      end
       fugit.next_time.to_t
     end
 
     def schedule
-      fugit.original
-    end
+      return "Custom schedule" if cron_proc?
 
-    def fugit
-      @_fugit ||= Fugit.parse(cron)
+      fugit.original
     end
 
     def jobs
@@ -80,11 +82,7 @@ module GoodJob # :nodoc:
     def last_at
       return if last_job.blank?
 
-      if GoodJob::Job.column_names.include?('cron_at')
-        (last_job.cron_at || last_job.created_at).localtime
-      else
-        last_job.created_at
-      end
+      (last_job.cron_at || last_job.created_at).localtime
     end
 
     def enabled?
@@ -116,11 +114,7 @@ module GoodJob # :nodoc:
     end
 
     def last_job
-      if GoodJob::Job.column_names.include?('cron_at')
-        jobs.order("cron_at DESC NULLS LAST").first
-      else
-        jobs.order(created_at: :asc).last
-      end
+      jobs.order("cron_at DESC NULLS LAST").first
     end
 
     def display_properties
@@ -138,6 +132,18 @@ module GoodJob # :nodoc:
 
     private
 
+    def cron
+      params.fetch(:cron)
+    end
+
+    def cron_proc?
+      cron.respond_to?(:call)
+    end
+
+    def fugit
+      @_fugit ||= Fugit.parse(cron)
+    end
+
     def set_value
       value = set || {}
       value.respond_to?(:call) ? value.call : value

data/lib/good_job/cron_manager.rb

@@ -82,12 +82,13 @@ module GoodJob # :nodoc:
 
     # Enqueues a scheduled task
     # @param cron_entry [CronEntry] the CronEntry object to schedule
-    def create_task(cron_entry)
-      cron_at = cron_entry.next_at
+    # @param previously_at [Date, Time, ActiveSupport::TimeWithZone, nil] the last, +in-memory+, scheduled time the cron task was intended to run
+    def create_task(cron_entry, previously_at: nil)
+      cron_at = cron_entry.next_at(previously_at: previously_at)
       delay = [(cron_at - Time.current).to_f, 0].max
       future = Concurrent::ScheduledTask.new(delay, args: [self, cron_entry, cron_at], executor: @executor) do |thr_scheduler, thr_cron_entry, thr_cron_at|
         # Re-schedule the next cron task before executing the current task
-        thr_scheduler.create_task(thr_cron_entry)
+        thr_scheduler.create_task(thr_cron_entry, previously_at: thr_cron_at)
 
         Rails.application.executor.wrap do
           cron_entry.enqueue(thr_cron_at) if thr_cron_entry.enabled?

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.17.3'
+  VERSION = '3.18.0'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.17.3
+  version: 3.18.0
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-19 00:00:00.000000000 Z
+date: 2023-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob