good_job 3.17.2 → 3.17.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8c92206b4099b3be756adba01af60f4ef531eaf8cf02a9c9cdd17129214f929c
-  data.tar.gz: 29f1e72a6b21d2f1e3d073d8b1bd9f4f2a78e417f69c21c195fc795f62ac4e5c
+  metadata.gz: e7b833bb3f1b28dca921562c3110e4147d955a98982f2b9481f9f7f2b41aa648
+  data.tar.gz: 4f230602f1f5a2faf5198035f207e6f206bc614078a8bce8f38f71613250a8bd
 SHA512:
-  metadata.gz: 2906c0b22dc6f6b0f0e78c607467533598e84dce2a29e654321293da877f1afd09ee59afd534d7a7b7f1481ae796d111b2492f62ec2cddcde843442e4262adbe
-  data.tar.gz: 0e8107f018f836e0d15f5836d93ebb8bdbe6e36381cba63680113302e3125f1a49d9aba5e05a2124ce50ec51cbfde7059ebed30b3cc5b64d859ce16867ae2c5e
+  metadata.gz: '0990adc9282acc9ad3b387f494b20e716e9f1f6ba37c1ec4da200dd89b53f8dd8d6cac60dc652323127086c837bf08bb02d3c28f1a75d589a1c435a897524b0d'
+  data.tar.gz: 961e5e7e3d522f07572f9031096b940408f3bc7568a46b475d45daeb37ae755e237f497cdbb3221e4419bde4d73a560d743f132359b7ee03ffc8062d24f99b23

data/CHANGELOG.md

@@ -1,5 +1,37 @@
 # Changelog
 
+## [v3.17.4](https://github.com/bensheldon/good_job/tree/v3.17.4) (2023-08-24)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.17.3...v3.17.4)
+
+**Fixed bugs:**
+
+- Handle edge case of logger not responding to silence [\#1049](https://github.com/bensheldon/good_job/pull/1049) ([bensheldon](https://github.com/bensheldon))
+
+**Closed issues:**
+
+- An idea for better .silence handling [\#1046](https://github.com/bensheldon/good_job/issues/1046)
+
+## [v3.17.3](https://github.com/bensheldon/good_job/tree/v3.17.3) (2023-08-19)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.17.2...v3.17.3)
+
+**Fixed bugs:**
+
+- New probe server fixes: allow accept\_nonblock to raise and IO.gets return nil [\#1043](https://github.com/bensheldon/good_job/pull/1043) ([stas](https://github.com/stas))
+
+**Closed issues:**
+
+- Dashboard as separate package? [\#965](https://github.com/bensheldon/good_job/issues/965)
+- Managing jobs with errors [\#929](https://github.com/bensheldon/good_job/issues/929)
+- Feature: dynamic options for good\_job\_control\_concurrency\_with [\#684](https://github.com/bensheldon/good_job/issues/684)
+
+**Merged pull requests:**
+
+- Attempt to overcome github\_changelog\_generator's rate limit problem [\#1045](https://github.com/bensheldon/good_job/pull/1045) ([bensheldon](https://github.com/bensheldon))
+- \[Doc\] for cron schedule add info about Dashboard view [\#1042](https://github.com/bensheldon/good_job/pull/1042) ([steveroot](https://github.com/steveroot))
+- Add description of  :class to readme for cron style repeating jobs section [\#1040](https://github.com/bensheldon/good_job/pull/1040) ([steveroot](https://github.com/steveroot))
+
 ## [v3.17.2](https://github.com/bensheldon/good_job/tree/v3.17.2) (2023-08-10)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.17.1...v3.17.2)

data/README.md

@@ -473,7 +473,7 @@ GoodJob's concurrency control strategy for `perform_limit` is "optimistic retry
 
 ### Cron-style repeating/recurring jobs
 
-GoodJob can enqueue jobs on a recurring basis that can be used as a replacement for cron.
+GoodJob can enqueue Active Job jobs on a recurring basis that can be used as a replacement for cron.
 
 Cron-style jobs can be performed by any GoodJob process (e.g., CLI or `:async` execution mode) that has `config.good_job.enable_cron` set to `true`. That is, one or more job executor processes can be configured to perform recurring jobs.
 
@@ -481,6 +481,8 @@ GoodJob's cron uses unique indexes to ensure that only a single job is enqueued
 
 Cron-format is parsed by the [`fugit`](https://github.com/floraison/fugit) gem, which has support for seconds-level resolution (e.g. `* * * * * *`) and natural language parsing (e.g. `every second`).
 
+If you use the [Dashboard](#dashboard) the scheduled tasks can be viewed in the 'cron' menu. In this view you can also disable a task or run/enqueue a task immediately.
+
 ```ruby
 # config/environments/application.rb or a specific environment e.g. production.rb
 
@@ -492,10 +494,10 @@ config.good_job.cron = {
   # Every 15 minutes, enqueue `ExampleJob.set(priority: -10).perform_later(42, "life", name: "Alice")`
   frequent_task: { # each recurring job must have a unique key
     cron: "*/15 * * * *", # cron-style scheduling format by fugit gem
-    class: "ExampleJob", # reference the Job class with a string
-    args: [42, "life"], # positional arguments to pass; can also be a proc e.g. `-> { [Time.now] }`
-    kwargs: { name: "Alice" }, # keyword arguments to pass; can also be a proc e.g. `-> { { name: NAMES.sample } }`
-    set: { priority: -10 }, # additional ActiveJob properties; can also be a lambda/proc e.g. `-> { { priority: [1,2].sample } }`
+    class: "ExampleJob", # name of the job class as a String; must reference an Active Job job class
+    args: [42, "life"], # positional arguments to pass to the job; can also be a proc e.g. `-> { [Time.now] }`
+    kwargs: { name: "Alice" }, # keyword arguments to pass to the job; can also be a proc e.g. `-> { { name: NAMES.sample } }`
+    set: { priority: -10 }, # additional Active Job properties; can also be a lambda/proc e.g. `-> { { priority: [1,2].sample } }`
     description: "Something helpful", # optional description that appears in Dashboard
   },
   another_task: {

data/app/models/good_job/base_record.rb

@@ -33,7 +33,7 @@ module GoodJob
     def self.with_logger_silenced(&block)
       # Assign to a local variable, just in case it's modified in another thread concurrently
       logger = self.logger
-      if logger
+      if logger.respond_to? :silence
         logger.silence(&block)
       else
         yield

data/lib/good_job/http_server.rb

@@ -46,11 +46,13 @@ module GoodJob
           ready_sockets, = IO.select([@server], nil, nil, SOCKET_READ_TIMEOUT)
           next unless ready_sockets
 
-          client = @server.accept_nonblock(exception: false)
+          client = @server.accept_nonblock
           request = client.gets
 
-          status, headers, body = @app.call(parse_request(request))
-          respond(client, status, headers, body)
+          if request
+            status, headers, body = @app.call(parse_request(request))
+            respond(client, status, headers, body)
+          end
 
           client.close
         rescue IO::WaitReadable, Errno::EINTR

data/lib/good_job/version.rb

@@ -2,7 +2,7 @@
 
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.17.2'
+  VERSION = '3.17.4'
 
   # GoodJob version as Gem::Version object
   GEM_VERSION = Gem::Version.new(VERSION)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.17.2
+  version: 3.17.4
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-08-10 00:00:00.000000000 Z
+date: 2023-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob