good_job 3.12.2 → 3.12.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: caa82da35ecdc7a40488de110b0e52b0a0e073abd8ca6e0cf877b3df4f770fce
-  data.tar.gz: 2bb351a541183ccd8f5b5d58209c09813ecc09cebafd4cea1daad462a66337fc
+  metadata.gz: cbd9eea98505960c1c53863338762b4c814d2248caf2642fc5774e1fbc19fc1c
+  data.tar.gz: 2c84f9908144e29f509355010d0d9daf2c6ebda1360c411f41328e6a25c45aad
 SHA512:
-  metadata.gz: a15ac0a81f3efcc6184ed7717430f67aa59d857a873ced5824922e36f499a275ec141636edbb80a3a7c587a9fdd64c3b98c3c189d09d4db45807829957259ca6
-  data.tar.gz: 3b948c09db4ca2a60a90770937960db944e2569b3f54fc570e597f97a3b8da3ee247b96d734e0d593be87eac9de0b3a75c20e08daa77590dd94be9d6b3219f36
+  metadata.gz: 68e5e4df608a70845510c9790c10b350f1d5bf960f5574de146278d3e9a9b95270cd96116c70428815fd3e06ecab789566e82c5eaabdb64a9fdc07f7f9555d94
+  data.tar.gz: c56b476a28edd728c6791bb61f53e8f9c073c865301dd7a8cbf40b3f432a2eb9db5e5fe48e268b7c454b4f242f5f27c1bbcf866e2924a6150ec7f8f1a0148f58

data/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## [v3.12.4](https://github.com/bensheldon/good_job/tree/v3.12.4) (2023-02-24)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.12.3...v3.12.4)
+
+**Closed issues:**
+
+- Rails 7.1 - Serialized columns like a store now needs a `coder: JSON` [\#863](https://github.com/bensheldon/good_job/issues/863)
+- Does good\_job automatically retry on ActiveRecord::LockWaitTimeout? [\#860](https://github.com/bensheldon/good_job/issues/860)
+- race condition for batches callback [\#832](https://github.com/bensheldon/good_job/issues/832)
+
+**Merged pull requests:**
+
+- Add serialize coder kwarg for Rails 7.1-alpha [\#864](https://github.com/bensheldon/good_job/pull/864) ([bensheldon](https://github.com/bensheldon))
+
+## [v3.12.3](https://github.com/bensheldon/good_job/tree/v3.12.3) (2023-02-21)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v3.12.2...v3.12.3)
+
+**Closed issues:**
+
+- \[Not Critical\] Too much space \(One\) in db/migrate/XXXXXX\_create\_index\_good\_jobs\_jobs\_on\_priority\_created\_at\_when\_unfinished.rb [\#851](https://github.com/bensheldon/good_job/issues/851)
+- Use timestamps with timezone when set as the default for postgresql. [\#668](https://github.com/bensheldon/good_job/issues/668)
+
+**Merged pull requests:**
+
+- Fix bug where notification check does not use configuration [\#857](https://github.com/bensheldon/good_job/pull/857) ([mitchellhenke](https://github.com/mitchellhenke))
+- Fix template for the update migrations 03 index \(\#851\) [\#852](https://github.com/bensheldon/good_job/pull/852) ([julienanne](https://github.com/julienanne))
+
 ## [v3.12.2](https://github.com/bensheldon/good_job/tree/v3.12.2) (2023-02-16)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v3.12.1...v3.12.2)

data/app/models/good_job/batch_record.rb

@@ -72,8 +72,15 @@ module GoodJob
       end
     end
 
-    attribute :serialized_properties, :json, default: -> { {} } # Can be set as default value in `serialize` as of Rails v6.1
-    serialize :serialized_properties, PropertySerializer
+    if Rails.gem_version < Gem::Version.new('6.1.0.alpha')
+      # serialize does not yet take a default value, must set via Attributes API
+      attribute :serialized_properties, :json, default: -> { {} }
+      serialize :serialized_properties, PropertySerializer
+    elsif Rails.gem_version < Gem::Version.new('7.1.0.alpha')
+      serialize :serialized_properties, PropertySerializer, default: -> { {} }
+    else
+      serialize :serialized_properties, coder: PropertySerializer, default: -> { {} }
+    end
     alias_attribute :properties, :serialized_properties
 
     def properties=(value)

data/lib/generators/good_job/templates/update/migrations/03_create_index_good_jobs_jobs_on_priority_created_at_when_unfinished.rb.erb

@@ -2,7 +2,7 @@
 class CreateIndexGoodJobsJobsOnPriorityCreatedAtWhenUnfinished < ActiveRecord::Migration<%= migration_version %>
   disable_ddl_transaction!
 
-   def change
+  def change
     reversible do |dir|
       dir.up do
         # Ensure this incremental update migration is idempotent

data/lib/good_job/adapter.rb

@@ -234,8 +234,8 @@ module GoodJob
     end
 
     def send_notify?(active_job)
-      return true unless active_job.respond_to?(:good_job_notify)
       return false unless GoodJob.configuration.enable_listen_notify
+      return true unless active_job.respond_to?(:good_job_notify)
 
       !(active_job.good_job_notify == false || (active_job.class.good_job_notify == false && active_job.good_job_notify.nil?))
     end

data/lib/good_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '3.12.2'
+  VERSION = '3.12.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 3.12.2
+  version: 3.12.4
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-02-16 00:00:00.000000000 Z
+date: 2023-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob