good_job 2.5.0 → 2.6.0

data/engine/app/controllers/good_job/assets_controller.rb

@@ -23,6 +23,10 @@ module GoodJob
       render file: GoodJob::Engine.root.join("app", "assets", "vendor", "chartist", "chartist.js")
     end
 
+    def rails_ujs_js
+      render file: GoodJob::Engine.root.join("app", "assets", "vendor", "rails_ujs.js")
+    end
+
     def style_css
       render file: GoodJob::Engine.root.join("app", "assets", "style.css")
     end

data/engine/app/controllers/good_job/cron_entries_controller.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+module GoodJob
+  class CronEntriesController < GoodJob::BaseController
+    def index
+      @cron_entries = CronEntry.all
+    end
+
+    def show
+      @cron_entry = CronEntry.find(params[:id])
+      @jobs_filter = JobsFilter.new(params, @cron_entry.jobs)
+    end
+
+    def enqueue
+      @cron_entry = CronEntry.find(params[:id])
+      @cron_entry.enqueue(Time.current)
+      redirect_back(fallback_location: cron_entries_path, notice: "Cron entry has been enqueued.")
+    end
+  end
+end

data/engine/app/filters/good_job/base_filter.rb

@@ -3,10 +3,11 @@ module GoodJob
   class BaseFilter
     DEFAULT_LIMIT = 25
 
-    attr_accessor :params
+    attr_accessor :params, :base_query
 
-    def initialize(params)
+    def initialize(params, base_query = nil)
       @params = params
+      @base_query = base_query || default_base_query
     end
 
     def records
@@ -24,13 +25,13 @@ module GoodJob
 
     def job_classes
       base_query.group("serialized_params->>'job_class'").count
-                .sort_by { |name, _count| name }
+                .sort_by { |name, _count| name.to_s }
                 .to_h
     end
 
     def queues
       base_query.group(:queue_name).count
-                .sort_by { |name, _count| name }
+                .sort_by { |name, _count| name.to_s }
                 .to_h
     end
 
@@ -94,7 +95,7 @@ module GoodJob
 
     private
 
-    def base_query
+    def default_base_query
       raise NotImplementedError
     end
 

data/engine/app/filters/good_job/executions_filter.rb

@@ -12,7 +12,7 @@ module GoodJob
 
     private
 
-    def base_query
+    def default_base_query
       GoodJob::Execution.all
     end
 

data/engine/app/filters/good_job/jobs_filter.rb

@@ -14,7 +14,7 @@ module GoodJob
 
     private
 
-    def base_query
+    def default_base_query
       GoodJob::ActiveJobJob.all
     end
 

data/engine/app/views/good_job/cron_entries/index.html.erb

@@ -0,0 +1,51 @@
+<% if @cron_entries.present? %>
+  <div class="card my-3">
+    <div class="table-responsive">
+      <table class="table card-table table-bordered table-hover table-sm mb-0">
+        <thead>
+          <th>Key</th>
+          <th>Schedule</th>
+          <th>
+            Properties
+            <%= tag.button "Toggle", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
+                           data: { bs_toggle: "collapse", bs_target: ".cron-entry-properties" },
+                           aria: { expanded: false, controls: @cron_entries.map { |cron_entry| "##{dom_id(cron_entry, 'properties')}" }.join(" ") }
+            %>
+          </th>
+          <th>Description</th>
+          <th>Next scheduled</th>
+          <th>Last run</th>
+          <th>Actions</th>
+        </thead>
+        <tbody>
+          <% @cron_entries.each do |cron_entry| %>
+            <tr id="<%= dom_id(cron_entry) %>">
+              <td class="font-monospace"><%= cron_entry.key %></td>
+              <td class="font-monospace"><%= cron_entry.schedule %></td>
+              <td>
+                <%= tag.button("Preview", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
+                        data: { bs_toggle: "collapse", bs_target: "##{dom_id(cron_entry, 'properties')}" },
+                        aria: { expanded: false, controls: dom_id(cron_entry, 'properties') }) %>
+                <%= tag.pre(JSON.pretty_generate(cron_entry.display_properties), id: dom_id(cron_entry, 'properties'), class: "collapse cron-entry-properties") %>
+              </td>
+              <td><%= cron_entry.description %></td>
+              <td><%= cron_entry.next_at %></td>
+              <td>
+                <% if cron_entry.last_job.present? %>
+                  <%= link_to cron_entry.last_at, cron_entry_path(cron_entry), title: "Job #{cron_entry.last_job.id}" %>
+                <% end %>
+              </td>
+              <td>
+                <%= button_to enqueue_cron_entry_path(cron_entry.id), method: :post, class: "btn btn-sm btn-outline-primary", form_class: "d-inline-block", aria: { label: "Run cron entry now" }, title: "Run cron entry now", data: { confirm: "Confirm run cron entry now" } do %>
+                  <%= render "good_job/shared/icons/play" %>
+                <% end %>
+              </td>
+            </tr>
+          <% end %>
+        </tbody>
+      </table>
+    </div>
+  </div>
+<% else %>
+  <em>No cron schedules present.</em>
+<% end %>

data/engine/app/views/good_job/cron_entries/show.html.erb

@@ -0,0 +1,4 @@
+<h1 class="mb-3">Cron Entry Key: <code><%= @cron_entry.id %></code></h1>
+
+<%= render 'good_job/shared/filter', filter: @jobs_filter %>
+<%= render 'good_job/jobs/table', jobs: @jobs_filter.records %>

data/engine/app/views/good_job/{shared/_executions_table.erb → executions/_table.erb}

@@ -44,7 +44,7 @@
               <%= tag.pre JSON.pretty_generate(execution.serialized_params), id: dom_id(execution, "params"), class: "collapse job-params" %>
             </td>
             <td>
-              <%= button_to execution_path(execution.id), method: :delete, class: "btn btn-sm btn-outline-danger", title: "Delete execution" do %>
+              <%= button_to execution_path(execution.id), method: :delete, class: "btn btn-sm btn-outline-danger", title: "Delete execution", data: { confirm: "Confirm delete" } do %>
                 <%= render "good_job/shared/icons/trash" %>
               <% end %>
             </td>

data/engine/app/views/good_job/executions/index.html.erb

@@ -5,7 +5,7 @@
 <%= render 'good_job/shared/filter', filter: @filter %>
 
 <% if @filter.records.present? %>
-  <%= render 'good_job/shared/executions_table', executions: @filter.records %>
+  <%= render 'good_job/executions/table', executions: @filter.records %>
 
   <nav aria-label="Job pagination" class="mt-3">
     <ul class="pagination">

data/engine/app/views/good_job/{shared/_jobs_table.erb → jobs/_table.erb}

@@ -46,16 +46,16 @@
             <td>
               <div class="text-nowrap">
                 <% job_reschedulable = job.status.in? [:scheduled, :retried, :queued] %>
-                <%= button_to reschedule_job_path(job.id), method: :put, class: "btn btn-sm #{job_reschedulable ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: !job_reschedulable, aria: { label: "Reschedule job" }, title: "Reschedule job" do %>
+                <%= button_to reschedule_job_path(job.id), method: :put, class: "btn btn-sm #{job_reschedulable ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: !job_reschedulable, aria: { label: "Reschedule job" }, title: "Reschedule job", data: { confirm: "Confirm reschedule" } do %>
                   <%= render "good_job/shared/icons/skip_forward" %>
                 <% end %>
 
                 <% job_discardable = job.status.in? [:scheduled, :retried, :queued] %>
-                <%= button_to discard_job_path(job.id), method: :put, class: "btn btn-sm #{job_discardable ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: !job_discardable, aria: { label: "Discard job" }, title: "Discard job" do %>
+                <%= button_to discard_job_path(job.id), method: :put, class: "btn btn-sm #{job_discardable ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: !job_discardable, aria: { label: "Discard job" }, title: "Discard job", data: { confirm: "Confirm discard" } do %>
                   <%= render "good_job/shared/icons/stop" %>
                 <% end %>
 
-                <%= button_to retry_job_path(job.id), method: :put, class: "btn btn-sm #{job.status == :discarded ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: job.status != :discarded, aria: { label: "Retry job" }, title: "Retry job" do %>
+                <%= button_to retry_job_path(job.id), method: :put, class: "btn btn-sm #{job.status == :discarded ? 'btn-outline-primary' : 'btn-outline-secondary'}", form_class: "d-inline-block", disabled: job.status != :discarded, aria: { label: "Retry job" }, title: "Retry job", data: { confirm: "Confirm retry" } do %>
                   <%= render "good_job/shared/icons/arrow_clockwise" %>
                 <% end %>
               </div>

data/engine/app/views/good_job/jobs/index.html.erb

@@ -5,7 +5,7 @@
 <%= render 'good_job/shared/filter', filter: @filter %>
 
 <% if @filter.records.present? %>
-  <%= render 'good_job/shared/jobs_table', jobs: @filter.records %>
+  <%= render 'good_job/jobs/table', jobs: @filter.records %>
   <nav aria-label="Job pagination" class="mt-3">
     <ul class="pagination">
       <li class="page-item">

data/engine/app/views/good_job/jobs/show.html.erb

@@ -1,3 +1,3 @@
-<h1>ActiveJob ID: <code><%= @executions.first.id %></code></h1>
+<h1 class="mb-3">ActiveJob ID: <code><%= @executions.first.id %></code></h1>
 
-<%= render 'good_job/shared/executions_table', executions: @executions %>
+<%= render 'good_job/executions/table', executions: @executions %>

data/engine/app/views/good_job/shared/_filter.erb

@@ -1,16 +1,15 @@
 <div class='card mb-2'>
   <div class='card-body d-flex flex-wrap'>
-
     <div class='me-4'>
       <small>Filter by job class</small>
       <br>
-      <% @filter.job_classes.each do |name, count| %>
+      <% filter.job_classes.each do |name, count| %>
         <% if params[:job_class] == name %>
-          <%= link_to(@filter.to_params(job_class: nil), class: 'btn btn-sm btn-outline-secondary active', role: "button", "aria-pressed": true)  do %>
+          <%= link_to(filter.to_params(job_class: nil), class: 'btn btn-sm btn-outline-secondary active', role: "button", "aria-pressed": true)  do %>
             <%= name %> (<%= count %>)
           <% end %>
         <% else %>
-          <%= link_to(@filter.to_params(job_class: name), class: 'btn btn-sm btn-outline-secondary', role: "button") do %>
+          <%= link_to(filter.to_params(job_class: name), class: 'btn btn-sm btn-outline-secondary', role: "button") do %>
             <%= name %> (<%= count %>)
           <% end %>
         <% end %>
@@ -20,13 +19,13 @@
     <div class='me-4'>
       <small>Filter by state</small>
       <br>
-      <% @filter.states.each do |name, count| %>
+      <% filter.states.each do |name, count| %>
         <% if params[:state] == name %>
-          <%= link_to(@filter.to_params(state: nil), class: 'btn btn-sm btn-outline-secondary active', role: "button", "aria-pressed": true)  do %>
+          <%= link_to(filter.to_params(state: nil), class: 'btn btn-sm btn-outline-secondary active', role: "button", "aria-pressed": true)  do %>
             <%= name %> (<%= count %>)
           <% end %>
         <% else %>
-          <%= link_to(@filter.to_params(state: name), class: 'btn btn-sm btn-outline-secondary', role: "button") do %>
+          <%= link_to(filter.to_params(state: name), class: 'btn btn-sm btn-outline-secondary', role: "button") do %>
             <%= name %> (<%= count %>)
           <% end %>
         <% end %>
@@ -36,13 +35,13 @@
     <div>
       <small>Filter by queue</small>
       <br>
-      <% @filter.queues.each do |name, count| %>
+      <% filter.queues.each do |name, count| %>
         <% if params[:queue_name] == name %>
-          <%= link_to(@filter.to_params(queue_name: nil), class: 'btn btn-sm btn-outline-secondary active', role: "button", "aria-pressed": true)  do %>
+          <%= link_to(filter.to_params(queue_name: nil), class: 'btn btn-sm btn-outline-secondary active', role: "button", "aria-pressed": true)  do %>
             <%= name %> (<%= count %>)
           <% end %>
         <% else %>
-          <%= link_to(@filter.to_params(queue_name: name), class: 'btn btn-sm btn-outline-secondary', role: "button") do %>
+          <%= link_to(filter.to_params(queue_name: name), class: 'btn btn-sm btn-outline-secondary', role: "button") do %>
             <%= name %> (<%= count %>)
           <% end %>
         <% end %>

data/engine/app/views/good_job/shared/icons/_play.html.erb

@@ -0,0 +1,4 @@
+<!-- https://icons.getbootstrap.com/icons/play/ -->
+<svg xmlns="http://www.w3.org/2000/svg" width="16" height="16" fill="currentColor" class="bi bi-play" viewBox="0 0 16 16">
+  <path d="M10.804 8 5 4.633v6.734L10.804 8zm.792-.696a.802.802 0 0 1 0 1.392l-6.363 3.692C4.713 12.69 4 12.345 4 11.692V4.308c0-.653.713-.998 1.233-.696l6.363 3.692z" />
+</svg>

data/engine/app/views/layouts/good_job/base.html.erb

@@ -11,6 +11,7 @@
 
   <%= javascript_include_tag bootstrap_path(format: :js, v: GoodJob::VERSION) %>
   <%= javascript_include_tag chartist_path(format: :js, v: GoodJob::VERSION) %>
+  <%= javascript_include_tag rails_ujs_path(format: :js, v: GoodJob::VERSION) %>
 </head>
 <body>
   <nav class="navbar navbar-expand-lg navbar-light bg-light">
@@ -29,7 +30,7 @@
             <%= link_to "All Jobs", jobs_path, class: ["nav-link", ("active" if current_page?(jobs_path))] %>
           </li>
           <li class="nav-item">
-            <%= link_to "Cron Schedules", cron_schedules_path, class: ["nav-link", ("active" if current_page?(cron_schedules_path))] %>
+            <%= link_to "Cron Schedules", cron_entries_path, class: ["nav-link", ("active" if current_page?(cron_entries_path))] %>
           </li>
           <li class="nav-item">
             <div class="nav-link">

data/engine/config/routes.rb

@@ -1,7 +1,13 @@
 # frozen_string_literal: true
 GoodJob::Engine.routes.draw do
   root to: 'executions#index'
-  resources :cron_schedules, only: %i[index]
+
+  resources :cron_entries, only: %i[index show] do
+    member do
+      post :enqueue
+    end
+  end
+
   resources :jobs, only: %i[index show] do
     member do
       put :discard
@@ -20,6 +26,7 @@ GoodJob::Engine.routes.draw do
 
     constraints(format: :js) do
       get :bootstrap, action: :bootstrap_js
+      get :rails_ujs, action: :rails_ujs_js
       get :chartist, action: :chartist_js
     end
   end

data/lib/good_job/configuration.rb

@@ -157,7 +157,7 @@ module GoodJob
     alias enable_cron? enable_cron
 
     def cron
-      env_cron = JSON.parse(ENV['GOOD_JOB_CRON']) if ENV['GOOD_JOB_CRON'].present?
+      env_cron = JSON.parse(ENV['GOOD_JOB_CRON'], symbolize_names: true) if ENV['GOOD_JOB_CRON'].present?
 
       options[:cron] ||
         rails_config[:cron] ||

data/lib/good_job/cron_entry.rb

@@ -12,14 +12,29 @@ module GoodJob # :nodoc:
 
     attr_reader :params
 
+    def self.all(configuration: nil)
+      configuration ||= GoodJob::Configuration.new({})
+      configuration.cron_entries
+    end
+
+    def self.find(key, configuration: nil)
+      all(configuration: configuration).find { |entry| entry.key == key.to_sym }.tap do |cron_entry|
+        raise ActiveRecord::RecordNotFound unless cron_entry
+      end
+    end
+
     def initialize(params = {})
-      @params = params.with_indifferent_access
+      @params = params
+
+      raise ArgumentError, "Invalid cron format: '#{cron}'" unless fugit.instance_of?(Fugit::Cron)
     end
 
     def key
       params.fetch(:key)
     end
+
     alias id key
+    alias to_param key
 
     def job_class
       params.fetch(:class)
@@ -42,16 +57,61 @@ module GoodJob # :nodoc:
     end
 
     def next_at
-      fugit = Fugit::Cron.parse(cron)
       fugit.next_time.to_t
     end
 
-    def enqueue
-      job_class.constantize.set(set_value).perform_later(*args_value)
+    def schedule
+      fugit.original
+    end
+
+    def fugit
+      @_fugit ||= Fugit.parse(cron)
+    end
+
+    def jobs
+      GoodJob::ActiveJobJob.where(cron_key: key)
+    end
+
+    def last_at
+      return if last_job.blank?
+
+      if GoodJob::ActiveJobJob.column_names.include?('cron_at')
+        (last_job.cron_at || last_job.created_at).localtime
+      else
+        last_job.created_at
+      end
+    end
+
+    def enqueue(cron_at = nil)
+      GoodJob::CurrentThread.within do |current_thread|
+        current_thread.cron_key = key
+        current_thread.cron_at = cron_at
+
+        job_class.constantize.set(set_value).perform_later(*args_value)
+      end
     rescue ActiveRecord::RecordNotUnique
       false
     end
 
+    def last_job
+      if GoodJob::ActiveJobJob.column_names.include?('cron_at')
+        jobs.order("cron_at DESC NULLS LAST").first
+      else
+        jobs.order(created_at: :asc).last
+      end
+    end
+
+    def display_properties
+      {
+        key: key,
+        class: job_class,
+        cron: schedule,
+        set: display_property(set),
+        args: display_property(args),
+        description: display_property(description),
+      }
+    end
+
     private
 
     def set_value
@@ -63,5 +123,16 @@ module GoodJob # :nodoc:
       value = args || []
       value.respond_to?(:call) ? value.call : value
     end
+
+    def display_property(value)
+      case value
+      when NilClass
+        "None"
+      when Proc
+        "Lambda/Callable"
+      else
+        value
+      end
+    end
   end
 end

data/lib/good_job/cron_manager.rb

@@ -89,11 +89,7 @@ module GoodJob # :nodoc:
         thr_scheduler.create_task(thr_cron_entry)
 
         Rails.application.executor.wrap do
-          CurrentThread.reset
-          CurrentThread.cron_key = thr_cron_entry.key
-          CurrentThread.cron_at = thr_cron_at
-
-          cron_entry.enqueue
+          cron_entry.enqueue(thr_cron_at)
         end
       end
 

data/lib/good_job/current_thread.rb

@@ -5,6 +5,15 @@ module GoodJob
   # Thread-local attributes for passing values from Instrumentation.
   # (Cannot use ActiveSupport::CurrentAttributes because ActiveJob resets it)
   module CurrentThread
+    # Resettable accessors for thread-local values.
+    ACCESSORS = %i[
+      cron_at
+      cron_key
+      error_on_discard
+      error_on_retry
+      execution
+    ].freeze
+
     # @!attribute [rw] cron_at
     #   @!scope class
     #   Cron At
@@ -36,13 +45,20 @@ module GoodJob
     thread_mattr_accessor :execution
 
     # Resets attributes
+    # @param [Hash] values to assign
     # @return [void]
-    def self.reset
-      self.cron_at = nil
-      self.cron_key = nil
-      self.execution = nil
-      self.error_on_discard = nil
-      self.error_on_retry = nil
+    def self.reset(values = {})
+      ACCESSORS.each do |accessor|
+        send("#{accessor}=", values[accessor])
+      end
+    end
+
+    # Exports values to hash
+    # @return [Hash]
+    def self.to_h
+      ACCESSORS.each_with_object({}) do |accessor, hash|
+        hash[accessor] = send(accessor)
+      end
     end
 
     # @return [String] UUID of the currently executing GoodJob::Execution
@@ -60,12 +76,14 @@ module GoodJob
       (Thread.current.name || Thread.current.object_id).to_s
     end
 
+    # Wrap the yielded block with CurrentThread values and reset after the block
+    # @yield [self]
     # @return [void]
     def self.within
-      reset
+      original_values = to_h
       yield(self)
     ensure
-      reset
+      reset(original_values)
     end
   end
 end

data/lib/good_job/execution.rb

@@ -309,22 +309,24 @@ module GoodJob
 
     # @return [ExecutionResult]
     def execute
-      GoodJob::CurrentThread.reset
-      GoodJob::CurrentThread.execution = self
+      GoodJob::CurrentThread.within do |current_thread|
+        current_thread.reset
+        current_thread.execution = self
 
-      # DEPRECATION: Remove deprecated `good_job:` parameter in GoodJob v3
-      ActiveSupport::Notifications.instrument("perform_job.good_job", { good_job: self, execution: self, process_id: GoodJob::CurrentThread.process_id, thread_name: GoodJob::CurrentThread.thread_name }) do
-        value = ActiveJob::Base.execute(active_job_data)
+        # DEPRECATION: Remove deprecated `good_job:` parameter in GoodJob v3
+        ActiveSupport::Notifications.instrument("perform_job.good_job", { good_job: self, execution: self, process_id: current_thread.process_id, thread_name: current_thread.thread_name }) do
+          value = ActiveJob::Base.execute(active_job_data)
 
-        if value.is_a?(Exception)
-          handled_error = value
-          value = nil
-        end
-        handled_error ||= GoodJob::CurrentThread.error_on_retry || GoodJob::CurrentThread.error_on_discard
+          if value.is_a?(Exception)
+            handled_error = value
+            value = nil
+          end
+          handled_error ||= current_thread.error_on_retry || current_thread.error_on_discard
 
-        ExecutionResult.new(value: value, handled_error: handled_error)
-      rescue StandardError => e
-        ExecutionResult.new(value: nil, unhandled_error: e)
+          ExecutionResult.new(value: value, handled_error: handled_error)
+        rescue StandardError => e
+          ExecutionResult.new(value: nil, unhandled_error: e)
+        end
       end
     end
   end

data/lib/good_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '2.5.0'
+  VERSION = '2.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.6.0
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-10-25 00:00:00.000000000 Z
+date: 2021-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -126,16 +126,16 @@ dependencies:
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.35.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.35.0
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -351,27 +351,29 @@ files:
 - engine/app/assets/vendor/bootstrap/bootstrap.min.css
 - engine/app/assets/vendor/chartist/chartist.css
 - engine/app/assets/vendor/chartist/chartist.js
+- engine/app/assets/vendor/rails_ujs.js
 - engine/app/controllers/good_job/assets_controller.rb
 - engine/app/controllers/good_job/base_controller.rb
-- engine/app/controllers/good_job/cron_schedules_controller.rb
+- engine/app/controllers/good_job/cron_entries_controller.rb
 - engine/app/controllers/good_job/executions_controller.rb
 - engine/app/controllers/good_job/jobs_controller.rb
 - engine/app/filters/good_job/base_filter.rb
 - engine/app/filters/good_job/executions_filter.rb
 - engine/app/filters/good_job/jobs_filter.rb
 - engine/app/helpers/good_job/application_helper.rb
-- engine/app/models/good_job/active_job_job.rb
-- engine/app/views/good_job/cron_schedules/index.html.erb
+- engine/app/views/good_job/cron_entries/index.html.erb
+- engine/app/views/good_job/cron_entries/show.html.erb
+- engine/app/views/good_job/executions/_table.erb
 - engine/app/views/good_job/executions/index.html.erb
+- engine/app/views/good_job/jobs/_table.erb
 - engine/app/views/good_job/jobs/index.html.erb
 - engine/app/views/good_job/jobs/show.html.erb
 - engine/app/views/good_job/shared/_chart.erb
-- engine/app/views/good_job/shared/_executions_table.erb
 - engine/app/views/good_job/shared/_filter.erb
-- engine/app/views/good_job/shared/_jobs_table.erb
 - engine/app/views/good_job/shared/icons/_arrow_clockwise.html.erb
 - engine/app/views/good_job/shared/icons/_check.html.erb
 - engine/app/views/good_job/shared/icons/_exclamation.html.erb
+- engine/app/views/good_job/shared/icons/_play.html.erb
 - engine/app/views/good_job/shared/icons/_skip_forward.html.erb
 - engine/app/views/good_job/shared/icons/_stop.html.erb
 - engine/app/views/good_job/shared/icons/_trash.html.erb
@@ -389,6 +391,7 @@ files:
 - lib/good_job.rb
 - lib/good_job/active_job_extensions.rb
 - lib/good_job/active_job_extensions/concurrency.rb
+- lib/good_job/active_job_job.rb
 - lib/good_job/adapter.rb
 - lib/good_job/cli.rb
 - lib/good_job/configuration.rb

data/engine/app/controllers/good_job/cron_schedules_controller.rb

@@ -1,9 +0,0 @@
-# frozen_string_literal: true
-module GoodJob
-  class CronSchedulesController < GoodJob::BaseController
-    def index
-      configuration = GoodJob::Configuration.new({})
-      @cron_entries = configuration.cron_entries
-    end
-  end
-end