good_job 2.14.2 → 2.14.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 723ecfed33656e11fcabed4f807c7b9735e474cf15701d97faa0d95c84dd4280
-  data.tar.gz: 210f4f8c8d420d46630292212c015d245c2035e8e79dc1b3148fcb40e1b8dbd0
+  metadata.gz: f53ed707cdafa1bedf790afd1465aefd1453bb7f7a1d358a577ee4769743d94a
+  data.tar.gz: 77274ebd06c82c4caec8369f6cf9eaeafd90c70960ed2722314cdd773c08a02b
 SHA512:
-  metadata.gz: 20f4b5844debd83589f2dc4f9cebe7be963f9dd7ec6749227db7fad00aca4366cdb87003776194695db84f2bc23739b65f866460d92622dbad8923ff690b9799
-  data.tar.gz: 3528895af9ce6f1d4d2e33dab0b6a2fa60cb255d3211a0cfc5b0e97d0f2444e7270c696872c47562dd18d822a95a550345068073a50f80d7ebdd0c9eac782bf8
+  metadata.gz: 83283b1fbd4983b9a7814cf5f67dad4c78df64d046db45c95f1f6aa8f118f1a1cb0e522b32bb8e5f38e8e0a52ec2408da209abc03a041fd9f665015d2c8b854f
+  data.tar.gz: 98091d7a44f02ddfad810af0195dab7c8c581475b8d049b570d28c86921363c6fafa8ab6fcc4221dc5efa662fae3918e5f98579f45f847ee82ba3d97e44a5b8c

data/CHANGELOG.md

@@ -1,5 +1,25 @@
 # Changelog
 
+## [v2.14.3](https://github.com/bensheldon/good_job/tree/v2.14.3) (2022-05-13)
+
+[Full Changelog](https://github.com/bensheldon/good_job/compare/v2.14.2...v2.14.3)
+
+**Fixed bugs:**
+
+- Bind probe server to all interfaces [\#598](https://github.com/bensheldon/good_job/pull/598) ([Timmitry](https://github.com/Timmitry))
+
+**Closed issues:**
+
+- NoMethodError: undefined method `current\_tags' for nil:NilClass  [\#596](https://github.com/bensheldon/good_job/issues/596)
+- When running rspec, I get: current transaction is aborted, commands ignored until end of transaction block [\#595](https://github.com/bensheldon/good_job/issues/595)
+- CLI healtheck only listening on localhost, not reachable for Kubernetes [\#592](https://github.com/bensheldon/good_job/issues/592)
+
+**Merged pull requests:**
+
+- Improve development instructions and tooling \(rename bin/rails, add bin/appraisal\) [\#590](https://github.com/bensheldon/good_job/pull/590) ([bensheldon](https://github.com/bensheldon))
+- Replace test Instrumentation mocking with temporary subscriptions [\#589](https://github.com/bensheldon/good_job/pull/589) ([bensheldon](https://github.com/bensheldon))
+- Update to development to Ruby 3.0.4, include `matrix` gem in development Gemfile [\#588](https://github.com/bensheldon/good_job/pull/588) ([bensheldon](https://github.com/bensheldon))
+
 ## [v2.14.2](https://github.com/bensheldon/good_job/tree/v2.14.2) (2022-05-01)
 
 [Full Changelog](https://github.com/bensheldon/good_job/compare/v2.14.1...v2.14.2)

data/README.md

@@ -60,6 +60,9 @@ For more of the story of GoodJob, read the [introductory blog post](https://isla
     - [CLI HTTP health check probes](#cli-http-health-check-probes)
 - [Contribute](#contribute)
     - [Gem development](#gem-development)
+        - [Development setup](#development-setup)
+        - [Rails development harness](#rails-development-harness)
+        - [Running tests](#running-tests)
     - [Release](#release)
 - [License](#license)
 
@@ -941,49 +944,82 @@ spec:
 
 ## Contribute
 
-Contributions are welcomed and appreciated 🙏
+<!-- Please keep this section in sync with CONTRIBUTING.md -->
+
+All contributions, from feedback to code and beyond, are welcomed and appreciated 🙏
 
 - Review the [Prioritized Project Backlog](https://github.com/bensheldon/good_job/projects/1).
 - Open a new Issue or contribute to an [existing Issue](https://github.com/bensheldon/good_job/issues). Questions or suggestions are fantastic.
-- Participate according to our [Code of Conduct](https://github.com/bensheldon/good_job/projects/1).
+- Participate according to our [Code of Conduct](/CODE_OF_CONDUCT.md).
+- Financially support the project via [Sponsorship](https://github.com/sponsors/bensheldon).
+
+For gem development and debugging information, please review the [README's Gem Development section](/README.md#gem-development).
 
 ### Gem development
 
-To run tests:
+#### Development setup
 
 ```bash
 # Clone the repository locally
-$ git clone git@github.com:bensheldon/good_job.git
+git clone git@github.com:bensheldon/good_job.git
 
 # Set up the local environment
-$ bin/setup
-
-# Run the tests
-$ bin/rspec
+bin/setup
 ```
 
-This gem uses Appraisal to run tests against multiple versions of Rails:
+#### Rails development harness
+
+A Rails application exists within `spec/test_app` that is used for development, test, and GoodJob Demo environments.
 
 ```bash
-# Install Appraisal(s) gemfiles
-$ bundle exec appraisal
+# Run a local development webserver
+bin/rails s
+
+# Disable job execution and cron for cleaner console output
+GOOD_JOB_ENABLE_CRON=0 GOOD_JOB_EXECUTION_MODE=external bin/rails s
 
-# Run tests
-$ bundle exec appraisal bin/rspec
+# Open the Rails console
+bin/rails c
 ```
 
 For developing locally within another Ruby on Rails project:
 
 ```bash
-# Within Ruby on Rails directory...
-$ bundle config local.good_job /path/to/local/git/repository
+# Within Ruby on Rails project directory
+# Ensure that the Gemfile is set to git with a branch e.g.
+# gem "good_job", git: "https://github.com/bensheldon/good_job.git", branch: "main"
+# Then, override the Bundle config to point to the local filesystem's good_job repository
+bundle config local.good_job /path/to/local/good_job/repository
 
 # Confirm that the local copy is used
-$ bundle install
+bundle install
 
 # => Using good_job 0.1.0 from https://github.com/bensheldon/good_job.git (at /Users/You/Projects/good_job@dc57fb0)
 ```
 
+#### Running tests
+
+Tests can be run against the primary development environment:
+
+```bash
+bin/rspec
+```
+
+Environment variables that may help with debugging:
+
+- `LOUD=1`: display all stdout/stderr output from all sources. This is helpful because GoodJob wraps some tests with `quiet { }` for cleaner test output, but it can hinder debugging.
+- `SHOW_BROWSER=1`: Run system tests headfully with Chrome/Chromedriver. Use `binding.irb` in the system tests to pause.
+
+Appraisal can be used to run a test matrix of multiple versions of Rails:
+
+```bash
+# Install Appraisal matrix of gemfiles
+bin/appraisal
+
+# Run tests against matrix
+bin/appraisal bin/rspec
+```
+
 ### Release
 
 Package maintainers can release this gem by running:

data/lib/good_job/probe_server.rb

@@ -17,7 +17,7 @@ module GoodJob
     def start
       @handler = Rack::Handler.get(RACK_SERVER)
       @future = Concurrent::Future.new(args: [@handler, @port, GoodJob.logger]) do |thr_handler, thr_port, thr_logger|
-        thr_handler.run(self, Port: thr_port, Logger: thr_logger, AccessLog: [])
+        thr_handler.run(self, Port: thr_port, Host: '0.0.0.0', Logger: thr_logger, AccessLog: [])
       end
       @future.add_observer(self.class, :task_observer)
       @future.execute

data/lib/good_job/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module GoodJob
   # GoodJob gem version.
-  VERSION = '2.14.2'
+  VERSION = '2.14.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: good_job
 version: !ruby/object:Gem::Version
-  version: 2.14.2
+  version: 2.14.3
 platform: ruby
 authors:
 - Ben Sheldon
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-05-01 00:00:00.000000000 Z
+date: 2022-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activejob
@@ -483,7 +483,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.2.33
 signing_key:
 specification_version: 4
 summary: A multithreaded, Postgres-based ActiveJob backend for Ruby on Rails