good_job 2.14.2 → 2.14.3

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 723ecfed33656e11fcabed4f807c7b9735e474cf15701d97faa0d95c84dd4280
4
- data.tar.gz: 210f4f8c8d420d46630292212c015d245c2035e8e79dc1b3148fcb40e1b8dbd0
3
+ metadata.gz: f53ed707cdafa1bedf790afd1465aefd1453bb7f7a1d358a577ee4769743d94a
4
+ data.tar.gz: 77274ebd06c82c4caec8369f6cf9eaeafd90c70960ed2722314cdd773c08a02b
5
5
  SHA512:
6
- metadata.gz: 20f4b5844debd83589f2dc4f9cebe7be963f9dd7ec6749227db7fad00aca4366cdb87003776194695db84f2bc23739b65f866460d92622dbad8923ff690b9799
7
- data.tar.gz: 3528895af9ce6f1d4d2e33dab0b6a2fa60cb255d3211a0cfc5b0e97d0f2444e7270c696872c47562dd18d822a95a550345068073a50f80d7ebdd0c9eac782bf8
6
+ metadata.gz: 83283b1fbd4983b9a7814cf5f67dad4c78df64d046db45c95f1f6aa8f118f1a1cb0e522b32bb8e5f38e8e0a52ec2408da209abc03a041fd9f665015d2c8b854f
7
+ data.tar.gz: 98091d7a44f02ddfad810af0195dab7c8c581475b8d049b570d28c86921363c6fafa8ab6fcc4221dc5efa662fae3918e5f98579f45f847ee82ba3d97e44a5b8c
data/CHANGELOG.md CHANGED
@@ -1,5 +1,25 @@
1
1
  # Changelog
2
2
 
3
+ ## [v2.14.3](https://github.com/bensheldon/good_job/tree/v2.14.3) (2022-05-13)
4
+
5
+ [Full Changelog](https://github.com/bensheldon/good_job/compare/v2.14.2...v2.14.3)
6
+
7
+ **Fixed bugs:**
8
+
9
+ - Bind probe server to all interfaces [\#598](https://github.com/bensheldon/good_job/pull/598) ([Timmitry](https://github.com/Timmitry))
10
+
11
+ **Closed issues:**
12
+
13
+ - NoMethodError: undefined method `current\_tags' for nil:NilClass [\#596](https://github.com/bensheldon/good_job/issues/596)
14
+ - When running rspec, I get: current transaction is aborted, commands ignored until end of transaction block [\#595](https://github.com/bensheldon/good_job/issues/595)
15
+ - CLI healtheck only listening on localhost, not reachable for Kubernetes [\#592](https://github.com/bensheldon/good_job/issues/592)
16
+
17
+ **Merged pull requests:**
18
+
19
+ - Improve development instructions and tooling \(rename bin/rails, add bin/appraisal\) [\#590](https://github.com/bensheldon/good_job/pull/590) ([bensheldon](https://github.com/bensheldon))
20
+ - Replace test Instrumentation mocking with temporary subscriptions [\#589](https://github.com/bensheldon/good_job/pull/589) ([bensheldon](https://github.com/bensheldon))
21
+ - Update to development to Ruby 3.0.4, include `matrix` gem in development Gemfile [\#588](https://github.com/bensheldon/good_job/pull/588) ([bensheldon](https://github.com/bensheldon))
22
+
3
23
  ## [v2.14.2](https://github.com/bensheldon/good_job/tree/v2.14.2) (2022-05-01)
4
24
 
5
25
  [Full Changelog](https://github.com/bensheldon/good_job/compare/v2.14.1...v2.14.2)
data/README.md CHANGED
@@ -60,6 +60,9 @@ For more of the story of GoodJob, read the [introductory blog post](https://isla
60
60
  - [CLI HTTP health check probes](#cli-http-health-check-probes)
61
61
  - [Contribute](#contribute)
62
62
  - [Gem development](#gem-development)
63
+ - [Development setup](#development-setup)
64
+ - [Rails development harness](#rails-development-harness)
65
+ - [Running tests](#running-tests)
63
66
  - [Release](#release)
64
67
  - [License](#license)
65
68
 
@@ -941,49 +944,82 @@ spec:
941
944
 
942
945
  ## Contribute
943
946
 
944
- Contributions are welcomed and appreciated 🙏
947
+ <!-- Please keep this section in sync with CONTRIBUTING.md -->
948
+
949
+ All contributions, from feedback to code and beyond, are welcomed and appreciated 🙏
945
950
 
946
951
  - Review the [Prioritized Project Backlog](https://github.com/bensheldon/good_job/projects/1).
947
952
  - Open a new Issue or contribute to an [existing Issue](https://github.com/bensheldon/good_job/issues). Questions or suggestions are fantastic.
948
- - Participate according to our [Code of Conduct](https://github.com/bensheldon/good_job/projects/1).
953
+ - Participate according to our [Code of Conduct](/CODE_OF_CONDUCT.md).
954
+ - Financially support the project via [Sponsorship](https://github.com/sponsors/bensheldon).
955
+
956
+ For gem development and debugging information, please review the [README's Gem Development section](/README.md#gem-development).
949
957
 
950
958
  ### Gem development
951
959
 
952
- To run tests:
960
+ #### Development setup
953
961
 
954
962
  ```bash
955
963
  # Clone the repository locally
956
- $ git clone git@github.com:bensheldon/good_job.git
964
+ git clone git@github.com:bensheldon/good_job.git
957
965
 
958
966
  # Set up the local environment
959
- $ bin/setup
960
-
961
- # Run the tests
962
- $ bin/rspec
967
+ bin/setup
963
968
  ```
964
969
 
965
- This gem uses Appraisal to run tests against multiple versions of Rails:
970
+ #### Rails development harness
971
+
972
+ A Rails application exists within `spec/test_app` that is used for development, test, and GoodJob Demo environments.
966
973
 
967
974
  ```bash
968
- # Install Appraisal(s) gemfiles
969
- $ bundle exec appraisal
975
+ # Run a local development webserver
976
+ bin/rails s
977
+
978
+ # Disable job execution and cron for cleaner console output
979
+ GOOD_JOB_ENABLE_CRON=0 GOOD_JOB_EXECUTION_MODE=external bin/rails s
970
980
 
971
- # Run tests
972
- $ bundle exec appraisal bin/rspec
981
+ # Open the Rails console
982
+ bin/rails c
973
983
  ```
974
984
 
975
985
  For developing locally within another Ruby on Rails project:
976
986
 
977
987
  ```bash
978
- # Within Ruby on Rails directory...
979
- $ bundle config local.good_job /path/to/local/git/repository
988
+ # Within Ruby on Rails project directory
989
+ # Ensure that the Gemfile is set to git with a branch e.g.
990
+ # gem "good_job", git: "https://github.com/bensheldon/good_job.git", branch: "main"
991
+ # Then, override the Bundle config to point to the local filesystem's good_job repository
992
+ bundle config local.good_job /path/to/local/good_job/repository
980
993
 
981
994
  # Confirm that the local copy is used
982
- $ bundle install
995
+ bundle install
983
996
 
984
997
  # => Using good_job 0.1.0 from https://github.com/bensheldon/good_job.git (at /Users/You/Projects/good_job@dc57fb0)
985
998
  ```
986
999
 
1000
+ #### Running tests
1001
+
1002
+ Tests can be run against the primary development environment:
1003
+
1004
+ ```bash
1005
+ bin/rspec
1006
+ ```
1007
+
1008
+ Environment variables that may help with debugging:
1009
+
1010
+ - `LOUD=1`: display all stdout/stderr output from all sources. This is helpful because GoodJob wraps some tests with `quiet { }` for cleaner test output, but it can hinder debugging.
1011
+ - `SHOW_BROWSER=1`: Run system tests headfully with Chrome/Chromedriver. Use `binding.irb` in the system tests to pause.
1012
+
1013
+ Appraisal can be used to run a test matrix of multiple versions of Rails:
1014
+
1015
+ ```bash
1016
+ # Install Appraisal matrix of gemfiles
1017
+ bin/appraisal
1018
+
1019
+ # Run tests against matrix
1020
+ bin/appraisal bin/rspec
1021
+ ```
1022
+
987
1023
  ### Release
988
1024
 
989
1025
  Package maintainers can release this gem by running:
@@ -17,7 +17,7 @@ module GoodJob
17
17
  def start
18
18
  @handler = Rack::Handler.get(RACK_SERVER)
19
19
  @future = Concurrent::Future.new(args: [@handler, @port, GoodJob.logger]) do |thr_handler, thr_port, thr_logger|
20
- thr_handler.run(self, Port: thr_port, Logger: thr_logger, AccessLog: [])
20
+ thr_handler.run(self, Port: thr_port, Host: '0.0.0.0', Logger: thr_logger, AccessLog: [])
21
21
  end
22
22
  @future.add_observer(self.class, :task_observer)
23
23
  @future.execute
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
  module GoodJob
3
3
  # GoodJob gem version.
4
- VERSION = '2.14.2'
4
+ VERSION = '2.14.3'
5
5
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: good_job
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.14.2
4
+ version: 2.14.3
5
5
  platform: ruby
6
6
  authors:
7
7
  - Ben Sheldon
8
8
  autorequire:
9
9
  bindir: exe
10
10
  cert_chain: []
11
- date: 2022-05-01 00:00:00.000000000 Z
11
+ date: 2022-05-13 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activejob
@@ -483,7 +483,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
483
483
  - !ruby/object:Gem::Version
484
484
  version: '0'
485
485
  requirements: []
486
- rubygems_version: 3.3.7
486
+ rubygems_version: 3.2.33
487
487
  signing_key:
488
488
  specification_version: 4
489
489
  summary: A multithreaded, Postgres-based ActiveJob backend for Ruby on Rails