goma 0.0.1.rc1 → 0.0.1.rc2

data/test/models/recoverable_test.rb

@@ -0,0 +1,108 @@
+require 'test_helper'
+
+class RecoverableTest < ActiveSupport::TestCase
+  test 'send_reset_password_instructions!' do
+    Goma.token_generator.expects(:friendly_token).returns('sesame')
+
+    user = Fabricate(:user)
+    assert_nil user.reset_password_token
+    assert_nil user.reset_password_token_sent_at
+
+    assert_emails 1 do
+      user.send_reset_password_instructions!
+    end
+    email = ActionMailer::Base.deliveries.last
+    assert_match %r{/passwords/sesame}, email.body.encoded
+
+    user.reload
+    assert user.reset_password_token
+    assert user.reset_password_token_sent_at
+  end
+
+  test 'change_password!' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+
+    user.change_password!('newpassword', 'newpassword')
+    user.reload
+    assert_nil user.reset_password_token
+    assert_nil user.reset_password_token_sent_at
+    assert user.valid_password?('newpassword')
+  end
+
+  test 'load_from_reset_password_token_with_error with correct token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    raw_token = user.raw_reset_password_token
+    loaded_user, error = User.load_from_reset_password_token_with_error(raw_token)
+    assert_equal user, loaded_user
+    assert_nil error
+  end
+
+  test 'load_from_reset_password_token_with_error with wrong token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    loaded_user, error = User.load_from_reset_password_token_with_error('beans')
+    assert_nil loaded_user
+    assert_equal :not_found, error
+  end
+
+  test 'load_from_reset_password_token_with_error with expired token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    raw_token = user.raw_reset_password_token
+    Timecop.travel 7.hours.from_now do
+      loaded_user, error = User.load_from_reset_password_token_with_error(raw_token)
+      assert_nil loaded_user
+      assert_equal :token_expired, error
+    end
+  end
+
+  test 'load_from_reset_password_token! with correct token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    raw_token = user.raw_reset_password_token
+    assert_equal user, User.load_from_reset_password_token!(raw_token)
+  end
+
+  test 'load_from_reset_password_token! with wrong token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    assert_raise Goma::NotFound do
+      User.load_from_reset_password_token!('beans')
+    end
+  end
+
+  test 'load_from_reset_password_token! with expired token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    raw_token = user.raw_reset_password_token
+    Timecop.travel 7.hours.from_now do
+      assert_raise Goma::TokenExpired do
+        User.load_from_reset_password_token!(raw_token)
+      end
+    end
+  end
+
+  test 'load_from_reset_password_token with correct token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    raw_token = user.raw_reset_password_token
+    assert_equal user, User.load_from_reset_password_token(raw_token)
+  end
+
+  test 'load_from_reset_password_token with wrong token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    assert_nil User.load_from_reset_password_token('beans')
+  end
+
+  test 'load_from_reset_password_token with expired token' do
+    user = Fabricate(:user)
+    user.send_reset_password_instructions!
+    raw_token = user.raw_reset_password_token
+    Timecop.travel 7.hours.from_now do
+      assert_nil User.load_from_reset_password_token(raw_token)
+    end
+  end
+end

data/test/models/rememberable_test.rb

@@ -0,0 +1,115 @@
+require "test_helper"
+
+class RememberableTest < ActiveSupport::TestCase
+  def setup
+    @user = Fabricate(:user)
+  end
+
+  test 'remember_me!' do
+    @user.remember_me!
+
+    assert_equal Time.now.utc.to_s, @user.remember_created_at.to_s
+  end
+
+  test 'remember_me! should not update remember_created_at' do
+    Timecop.freeze Time.now
+    @user.remember_me!
+    remember_created_at = Time.now.utc
+
+    Timecop.freeze (2.weeks - 1.second).from_now
+    @user.remember_me!
+    assert_equal remember_created_at.to_s, @user.remember_created_at.to_s
+
+    Timecop.return
+  end
+
+  test 'remember_me! should update remember_created_at if config.extend_remember_period == true' do
+    swap Goma.config(:user), extend_remember_period: true do
+      @user.remember_me!
+      assert_equal Time.now.utc.to_s, @user.remember_created_at.to_s
+
+      Timecop.freeze 1.day.from_now do
+        @user.remember_me!
+        assert_equal Time.now.utc.to_s, @user.remember_created_at.to_s
+      end
+    end
+  end
+
+  test 'remember_me! should update remember_created_at if remember period expired' do
+    @user.remember_me!
+    assert_equal Time.now.utc.to_s, @user.remember_created_at.to_s
+
+    Timecop.freeze 2.weeks.from_now do
+      @user.remember_me!
+      assert_equal Time.now.utc.to_s, @user.remember_created_at.to_s
+    end
+  end
+
+  test 'forget_me!' do
+    @user.remember_me!
+    @user.forget_me!
+    assert_nil @user.remember_created_at
+  end
+
+  test 'remember_me! should generate remember_token if config.remember_token_attribute_name != nil' do
+    @user.singleton_class.send :attr_accessor, :remember_token
+    swap Goma.config(:user), remember_token_attribute_name: :remember_token do
+      @user.remember_me!
+      assert @user.remember_token
+    end
+  end
+
+  test 'remember_me! should regenerate remember_token if config.remember_token_attribute_name != nil and remember period expired' do
+    @user.singleton_class.send :attr_accessor, :remember_token
+    swap Goma.config(:user), remember_token_attribute_name: :remember_token do
+      Timecop.freeze Time.now
+      @user.remember_me!
+      token = @user.remember_token
+
+      Timecop.freeze (2.weeks - 1.second).from_now
+      @user.remember_me!
+      assert_equal token, @user.remember_token
+
+      Timecop.freeze 1.second.from_now
+      @user.remember_me!
+      assert_not_equal token, @user.remember_token
+      assert @user.remember_token
+      Timecop.return
+    end
+  end
+
+  test 'serialize_into_cookie and serialize_from_cookie' do
+    @user.remember_me!
+    serialized = User.serialize_into_cookie(@user)
+    assert serialized
+    assert_equal @user, User.serialize_from_cookie(*serialized)
+  end
+
+  test 'serialize_from_cookie return nil if it is wrong' do
+    @user.remember_me!
+    serialized = User.serialize_into_cookie(@user)
+    serialized.last << 'aaa'
+    assert_nil User.serialize_from_cookie(*serialized)
+  end
+
+  test 'serialize_from_cookie return nil if user changed her password' do
+    @user.remember_me!
+    serialized = User.serialize_into_cookie(@user)
+    @user.update(password: 'newpassword', password_confirmation: 'newpassword')
+    assert_nil User.serialize_from_cookie(*serialized)
+  end
+
+  test 'serialize_from_cookie return nil if remember period expired' do
+    Timecop.freeze Time.now
+    @user.remember_me!
+    serialized = User.serialize_into_cookie(@user)
+
+    Timecop.freeze (2.weeks - 1.second).from_now
+    assert_equal @user, User.serialize_from_cookie(*serialized)
+
+    Timecop.freeze 1.second.from_now
+    assert_nil User.serialize_from_cookie(*serialized)
+
+    Timecop.return
+  end
+end

data/test/models/timeoutable_test.rb

@@ -0,0 +1,33 @@
+require "test_helper"
+
+class TimeoutableTest < ActiveSupport::TestCase
+  test 'timeout? return false if remembered' do
+    user = Fabricate(:user)
+    user.stubs(:rememberable?).returns(true)
+    user.stubs(:remember_expired?).returns(false)
+
+    refute user.timeout?(1.hour.ago)
+  end
+
+  test 'timeout? return false if last_request_at == nil' do
+    user = Fabricate(:user)
+    refute user.timeout?(nil)
+  end
+
+  test 'timeout? return true if last_request_at <= config.timeout_in.ago' do
+    user = Fabricate(:user)
+    assert user.timeout?(30.minutes.ago)
+  end
+
+  test 'timeout? return false if last_request_at > config.timeout_in.ago' do
+    user = Fabricate(:user)
+    refute user.timeout?(29.minutes.ago)
+  end
+
+  test 'timeout? return false if timeout_in == nil' do
+    swap Goma.config(:user), timeout_in: nil do
+      user = Fabricate(:user)
+      refute user.timeout?(29.minutes.ago)
+    end
+  end
+end

data/test/models/trackable_test.rb

@@ -0,0 +1,37 @@
+require "test_helper"
+
+class TrackableTest < ActiveSupport::TestCase
+  test 'update_tracked_fields!' do
+    Timecop.freeze Time.now do
+      user = Fabricate(:user, last_login_at: 2.days.ago.utc,
+                              current_login_at: 1.hour.ago.utc,
+                              last_login_ip: '127.0.0.1',
+                              current_login_ip: '127.0.0.2',
+                              login_count: 2)
+      request = stub(remote_ip: '127.0.0.3')
+      user.update_tracked_fields!(request)
+
+      user.reload
+      assert_equal 1.hour.ago.utc.to_s, user.last_login_at.to_s
+      assert_equal Time.now.utc.to_s, user.current_login_at.to_s
+      assert_equal '127.0.0.2', user.last_login_ip
+      assert_equal '127.0.0.3', user.current_login_ip
+      assert_equal 3, user.login_count
+    end
+  end
+
+  test 'update_tracked_fields! for the first time' do
+    Timecop.freeze Time.now do
+      user = Fabricate(:user)
+      request = stub(remote_ip: '127.0.0.3')
+      user.update_tracked_fields!(request)
+
+      user.reload
+      assert_equal Time.now.utc.to_s, user.last_login_at.to_s
+      assert_equal Time.now.utc.to_s, user.current_login_at.to_s
+      assert_equal '127.0.0.3', user.last_login_ip
+      assert_equal '127.0.0.3', user.current_login_ip
+      assert_equal 1, user.login_count
+    end
+  end
+end

data/test/models/validatable_test.rb

@@ -1,59 +1,155 @@
 require 'test_helper'
 
-class ValidatableTest < ActiveSupport::TestCase
+module ValidatableTests
+  extend ActiveSupport::Testing::Declarative
+
+  test 'should pass all the validations with valid data' do
+    user = Fabricate.build(:unactivated_user)
+    assert user.valid?
+  end
+
+  test 'validates_uniqueness_of a value of an authentication key other than email' do
+    @user.assign_attributes(username: 'foo')
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Username has already been taken", @user.errors.full_messages.first
+  end
+
+  test 'validates_uniqueness_of :email' do
+    @user.assign_attributes(email: 'foo@example.com')
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Email has already been taken", @user.errors.full_messages.first
+  end
+
+  test 'validates_format_of :email' do
+    @user.assign_attributes(email: 'foo.example.com')
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Email is invalid", @user.errors.full_messages.first
+  end
+
+  test 'validates_length_of :password with too short password' do
+    @user.assign_attributes(password: 's' * 7, password_confirmation: 's' * 7)
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Password is too short (minimum is 8 characters)", @user.errors.full_messages.first
+  end
+
+  test 'validates_length_of :password with too long password' do
+    @user.assign_attributes(password: 's' * 129, password_confirmation: 's' * 129)
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Password is too long (maximum is 128 characters)", @user.errors.full_messages.first
+
+    @user.assign_attributes(password: 's' * 128, password_confirmation: 's' * 128)
+    assert @user.valid?
+  end
+
+  test 'validates_confirmation_of :password' do
+    @user.assign_attributes(password: 'password', password_confirmation: 'oops')
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Password confirmation doesn't match Password", @user.errors.full_messages.first
+  end
+end
+
+class NewUserValidatableTest < ActiveSupport::TestCase
+  include ValidatableTests
+
   def setup
-    @user = Fabricate(:user, username: 'foo', email: 'foo@example.com')
+    Fabricate(:user, username: 'foo', email: 'foo@example.com')
+    @user = Fabricate.build(:user)
   end
 
-  test 'should pass all the validations with valid data' do
-    assert_difference 'User.count', 1 do
-      User.create!(username: 'bar', email: 'bar@example.com', password: 'password', password_confirmation: 'password')
-    end
+  test 'validates_presence_of a value of an authentication key other than email' do
+    @user.assign_attributes(username: nil)
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Username can't be blank", @user.errors.full_messages.first
   end
 
-  test 'should validates_presence_of :username' do
-    assert_raise ActiveRecord::RecordInvalid do
-      user = User.create!(username: nil, email: 'bar@example.com', password: 'password', password_confirmation: 'password')
-    end
+  test 'validates_presence_of :email' do
+    @user.assign_attributes(email: nil)
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Email can't be blank", @user.errors.full_messages.first
   end
 
-  test 'should validates_uniqueness_of :username' do
-    assert_raise ActiveRecord::RecordInvalid do
-      user = User.create!(username: 'foo', email: 'bar@example.com', password: 'password', password_confirmation: 'password')
-    end
+  test 'validates_presense_of :password' do
+    @user.assign_attributes(password: '', password_confirmation: '')
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Password can't be blank", @user.errors.full_messages.first
   end
+end
 
-  test 'should validates_presence_of :email' do
-    assert_raise ActiveRecord::RecordInvalid do
-      user = User.create!(username: 'foo', email: nil, password: 'password', password_confirmation: 'password')
-    end
+class ExistingUserValidatableTest < ActiveSupport::TestCase
+  include ValidatableTests
+
+  def setup
+    Fabricate(:user, username: 'foo', email: 'foo@example.com')
+    @user = Fabricate(:user)
   end
 
-  test 'should validates_uniqueness_of :email' do
-    assert_raise ActiveRecord::RecordInvalid do
-      user = User.create!(username: 'bar', email: 'foo@example.com', password: 'password', password_confirmation: 'password')
-    end
+  test 'validates_presence_of a value of an authentication key other than email' do
+    @user.assign_attributes(username: nil)
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Username can't be blank", @user.errors.full_messages.first
   end
 
-  test 'should validates_format_of :email' do
-    assert_raise ActiveRecord::RecordInvalid do
-      user = User.create!(username: 'bar', email: 'bar.example.com', password: 'password', password_confirmation: 'password')
-    end
+  test 'validates_presence_of :email' do
+    @user.assign_attributes(email: nil)
+    refute @user.valid?
+    assert_equal 1, @user.errors.count
+    assert_equal "Email can't be blank", @user.errors.full_messages.first
   end
+end
 
-  test 'should validates_length_of :password with too short password' do
-    assert_raise ActiveRecord::RecordInvalid do
-      user = User.create!(username: 'bar', email: 'bar@example.com', password: 's' * 7, password_confirmation: 's' * 7)
-    end
+class UserCreatingWithOmniauthValidatableTest < ActiveSupport::TestCase
+  include ValidatableTests
+
+  def setup
+    Fabricate(:user, username: 'foo', email: 'foo@example.com')
+    @user = User.build_with_omniauth!(Fabricate.attributes_for(:authentication))
   end
 
-  test 'should validates_length_of :password with too long password' do
-    assert_raise ActiveRecord::RecordInvalid do
-      user = User.create!(username: 'bar', email: 'bar@example.com', password: 's' * 129, password_confirmation: 's' * 129)
+  test 'should check validations if *_required? returns true' do
+    class NamedUser < User
+      def username_required?
+        true
+      end
     end
+    user = NamedUser.build_with_omniauth!(Fabricate.attributes_for(:authentication))
+    refute user.valid?
+    assert_equal 1, user.errors.count
+    assert_equal "Username can't be blank", user.errors.full_messages.first
+    user.username = 'Ugo'
+    assert user.valid?
+  end
+end
+
+class OAuthUserValidatableTest < ActiveSupport::TestCase
+  include ValidatableTests
+
+  def setup
+    Fabricate(:user, username: 'foo', email: 'foo@example.com')
+    @user = Fabricate(:oauth_user)
+  end
 
-    assert_difference 'User.count', 1 do
-      User.create!(username: 'baz', email: 'baz@example.com', password: 's' * 128, password_confirmation: 's' * 128)
+  test 'should check validations if *_required? returns true' do
+    class NamedUser < User
+      def username_required?
+        true
+      end
     end
+    user = NamedUser.build_with_omniauth!(Fabricate.attributes_for(:authentication))
+    user.save!(validate: false)
+    refute user.valid?
+    assert_equal 1, user.errors.count
+    assert_equal "Username can't be blank", user.errors.full_messages.first
+    user.username = 'Ugo'
+    assert user.valid?
   end
 end

data/test/rails_app/config/initializers/goma.rb

@@ -63,7 +63,7 @@ Goma.configure do |config|
   # Timeoutable
   # config.timeout_in = 30.minutes
   # config.logout_all_scopes = false
-  # config.validate_session_even_in_not_login_area = true
+  config.validate_session_even_in_not_login_area = ENV['VALIDATE_SESSION_EVEN_IN_NOT_LOGIN_AREA'] == 'true'
 
   ####################################################
   # Lockable

data/test/rails_app/db/migrate/20140515111009_create_users.rb

@@ -14,6 +14,7 @@ class CreateUsers < ActiveRecord::Migration
       t.string :activated_at
 
       # Rememberable
+      t.string :remember_token # Added for test. This field does not exist in the default settings.
       t.datetime :remember_created_at
 
       # Lockable

data/test/rails_app/db/schema.rb

@@ -32,6 +32,7 @@ ActiveRecord::Schema.define(version: 20140515111010) do
     t.string   "confirmation_token"
     t.datetime "confirmation_token_sent_at"
     t.string   "activated_at"
+    t.string   "remember_token"
     t.datetime "remember_created_at"
     t.integer  "failed_attempts",              default: 0, null: false
     t.datetime "locked_at"

data/test/test_helper.rb

@@ -29,6 +29,7 @@ if ActiveSupport::TestCase.method_defined?(:fixture_path=)
 end
 
 class ActiveSupport::TestCase
+  include ActionMailer::TestHelper
   def swap(object, values)
     original_values = {}
     values.each do |k, v|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: goma
 version: !ruby/object:Gem::Version
-  version: 0.0.1.rc1
+  version: 0.0.1.rc2
 platform: ruby
 authors:
 - Kentaro Imai
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-19 00:00:00.000000000 Z
+date: 2014-05-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -280,12 +280,11 @@ files:
 - lib/goma/version.rb
 - lib/goma/warden.rb
 - lib/tasks/goma_tasks.rake
-- test/config_test.rb
 - test/controllers/helpers_test.rb
 - test/controllers/lockable_controller_test.rb
 - test/controllers/sessions_controller_test.rb
-- test/fabricators/users_fabricator.rb
-- test/goma_test.rb
+- test/fabricators/authentication_fabricator.rb
+- test/fabricators/user_fabricator.rb
 - test/integration/confirmable_integration_test.rb
 - test/integration/lockable_integration_test.rb
 - test/integration/omniauthable_integration_test.rb
@@ -297,8 +296,14 @@ files:
 - test/integration/trackable_integration_test.rb
 - test/models/authenticatable_test.rb
 - test/models/confirmable_test.rb
+- test/models/goma_test.rb
+- test/models/lockable_test.rb
 - test/models/omniauthable_test.rb
 - test/models/password_authenticatable_test.rb
+- test/models/recoverable_test.rb
+- test/models/rememberable_test.rb
+- test/models/timeoutable_test.rb
+- test/models/trackable_test.rb
 - test/models/validatable_test.rb
 - test/orm/active_record.rb
 - test/rails_app/README.rdoc
@@ -407,11 +412,7 @@ post_install_message: "\n\e[32mThank you for installing!\n\nYou can use this gem
   \ \e[0mconfig.action_mailer.default_url_options = { host: 'localhost:3000' }\e[32m\n\n
   \ in production, :host should be set to the actual host of your application.\n\n===========================================================================\n\n\nThat's
   it.\n\nThis gem is in early development phase and I do not recommend you to use
-  this for production for a while.\nBug reports and pull requests are welcome.\n\nI
-  am surprised that this gem has been downloaded over 200 times, in spite of pre release
-  versions of v0.0.1.\nAnd, I feel bad about there were lots of bugs and incomplete
-  implementations in previous versions.\n\nI will release this as a release candidate,
-  but will add lots of code before v0.0.1.\n\nEnjoy!\e[0m\n"
+  this for production for a while.\nBug reports and pull requests are welcome.\n\nEnjoy!\e[0m\n"
 rdoc_options: []
 require_paths:
 - lib
@@ -432,12 +433,11 @@ signing_key:
 specification_version: 4
 summary: An authentication solution for Rails 4
 test_files:
-- test/config_test.rb
 - test/controllers/helpers_test.rb
 - test/controllers/lockable_controller_test.rb
 - test/controllers/sessions_controller_test.rb
-- test/fabricators/users_fabricator.rb
-- test/goma_test.rb
+- test/fabricators/authentication_fabricator.rb
+- test/fabricators/user_fabricator.rb
 - test/integration/confirmable_integration_test.rb
 - test/integration/lockable_integration_test.rb
 - test/integration/omniauthable_integration_test.rb
@@ -449,8 +449,14 @@ test_files:
 - test/integration/trackable_integration_test.rb
 - test/models/authenticatable_test.rb
 - test/models/confirmable_test.rb
+- test/models/goma_test.rb
+- test/models/lockable_test.rb
 - test/models/omniauthable_test.rb
 - test/models/password_authenticatable_test.rb
+- test/models/recoverable_test.rb
+- test/models/rememberable_test.rb
+- test/models/timeoutable_test.rb
+- test/models/trackable_test.rb
 - test/models/validatable_test.rb
 - test/orm/active_record.rb
 - test/rails_app/README.rdoc

data/test/config_test.rb

@@ -1,2 +0,0 @@
-require 'test_helper'
-