golint 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b17a8fc7941117aa55eb791c0701d08024bdaf88
-  data.tar.gz: 9a32b26e1bf0441e3c1dcc0e9bd8df8103dfe4b3
+  metadata.gz: 99aeb7a1e0d2754c3fddd1cb0b47d031f500d59b
+  data.tar.gz: 8a0c9f63aa71e0467e1830a025c777d62bb765da
 SHA512:
-  metadata.gz: 33db5a4cbdfa7db1140aa11fc409d866bc2ccf710cb10b2c1ca6a71046cd442bd8c935c5aca3989092bc359b8c20d6a9be25c06e28532d85fd2322398bcdedc4
-  data.tar.gz: 50f1567b999ad19b6806f9bf07f91c9683f93d93cd534f30f731124c279549abf8cb0f4cc1cd860ea5fe824482939a8c251218b4c92960ed7dfb7d7fece6944f
+  metadata.gz: b7e55ec17dc9b33e113efd3a0274170303b2dea3c6651443970a3d24b309693e494ccddf08aed357bd01f56da18947fc2b5089e6d78bba5e36a8db10b6b1dd45
+  data.tar.gz: 5983ac1ec23f485bfcf03df8e7d590af83ce580d4a2125934e85962507dd1a0002b6613d2dcc2ae73aa2cad7835fa2500ea8daca4934dac6369b90f29961cb08

data/golint.gemspec

@@ -19,5 +19,5 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rake", "~> 0"
 end

data/lib/golint.rb

@@ -1,6 +1,7 @@
 require "golint/version"
 require "tempfile"
 require "base64"
+require 'open3'
 
 module Golint
   class Match < Struct.new(:line, :comment)
@@ -15,15 +16,26 @@ module Golint
       file.write(content)
       file.close
 
-      diff = `golint #{file.path}`
+      stdin, stdout, stderr, wait_thr = Open3.popen3('golint', file.path)
 
-      pattern = "#{file.path}:"
+      out = stdout.read
+      err = stderr.read
 
+      if err.size > 0
+        parse_matches(file.path, err)
+      elsif out.size > 0
+        parse_matches(file.path, out)
+      end
+    end
+
+    def parse_matches(path, body)
+      pattern = "#{path}:"
       matches = []
-      diff.each_line do |line|
+      body.each_line do |line|
         line = line.sub(pattern, "").sub("\n", "")
+
         res = line.match(REGEXP)
-        matches << Match.new(res[1], res[3].strip)
+        matches << Match.new(res[1].to_i, res[3].strip)
       end
 
       matches

data/lib/golint/version.rb

@@ -1,3 +1,3 @@
 module Golint
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/test/golint_test.rb

@@ -1,8 +1,41 @@
 require 'test_helper'
 
 class TestGolint < MiniTest::Unit::TestCase
-  def test_shit
+  def test_server
     file = File.open('test/fixtures/server.go')
-    puts Golint.lint(file.read)
+    results = Golint.lint(file.read)
+
+    assert_equal results.size, 11
+
+    assert_equal results[0].line, 30
+    assert_equal results[0].comment, "don't use underscores in Go names; var item_id should be itemID"
+    assert_equal results[1].line, 32
+    assert_equal results[1].comment, "don't use underscores in Go names; var some_item should be someItem"
+    assert_equal results[2].line, 69
+    assert_equal results[2].comment, "don't use underscores in Go names; var revision_file should be revisionFile"
+    assert_equal results[3].line, 83
+    assert_equal results[3].comment, "don't use underscores in Go names; var category_id should be categoryID"
+    assert_equal results[4].line, 84
+    assert_equal results[4].comment, "don't use underscores in Go names; var aspect_filters should be aspectFilters"
+    assert_equal results[5].line, 87
+    assert_equal results[5].comment, "don't use underscores in Go names; var per_page should be perPage"
+    assert_equal results[6].line, 92
+    assert_equal results[6].comment, "don't use underscores in Go names; var page_num should be pageNum"
+    assert_equal results[7].line, 97
+    assert_equal results[7].comment, "don't use underscores in Go names; var search_result should be searchResult"
+    assert_equal results[8].line, 118
+    assert_equal results[8].comment, "don't use underscores in Go names; var secret_useragent should be secretUseragent"
+    assert_equal results[9].line, 122
+    assert_equal results[9].comment, "don't use ALL_CAPS in Go names; use CamelCase"
+    assert_equal results[10].line, 122
+    assert_equal results[10].comment, "exported const ROUTE_PREFIX should have comment (or a comment on this block) or be unexported"
+  end
+
+  def test_one_line
+    results = Golint.lint('item_id := vars["item_id"]')
+
+    assert_equal results.size, 1
+    assert_equal results[0].line, 1
+    assert_equal results[0].comment, "expected 'package', found 'IDENT' item_id"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: golint
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Kir Shatrov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-15 00:00:00.000000000 Z
+date: 2014-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,14 +28,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 description: Ruby wrapper for golint utility