goliath 0.9.0

data/spec/unit/rack/validation/numeric_range_spec.rb

@@ -0,0 +1,96 @@
+require 'spec_helper'
+require 'goliath/rack/validation/numeric_range'
+
+describe Goliath::Rack::Validation::NumericRange do
+  before(:each) do
+    @app = mock('app').as_null_object
+    @env = {'params' => {}}
+  end
+
+  it 'accepts options on create' do
+    opts = { :min => 1, :key => 2 }
+    lambda { Goliath::Rack::Validation::NumericRange.new('my app', opts) }.should_not raise_error(Exception)
+  end
+
+  describe 'with middleware' do
+    before(:each) do
+      @nr = Goliath::Rack::Validation::NumericRange.new(@app, {:key => 'id', :min => -5, :max => 20, :default => 15})
+    end
+
+    it 'uses the default if value is less then min' do
+      @env['params']['id'] = -10
+      @nr.call(@env)
+      @env['params']['id'].should == 15
+    end
+
+    it 'uses the default if value is greater then max' do
+      @env['params']['id'] = 25
+      @nr.call(@env)
+      @env['params']['id'].should == 15
+    end
+
+    it 'uses the first value, if the value is an array' do
+      @env['params']['id'] = [10,11,12]
+      @nr.call(@env)
+      @env['params']['id'].should == 10
+    end
+
+    it 'uses the default if value is not present' do
+      @nr.call(@env)
+      @env['params']['id'].should == 15
+    end
+
+    it 'uses the default if value is nil' do
+      @env['params']['id'] = nil
+      @nr.call(@env)
+      @env['params']['id'].should == 15
+    end
+
+    it 'returns the app status, headers and body' do
+      app_headers = {'Content-Type' => 'app'}
+      app_body = {'b' => 'c'}
+      @app.should_receive(:call).and_return([200, app_headers, app_body])
+
+      status, headers, body = @nr.call(@env)
+      status.should == 200
+      headers.should == app_headers
+      body.should == app_body
+    end
+  end
+
+  it 'raises error if key is not set' do
+    lambda { Goliath::Rack::Validation::NumericRange.new('app', {:min => 5}) }.should raise_error(Exception)
+  end
+
+  it 'raises error if neither min nor max set' do
+    lambda { Goliath::Rack::Validation::NumericRange.new('app', {:key => 5}) }.should raise_error(Exception)
+  end
+
+  it 'uses min if default not set' do
+    nr = Goliath::Rack::Validation::NumericRange.new(@app, {:key => 'id', :min => 5, :max => 10})
+    @env['params']['id'] = 15
+    nr.call(@env)
+    @env['params']['id'].should == 5
+  end
+
+  it 'uses max if default and min not set' do
+    nr = Goliath::Rack::Validation::NumericRange.new(@app, {:key => 'id', :max => 10})
+    @env['params']['id'] = 15
+    nr.call(@env)
+    @env['params']['id'].should == 10
+  end
+
+  it "doesn't require min" do
+    nr = Goliath::Rack::Validation::NumericRange.new(@app, {:key => 'id', :max => 10})
+    @env['params']['id'] = 8
+    nr.call(@env)
+    @env['params']['id'].should == 8
+  end
+
+  it "doesn't require max" do
+    nr = Goliath::Rack::Validation::NumericRange.new(@app, {:key => 'id', :min => 1})
+    @env['params']['id'] = 15
+    nr.call(@env)
+    @env['params']['id'].should == 15
+  end
+end

data/spec/unit/rack/validation/request_method_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require 'goliath/rack/validation/request_method'
+
+describe Goliath::Rack::Validation::RequestMethod do
+  before(:each) do
+    @app = mock('app').as_null_object
+  end
+
+  it 'accepts an app' do
+    lambda { Goliath::Rack::Validation::RequestMethod.new('my app') }.should_not raise_error(Exception)
+  end
+
+  describe 'with defaults' do
+    before(:each) do
+      @env = {}
+      @rm = Goliath::Rack::Validation::RequestMethod.new(@app, ['GET', 'POST'])
+    end
+
+    it 'raises error if method is invalid' do
+      @env['REQUEST_METHOD'] = 'fubar'
+      lambda { @rm.call(@env) }.should raise_error(Goliath::Validation::Error)
+    end
+
+    it 'allows valid methods through' do
+      @env['REQUEST_METHOD'] = 'GET'
+      lambda { @rm.call(@env) }.should_not raise_error
+    end
+
+    it 'returns app status, headers and body' do
+      app_headers = {'Content-Type' => 'asdf'}
+      app_body = {'a' => 'b'}
+      @app.should_receive(:call).and_return([200, app_headers, app_body])
+
+      @env['REQUEST_METHOD'] = 'POST'
+
+      status, headers, body = @rm.call(@env)
+      status.should == 200
+      headers.should == app_headers
+      body.should == app_body
+    end
+  end
+
+  it 'accepts methods on initialize' do
+    rm = Goliath::Rack::Validation::RequestMethod.new('my app', ['GET', 'DELETE', 'HEAD'])
+    rm.methods.should == ['GET', 'DELETE', 'HEAD']
+  end
+end

data/spec/unit/rack/validation/required_param_spec.rb

@@ -0,0 +1,92 @@
+require 'spec_helper'
+require 'goliath/rack/validation/required_param'
+
+describe Goliath::Rack::Validation::RequiredParam do
+  it 'accepts an app' do
+    lambda { Goliath::Rack::Validation::RequiredParam.new('my app') }.should_not raise_error(Exception)
+  end
+
+  it 'accepts options on create' do
+    opts = { :type => 1, :key => 2 }
+    lambda { Goliath::Rack::Validation::RequiredParam.new('my app', opts) }.should_not raise_error(Exception)
+  end
+
+  it 'defaults type and key' do
+    @rp = Goliath::Rack::Validation::RequiredParam.new('app')
+    @rp.key.should_not be_nil
+    @rp.key.should_not =~ /^\s*$/
+
+    @rp.type.should_not be_nil
+    @rp.type.should_not =~ /^\s*$/
+  end
+
+  describe 'with middleware' do
+    before(:each) do
+      @app = mock('app').as_null_object
+      @env = {'params' => {}}
+      @rp = Goliath::Rack::Validation::RequiredParam.new(@app, {:type => 'Monkey', :key => 'mk'})
+    end
+
+    it 'stores type and key options' do
+      @rp.type.should == 'Monkey'
+      @rp.key.should == 'mk'
+    end
+
+    it 'returns the app status, headers and body' do
+      app_headers = {'Content-Type' => 'app'}
+      app_body = {'b' => 'c'}
+      @app.should_receive(:call).and_return([201, app_headers, app_body])
+
+      @env['params']['mk'] = 'monkey'
+
+      status, headers, body = @rp.call(@env)
+      status.should == 201
+      headers.should == app_headers
+      body.should == app_body
+    end
+
+    describe 'key_valid!' do
+      it 'raises exception if the key is not provided' do
+        lambda { @rp.key_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'raises exception if the key is blank' do
+        @env['params']['mk'] = ''
+
+        lambda { @rp.key_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'raises exception if the key is nil' do
+        @env['params']['mk'] = nil
+
+        lambda { @rp.key_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'handles an empty array' do
+        @env['params']['mk'] = []
+        lambda { @rp.key_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'handles an array of nils' do
+        @env['params']['mk'] = [nil, nil, nil]
+        lambda { @rp.key_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'handles an array of blanks' do
+        @env['params']['mk'] = ['', '', '']
+        lambda { @rp.key_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it "doesn't raise if the key provided" do
+        @env['params']['mk'] = 'my value'
+
+        lambda { @rp.key_valid!(@env['params']) }.should_not raise_error(Goliath::Validation::Error)
+      end
+
+      it "doesn't raise if the array contains valid data" do
+        @env['params']['mk'] = [1, 2, 3, 4]
+        lambda{ @rp.key_valid!(@env['params']) }.should_not raise_error
+      end
+    end
+  end
+end

data/spec/unit/rack/validation/required_value_spec.rb

@@ -0,0 +1,99 @@
+require 'spec_helper'
+require 'goliath/rack/validation/required_value'
+
+describe Goliath::Rack::Validation::RequiredValue do
+  it 'accepts an app' do
+    lambda { Goliath::Rack::Validation::RequiredValue.new('my app') }.should_not raise_error(Exception)
+  end
+
+  it 'accepts options on create' do
+    opts = { :key => 2, :values => ["foo", "bar"] }
+    lambda { Goliath::Rack::Validation::RequiredValue.new('my app', opts) }.should_not raise_error(Exception)
+  end
+
+
+  it 'turns a single option into an array' do
+    rv = Goliath::Rack::Validation::RequiredValue.new('my app', :key => 2, :values => "foo")
+    rv.values.should == ['foo']
+  end
+
+  describe 'with middleware' do
+    before(:each) do
+      @app = mock('app').as_null_object
+      @env = {'params' => {}}
+      @rv = Goliath::Rack::Validation::RequiredValue.new(@app, {:values => ['Monkey', 'frog'], :key => 'mk'})
+    end
+
+    it 'stores type and key options' do
+      @rv.values.should == ['Monkey', 'frog']
+      @rv.key.should == 'mk'
+    end
+
+    it 'returns the app status, headers and body' do
+      app_headers = {'Content-Type' => 'app'}
+      app_body = {'b' => 'c'}
+      @app.should_receive(:call).and_return([201, app_headers, app_body])
+
+      @env['params']['mk'] = 'Monkey'
+
+      status, headers, body = @rv.call(@env)
+      status.should == 201
+      headers.should == app_headers
+      body.should == app_body
+    end
+
+    context '#value_valid!' do
+      it 'raises exception if the key is not provided' do
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'raises exception if the key is blank' do
+        @env['params']['mk'] = ''
+
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'raises exception if the key is nil' do
+        @env['params']['mk'] = nil
+
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'raises exception if the key is does not match' do
+        @env['params']['mk'] = "blarg"
+
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'handles an empty array' do
+        @env['params']['mk'] = []
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'handles an array of nils' do
+        @env['params']['mk'] = [nil, nil, nil]
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it 'handles an array of blanks' do
+        @env['params']['mk'] = ['', '', '']
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+
+      it "doesn't raise if the key is value" do
+        @env['params']['mk'] = 'Monkey'
+        lambda { @rv.value_valid!(@env['params']) }.should_not raise_error(Goliath::Validation::Error)
+      end
+
+      it "doesn't raise if the array contains valid data" do
+        @env['params']['mk'] = ['Monkey', 'frog']
+        lambda{ @rv.value_valid!(@env['params']) }.should_not raise_error
+      end
+
+      it 'raises if any of the array elements do not match' do
+        @env['params']['mk'] = ["Monkey", "frog", "bat"]
+        lambda { @rv.value_valid!(@env['params']) }.should raise_error(Goliath::Validation::Error)
+      end
+    end
+  end
+end

data/spec/unit/rack/validation_error_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+require 'goliath/rack/validation_error'
+
+describe Goliath::Rack::ValidationError do
+  it 'accepts an app' do
+    lambda { Goliath::Rack::ValidationError.new('my app') }.should_not raise_error(Exception)
+  end
+
+  describe 'with middleware' do
+    before(:each) do
+      @app = mock('app').as_null_object
+      @ve = Goliath::Rack::ValidationError.new(@app)
+    end
+
+    it 'returns the apps status' do
+      app_headers = {'Content-Type' => 'mine'}
+      app_body = {'a' => 'b'}
+      @app.should_receive(:call).and_return([200, app_headers, app_body])
+
+      status, headers, body = @ve.call({})
+      status.should == 200
+      headers.should == app_headers
+      body.should == app_body
+    end
+
+    it 'catches Goliath::Validation::Error' do
+      @app.should_receive(:call).and_raise(Goliath::Validation::Error.new(401, 'my error'))
+      lambda { @ve.call({}) }.should_not raise_error(Goliath::Validation::Error)
+    end
+
+    it 'returns an error response on exception' do
+      @app.should_receive(:call).and_raise(Goliath::Validation::Error.new(401, 'my error'))
+      status, headers, body = @ve.call({})
+
+      status.should == 401
+      headers.should == {}
+      body.should == {:error => 'my error'}
+    end
+  end
+end

data/spec/unit/request_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe Goliath::Request do
+  before(:each) do
+
+    app = mock('app').as_null_object
+    env = Goliath::Env.new
+
+    @r = Goliath::Request.new(app, nil, env)
+  end
+
+  describe 'initialization' do
+
+    it 'initializes env defaults' do
+      env = Goliath::Env.new
+      env['INIT'] = 'init'
+
+      r = Goliath::Request.new(nil, nil, env)
+      r.env['INIT'].should == 'init'
+    end
+
+    it 'initializes an async callback' do
+      @r.env['async.callback'].should_not be_nil
+    end
+
+    it 'initializes request' do
+      @r.instance_variable_get("@state").should == :processing
+    end
+  end
+
+  describe 'process' do
+
+    it 'executes the application' do
+      app_mock = mock('app').as_null_object
+      env_mock = mock('app').as_null_object
+      request = Goliath::Request.new(app_mock, nil, env_mock)
+
+      app_mock.should_receive(:call).with(request.env)
+      request.should_receive(:post_process)
+
+      request.process
+    end
+
+  end
+
+  describe 'finished?' do
+    it "returns false if the request parsing has not yet finished" do
+      @r.finished?.should be_false
+    end
+
+    it 'returns true if we have finished request parsing' do
+      @r.should_receive(:post_process).and_return(nil)
+      @r.process
+
+      @r.finished?.should be_true
+    end
+
+  end
+end

data/spec/unit/response_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+require 'goliath/response'
+
+describe Goliath::Response do
+  before(:each) do
+    @r = Goliath::Response.new
+  end
+
+  it 'allows setting status' do
+    @r.status = 400
+    @r.status.should == 400
+  end
+
+  it 'allows setting headers' do
+    @r.headers = [['my_key', 'my_headers']]
+    @r.headers.to_s.should == "my_key: my_headers\r\n"
+  end
+
+  it 'allows setting body' do
+    @r.body = 'my body'
+    @r.body.should == 'my body'
+  end
+
+  it 'sets a default status' do
+    @r.status.should == 200
+  end
+
+  it 'sets default headers' do
+    @r.headers.should_not be_nil
+  end
+
+  it 'outputs the http header' do
+    @r.head.should == "HTTP/1.1 200 OK\r\n"
+  end
+end