goldiloader 3.0.3 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5f23e35eaad8987983cf1c95ec9c99e281e23715
-  data.tar.gz: 9882b6e39452af1d0a9d55b28b7d1d40e3e3513a
+SHA256:
+  metadata.gz: 3da0240495233f97f9762b4c81249b24fc6b9fb39e46801243e865ae2ed4d50d
+  data.tar.gz: d5bc7704557c4a9cdaf4e8d8e31d7d066444a964faf31812ce34117f845ccbeb
 SHA512:
-  metadata.gz: 22065fba51aa33fbc113ddc113a84d998de8b5915108c0dd54a878b182684155b957be4aa86bec6971010ff6f930a94116e4ebc4ff3490e6c0257975e0e26272
-  data.tar.gz: 03244b1b7fc590389d9a89a0a5f26376c0198b1e0ce68e5605e5e254ad116e203ae88573da24ca671ed2b5bb44fe0d58cc19f9509a754c462fa9d0e9e2c36129
+  metadata.gz: 73ab77e3c22b3e80dc903079dfe65245fceae13ab8b4fa1870705df1d1302eac82982523fad9cf7b9c2f4576022894ff16c8cd83b72d966ede5cd88ffb2b56d0
+  data.tar.gz: 402c5bfe96112e1a697af866205c3a16cb85966566adcac722deefc4ce4d487b4df10e335d1ce057cb2ddcf5ce4c8d490998c46b3e20feca4d98f334f2719534

data/lib/goldiloader/active_record_patches.rb

@@ -47,21 +47,12 @@ module Goldiloader
     end
 
     def auto_include_value
-      # Note: Don't use get_value because that doesn't work properly with defaulting boolean values
       @values.fetch(:auto_include, true)
     end
 
     def auto_include_value=(value)
-      if Goldiloader::Compatibility.rails_4?
-        raise ::ActiveRecord::Relation::ImmutableRelation if @loaded
-        check_cached_relation
-        @values[:auto_include] = value
-      elsif Goldiloader::Compatibility.rails_5_0?
-        assert_mutability!
-        @values[:auto_include] = value
-      else
-        set_value(:auto_include, value)
-      end
+      assert_mutability!
+      @values[:auto_include] = value
     end
   end
   ::ActiveRecord::Relation.prepend(::Goldiloader::RelationPatch)
@@ -77,29 +68,26 @@ module Goldiloader
   ActiveRecord::Relation::Merger.prepend(::Goldiloader::MergerPatch)
 
   module AssociationReflectionPatch
-    def eager_loadable?
-      return @eager_loadable if instance_variable_defined?(:@eager_loadable)
-
-      @eager_loadable = if scope.nil?
-                          # Associations without any scoping options are eager loadable
-                          true
-                        elsif scope.arity > 0
-                          # The scope will be evaluated for every model instance so it can't
-                          # be eager loaded
-                          false
-                        else
-                          scope_info = if Goldiloader::Compatibility.rails_4?
-                                         Goldiloader::ScopeInfo.new(klass.unscoped.instance_exec(&scope) || klass.unscoped)
-                                       else
-                                         Goldiloader::ScopeInfo.new(scope_for(klass.unscoped))
-                                       end
-                          scope_info.auto_include? &&
-                            !scope_info.limit? &&
-                            !scope_info.offset? &&
-                            (!has_one? || !scope_info.order?) &&
-                            (::Goldiloader::Compatibility.group_eager_loadable? || !scope_info.group?) &&
-                            (::Goldiloader::Compatibility.from_eager_loadable? || !scope_info.from?)
-                        end
+    # Note we need to pass the association's target class as an argument since it won't be known
+    # outside the context of an association instance for polymorphic associations.
+    def eager_loadable?(target_klass)
+      @eager_loadable_cache ||= Hash.new do |cache, target_klass_key|
+        cache[target_klass_key] = if scope.nil?
+                                    # Associations without any scoping options are eager loadable
+                                    true
+                                  elsif scope.arity > 0
+                                    # The scope will be evaluated for every model instance so it can't
+                                    # be eager loaded
+                                    false
+                                  else
+                                    scope_info = Goldiloader::ScopeInfo.new(scope_for(target_klass_key.unscoped))
+                                    scope_info.auto_include? &&
+                                      !scope_info.limit? &&
+                                      !scope_info.offset? &&
+                                      (!has_one? || !scope_info.order?)
+                                  end
+      end
+      @eager_loadable_cache[target_klass]
     end
   end
   ActiveRecord::Reflection::AssociationReflection.include(::Goldiloader::AssociationReflectionPatch)
@@ -126,7 +114,7 @@ module Goldiloader
     private
 
     def eager_loadable?
-      reflection.eager_loadable? &&
+      klass && reflection.eager_loadable?(klass) &&
         (::Goldiloader::Compatibility.destroyed_model_associations_eager_loadable? || !owner.destroyed?)
     end
 
@@ -162,12 +150,7 @@ module Goldiloader
 
   module CollectionAssociationPatch
     # Force these methods to load the entire association for fully_load associations
-    association_methods = [:size, :ids_reader, :empty?]
-    if Goldiloader::Compatibility::ACTIVE_RECORD_VERSION < ::Gem::Version.new('5.1')
-      association_methods.concat([:first, :second, :third, :fourth, :fifth, :last])
-    end
-
-    association_methods.each do |method|
+    [:size, :ids_reader, :empty?].each do |method|
       define_method(method) do |*args, &block|
         load_target if fully_load?
         super(*args, &block)
@@ -178,10 +161,8 @@ module Goldiloader
       load_with_auto_include { super }
     end
 
-    if Goldiloader::Compatibility::ACTIVE_RECORD_VERSION >= ::Gem::Version.new('5.1')
-      def find_from_target?
-        fully_load? || super
-      end
+    def find_from_target?
+      fully_load? || super
     end
   end
   ::ActiveRecord::Associations::CollectionAssociation.prepend(::Goldiloader::CollectionAssociationPatch)

data/lib/goldiloader/association_loader.rb

@@ -15,17 +15,11 @@ module Goldiloader
     private
 
     def eager_load(models, association_name)
-      ::ActiveRecord::Associations::Preloader.new.preload(models, [association_name])
-    end
-
-    def first_model_with_association(models, association_name)
-      models.find { |model| has_association?(model, association_name) }
-    end
-
-    def associated_models(models, association_name)
-      # We can't just do model.send(association_name) because the association method may have been
-      # overridden
-      models.map { |model| model.association(association_name).target }.flatten.compact.uniq
+      if Goldiloader::Compatibility.pre_rails_6_2?
+        ::ActiveRecord::Associations::Preloader.new.preload(models, [association_name])
+      else
+        ::ActiveRecord::Associations::Preloader.new(records: models, associations: [association_name]).call
+      end
     end
 
     def load?(model, association_name)

data/lib/goldiloader/association_options.rb

@@ -18,11 +18,7 @@ module Goldiloader
     end
 
     def register
-      if Goldiloader::Compatibility.rails_4?
-        ActiveRecord::Associations::Builder::Association.valid_options.concat(OPTIONS)
-      else
-        ActiveRecord::Associations::Builder::Association.extensions << AssociationBuilderExtension
-      end
+      ActiveRecord::Associations::Builder::Association.extensions << AssociationBuilderExtension
     end
   end
 end

data/lib/goldiloader/compatibility.rb

@@ -2,34 +2,17 @@
 
 module Goldiloader
   module Compatibility
-    ACTIVE_RECORD_VERSION = ::Gem::Version.new(::ActiveRecord::VERSION::STRING)
+    ACTIVE_RECORD_VERSION = ::Gem::Version.new(::ActiveRecord::VERSION::STRING).release
+    PRE_RAILS_6_2 = ACTIVE_RECORD_VERSION < ::Gem::Version.new('6.2.0')
     RAILS_5_2_0 = ACTIVE_RECORD_VERSION == ::Gem::Version.new('5.2.0')
-    PRE_RAILS_5_2 = ACTIVE_RECORD_VERSION < ::Gem::Version.new('5.2.0')
-    POST_RAILS_5_1_4 = ACTIVE_RECORD_VERSION > ::Gem::Version.new('5.1.5')
-    PRE_RAILS_5_1_5 = ACTIVE_RECORD_VERSION < ::Gem::Version.new('5.1.5')
-    FROM_EAGER_LOADABLE = ACTIVE_RECORD_VERSION >= ::Gem::Version.new('5.1.5') ||
-      (ACTIVE_RECORD_VERSION >= ::Gem::Version.new('5.0.7') && ACTIVE_RECORD_VERSION < ::Gem::Version.new('5.1.0'))
-    GROUP_EAGER_LOADABLE = FROM_EAGER_LOADABLE
 
-    def self.rails_4?
-      ::ActiveRecord::VERSION::MAJOR == 4
-    end
-
-    def self.rails_5_0?
-      ::ActiveRecord::VERSION::MAJOR == 5 && ::ActiveRecord::VERSION::MINOR == 0
+    def self.pre_rails_6_2?
+      PRE_RAILS_6_2
     end
 
     # See https://github.com/rails/rails/pull/32375
     def self.destroyed_model_associations_eager_loadable?
       !RAILS_5_2_0
     end
-
-    def self.from_eager_loadable?
-      FROM_EAGER_LOADABLE
-    end
-
-    def self.group_eager_loadable?
-      GROUP_EAGER_LOADABLE
-    end
   end
 end

data/lib/goldiloader/scope_info.rb

@@ -21,11 +21,7 @@ module Goldiloader
     end
 
     def from?
-      if Goldiloader::Compatibility.rails_4?
-        scope.from_value.present?
-      else
-        scope.from_clause.present?
-      end
+      scope.from_clause.present?
     end
 
     def group?

data/lib/goldiloader/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Goldiloader
-  VERSION = '3.0.3'
+  VERSION = '4.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: goldiloader
 version: !ruby/object:Gem::Version
-  version: 3.0.3
+  version: 4.0.1
 platform: ruby
 authors:
 - Joel Turkel
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-12-10 00:00:00.000000000 Z
+date: 2021-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,40 +16,40 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7.1'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -79,19 +79,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: coveralls_reborn
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.18.0
 - !ruby/object:Gem::Dependency
   name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
@@ -148,20 +148,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: salsify_rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.1.1
+        version: 1.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.52.1.1
+        version: 1.0.1
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -180,16 +194,16 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '1.3'
 description: Automatically eager loads Rails associations as associations are traversed
 email:
 - jturkel@salsify.com
@@ -214,7 +228,7 @@ metadata:
   changelog_uri: https://github.com/salsify/goldiloader/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/salsify/goldiloader/
   bug_tracker_uri: https://github.com/salsify/goldiloader/issues
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -222,16 +236,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Automatic Rails association eager loading
 test_files: []