goldiloader 0.0.11 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 526a23489a3e8b11cc8f0f54bbad2d172aab998c
-  data.tar.gz: 65d84a61f5f1d7c1efee2ac66e46b4661cdbc8ac
+  metadata.gz: 9e841dae40175e8b5f4dfff64bafa99235d12a7c
+  data.tar.gz: 5c9f9b0e4e39c0dc3ceab77bcf7cd00f7f38c96f
 SHA512:
-  metadata.gz: 7b689413962ae9ae86dcec25f2a27a3472f7c406a3b932f7b20f4f92dade3900c8a6d20e5eca79f7e6762c886d5520d1512904479aa28f428b3e519983b2ac9c
-  data.tar.gz: 363b20372285117f68e22281b823586ca0136417b0449cf94f47a345ecad372e6cc2f3d09336911d476d4c15b080bdc0c421d91074fe78f16c0c472822cd8b18
+  metadata.gz: e2829c6d011ecdbf060867f1fe302beff76a831ad966017cbe0e581c914297c38f53f181f167736a9bd04d3a9d0ba92f3e25e24f7e6346270b1f5dfb451e6754
+  data.tar.gz: b9d871721fdc9385ebef66365b304aacc0d75facb69f2edbd349b86539c15507255b03c083b5ba89334d972f05fe1d2cec2efb899694eaa308913f88114d425c

data/lib/goldiloader/active_record_patches.rb

@@ -28,10 +28,10 @@ ActiveRecord::Base.send(:include, Goldiloader::AutoIncludableModel)
 
 ActiveRecord::Relation.class_eval do
 
-  def exec_queries_with_auto_include
-    return exec_queries_without_auto_include if loaded?
+  def exec_queries_with_auto_include(&block)
+    return exec_queries_without_auto_include(&block) if loaded?
 
-    models = exec_queries_without_auto_include
+    models = exec_queries_without_auto_include(&block)
     Goldiloader::AutoIncludeContext.register_models(models, eager_load_values)
     models
   end

data/lib/goldiloader/version.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
 
 module Goldiloader
-  VERSION = '0.0.11'.freeze
+  VERSION = '0.0.12'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: goldiloader
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.12
 platform: ruby
 authors:
 - Joel Turkel
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-25 00:00:00.000000000 Z
+date: 2017-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -155,15 +155,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
-- CHANGELOG.md
-- Gemfile
 - LICENSE.txt
-- README.md
-- Rakefile
-- goldiloader.gemspec
 - lib/goldiloader.rb
 - lib/goldiloader/active_record_patches.rb
 - lib/goldiloader/association_info.rb
@@ -172,11 +164,6 @@ files:
 - lib/goldiloader/auto_include_context.rb
 - lib/goldiloader/compatibility.rb
 - lib/goldiloader/version.rb
-- spec/db/database.yml
-- spec/db/schema.rb
-- spec/goldiloader/auto_include_context_spec.rb
-- spec/goldiloader/goldiloader_spec.rb
-- spec/spec_helper.rb
 homepage: https://github.com/salsify/goldiloader
 licenses:
 - MIT
@@ -197,13 +184,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Automatic Rails association eager loading
-test_files:
-- spec/db/database.yml
-- spec/db/schema.rb
-- spec/goldiloader/auto_include_context_spec.rb
-- spec/goldiloader/goldiloader_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.gitignore

@@ -1,21 +0,0 @@
-*.gem
-*.iml
-*.rbc
-.bundle
-.config
-.idea/
-.yardoc
-Gemfile.lock
-InstalledFiles
-_yardoc
-coverage
-doc/
-lib/bundler/man
-log/
-pkg
-rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
-.ruby-version

data/.rspec

@@ -1,2 +0,0 @@
---color
---format progress

data/.travis.yml

@@ -1,28 +0,0 @@
-language: ruby
-sudo: false
-env:
-  - RAILS_VERSION="~> 3.2.22.2" JRUBY_OPTS="$JRUBY_OPTS --debug"
-  - RAILS_VERSION="~> 4.0.13" JRUBY_OPTS="$JRUBY_OPTS --debug"
-  - RAILS_VERSION="~> 4.1.16" JRUBY_OPTS="$JRUBY_OPTS --debug"
-  - RAILS_VERSION="~> 4.2.7.1" JRUBY_OPTS="$JRUBY_OPTS --debug"
-  - RAILS_VERSION="~> 5.0.1" JRUBY_OPTS="$JRUBY_OPTS --debug"
-rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1.10
-  - 2.2.6
-  - 2.3.3
-  - jruby-19mode
-  - jruby-9.1.7.0
-matrix:
-  exclude:
-    - rvm: 1.9.3
-      env: RAILS_VERSION="~> 5.0.1" JRUBY_OPTS="$JRUBY_OPTS --debug"
-    - rvm: 2.0.0
-      env: RAILS_VERSION="~> 5.0.1" JRUBY_OPTS="$JRUBY_OPTS --debug"
-    - rvm: 2.1.10
-      env: RAILS_VERSION="~> 5.0.1" JRUBY_OPTS="$JRUBY_OPTS --debug"
-    - rvm: jruby-19mode
-      env: RAILS_VERSION="~> 5.0.1" JRUBY_OPTS="$JRUBY_OPTS --debug"
-    - rvm: jruby-9.1.7.0
-      env: RAILS_VERSION="~> 5.0.1" JRUBY_OPTS="$JRUBY_OPTS --debug"

data/CHANGELOG.md

@@ -1,67 +0,0 @@
-# Changelog
-
-### 0.0.11 (unreleased)
-* Fix [issue 34](https://github.com/salsify/goldiloader/issues/34) - HABTM associations now honor 
-  the auto_include option.
-* Fix [issue 39](https://github.com/salsify/goldiloader/issues/39) - `CollectionProxy#exists?` should return false 
-  for a new model's association with no values.
-  
-### 0.0.10
-* Fix [issue 13](https://github.com/salsify/goldiloader/issues/13) - Eager load associations with unscope
-  in Rails 4.1.9+ now that the underlying Rails bug has been fixed.
-* Fix [issue 11](https://github.com/salsify/goldiloader/issues/11) - Eager load associations with joins in 
-  Rails 4.2+ now that the underlying Rails bug has been fixed.
-* Initial support for Rails 5. There are no known issues but see 
-  [issue 27](https://github.com/salsify/goldiloader/issues/27) for remaining tasks.
-* MRI 2.3.0 support.
-* JRuby 9000 support.
-
-### 0.0.9
-* Merge [pull request](https://github.com/salsify/goldiloader/pull/24) - Optimization: Cache compatibility
-  checks. **Thanks Jonathan Calvert!**
-
-### 0.0.8
-* Fix [issue 23](https://github.com/salsify/goldiloader/issues/23) - Handle polymorphic belongs_to
-  associations in Rails 4 that have a mix of non-nil and nil values.
-
-### 0.0.7
-* Fix [issue 20](https://github.com/salsify/goldiloader/issues/20) by not auto-eager loading 
-  associations that are instance dependent. Eager loading these associations produces potentially
-  incorrect results and leads to a deprecation warning in Rails 4.2.
-* Fix [issue 21](https://github.com/salsify/goldiloader/issues/21) - Handle explicit eager loads
-  of singular associations that are nil.
-* Rails 4.2 support.
-
-### 0.0.6
-* Workaround [issue 16](https://github.com/salsify/goldiloader/issues/16) by not auto-eager loading 
-  has_and_belongs_to_many associations with a uniq in Rails 3.2 since Rails doesn't eager load them 
-  properly.
-* Fix [issue 17](https://github.com/salsify/goldiloader/issues/17) - models eager loaded via an explicit
-  call to eager_load now auto eager load nested models.
-
-### 0.0.5
-
-* Fix ActiveRecord and ActiveSupport dependencies to work with versions greater than 4.1.0. Thanks for the pull
-  requests [Alexey Volodkin](https://github.com/miraks) and [Philip Claren](https://github.com/DerKobe).
-* Workaround [issue 13](https://github.com/salsify/goldiloader/issues/13) by not auto-eager loading associations
-  that use `unscope`. This workaround will be removed when the underlying 
-  [bug 11036](https://github.com/rails/rails/issues/11036) in the Rails eager loader is fixed.
-* Workaround [issue 11](https://github.com/salsify/goldiloader/issues/11) by not auto-eager loading associations
-  that use `joins`. This workaround will be removed when the underlying 
-  [bug 11518](https://github.com/rails/rails/pull/11518) in the Rails eager loader is fixed.
-* Fix [issue 15](https://github.com/salsify/goldiloader/issues/15) - Don't auto eager load associations 
-  with finder_sql in Rails 4.0. Previously this was only done for Rails 3.2.
-
-### 0.0.4
- 
-* Fix [issue 3](https://github.com/salsify/goldiloader/issues/3) - `exists?` method should take an argument. 
-  Thanks for reporting [Bert Goethals](https://github.com/Bertg)
-* Fix [issue 4](https://github.com/salsify/goldiloader/issues/4) - Associations couldn't be loaded in after 
-  destroy callbacks. Thanks for reporting [Bert Goethals](https://github.com/Bertg)
-* Fix [issue 6](https://github.com/salsify/goldiloader/issues/6) - Models in read only associations weren't
-  being marked as read only
-* Fix [issue 7](https://github.com/salsify/goldiloader/issues/7) - Don't attempt to eager load associations that
-  aren't eager loadable e.g. if they have a limit
-* Fix [issue 8](https://github.com/salsify/goldiloader/issues/8) - Handle eager loading associations whose 
-  accessor methods have been overridden.
-

data/Gemfile

@@ -1,3 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec

data/README.md

@@ -1,186 +0,0 @@
-# Goldiloader
-
-[![Gem Version](https://badge.fury.io/rb/goldiloader.png)][gem]
-[![Build Status](https://secure.travis-ci.org/salsify/goldiloader.png?branch=master)][travis]
-[![Code Climate](https://codeclimate.com/github/salsify/goldiloader.png)][codeclimate]
-[![Coverage Status](https://coveralls.io/repos/salsify/goldiloader/badge.png)][coveralls]
-
-[gem]: https://rubygems.org/gems/goldiloader
-[travis]: http://travis-ci.org/salsify/goldiloader
-[codeclimate]: https://codeclimate.com/github/salsify/goldiloader
-[coveralls]: https://coveralls.io/r/salsify/goldiloader
-
-Wouldn't it be awesome if ActiveRecord didn't make you think about eager loading and it just did the "right" thing by default? With Goldiloader it can!
-
-Consider the following models:
-
-```ruby
-class Blog < ActiveRecord::Base
-  has_many :posts
-end
-
-class Post < ActiveRecord::Base
-  belongs_to :blog
-end
-```
-
-Here are some sample queries without the Goldiloader:
-
-```ruby
-> blogs = Blogs.limit(5).to_a
-# SELECT * FROM blogs LIMIT 5
-
-> blogs.each { |blog| blog.posts.to_a }
-# SELECT * FROM posts WHERE blog_id = 1
-# SELECT * FROM posts WHERE blog_id = 2
-# SELECT * FROM posts WHERE blog_id = 3
-# SELECT * FROM posts WHERE blog_id = 4
-# SELECT * FROM posts WHERE blog_id = 5
-```
-
-Here are the same queries with the Goldiloader:
-
-```ruby
-> blogs = Blogs.limit(5).to_a
-# SELECT * FROM blogs LIMIT 5
-
-> blogs.each { |blog| blog.posts.to_a }
-# SELECT * FROM posts WHERE blog_id IN (1,2,3,4,5)
-```
-
-Whoa! It automatically loaded all of the posts for our five blogs in a single database query without specifying any eager loads! Goldiloader assumes that you'll access all models loaded from a query in a uniform way. The first time you traverse an association on any of the models it will eager load the association for all the models. It even works with arbitrary nesting of associations.
-
-Read more about the motivation for the Goldiloader in this [blog post](http://www.salsify.com/blog/automatic-eager-loading-rails/).
-
-## Installation
-
-Add this line to your application's Gemfile:
-
-    gem 'goldiloader'
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install goldiloader
-
-## Usage
-
-By default all associations will be automatically eager loaded when they are first accessed so hopefully most use cases should require no additional configuration. Note you're still free to explicitly eager load associations via `eager_load`, `includes`, or `preload`.
-
-### Association Options
-
-Goldiloader supports a few options on ActiveRecord associations to customize its behavior.
-
-#### auto_include
-
-You can disable automatic eager loading on specific associations with the `auto_include` option:
-
-```ruby
-class Blog < ActiveRecord::Base
-  has_many :posts, auto_include: false
-end
-```
-
-#### fully_load
-
-There are several association methods that ActiveRecord can either execute on in memory models or push down into SQL depending on whether or not the association is loaded. This includes the following methods:
-
-* `first`
-* `second`
-* `third`
-* `fourth`
-* `fifth`
-* `forty_two` (one of the hidden gems in Rails 4.1)
-* `last`
-* `size`
-* `ids_reader`
-* `empty?`
-* `exists?`
-
-This can cause problems for certain usage patterns if we're no longer specifying eager loads:
-
-```ruby
-> blogs = Blogs.limit(5).to_a
-# SELECT * FROM blogs LIMIT 5
-
-> blogs.each do |blog| 
-    if blog.posts.exists? 
-      puts blog.posts
-    else
-      puts 'No posts'
-  end
-# SELECT 1 AS one FROM posts WHERE blog_id = 1 LIMIT 1
-# SELECT * FROM posts WHERE blog_id IN (1,2,3,4,5)
-```
-
-Notice the first call to `blog.posts.exists?` was executed via SQL because the `posts` association wasn't yet loaded. The `fully_load` option can be used to force ActiveRecord to fully load the association (and do any necessary automatic eager loading) when evaluating methods like `exists?`:
-
-```ruby
-class Blog < ActiveRecord::Base
-  has_many :posts, fully_load: true
-end
-```
-
-## Limitations
-
-Goldiloader leverages the ActiveRecord eager loader so it shares some of the same limitations. 
-
-### has_one associations that rely on a SQL limit
-
-You should not try to auto eager load (or regular eager load) `has_one` associations that actually correspond to multiple records and rely on a SQL limit to only return one record. Consider the following example:
-
-```ruby
-class Blog < ActiveRecord::Base
-  has_many :posts
-  has_one :most_recent_post, -> { order(published_at: desc) }, class_name: 'Post'
-end
-```
-
-With standard Rails lazy loading the `most_recent_post` association is loaded with a query like this:
-
-```sql
-SELECT * FROM posts WHERE blog_id = 1 ORDER BY published_at DESC LIMIT 1
-```
-
-With auto eager loading (or regular eager loading) the `most_recent_post` association is loaded with a query like this:
-
-```sql
-SELECT * FROM posts WHERE blog_id IN (1,2,3,4,5) ORDER BY published_at DESC
-```
-
-Notice the SQL limit can no longer be used which results in fetching all posts for each blog. This can cause severe performance problems if there are a large number of posts. 
-
-### Other Limitations
-
-Associations with any of the following options cannot be eager loaded:
-
-* `limit`
-* `offset`
-* `finder_sql`
-* `group` (due to a Rails bug)
-* `from` (due to a Rails bug)
-* `joins` (only Rails 4.0/4.1 - due to a Rails bug)
-* `uniq` (only Rails 3.2 - due to a Rails bug)
-
-Goldiloader detects associations with any of these options and disables automatic eager loading on them.
-
-## Status
-
-This gem is tested with Rails 3.2, 4.0, 4.1, 4.2, and 5.0 using MRI 1.9.3, 2.0, 2.1, 2.2, 2.3, JRuby 1.7 in 1.9 mode, and JRuby 9000. 
-
-Let us know if you find any issues or have any other feedback. 
-
-## Change log
-
-See the [change log](https://github.com/salsify/goldiloader/blob/master/CHANGELOG.md).
-
-## Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request

data/Rakefile

@@ -1,9 +0,0 @@
-require 'bundler/setup'
-Bundler::GemHelper.install_tasks
-
-require 'rspec/core/rake_task'
-RSpec::Core::RakeTask.new(:spec) do |task|
-  task.verbose = false
-end
-
-task default: :spec

data/goldiloader.gemspec

@@ -1,40 +0,0 @@
-# encoding: UTF-8
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'goldiloader/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = 'goldiloader'
-  spec.version       = Goldiloader::VERSION
-  spec.authors       = ['Joel Turkel']
-  spec.email         = ['jturkel@salsify.com']
-  spec.description   = %q{Automatically eager loads Rails associations as associations are traversed}
-  spec.summary       = %q{Automatic Rails association eager loading}
-  spec.homepage      = 'https://github.com/salsify/goldiloader'
-  spec.license       = 'MIT'
-
-  spec.files         = `git ls-files`.split($/)
-  spec.test_files    = Dir.glob('spec/**/*')
-  spec.require_paths = ['lib']
-
-  spec.add_dependency 'activerecord', ENV.fetch('RAILS_VERSION', ['>= 3.2', '< 5.1'])
-  spec.add_dependency 'activesupport', ENV.fetch('RAILS_VERSION', ['>= 3.2', '< 5.1'])
-
-  spec.add_development_dependency 'coveralls'
-  spec.add_development_dependency 'database_cleaner', '>= 1.2'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rspec', '~> 3'
-  spec.add_development_dependency 'simplecov', '~> 0.7.1'
-  # mime-type 3 requires Ruby >= 2.0
-  spec.add_development_dependency 'mime-types', '~> 2'
-
-  if RUBY_PLATFORM == 'java'
-    # jdbc-sqlite3 > 3.8 doesn't work with JRuby 1.7
-    spec.add_development_dependency 'jdbc-sqlite3', '~> 3.8.11'
-    spec.add_development_dependency 'activerecord-jdbcsqlite3-adapter'
-  else
-    spec.add_development_dependency 'sqlite3'
-  end
-
-end
-