goldendocx 0.2.2 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1603ab8a5538d27e48b351b381f8859c92fb9e42169df8cbcc6104545803c2b
-  data.tar.gz: 9bc30497d4a1f96da15f8190d9edb42857f2ec6876550ebb47415f3ed5e67caa
+  metadata.gz: dc5f8d130528f4e1f5e5738146ab61e9cc771968d549ec251d1996aa7704c1e8
+  data.tar.gz: 37981979a35e94d81c5515783f28752ebcf0425a635d2d610afdab1b05b4c897
 SHA512:
-  metadata.gz: b826c86f0013b2af7af58b047cdb5340cc912913ca78b0198ab9b506a8614a173b2d1a53f42d928da6f277f21a6312895175687a49e79e2cf63658acace1ef4a
-  data.tar.gz: cb4198c911418e3579df98019d87709a009aed9bd595b2889602e595a32d53b2a333561cd8d43dde67f40a55b1ebd6552e0921a184308417f4ce8270a215cd0f
+  metadata.gz: a1e8b756aa8960aa6796a23539498bb9632c68cc8f2c7e18bd02cc5546926afc61347302e8251eeb5e676075dfc97f2bc7c5126d626aec7b6b7f48400aa7f4b1
+  data.tar.gz: 7e4b16e552fbac46c52880c39267472d07481a5a895a9e98d892b508d51a040de7e0bd32bac05ad26c29cb722cd7829df0321b02f47ad14c53e977a758802bac

data/.rubocop.yml

@@ -4,7 +4,7 @@ require:
 
 AllCops:
   NewCops: enable
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.2
   SuggestExtensions: false
 
 Metrics/AbcSize:

data/.ruby-version

@@ -0,0 +1 @@
+3.2.0

data/CHANGELOG.md

@@ -30,7 +30,7 @@ Mostly refactoring
 - Introduce `ActiveSupport` to make coding easier
 - Clean irrelevant demos
 
-## [0.2.2] - 2023-03-31(WIP)
+## [0.2.2] - 2023-03-31
 
 ### Features
 
@@ -40,4 +40,10 @@ Mostly refactoring
 ### Fixes
 
 - Fix create charts issues
-- Fix Nokogiri XML serializer compatible issues
+- Fix Nokogiri XML serializer compatible issues
+
+## [0.2.3] - 2023-04-07
+
+### Features
+
+- Support create new MS Word docx file without template

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    goldendocx (0.2.2)
+    goldendocx (0.3.0)
       activesupport (~> 7.0)
       nokogiri (~> 1.14)
       ox (~> 2.14)
@@ -78,6 +78,7 @@ GEM
     simplecov-html (0.12.3)
     simplecov-lcov (0.8.0)
     simplecov_json_formatter (0.1.4)
+    timecop (0.9.6)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.2.0)
@@ -96,6 +97,7 @@ DEPENDENCIES
   rubocop-rspec (~> 2.19)
   simplecov (~> 0.22.0)
   simplecov-lcov (~> 0.8.0)
+  timecop (~> 0.9.6)
 
 BUNDLED WITH
    2.3.23

data/README.md

@@ -1,5 +1,8 @@
 # The Ruby API for Microsoft Word
 
+[![Gem Version](https://badge.fury.io/rb/goldendocx.svg)](https://badge.fury.io/rb/goldendocx)
+[![Coverage Status](https://coveralls.io/repos/github/SheldonLeo/goldendocx/badge.svg)](https://coveralls.io/github/SheldonLeo/goldendocx)
+
 Ruby APIs for manipulating Microsoft Word based upon OOXML standards.
 
 ## Installation
@@ -23,6 +26,7 @@ If bundler is not being used to manage dependencies, install the gem by executin
 Support both `ox` and `nokogiri` as XML serializer, and `ox` as default.
 
 You can customize with configuration
+
 ```ruby
 Goldendocx.configure do |config|
   config.xml_serializer = :nokogiri
@@ -30,9 +34,13 @@ end
 ```
 
 ### Compose MS Word
-- Read MS Word file and write to another path
+
+- Create new MS Word file or read exists file and write to another path
     ```ruby
+      docx = Goldendocx::Docx.new
       docx = Goldendocx::Docx.new(docx_file_path)
+      docx.read_from(docx_file_path)
+  
       docx.write_to(new_file_path)
     ```
 - Create texts to MS Word
@@ -71,6 +79,6 @@ end
       values = [13, 12, 9, 9, 8, 7, 7, 6, 5, 3]
       chart.add_series('地域分布详情数据', categories, values)
     ```
-  
+
 More demos view at [Demos](demo/)
 

data/Rakefile

@@ -4,7 +4,18 @@ require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'
 
-RSpec::Core::RakeTask.new(:spec)
-RuboCop::RakeTask.new
+RSpec::Core::RakeTask.new(:ox_compatible_spec) do |task|
+  ENV['XML_SERIALIZER'] = 'ox'
+  task.failure_message = 'Failed with ox xml serializer compatible'
+end
 
-task default: %i[rubocop spec]
+RSpec::Core::RakeTask.new(:nokogiri_compatible_spec) do |task|
+  ENV['XML_SERIALIZER'] = 'nokogiri'
+  task.failure_message = 'Failed with nokogiri xml serializer compatible'
+end
+
+RuboCop::RakeTask.new(:rubocop) do |task|
+  task.options = ['-P']
+end
+
+task default: %i[rubocop ox_compatible_spec nokogiri_compatible_spec]

data/demo/tables/create_embed_image_table.rb

@@ -27,9 +27,9 @@ image_base64 = File.read("#{Dir.pwd}/demo/templates/image_base64")
 image = docx.create_embed_image(image_base64, width: 720000, height: 720000, align: :left)
 
 rows = [
-  [Goldendocx::Tables::ImageCell.new(image: image, content: '选项A'), 3, '¥3.00', '¥9.00'],
-  [Goldendocx::Tables::ImageCell.new(image: image, content: '选项B'), 4, '¥6.50', '¥18.00'],
-  [Goldendocx::Tables::ImageCell.new(image: image, content: '选项C'), 10, '¥6.00', '¥60.00']
+  [Goldendocx::Tables::ImageCell.new(image:, content: '选项A'), 3, '¥3.00', '¥9.00'],
+  [Goldendocx::Tables::ImageCell.new(image:, content: '选项B'), 4, '¥6.50', '¥18.00'],
+  [Goldendocx::Tables::ImageCell.new(image:, content: '选项C'), 10, '¥6.00', '¥60.00']
 ]
 rows.each do |r|
   row = table.add_row(r)

data/demo/templates/generate_codes.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+require 'ox'
+require_relative 'xml_to_class'
+
+xml_fragment = File.read("#{Dir.pwd}/demo/templates/styles/reportTitle")
+root_class = XmlToClass.new.parse(Ox.parse(xml_fragment))
+
+root_class.write_rb('goldendocx/styles')
+root_class.write_spec('goldendocx/styles')

data/demo/templates/xml_to_class.rb

@@ -0,0 +1,97 @@
+# frozen_string_literal: true
+
+# rubocop:disable Metrics/AbcSize
+# rubocop:disable Metrics/MethodLength
+# rubocop:disable Metrics/CyclomaticComplexity
+require 'ox'
+require 'fileutils'
+require 'active_support/core_ext/string/inflections'
+
+class XmlToClass
+  def parse(node)
+    @node = node
+    @namespace, @tag = parse_tag(@node.name)
+    @class_name = "#{@tag}Property".classify
+    parse_attributes
+    parse_children
+    self
+  end
+
+  def write_rb(dir)
+    dir_to_write = "#{Dir.pwd}/lib/#{dir}"
+    FileUtils.mkdir_p(dir_to_write)
+
+    File.open("#{dir_to_write}/#{@tag}.rb", 'w') do |f|
+      f.puts '# frozen_string_literal: true'
+      f.puts ''
+      f.puts "class Goldendocx::#{@class_name}"
+      f.puts '  include Goldendocx::Element'
+      f.puts ''
+      f.puts "  namespace :#{@namespace}" if @namespace
+      f.puts "  tag :#{@tag}"
+      f.puts ''
+      @attributes.each do |name, opt|
+        options = opt.map { |k, v| "#{k}: :#{v}" }.join(',')
+        f.puts "  attribute :#{name.underscore}, #{options}"
+      end
+      f.puts ''
+      @children.group_by(&:to_s).each do |name, values|
+        method = values.size > 1 ? :embeds_many : :embeds_one
+        _, class_name = parse_tag(name)
+        f.puts "  #{method} :#{class_name.underscore}, class_name: 'Goldendocx::#{class_name.classify}Property'"
+      end
+      f.puts 'end'
+    end
+
+    @subclasses.each { |c| c.write_rb("#{dir}/#{@tag}") }
+  end
+
+  def write_spec(dir)
+    dir_to_write = "#{Dir.pwd}/spec/#{dir}"
+    FileUtils.mkdir_p(dir_to_write)
+
+    File.open("#{dir_to_write}/#{@tag}_spec.rb", 'w') do |f|
+      f.puts '# frozen_string_literal: true'
+      f.puts ''
+      f.puts "describe Goldendocx::#{@class_name} do"
+      f.puts '  let(:property) { described_class.new }'
+      f.puts ''
+      f.puts "  specify 'builds default #{@tag} property xml' do "
+      f.puts "    expect(property.to_xml).to eq('<#{@namespace}:#{@tag}/>')"
+      f.puts '  end'
+      f.puts ''
+      f.puts "  specify 'builds customized #{@tag} property xml' do"
+      f.puts '    property.attribute = :value '
+      f.puts "    expect(property.to_xml).to eq('<#{@namespace}:#{@tag}/>') "
+      f.puts '  end '
+      f.puts 'end'
+    end
+
+    @subclasses.each { |c| c.write_spec("#{dir}/#{@tag}") }
+  end
+
+  def parse_tag(string)
+    string = string.to_s
+    string.include?(':') ? string.split(':') : [nil, string]
+  end
+
+  def parse_attributes
+    @attributes ||= {}
+    @node.attributes.each_key do |name|
+      ns, tg = parse_tag(name)
+      @attributes[tg] = { alias_name: tg, namespace: ns }.compact
+    end
+  end
+
+  def parse_children
+    @children = []
+    @subclasses = []
+    @node.nodes.each do |node|
+      @children << node.name.to_s
+      @subclasses << XmlToClass.new.parse(node)
+    end
+  end
+end
+# rubocop:enable Metrics/AbcSize
+# rubocop:enable Metrics/MethodLength
+# rubocop:enable Metrics/CyclomaticComplexity

data/demo/texts/append_plain_text.rb

@@ -3,7 +3,7 @@
 $LOAD_PATH.push "#{Dir.pwd}/lib"
 require 'goldendocx'
 
-docx = Goldendocx::Docx.new("#{Dir.pwd}/demo/templates/blankDocument.docx")
+docx = Goldendocx::Docx.new.read_from("#{Dir.pwd}/demo/templates/blankDocument.docx")
 
 docx.create_text('Hello World!')
 

data/demo/texts/append_styled_text.rb

@@ -2,8 +2,7 @@
 
 $LOAD_PATH.push "#{Dir.pwd}/lib"
 require 'goldendocx'
-
-docx = Goldendocx::Docx.new("#{Dir.pwd}/demo/templates/blankDocument.docx")
+docx = Goldendocx::Docx.new.read_from("#{Dir.pwd}/demo/templates/blankDocument.docx")
 
 # Register styles because default document without any style
 docx.add_style(File.read("#{Dir.pwd}/demo/templates/styles/reportTitle"))

data/demo/texts/create_text.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+$LOAD_PATH.push "#{Dir.pwd}/lib"
+require 'goldendocx'
+
+docx = Goldendocx::Docx.new
+
+docx.create_text('Hello World!')
+docx.create_text('Hello World!', align: :center, color: 'FF8533', bold: true)
+
+filename = 'plainTextDocument.docx'
+system "rm -f ~/Desktop/#{filename}" # -f so that we don't have an error if the file doesn't exist
+docx.write_to File.expand_path("~/Desktop/#{filename}")
+exec "open ~/Desktop/#{filename}"

data/lib/extensions/active_support_extensions.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'active_support/concern'
+require 'active_support/core_ext/array/access'
+require 'active_support/core_ext/class/attribute'
+require 'active_support/core_ext/class/subclasses'
+require 'active_support/core_ext/hash/indifferent_access'
+require 'active_support/core_ext/string/inflections'
+require 'active_support/core_ext/string/conversions'
+
+ActiveSupport::Inflector.inflections do |inflect|
+  inflect.uncountable 'extents', 'image_data', 'data', 'defaults', 'latentStyles'
+  inflect.irregular 'axis', 'axes'
+
+  inflect.uncountable 'values' # TODO: Find better names
+end

data/lib/extensions/nokogiri_extensions.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'nokogiri'
+
+# FIXME: Temporarily here to provider syntactic sugar
+module Nokogiri
+  module XML
+    class Document
+      def tag_name
+        root.tag_name
+      end
+    end
+
+    class Node
+      def <<(node_or_tags)
+        # FIXME: Add this line to transform element implicitly
+        node_or_tags = node_or_tags.public_send(:to_element, parent: self) if node_or_tags.respond_to?(:to_element)
+
+        add_child(node_or_tags)
+        self
+      end
+
+      def adapt?(klass)
+        adaptable_classes = [String, Integer, Time]
+        is_a?(Nokogiri::XML::Text) && adaptable_classes.include?(klass)
+      end
+
+      def tag_name
+        [namespace&.prefix, name].compact.join(':')
+      end
+
+      def unparsed_children
+        @unparsed_children ||= children.dup
+      end
+
+      def attributes_hash
+        attribute_nodes.reject { |node| node.tag_name == 'mc:Ignorable' }.to_h { |node| [node.tag_name, node.value] }
+      end
+    end
+  end
+end

data/lib/extensions/ox_extensions.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require 'ox'
+
+module Ox
+  class Document
+    def root
+      children.first
+    end
+  end
+
+  class Element
+    def <<(node)
+      # FIXME: Add this line to transform element implicitly
+      node = node.public_send(:to_element) if node.respond_to?(:to_element)
+
+      raise 'argument to << must be a String or Ox::Node.' unless node.is_a?(String) || node.is_a?(Node)
+
+      @nodes = [] if !instance_variable_defined?(:@nodes) || @nodes.nil?
+      @nodes << node
+      self
+    end
+
+    alias children nodes
+    alias tag_name name
+
+    def unparsed_children
+      @unparsed_children ||= children.dup
+    end
+
+    def attributes_hash
+      attributes.with_indifferent_access.reject { |k, _| k.to_s.start_with?('xmlns') || k.to_s == 'mc:Ignorable' }
+    end
+  end
+end

data/lib/extensions/xml_serialize_extensions.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+class String
+  class << self
+    def adapt?(xml_node)
+      xml_node.is_a?(String) || xml_node.adapt?(String)
+    end
+
+    def read_from(xml_node)
+      xml_node.to_s
+    end
+  end
+end
+
+class Time
+  class << self
+    def adapt?(xml_node)
+      xml_node.is_a?(String) || xml_node.adapt?(Time)
+    end
+
+    def read_from(xml_node)
+      xml_node.to_s.to_time
+    end
+  end
+
+  def to_element(**_context)
+    strftime('%Y-%m-%dT%H:%M:%SZ')
+  end
+end
+
+class Integer
+  class << self
+    def adapt?(xml_node)
+      xml_node.is_a?(String) || xml_node.adapt?(Integer)
+    end
+
+    def read_from(xml_node)
+      xml_node.to_s.to_i
+    end
+  end
+
+  def to_element(**_context)
+    to_s
+  end
+end

data/lib/goldendocx/charts/properties.rb

@@ -7,6 +7,6 @@ module Goldendocx
   end
 end
 
-Dir.glob(File.join(File.dirname(__FILE__), 'properties', '*.rb').to_s).sort.each do |file|
+Dir.glob(File.join(File.dirname(__FILE__), 'properties', '*.rb').to_s).each do |file|
   require file
 end

data/lib/goldendocx/charts/series.rb

@@ -27,7 +27,7 @@ module Goldendocx
       def categories=(categories)
         category_axis.values.build_count(count: categories.size)
         categories.each_with_index do |cat, index|
-          point = category_axis.values.build_point(index: index)
+          point = category_axis.values.build_point(index:)
           point.build_value(value: cat)
         end
       end
@@ -35,7 +35,7 @@ module Goldendocx
       def values=(values)
         value_axis.values.build_count(count: values.size)
         values.each_with_index do |val, index|
-          point = value_axis.values.build_point(index: index)
+          point = value_axis.values.build_point(index:)
           point.build_value(value: val)
         end
       end

data/lib/goldendocx/charts.rb

@@ -21,6 +21,6 @@ end
 
 require 'goldendocx/charts/properties'
 
-Dir.glob(File.join(File.dirname(__FILE__), 'charts', '*.rb').to_s).sort.each do |file|
+Dir.glob(File.join(File.dirname(__FILE__), 'charts', '*.rb').to_s).each do |file|
   require file
 end

data/lib/goldendocx/components/bar_chart.rb

@@ -3,8 +3,8 @@
 module Goldendocx
   module Components
     class BarChart < Chart
-      def initialize(chart_id, relationship_id, **attributes)
-        super(chart_id, relationship_id, **attributes)
+      def initialize(chart_id, relationship_id, attributes = {})
+        super(chart_id, relationship_id, attributes)
 
         build_chart.plot_area.build_bar_chart
       end

data/lib/goldendocx/components/chart.rb

@@ -18,21 +18,21 @@ module Goldendocx
       attr_accessor :name
       attr_reader :id, :series
 
-      def initialize(chart_id, relationship_id, **attributes)
+      def initialize(chart_id, relationship_id, attributes = {})
         @id = chart_id
         @series = []
 
         @paragraph = Goldendocx::Components::Paragraph.new
         inline_drawing = @paragraph.build_run.build_drawing.build_inline
-        inline_drawing.build_non_visual_property(relationship_id: relationship_id)
+        inline_drawing.build_non_visual_property(relationship_id:)
         inline_drawing.build_extents(width: attributes[:width], height: attributes[:height])
-        inline_drawing.build_graphic.build_data.build_chart(relationship_id: relationship_id)
+        inline_drawing.build_graphic.build_data.build_chart(relationship_id:)
       end
 
       def add_series(name, categories, values)
         ser_id = series.size + 1
-        the_chart.build_series(categories: categories, values: values, id: ser_id, name: name)
-        ser = Goldendocx::Charts::Series.new(categories: categories, values: values, id: ser_id, name: name)
+        the_chart.build_series(categories:, values:, id: ser_id, name:)
+        ser = Goldendocx::Charts::Series.new(categories:, values:, id: ser_id, name:)
         series << ser
         ser
       end
@@ -46,7 +46,7 @@ module Goldendocx
       end
 
       def write_to(zos)
-        entry_name = format(Goldendocx::Charts::RELATIONSHIP_NAME_PATTERN, id: id)
+        entry_name = format(Goldendocx::Charts::RELATIONSHIP_NAME_PATTERN, id:)
         zos.put_next_entry "word/#{entry_name}"
         zos.write to_document_xml
       end

data/lib/goldendocx/components/column_chart.rb

@@ -3,8 +3,8 @@
 module Goldendocx
   module Components
     class ColumnChart < Chart
-      def initialize(chart_id, relationship_id, **attributes)
-        super(chart_id, relationship_id, **attributes)
+      def initialize(chart_id, relationship_id, attributes = {})
+        super(chart_id, relationship_id, attributes)
 
         build_chart.plot_area.build_column_chart
       end

data/lib/goldendocx/components/doughnut_chart.rb

@@ -3,8 +3,8 @@
 module Goldendocx
   module Components
     class DoughnutChart < Chart
-      def initialize(chart_id, relationship_id, **attributes)
-        super(chart_id, relationship_id, **attributes)
+      def initialize(chart_id, relationship_id, attributes = {})
+        super(chart_id, relationship_id, attributes)
 
         build_chart.plot_area.build_doughnut_chart
       end

data/lib/goldendocx/components/line_chart.rb

@@ -3,8 +3,8 @@
 module Goldendocx
   module Components
     class LineChart < Chart
-      def initialize(chart_id, relationship_id, **attributes)
-        super(chart_id, relationship_id, **attributes)
+      def initialize(chart_id, relationship_id, attributes = {})
+        super(chart_id, relationship_id, attributes)
 
         build_chart.plot_area.build_line_chart
       end

data/lib/goldendocx/components/properties/font_property.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Goldendocx
+  module Components
+    module Properties
+      class FontProperty
+        include Goldendocx::Element
+
+        namespace :w
+        tag :rFonts
+
+        attribute :ascii, namespace: :w, default: 'Times New Roman'
+        attribute :east_asia, alias_name: :eastAsia, namespace: :w, default: '宋体'
+        attribute :high_ansi, alias_name: :hAnsi, namespace: :w, default: 'Times New Roman'
+        attribute :complex, alias_name: :cs, namespace: :w, default: 'Times New Roman'
+      end
+    end
+  end
+end

data/lib/goldendocx/components/properties/language_property.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Goldendocx
+  module Components
+    module Properties
+      class LanguageProperty
+        include Goldendocx::Element
+
+        namespace :w
+        tag :lang
+
+        attribute :complex, alias_name: :bidi, namespace: :w, default: 'ar-SA'
+        attribute :east_asia, alias_name: :eastAsia, namespace: :w, default: 'zh-CN'
+        attribute :latin, alias_name: :val, namespace: :w, default: 'en-US'
+      end
+    end
+  end
+end

data/lib/goldendocx/components/properties/run_property.rb

@@ -11,6 +11,8 @@ module Goldendocx
 
         embeds_one :color, class_name: 'Goldendocx::Components::Properties::ColorProperty', auto_build: false
         embeds_one :bold, class_name: 'Goldendocx::Components::Properties::BoldProperty', auto_build: false
+        embeds_one :language, class_name: 'Goldendocx::Components::Properties::LanguageProperty', auto_build: false
+        embeds_one :font, class_name: 'Goldendocx::Components::Properties::FontProperty', auto_build: false
       end
     end
   end

data/lib/goldendocx/components/properties.rb

@@ -7,6 +7,6 @@ module Goldendocx
   end
 end
 
-Dir.glob(File.join(File.dirname(__FILE__), 'properties', '*.rb').to_s).sort.each do |file|
+Dir.glob(File.join(File.dirname(__FILE__), 'properties', '*.rb').to_s).each do |file|
   require file
 end

data/lib/goldendocx/components/table.rb

@@ -29,8 +29,8 @@ module Goldendocx
       end
 
       def add_header(title, width: nil)
-        header.build_cell(content: title, width: width)
-        grid_property.build_grid_column(width: width) if width
+        header.build_cell(content: title, width:)
+        grid_property.build_grid_column(width:) if width
         header
       end
 

data/lib/goldendocx/components.rb

@@ -11,6 +11,6 @@ end
 require 'goldendocx/components/properties'
 require 'goldendocx/components/chart'
 
-Dir.glob(File.join(File.dirname(__FILE__), 'components', '*.rb').to_s).sort.each do |file|
+Dir.glob(File.join(File.dirname(__FILE__), 'components', '*.rb').to_s).each do |file|
   require file
 end

data/lib/goldendocx/content_types/default.rb

@@ -6,13 +6,9 @@ module Goldendocx
       include Goldendocx::Element
 
       tag :Default
-      attribute :extension, alias_name: :Extension, readonly: true
-      attribute :content_type, alias_name: :ContentType, readonly: true
 
-      def initialize(extension, content_type)
-        @extension = extension
-        @content_type = content_type
-      end
+      attribute :extension, alias_name: :Extension
+      attribute :content_type, alias_name: :ContentType
 
       def ==(other)
         extension == other.extension && content_type == other.content_type