gocardless_pro 2.27.0 → 2.30.0

data/spec/services/billing_requests_service_spec.rb

@@ -18,8 +18,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
           'billing_requests' => [{
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -49,10 +49,10 @@ describe GoCardlessPro::Services::BillingRequestsService do
 
         expect(get_list_response.records.first.actions).to eq('actions-input')
 
-        expect(get_list_response.records.first.auto_fulfil).to eq('auto_fulfil-input')
-
         expect(get_list_response.records.first.created_at).to eq('created_at-input')
 
+        expect(get_list_response.records.first.fallback_enabled).to eq('fallback_enabled-input')
+
         expect(get_list_response.records.first.id).to eq('id-input')
 
         expect(get_list_response.records.first.mandate_request).to eq('mandate_request-input')
@@ -105,8 +105,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
           'billing_requests' => [{
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -130,8 +130,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
           'billing_requests' => [{
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -164,8 +164,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'billing_requests' => [{
 
               'actions' => 'actions-input',
-              'auto_fulfil' => 'auto_fulfil-input',
               'created_at' => 'created_at-input',
+              'fallback_enabled' => 'fallback_enabled-input',
               'id' => 'id-input',
               'links' => 'links-input',
               'mandate_request' => 'mandate_request-input',
@@ -189,8 +189,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
                                    'billing_requests' => [{
 
                                      'actions' => 'actions-input',
-                                     'auto_fulfil' => 'auto_fulfil-input',
                                      'created_at' => 'created_at-input',
+                                     'fallback_enabled' => 'fallback_enabled-input',
                                      'id' => 'id-input',
                                      'links' => 'links-input',
                                      'mandate_request' => 'mandate_request-input',
@@ -219,8 +219,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'billing_requests' => [{
 
               'actions' => 'actions-input',
-              'auto_fulfil' => 'auto_fulfil-input',
               'created_at' => 'created_at-input',
+              'fallback_enabled' => 'fallback_enabled-input',
               'id' => 'id-input',
               'links' => 'links-input',
               'mandate_request' => 'mandate_request-input',
@@ -247,8 +247,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
                                    'billing_requests' => [{
 
                                      'actions' => 'actions-input',
-                                     'auto_fulfil' => 'auto_fulfil-input',
                                      'created_at' => 'created_at-input',
+                                     'fallback_enabled' => 'fallback_enabled-input',
                                      'id' => 'id-input',
                                      'links' => 'links-input',
                                      'mandate_request' => 'mandate_request-input',
@@ -280,8 +280,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
         {
 
           'actions' => 'actions-input',
-          'auto_fulfil' => 'auto_fulfil-input',
           'created_at' => 'created_at-input',
+          'fallback_enabled' => 'fallback_enabled-input',
           'id' => 'id-input',
           'links' => 'links-input',
           'mandate_request' => 'mandate_request-input',
@@ -299,8 +299,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',
@@ -318,8 +318,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
                 {
 
                   'actions' => 'actions-input',
-                  'auto_fulfil' => 'auto_fulfil-input',
                   'created_at' => 'created_at-input',
+                  'fallback_enabled' => 'fallback_enabled-input',
                   'id' => 'id-input',
                   'links' => 'links-input',
                   'mandate_request' => 'mandate_request-input',
@@ -393,8 +393,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
         {
 
           'actions' => 'actions-input',
-          'auto_fulfil' => 'auto_fulfil-input',
           'created_at' => 'created_at-input',
+          'fallback_enabled' => 'fallback_enabled-input',
           'id' => 'id-input',
           'links' => 'links-input',
           'mandate_request' => 'mandate_request-input',
@@ -435,8 +435,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',
@@ -471,19 +471,6 @@ describe GoCardlessPro::Services::BillingRequestsService do
             to raise_error(GoCardlessPro::IdempotencyConflict)
         end
       end
-
-      context 'with on_idempotency_conflict: :unknown' do
-        let(:client) do
-          GoCardlessPro::Client.new(
-            access_token: 'SECRET_TOKEN',
-            on_idempotency_conflict: :unknown
-          )
-        end
-
-        it 'raises an ArgumentError' do
-          expect { post_create_response }.to raise_error(ArgumentError)
-        end
-      end
     end
   end
 
@@ -502,8 +489,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',
@@ -537,8 +524,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'billing_requests' => {
 
               'actions' => 'actions-input',
-              'auto_fulfil' => 'auto_fulfil-input',
               'created_at' => 'created_at-input',
+              'fallback_enabled' => 'fallback_enabled-input',
               'id' => 'id-input',
               'links' => 'links-input',
               'mandate_request' => 'mandate_request-input',
@@ -644,12 +631,13 @@ describe GoCardlessPro::Services::BillingRequestsService do
       # /billing_requests/%v/actions/collect_customer_details
       stub_url = '/billing_requests/:identity/actions/collect_customer_details'.gsub(':identity', resource_id)
       stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+
         body: {
           'billing_requests' => {
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -659,6 +647,7 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'status' => 'status-input',
           },
         }.to_json,
+
         headers: response_headers
       )
     end
@@ -699,8 +688,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',
@@ -716,21 +705,22 @@ describe GoCardlessPro::Services::BillingRequestsService do
     end
   end
 
-  describe '#collect_bank_account_details' do
-    subject(:post_response) { client.billing_requests.collect_bank_account_details(resource_id) }
+  describe '#collect_bank_account' do
+    subject(:post_response) { client.billing_requests.collect_bank_account(resource_id) }
 
     let(:resource_id) { 'ABC123' }
 
     let!(:stub) do
-      # /billing_requests/%v/actions/collect_bank_account_details
-      stub_url = '/billing_requests/:identity/actions/collect_bank_account_details'.gsub(':identity', resource_id)
+      # /billing_requests/%v/actions/collect_bank_account
+      stub_url = '/billing_requests/:identity/actions/collect_bank_account'.gsub(':identity', resource_id)
       stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+
         body: {
           'billing_requests' => {
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -740,6 +730,7 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'status' => 'status-input',
           },
         }.to_json,
+
         headers: response_headers
       )
     end
@@ -752,7 +743,7 @@ describe GoCardlessPro::Services::BillingRequestsService do
 
     describe 'retry behaviour' do
       it "doesn't retry errors" do
-        stub_url = '/billing_requests/:identity/actions/collect_bank_account_details'.gsub(':identity', resource_id)
+        stub_url = '/billing_requests/:identity/actions/collect_bank_account'.gsub(':identity', resource_id)
         stub = stub_request(:post, /.*api.gocardless.com#{stub_url}/).
                to_timeout
 
@@ -764,13 +755,13 @@ describe GoCardlessPro::Services::BillingRequestsService do
     context 'when the request needs a body and custom header' do
       let(:body) { { foo: 'bar' } }
       let(:headers) { { 'Foo' => 'Bar' } }
-      subject(:post_response) { client.billing_requests.collect_bank_account_details(resource_id, body, headers) }
+      subject(:post_response) { client.billing_requests.collect_bank_account(resource_id, body, headers) }
 
       let(:resource_id) { 'ABC123' }
 
       let!(:stub) do
-        # /billing_requests/%v/actions/collect_bank_account_details
-        stub_url = '/billing_requests/:identity/actions/collect_bank_account_details'.gsub(':identity', resource_id)
+        # /billing_requests/%v/actions/collect_bank_account
+        stub_url = '/billing_requests/:identity/actions/collect_bank_account'.gsub(':identity', resource_id)
         stub_request(:post, /.*api.gocardless.com#{stub_url}/).
           with(
             body: { foo: 'bar' },
@@ -780,8 +771,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',
@@ -806,12 +797,13 @@ describe GoCardlessPro::Services::BillingRequestsService do
       # /billing_requests/%v/actions/fulfil
       stub_url = '/billing_requests/:identity/actions/fulfil'.gsub(':identity', resource_id)
       stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+
         body: {
           'billing_requests' => {
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -821,6 +813,7 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'status' => 'status-input',
           },
         }.to_json,
+
         headers: response_headers
       )
     end
@@ -861,8 +854,91 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'mandate_request' => 'mandate_request-input',
+                'metadata' => 'metadata-input',
+                'payment_request' => 'payment_request-input',
+                'resources' => 'resources-input',
+                'status' => 'status-input',
+              },
+            }.to_json,
+            headers: response_headers
+          )
+      end
+    end
+  end
+
+  describe '#confirm_payer_details' do
+    subject(:post_response) { client.billing_requests.confirm_payer_details(resource_id) }
+
+    let(:resource_id) { 'ABC123' }
+
+    let!(:stub) do
+      # /billing_requests/%v/actions/confirm_payer_details
+      stub_url = '/billing_requests/:identity/actions/confirm_payer_details'.gsub(':identity', resource_id)
+      stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+
+        body: {
+          'billing_requests' => {
+
+            'actions' => 'actions-input',
+            'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'mandate_request' => 'mandate_request-input',
+            'metadata' => 'metadata-input',
+            'payment_request' => 'payment_request-input',
+            'resources' => 'resources-input',
+            'status' => 'status-input',
+          },
+        }.to_json,
+
+        headers: response_headers
+      )
+    end
+
+    it 'wraps the response and calls the right endpoint' do
+      expect(post_response).to be_a(GoCardlessPro::Resources::BillingRequest)
+
+      expect(stub).to have_been_requested
+    end
+
+    describe 'retry behaviour' do
+      it "doesn't retry errors" do
+        stub_url = '/billing_requests/:identity/actions/confirm_payer_details'.gsub(':identity', resource_id)
+        stub = stub_request(:post, /.*api.gocardless.com#{stub_url}/).
+               to_timeout
+
+        expect { post_response }.to raise_error(Faraday::ConnectionFailed)
+        expect(stub).to have_been_requested
+      end
+    end
+
+    context 'when the request needs a body and custom header' do
+      let(:body) { { foo: 'bar' } }
+      let(:headers) { { 'Foo' => 'Bar' } }
+      subject(:post_response) { client.billing_requests.confirm_payer_details(resource_id, body, headers) }
+
+      let(:resource_id) { 'ABC123' }
+
+      let!(:stub) do
+        # /billing_requests/%v/actions/confirm_payer_details
+        stub_url = '/billing_requests/:identity/actions/confirm_payer_details'.gsub(':identity', resource_id)
+        stub_request(:post, /.*api.gocardless.com#{stub_url}/).
+          with(
+            body: { foo: 'bar' },
+            headers: { 'Foo' => 'Bar' }
+          ).to_return(
+            body: {
+              'billing_requests' => {
+
+                'actions' => 'actions-input',
+                'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',
@@ -887,12 +963,13 @@ describe GoCardlessPro::Services::BillingRequestsService do
       # /billing_requests/%v/actions/cancel
       stub_url = '/billing_requests/:identity/actions/cancel'.gsub(':identity', resource_id)
       stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+
         body: {
           'billing_requests' => {
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -902,6 +979,7 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'status' => 'status-input',
           },
         }.to_json,
+
         headers: response_headers
       )
     end
@@ -942,8 +1020,8 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',
@@ -968,12 +1046,13 @@ describe GoCardlessPro::Services::BillingRequestsService do
       # /billing_requests/%v/actions/notify
       stub_url = '/billing_requests/:identity/actions/notify'.gsub(':identity', resource_id)
       stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+
         body: {
           'billing_requests' => {
 
             'actions' => 'actions-input',
-            'auto_fulfil' => 'auto_fulfil-input',
             'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
             'id' => 'id-input',
             'links' => 'links-input',
             'mandate_request' => 'mandate_request-input',
@@ -983,6 +1062,7 @@ describe GoCardlessPro::Services::BillingRequestsService do
             'status' => 'status-input',
           },
         }.to_json,
+
         headers: response_headers
       )
     end
@@ -1023,8 +1103,91 @@ describe GoCardlessPro::Services::BillingRequestsService do
               'billing_requests' => {
 
                 'actions' => 'actions-input',
-                'auto_fulfil' => 'auto_fulfil-input',
                 'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'mandate_request' => 'mandate_request-input',
+                'metadata' => 'metadata-input',
+                'payment_request' => 'payment_request-input',
+                'resources' => 'resources-input',
+                'status' => 'status-input',
+              },
+            }.to_json,
+            headers: response_headers
+          )
+      end
+    end
+  end
+
+  describe '#fallback' do
+    subject(:post_response) { client.billing_requests.fallback(resource_id) }
+
+    let(:resource_id) { 'ABC123' }
+
+    let!(:stub) do
+      # /billing_requests/%v/actions/fallback
+      stub_url = '/billing_requests/:identity/actions/fallback'.gsub(':identity', resource_id)
+      stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+
+        body: {
+          'billing_requests' => {
+
+            'actions' => 'actions-input',
+            'created_at' => 'created_at-input',
+            'fallback_enabled' => 'fallback_enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'mandate_request' => 'mandate_request-input',
+            'metadata' => 'metadata-input',
+            'payment_request' => 'payment_request-input',
+            'resources' => 'resources-input',
+            'status' => 'status-input',
+          },
+        }.to_json,
+
+        headers: response_headers
+      )
+    end
+
+    it 'wraps the response and calls the right endpoint' do
+      expect(post_response).to be_a(GoCardlessPro::Resources::BillingRequest)
+
+      expect(stub).to have_been_requested
+    end
+
+    describe 'retry behaviour' do
+      it "doesn't retry errors" do
+        stub_url = '/billing_requests/:identity/actions/fallback'.gsub(':identity', resource_id)
+        stub = stub_request(:post, /.*api.gocardless.com#{stub_url}/).
+               to_timeout
+
+        expect { post_response }.to raise_error(Faraday::ConnectionFailed)
+        expect(stub).to have_been_requested
+      end
+    end
+
+    context 'when the request needs a body and custom header' do
+      let(:body) { { foo: 'bar' } }
+      let(:headers) { { 'Foo' => 'Bar' } }
+      subject(:post_response) { client.billing_requests.fallback(resource_id, body, headers) }
+
+      let(:resource_id) { 'ABC123' }
+
+      let!(:stub) do
+        # /billing_requests/%v/actions/fallback
+        stub_url = '/billing_requests/:identity/actions/fallback'.gsub(':identity', resource_id)
+        stub_request(:post, /.*api.gocardless.com#{stub_url}/).
+          with(
+            body: { foo: 'bar' },
+            headers: { 'Foo' => 'Bar' }
+          ).to_return(
+            body: {
+              'billing_requests' => {
+
+                'actions' => 'actions-input',
+                'created_at' => 'created_at-input',
+                'fallback_enabled' => 'fallback_enabled-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
                 'mandate_request' => 'mandate_request-input',