gocardless_pro 2.24.0 → 2.29.0

data/lib/gocardless_pro/services/subscriptions_service.rb

@@ -34,8 +34,6 @@ module GoCardlessPro
               raise IdempotencyConflict, e.error
             when :fetch
               return get(e.conflicting_resource_id)
-            else
-              raise ArgumentError, 'Unknown mode for :on_idempotency_conflict'
             end
           end
 
@@ -65,7 +63,7 @@ module GoCardlessPro
         )
       end
 
-      # Get a lazily enumerated list of all the items returned. This is simmilar to the `list` method but will paginate for you automatically.
+      # Get a lazily enumerated list of all the items returned. This is similar to the `list` method but will paginate for you automatically.
       #
       # @param options [Hash] parameters as a hash. If the request is a GET, these will be converted to query parameters.
       # Otherwise they will be the body of the request.
@@ -140,9 +138,10 @@ module GoCardlessPro
       # Pause a subscription object.
       # No payments will be created until it is resumed.
       #
-      # This can only be used when a subscription collecting a fixed number of
-      # payments (created using `count`)
-      # or when they continue forever (created without `count` or `end_date`)
+      # This can only be used when a subscription is collecting a fixed number of
+      # payments (created using `count`),
+      # when they continue forever (created without `count` or `end_date`) or
+      # the subscription is already paused for a number of cycles.
       #
       # When `pause_cycles` is omitted the subscription is paused until the [resume
       # endpoint](#subscriptions-resume-a-subscription) is called.
@@ -166,7 +165,11 @@ module GoCardlessPro
       # - `validation_failed` if invalid data is provided when attempting to pause a
       # subscription.
       #
-      # - `subscription_not_active` if the subscription is no longer active.
+      # - `subscription_paused_cannot_update_cycles` if the subscription is already
+      # paused for a number of cycles and the request provides a value for
+      # `pause_cycle`.
+      #
+      # - `subscription_cannot_be_paused` if the subscription cannot be paused.
       #
       # - `subscription_already_ended` if the subscription has taken all payments.
       #
@@ -198,8 +201,6 @@ module GoCardlessPro
               raise IdempotencyConflict, e.error
             when :fetch
               return get(e.conflicting_resource_id)
-            else
-              raise ArgumentError, 'Unknown mode for :on_idempotency_conflict'
             end
           end
 
@@ -253,8 +254,6 @@ module GoCardlessPro
               raise IdempotencyConflict, e.error
             when :fetch
               return get(e.conflicting_resource_id)
-            else
-              raise ArgumentError, 'Unknown mode for :on_idempotency_conflict'
             end
           end
 
@@ -297,8 +296,6 @@ module GoCardlessPro
               raise IdempotencyConflict, e.error
             when :fetch
               return get(e.conflicting_resource_id)
-            else
-              raise ArgumentError, 'Unknown mode for :on_idempotency_conflict'
             end
           end
 

data/lib/gocardless_pro/services/tax_rates_service.rb

@@ -28,7 +28,7 @@ module GoCardlessPro
         )
       end
 
-      # Get a lazily enumerated list of all the items returned. This is simmilar to the `list` method but will paginate for you automatically.
+      # Get a lazily enumerated list of all the items returned. This is similar to the `list` method but will paginate for you automatically.
       #
       # @param options [Hash] parameters as a hash. If the request is a GET, these will be converted to query parameters.
       # Otherwise they will be the body of the request.

data/lib/gocardless_pro/services/webhooks_service.rb

@@ -0,0 +1,111 @@
+require_relative './base_service'
+
+# encoding: utf-8
+#
+# This client is automatically generated from a template and JSON schema definition.
+# See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.
+#
+
+module GoCardlessPro
+  module Services
+    # Service for making requests to the Webhook endpoints
+    class WebhooksService < BaseService
+      # Returns a [cursor-paginated](#api-usage-cursor-pagination) list of your
+      # webhooks.
+      # Example URL: /webhooks
+      # @param options [Hash] parameters as a hash, under a params key.
+      def list(options = {})
+        path = '/webhooks'
+
+        options[:retry_failures] = true
+
+        response = make_request(:get, path, options)
+
+        ListResponse.new(
+          response: response,
+          unenveloped_body: unenvelope_body(response.body),
+          resource_class: Resources::Webhook
+        )
+      end
+
+      # Get a lazily enumerated list of all the items returned. This is similar to the `list` method but will paginate for you automatically.
+      #
+      # @param options [Hash] parameters as a hash. If the request is a GET, these will be converted to query parameters.
+      # Otherwise they will be the body of the request.
+      def all(options = {})
+        Paginator.new(
+          service: self,
+          options: options
+        ).enumerator
+      end
+
+      # Retrieves the details of an existing webhook.
+      # Example URL: /webhooks/:identity
+      #
+      # @param identity       # Unique identifier, beginning with "WB".
+      # @param options [Hash] parameters as a hash, under a params key.
+      def get(identity, options = {})
+        path = sub_url('/webhooks/:identity', 'identity' => identity)
+
+        options[:retry_failures] = true
+
+        response = make_request(:get, path, options)
+
+        return if response.body.nil?
+
+        Resources::Webhook.new(unenvelope_body(response.body), response)
+      end
+
+      # Requests for a previous webhook to be sent again
+      # Example URL: /webhooks/:identity/actions/retry
+      #
+      # @param identity       # Unique identifier, beginning with "WB".
+      # @param options [Hash] parameters as a hash, under a params key.
+      def retry(identity, options = {})
+        path = sub_url('/webhooks/:identity/actions/retry', 'identity' => identity)
+
+        params = options.delete(:params) || {}
+        options[:params] = {}
+        options[:params]['data'] = params
+
+        options[:retry_failures] = false
+
+        begin
+          response = make_request(:post, path, options)
+
+          # Response doesn't raise any errors until #body is called
+          response.tap(&:body)
+        rescue InvalidStateError => e
+          if e.idempotent_creation_conflict?
+            case @api_service.on_idempotency_conflict
+            when :raise
+              raise IdempotencyConflict, e.error
+            when :fetch
+              return get(e.conflicting_resource_id)
+            end
+          end
+
+          raise e
+        end
+
+        return if response.body.nil?
+
+        Resources::Webhook.new(unenvelope_body(response.body), response)
+      end
+
+      private
+
+      # Unenvelope the response of the body using the service's `envelope_key`
+      #
+      # @param body [Hash]
+      def unenvelope_body(body)
+        body[envelope_key] || body['data']
+      end
+
+      # return the key which API responses will envelope data under
+      def envelope_key
+        'webhooks'
+      end
+    end
+  end
+end

data/lib/gocardless_pro/version.rb

@@ -4,5 +4,5 @@ end
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '2.24.0'.freeze
+  VERSION = '2.29.0'.freeze
 end

data/lib/gocardless_pro.rb

@@ -32,15 +32,33 @@ require_relative 'gocardless_pro/error/gocardless_error'
 require_relative 'gocardless_pro/error/invalid_api_usage_error'
 require_relative 'gocardless_pro/error/invalid_state_error'
 require_relative 'gocardless_pro/error/api_error'
+require_relative 'gocardless_pro/error/permission_error'
+require_relative 'gocardless_pro/error/authentication_error'
+require_relative 'gocardless_pro/error/rate_limit_error'
 require_relative 'gocardless_pro/paginator'
 require_relative 'gocardless_pro/request'
 require_relative 'gocardless_pro/response'
 require_relative 'gocardless_pro/api_response'
 require_relative 'gocardless_pro/webhook'
 
+require_relative 'gocardless_pro/resources/bank_authorisation'
+require_relative 'gocardless_pro/services/bank_authorisations_service'
+
 require_relative 'gocardless_pro/resources/bank_details_lookup'
 require_relative 'gocardless_pro/services/bank_details_lookups_service'
 
+require_relative 'gocardless_pro/resources/billing_request'
+require_relative 'gocardless_pro/services/billing_requests_service'
+
+require_relative 'gocardless_pro/resources/billing_request_flow'
+require_relative 'gocardless_pro/services/billing_request_flows_service'
+
+require_relative 'gocardless_pro/resources/billing_request_template'
+require_relative 'gocardless_pro/services/billing_request_templates_service'
+
+require_relative 'gocardless_pro/resources/block'
+require_relative 'gocardless_pro/services/blocks_service'
+
 require_relative 'gocardless_pro/resources/creditor'
 require_relative 'gocardless_pro/services/creditors_service'
 
@@ -65,6 +83,9 @@ require_relative 'gocardless_pro/services/events_service'
 require_relative 'gocardless_pro/resources/instalment_schedule'
 require_relative 'gocardless_pro/services/instalment_schedules_service'
 
+require_relative 'gocardless_pro/resources/institution'
+require_relative 'gocardless_pro/services/institutions_service'
+
 require_relative 'gocardless_pro/resources/mandate'
 require_relative 'gocardless_pro/services/mandates_service'
 
@@ -77,6 +98,9 @@ require_relative 'gocardless_pro/services/mandate_import_entries_service'
 require_relative 'gocardless_pro/resources/mandate_pdf'
 require_relative 'gocardless_pro/services/mandate_pdfs_service'
 
+require_relative 'gocardless_pro/resources/payer_authorisation'
+require_relative 'gocardless_pro/services/payer_authorisations_service'
+
 require_relative 'gocardless_pro/resources/payment'
 require_relative 'gocardless_pro/services/payments_service'
 
@@ -92,10 +116,16 @@ require_relative 'gocardless_pro/services/redirect_flows_service'
 require_relative 'gocardless_pro/resources/refund'
 require_relative 'gocardless_pro/services/refunds_service'
 
+require_relative 'gocardless_pro/resources/scenario_simulator'
+require_relative 'gocardless_pro/services/scenario_simulators_service'
+
 require_relative 'gocardless_pro/resources/subscription'
 require_relative 'gocardless_pro/services/subscriptions_service'
 
 require_relative 'gocardless_pro/resources/tax_rate'
 require_relative 'gocardless_pro/services/tax_rates_service'
 
+require_relative 'gocardless_pro/resources/webhook'
+require_relative 'gocardless_pro/services/webhooks_service'
+
 require_relative 'gocardless_pro/client.rb'

data/spec/api_service_spec.rb

@@ -1,8 +1,11 @@
 require 'spec_helper'
 
 describe GoCardlessPro::ApiService do
-  subject(:service) { described_class.new('https://api.example.com', 'secret_token') }
+  subject(:service) do
+    described_class.new('https://api.example.com', 'secret_token', options)
+  end
 
+  let(:options) { {} }
   let(:default_response) do
     {
       status: 200,
@@ -174,4 +177,12 @@ describe GoCardlessPro::ApiService do
       expect(stub).to have_been_requested
     end
   end
+
+  describe 'when passing an invalid :on_idempotency_conflict' do
+    let(:options) { { on_idempotency_conflict: :junk } }
+
+    it 'raises an error' do
+      expect { service }.to raise_error(ArgumentError)
+    end
+  end
 end

data/spec/middlewares/raise_gocardless_errors_spec.rb

@@ -74,6 +74,36 @@ describe GoCardlessPro::Middlewares::RaiseGoCardlessErrors do
       end
     end
 
+    context 'for a Permission error' do
+      let(:status) { 403 }
+      let(:body) { { error: { type: 'invalid_api_usage' } }.to_json }
+
+      it 'raises a GoCardlessError' do
+        expect { connection.post('https://api.gocardless.com/widgets') }.
+          to raise_error(GoCardlessPro::PermissionError)
+      end
+    end
+
+    context 'for a RateLimit error' do
+      let(:status) { 429 }
+      let(:body) { { error: { type: 'invalid_api_usage' } }.to_json }
+
+      it 'raises a GoCardlessError' do
+        expect { connection.post('https://api.gocardless.com/widgets') }.
+          to raise_error(GoCardlessPro::RateLimitError)
+      end
+    end
+
+    context 'for a Authentication error' do
+      let(:status) { 401 }
+      let(:body) { { error: { type: 'invalid_api_usage' } }.to_json }
+
+      it 'raises a GoCardlessError' do
+        expect { connection.post('https://api.gocardless.com/widgets') }.
+          to raise_error(GoCardlessPro::AuthenticationError)
+      end
+    end
+
     context 'for an invalid API usage error' do
       let(:status) { 400 }
       let(:body) { { error: { type: 'invalid_api_usage' } }.to_json }

data/spec/resources/bank_authorisation_spec.rb

@@ -0,0 +1,259 @@
+require 'spec_helper'
+
+describe GoCardlessPro::Resources::BankAuthorisation do
+  let(:client) do
+    GoCardlessPro::Client.new(
+      access_token: 'SECRET_TOKEN'
+    )
+  end
+
+  let(:response_headers) { { 'Content-Type' => 'application/json' } }
+
+  describe '#get' do
+    let(:id) { 'ID123' }
+
+    subject(:get_response) { client.bank_authorisations.get(id) }
+
+    context 'passing in a custom header' do
+      let!(:stub) do
+        stub_url = '/bank_authorisations/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).
+          with(headers: { 'Foo' => 'Bar' }).
+          to_return(
+            body: {
+              'bank_authorisations' => {
+
+                'authorisation_type' => 'authorisation_type-input',
+                'authorised_at' => 'authorised_at-input',
+                'created_at' => 'created_at-input',
+                'expires_at' => 'expires_at-input',
+                'id' => 'id-input',
+                'last_visited_at' => 'last_visited_at-input',
+                'links' => 'links-input',
+                'redirect_uri' => 'redirect_uri-input',
+                'url' => 'url-input',
+              },
+            }.to_json,
+            headers: response_headers
+          )
+      end
+
+      subject(:get_response) do
+        client.bank_authorisations.get(id, headers: {
+                                         'Foo' => 'Bar',
+                                       })
+      end
+
+      it 'includes the header' do
+        get_response
+        expect(stub).to have_been_requested
+      end
+    end
+
+    context 'when there is a bank_authorisation to return' do
+      before do
+        stub_url = '/bank_authorisations/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: {
+            'bank_authorisations' => {
+
+              'authorisation_type' => 'authorisation_type-input',
+              'authorised_at' => 'authorised_at-input',
+              'created_at' => 'created_at-input',
+              'expires_at' => 'expires_at-input',
+              'id' => 'id-input',
+              'last_visited_at' => 'last_visited_at-input',
+              'links' => 'links-input',
+              'redirect_uri' => 'redirect_uri-input',
+              'url' => 'url-input',
+            },
+          }.to_json,
+          headers: response_headers
+        )
+      end
+
+      it 'wraps the response in a resource' do
+        expect(get_response).to be_a(GoCardlessPro::Resources::BankAuthorisation)
+      end
+    end
+
+    context 'when nothing is returned' do
+      before do
+        stub_url = '/bank_authorisations/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: '',
+          headers: response_headers
+        )
+      end
+
+      it 'returns nil' do
+        expect(get_response).to be_nil
+      end
+    end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
+  end
+
+  describe '#create' do
+    subject(:post_create_response) { client.bank_authorisations.create(params: new_resource) }
+    context 'with a valid request' do
+      let(:new_resource) do
+        {
+
+          'authorisation_type' => 'authorisation_type-input',
+          'authorised_at' => 'authorised_at-input',
+          'created_at' => 'created_at-input',
+          'expires_at' => 'expires_at-input',
+          'id' => 'id-input',
+          'last_visited_at' => 'last_visited_at-input',
+          'links' => 'links-input',
+          'redirect_uri' => 'redirect_uri-input',
+          'url' => 'url-input',
+        }
+      end
+
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/bank_authorisations}).
+          with(
+            body: {
+              'bank_authorisations' => {
+
+                'authorisation_type' => 'authorisation_type-input',
+                'authorised_at' => 'authorised_at-input',
+                'created_at' => 'created_at-input',
+                'expires_at' => 'expires_at-input',
+                'id' => 'id-input',
+                'last_visited_at' => 'last_visited_at-input',
+                'links' => 'links-input',
+                'redirect_uri' => 'redirect_uri-input',
+                'url' => 'url-input',
+              },
+            }
+          ).
+          to_return(
+            body: {
+              'bank_authorisations' =>
+
+                {
+
+                  'authorisation_type' => 'authorisation_type-input',
+                  'authorised_at' => 'authorised_at-input',
+                  'created_at' => 'created_at-input',
+                  'expires_at' => 'expires_at-input',
+                  'id' => 'id-input',
+                  'last_visited_at' => 'last_visited_at-input',
+                  'links' => 'links-input',
+                  'redirect_uri' => 'redirect_uri-input',
+                  'url' => 'url-input',
+                },
+
+            }.to_json,
+            headers: response_headers
+          )
+      end
+
+      it 'creates and returns the resource' do
+        expect(post_create_response).to be_a(GoCardlessPro::Resources::BankAuthorisation)
+      end
+    end
+
+    context 'with a request that returns a validation error' do
+      let(:new_resource) { {} }
+
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/bank_authorisations}).to_return(
+          body: {
+            error: {
+              type: 'validation_failed',
+              code: 422,
+              errors: [
+                { message: 'test error message', field: 'test_field' },
+              ],
+            },
+          }.to_json,
+          headers: response_headers,
+          status: 422
+        )
+      end
+
+      it 'throws the correct error' do
+        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
+      end
+    end
+
+    context 'with a request that returns an idempotent creation conflict error' do
+      let(:id) { 'ID123' }
+
+      let(:new_resource) do
+        {
+
+          'authorisation_type' => 'authorisation_type-input',
+          'authorised_at' => 'authorised_at-input',
+          'created_at' => 'created_at-input',
+          'expires_at' => 'expires_at-input',
+          'id' => 'id-input',
+          'last_visited_at' => 'last_visited_at-input',
+          'links' => 'links-input',
+          'redirect_uri' => 'redirect_uri-input',
+          'url' => 'url-input',
+        }
+      end
+
+      let!(:post_stub) do
+        stub_request(:post, %r{.*api.gocardless.com/bank_authorisations}).to_return(
+          body: {
+            error: {
+              type: 'invalid_state',
+              code: 409,
+              errors: [
+                {
+                  message: 'A resource has already been created with this idempotency key',
+                  reason: 'idempotent_creation_conflict',
+                  links: {
+                    conflicting_resource_id: id,
+                  },
+                },
+              ],
+            },
+          }.to_json,
+          headers: response_headers,
+          status: 409
+        )
+      end
+
+      let!(:get_stub) do
+        stub_url = "/bank_authorisations/#{id}"
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).
+          to_return(
+            body: {
+              'bank_authorisations' => {
+
+                'authorisation_type' => 'authorisation_type-input',
+                'authorised_at' => 'authorised_at-input',
+                'created_at' => 'created_at-input',
+                'expires_at' => 'expires_at-input',
+                'id' => 'id-input',
+                'last_visited_at' => 'last_visited_at-input',
+                'links' => 'links-input',
+                'redirect_uri' => 'redirect_uri-input',
+                'url' => 'url-input',
+              },
+            }.to_json,
+            headers: response_headers
+          )
+      end
+
+      it 'fetches the already-created resource' do
+        post_create_response
+        expect(post_stub).to have_been_requested
+        expect(get_stub).to have_been_requested
+      end
+    end
+  end
+end