gocardless_pro 2.13.0 → 2.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fd702df303218fec5c4bc90ad731762d95c78a57df3c5f4c74dd2cec45e1c61
-  data.tar.gz: f7de4d6744ee3c86a191b9649ca921d468ba64740031612670ee558d2d67f81d
+  metadata.gz: 131219f7fa59f03ce5e6417b9409fa86bf094f38598e95956a5e2e248bb5d9ea
+  data.tar.gz: 03b5abcd23588c08423705525e678656435cd833349f5c9313a2afe05ce185a5
 SHA512:
-  metadata.gz: 51f15a425b95e8a38a957f4d875fbc8518c452e32f5a1d118866981aca16d7d4ebdecae96006b1cdb4adbb9d276184e2953d2991085a42004bf074019791281c
-  data.tar.gz: 4c39f5eb990e649758ab981b20e9b74dda3a322de0e94a51f1765551db0d33792a705bd1377b511d0f1b4e8deda500676a2abe9f45160ffe80c0a2f9ef6fc38c
+  metadata.gz: 99bdc0f720c6cd9b6083a80f1901a1cded3afaf69fcf8f1318ab2ce5595b3ac92793df826cbba8319eaecadb025c242ecb9d7c002bae958f9a9cb7b92f316eaf
+  data.tar.gz: 85bd9696613ea720eec40cdecce0aa12b1bd199961186e189a1caaa9a8d086fc846459ea437a74274f578701dfd7f30a372a821cd94ab3771f0912538dabd609

data/README.md

@@ -141,7 +141,7 @@ The most common use of a custom header would be to set a custom [idempotency key
     ...
   },
   headers: {
-    "Idempotency-Key": "1f9630a9-0487-418d-bd37-8b77793c9985"
+    "Idempotency-Key" => "1f9630a9-0487-418d-bd37-8b77793c9985"
   }
 )
 ```

data/gocardless_pro.gemspec

@@ -17,12 +17,18 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
+  spec.add_dependency 'faraday', ['>= 0.9.2', '< 1.0']
+
   spec.add_development_dependency 'rspec', '~> 3.7.0'
-  # Used by webmock and newer versions require ruby 2.1
-  spec.add_development_dependency 'public_suffix', '~> 2.0.5'
   spec.add_development_dependency 'webmock', '~> 1.18'
   spec.add_development_dependency 'rubocop', '~> 0.49.1'
   spec.add_development_dependency 'yard', '~> 0.9.11'
 
-  spec.add_dependency 'faraday', ['>= 0.9.2', '< 1.0']
+  # Pin the version of the 'public_suffix' gem, which is a transitive dependency
+  # of 'webmock' (newer versions require Ruby 2.1+).
+  spec.add_development_dependency 'public_suffix', '~> 2.0.5'
+
+  # Pin the version of the 'parallel' gem, which is a transitive dependency of
+  # 'rubocop' (newer versions require Ruby 2.2+).
+  spec.add_development_dependency 'parallel', '~> 1.13.0'
 end

data/lib/gocardless_pro/client.rb

@@ -138,7 +138,7 @@ module GoCardlessPro
           'User-Agent' => user_agent.to_s,
           'Content-Type' => 'application/json',
           'GoCardless-Client-Library' => 'gocardless-pro-ruby',
-          'GoCardless-Client-Version' => '2.13.0',
+          'GoCardless-Client-Version' => '2.14.0',
         },
       }
     end

data/lib/gocardless_pro/resources/creditor.rb

@@ -82,6 +82,10 @@ module GoCardlessPro
           @links['default_aud_payout_account']
         end
 
+        def default_cad_payout_account
+          @links['default_cad_payout_account']
+        end
+
         def default_dkk_payout_account
           @links['default_dkk_payout_account']
         end

data/lib/gocardless_pro/resources/creditor_bank_account.rb

@@ -28,6 +28,7 @@ module GoCardlessPro
     class CreditorBankAccount
       attr_reader :account_holder_name
       attr_reader :account_number_ending
+      attr_reader :account_type
       attr_reader :bank_name
       attr_reader :country_code
       attr_reader :created_at
@@ -43,6 +44,7 @@ module GoCardlessPro
 
         @account_holder_name = object['account_holder_name']
         @account_number_ending = object['account_number_ending']
+        @account_type = object['account_type']
         @bank_name = object['bank_name']
         @country_code = object['country_code']
         @created_at = object['created_at']

data/lib/gocardless_pro/resources/customer.rb

@@ -16,17 +16,6 @@ module GoCardlessPro
     # have several [customer bank
     # accounts](#core-endpoints-customer-bank-accounts), which in turn can have
     # several Direct Debit [mandates](#core-endpoints-mandates).
-    #
-    # Notes:
-    # - the `phone_number` field may only be supplied for New Zealand customers,
-    # and must be supplied if you intend to set up an BECS NZ mandate with the
-    # customer.
-    # - the `swedish_identity_number` field may only be supplied for Swedish
-    # customers, and must be supplied if you intend to set up an Autogiro
-    # mandate with the customer.
-    # - the `danish_identity_number` field may only be supplied for Danish
-    # customers, and must be supplied if you intend to set up a Betalingsservice
-    # mandate with the customer.
     class Customer
       attr_reader :address_line1
       attr_reader :address_line2

data/lib/gocardless_pro/resources/customer_bank_account.rb

@@ -25,6 +25,7 @@ module GoCardlessPro
     class CustomerBankAccount
       attr_reader :account_holder_name
       attr_reader :account_number_ending
+      attr_reader :account_type
       attr_reader :bank_name
       attr_reader :country_code
       attr_reader :created_at
@@ -40,6 +41,7 @@ module GoCardlessPro
 
         @account_holder_name = object['account_holder_name']
         @account_number_ending = object['account_number_ending']
+        @account_type = object['account_type']
         @bank_name = object['bank_name']
         @country_code = object['country_code']
         @created_at = object['created_at']

data/lib/gocardless_pro/resources/redirect_flow.rb

@@ -15,8 +15,8 @@ module GoCardlessPro
     # Redirect flows enable you to use GoCardless' [hosted payment
     # pages](https://pay-sandbox.gocardless.com/AL000000AKFPFF) to set up
     # mandates with your customers. These pages are fully compliant and have
-    # been translated into Dutch, French, German, Italian, Portuguese, Spanish
-    # and Swedish.
+    # been translated into Danish, Dutch, French, German, Italian, Norwegian,
+    # Portuguese, Slovak, Spanish and Swedish.
     #
     # The overall flow is:
     #

data/lib/gocardless_pro/services/customer_notifications_service.rb

@@ -17,7 +17,7 @@ module GoCardlessPro
       # If the notification has already been actioned, or the deadline to notify has
       # passed,
       # this endpoint will return an `already_actioned` error and you should not take
-      # further action.
+      # further action. This endpoint takes no additional parameters.
       #
       # Example URL: /customer_notifications/:identity/actions/handle
       #

data/lib/gocardless_pro/services/customers_service.rb

@@ -116,6 +116,31 @@ module GoCardlessPro
         Resources::Customer.new(unenvelope_body(response.body), response)
       end
 
+      # Removed customers will not appear in search results or lists of customers (in
+      # our API
+      # or exports), and it will not be possible to load an individually removed
+      # customer by
+      # ID.
+      #
+      # <p class="restricted-notice"><strong>The action of removing a customer cannot
+      # be
+      # reversed, so please use with care.</strong></p>
+      # Example URL: /customers/:identity
+      #
+      # @param identity       # Unique identifier, beginning with "CU".
+      # @param options [Hash] parameters as a hash, under a params key.
+      def remove(identity, options = {})
+        path = sub_url('/customers/:identity', 'identity' => identity)
+
+        options[:retry_failures] = false
+
+        response = make_request(:delete, path, options)
+
+        return if response.body.nil?
+
+        Resources::Customer.new(unenvelope_body(response.body), response)
+      end
+
       private
 
       # Unenvelope the response of the body using the service's `envelope_key`

data/lib/gocardless_pro/services/mandate_pdfs_service.rb

@@ -30,18 +30,27 @@ module GoCardlessPro
       # | :--------------- |
       # :-------------------------------------------------------------------------------------------------------------------------------------------
       # |
+      # | ACH              | English (`en`)
+      #
+      #     |
       # | Autogiro         | English (`en`), Swedish (`sv`)
       #
       #     |
       # | Bacs             | English (`en`)
       #
       #     |
-      # | Becs             | English (`en`)
+      # | BECS             | English (`en`)
+      #
+      #     |
+      # | BECS NZ          | English (`en`)
       #
       #     |
       # | Betalingsservice | Danish (`da`), English (`en`)
       #
       #     |
+      # | PAD              | English (`en`)
+      #
+      #     |
       # | SEPA Core        | Danish (`da`), Dutch (`nl`), English (`en`), French
       # (`fr`), German (`de`), Italian (`it`), Portuguese (`pt`), Spanish (`es`),
       # Swedish (`sv`) |

data/lib/gocardless_pro/services/mandates_service.rb

@@ -80,7 +80,8 @@ module GoCardlessPro
       # Retrieves the details of an existing mandate.
       # Example URL: /mandates/:identity
       #
-      # @param identity       # Unique identifier, beginning with "MD".
+      # @param identity       # Unique identifier, beginning with "MD". Note that this prefix may not
+      # apply to mandates created before 2016.
       # @param options [Hash] parameters as a hash, under a params key.
       def get(identity, options = {})
         path = sub_url('/mandates/:identity', 'identity' => identity)
@@ -97,7 +98,8 @@ module GoCardlessPro
       # Updates a mandate object. This accepts only the metadata parameter.
       # Example URL: /mandates/:identity
       #
-      # @param identity       # Unique identifier, beginning with "MD".
+      # @param identity       # Unique identifier, beginning with "MD". Note that this prefix may not
+      # apply to mandates created before 2016.
       # @param options [Hash] parameters as a hash, under a params key.
       def update(identity, options = {})
         path = sub_url('/mandates/:identity', 'identity' => identity)
@@ -123,7 +125,8 @@ module GoCardlessPro
       # cancelled.
       # Example URL: /mandates/:identity/actions/cancel
       #
-      # @param identity       # Unique identifier, beginning with "MD".
+      # @param identity       # Unique identifier, beginning with "MD". Note that this prefix may not
+      # apply to mandates created before 2016.
       # @param options [Hash] parameters as a hash, under a params key.
       def cancel(identity, options = {})
         path = sub_url('/mandates/:identity/actions/cancel', 'identity' => identity)
@@ -172,7 +175,8 @@ module GoCardlessPro
       # Mandates can be resubmitted up to 3 times.
       # Example URL: /mandates/:identity/actions/reinstate
       #
-      # @param identity       # Unique identifier, beginning with "MD".
+      # @param identity       # Unique identifier, beginning with "MD". Note that this prefix may not
+      # apply to mandates created before 2016.
       # @param options [Hash] parameters as a hash, under a params key.
       def reinstate(identity, options = {})
         path = sub_url('/mandates/:identity/actions/reinstate', 'identity' => identity)

data/lib/gocardless_pro/version.rb

@@ -4,5 +4,5 @@ end
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '2.13.0'.freeze
+  VERSION = '2.14.0'.freeze
 end

data/spec/resources/creditor_bank_account_spec.rb

@@ -17,6 +17,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -36,6 +37,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -55,6 +57,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
                   'account_holder_name' => 'account_holder_name-input',
                   'account_number_ending' => 'account_number_ending-input',
+                  'account_type' => 'account_type-input',
                   'bank_name' => 'bank_name-input',
                   'country_code' => 'country_code-input',
                   'created_at' => 'created_at-input',
@@ -107,6 +110,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -149,6 +153,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -182,6 +187,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -209,6 +215,8 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
         expect(get_list_response.records.first.account_number_ending).to eq('account_number_ending-input')
 
+        expect(get_list_response.records.first.account_type).to eq('account_type-input')
+
         expect(get_list_response.records.first.bank_name).to eq('bank_name-input')
 
         expect(get_list_response.records.first.country_code).to eq('country_code-input')
@@ -241,6 +249,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -266,6 +275,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -307,6 +317,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -342,6 +353,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -398,6 +410,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -438,6 +451,7 @@ describe GoCardlessPro::Resources::CreditorBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',

data/spec/resources/customer_bank_account_spec.rb

@@ -17,6 +17,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -36,6 +37,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -55,6 +57,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
                   'account_holder_name' => 'account_holder_name-input',
                   'account_number_ending' => 'account_number_ending-input',
+                  'account_type' => 'account_type-input',
                   'bank_name' => 'bank_name-input',
                   'country_code' => 'country_code-input',
                   'created_at' => 'created_at-input',
@@ -107,6 +110,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -149,6 +153,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -182,6 +187,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -209,6 +215,8 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
         expect(get_list_response.records.first.account_number_ending).to eq('account_number_ending-input')
 
+        expect(get_list_response.records.first.account_type).to eq('account_type-input')
+
         expect(get_list_response.records.first.bank_name).to eq('bank_name-input')
 
         expect(get_list_response.records.first.country_code).to eq('country_code-input')
@@ -241,6 +249,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -266,6 +275,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -307,6 +317,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -342,6 +353,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -399,6 +411,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -434,6 +447,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -474,6 +488,7 @@ describe GoCardlessPro::Resources::CustomerBankAccount do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',

data/spec/resources/customer_spec.rb

@@ -525,4 +525,90 @@ describe GoCardlessPro::Resources::Customer do
       end
     end
   end
+
+  describe '#remove' do
+    subject(:delete_response) { client.customers.remove(resource_id) }
+
+    let(:resource_id) { 'ABC123' }
+
+    let!(:stub) do
+      # /customers/%v
+      stub_url = '/customers/:identity'.gsub(':identity', resource_id)
+      stub_request(:delete, /.*api.gocardless.com#{stub_url}/).to_return(
+        body: {
+          'customers' => {
+
+            'address_line1' => 'address_line1-input',
+            'address_line2' => 'address_line2-input',
+            'address_line3' => 'address_line3-input',
+            'city' => 'city-input',
+            'company_name' => 'company_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'danish_identity_number' => 'danish_identity_number-input',
+            'email' => 'email-input',
+            'family_name' => 'family_name-input',
+            'given_name' => 'given_name-input',
+            'id' => 'id-input',
+            'language' => 'language-input',
+            'metadata' => 'metadata-input',
+            'phone_number' => 'phone_number-input',
+            'postal_code' => 'postal_code-input',
+            'region' => 'region-input',
+            'swedish_identity_number' => 'swedish_identity_number-input',
+          },
+        }.to_json,
+        headers: response_headers
+      )
+    end
+
+    it 'wraps the response and calls the right endpoint' do
+      expect(delete_response).to be_a(GoCardlessPro::Resources::Customer)
+
+      expect(stub).to have_been_requested
+    end
+
+    context 'when the request needs a body and custom header' do
+      let(:body) { { foo: 'bar' } }
+      let(:headers) { { 'Foo' => 'Bar' } }
+      subject(:delete_response) { client.customers.remove(resource_id, body, headers) }
+
+      let(:resource_id) { 'ABC123' }
+
+      let!(:stub) do
+        # /customers/%v
+        stub_url = '/customers/:identity'.gsub(':identity', resource_id)
+        stub_request(:delete, /.*api.gocardless.com#{stub_url}/).
+          with(
+            body: { foo: 'bar' },
+            headers: { 'Foo' => 'Bar' }
+          ).to_return(
+            body: {
+              'customers' => {
+
+                'address_line1' => 'address_line1-input',
+                'address_line2' => 'address_line2-input',
+                'address_line3' => 'address_line3-input',
+                'city' => 'city-input',
+                'company_name' => 'company_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'danish_identity_number' => 'danish_identity_number-input',
+                'email' => 'email-input',
+                'family_name' => 'family_name-input',
+                'given_name' => 'given_name-input',
+                'id' => 'id-input',
+                'language' => 'language-input',
+                'metadata' => 'metadata-input',
+                'phone_number' => 'phone_number-input',
+                'postal_code' => 'postal_code-input',
+                'region' => 'region-input',
+                'swedish_identity_number' => 'swedish_identity_number-input',
+              },
+            }.to_json,
+            headers: response_headers
+          )
+      end
+    end
+  end
 end

data/spec/services/creditor_bank_accounts_service_spec.rb

@@ -17,6 +17,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -36,6 +37,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -55,6 +57,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
                   'account_holder_name' => 'account_holder_name-input',
                   'account_number_ending' => 'account_number_ending-input',
+                  'account_type' => 'account_type-input',
                   'bank_name' => 'bank_name-input',
                   'country_code' => 'country_code-input',
                   'created_at' => 'created_at-input',
@@ -130,6 +133,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -172,6 +176,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -233,6 +238,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -265,6 +271,8 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
         expect(get_list_response.records.first.account_number_ending).to eq('account_number_ending-input')
 
+        expect(get_list_response.records.first.account_type).to eq('account_type-input')
+
         expect(get_list_response.records.first.bank_name).to eq('bank_name-input')
 
         expect(get_list_response.records.first.country_code).to eq('country_code-input')
@@ -320,6 +328,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -345,6 +354,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -379,6 +389,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -404,6 +415,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
                                      'account_holder_name' => 'account_holder_name-input',
                                      'account_number_ending' => 'account_number_ending-input',
+                                     'account_type' => 'account_type-input',
                                      'bank_name' => 'bank_name-input',
                                      'country_code' => 'country_code-input',
                                      'created_at' => 'created_at-input',
@@ -434,6 +446,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -462,6 +475,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
                                      'account_holder_name' => 'account_holder_name-input',
                                      'account_number_ending' => 'account_number_ending-input',
+                                     'account_type' => 'account_type-input',
                                      'bank_name' => 'bank_name-input',
                                      'country_code' => 'country_code-input',
                                      'created_at' => 'created_at-input',
@@ -503,6 +517,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -538,6 +553,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -649,6 +665,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -700,6 +717,7 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',

data/spec/services/customer_bank_accounts_service_spec.rb

@@ -17,6 +17,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -36,6 +37,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -55,6 +57,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
                   'account_holder_name' => 'account_holder_name-input',
                   'account_number_ending' => 'account_number_ending-input',
+                  'account_type' => 'account_type-input',
                   'bank_name' => 'bank_name-input',
                   'country_code' => 'country_code-input',
                   'created_at' => 'created_at-input',
@@ -130,6 +133,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
           'account_holder_name' => 'account_holder_name-input',
           'account_number_ending' => 'account_number_ending-input',
+          'account_type' => 'account_type-input',
           'bank_name' => 'bank_name-input',
           'country_code' => 'country_code-input',
           'created_at' => 'created_at-input',
@@ -172,6 +176,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -233,6 +238,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -265,6 +271,8 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
         expect(get_list_response.records.first.account_number_ending).to eq('account_number_ending-input')
 
+        expect(get_list_response.records.first.account_type).to eq('account_type-input')
+
         expect(get_list_response.records.first.bank_name).to eq('bank_name-input')
 
         expect(get_list_response.records.first.country_code).to eq('country_code-input')
@@ -320,6 +328,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -345,6 +354,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -379,6 +389,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -404,6 +415,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
                                      'account_holder_name' => 'account_holder_name-input',
                                      'account_number_ending' => 'account_number_ending-input',
+                                     'account_type' => 'account_type-input',
                                      'bank_name' => 'bank_name-input',
                                      'country_code' => 'country_code-input',
                                      'created_at' => 'created_at-input',
@@ -434,6 +446,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -462,6 +475,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
                                      'account_holder_name' => 'account_holder_name-input',
                                      'account_number_ending' => 'account_number_ending-input',
+                                     'account_type' => 'account_type-input',
                                      'bank_name' => 'bank_name-input',
                                      'country_code' => 'country_code-input',
                                      'created_at' => 'created_at-input',
@@ -503,6 +517,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',
@@ -538,6 +553,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -650,6 +666,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
               'account_holder_name' => 'account_holder_name-input',
               'account_number_ending' => 'account_number_ending-input',
+              'account_type' => 'account_type-input',
               'bank_name' => 'bank_name-input',
               'country_code' => 'country_code-input',
               'created_at' => 'created_at-input',
@@ -710,6 +727,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
             'account_holder_name' => 'account_holder_name-input',
             'account_number_ending' => 'account_number_ending-input',
+            'account_type' => 'account_type-input',
             'bank_name' => 'bank_name-input',
             'country_code' => 'country_code-input',
             'created_at' => 'created_at-input',
@@ -761,6 +779,7 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
 
                 'account_holder_name' => 'account_holder_name-input',
                 'account_number_ending' => 'account_number_ending-input',
+                'account_type' => 'account_type-input',
                 'bank_name' => 'bank_name-input',
                 'country_code' => 'country_code-input',
                 'created_at' => 'created_at-input',

data/spec/services/customers_service_spec.rb

@@ -833,4 +833,101 @@ describe GoCardlessPro::Services::CustomersService do
       end
     end
   end
+
+  describe '#remove' do
+    subject(:delete_response) { client.customers.remove(resource_id) }
+
+    let(:resource_id) { 'ABC123' }
+
+    let!(:stub) do
+      # /customers/%v
+      stub_url = '/customers/:identity'.gsub(':identity', resource_id)
+      stub_request(:delete, /.*api.gocardless.com#{stub_url}/).to_return(
+        body: {
+          'customers' => {
+
+            'address_line1' => 'address_line1-input',
+            'address_line2' => 'address_line2-input',
+            'address_line3' => 'address_line3-input',
+            'city' => 'city-input',
+            'company_name' => 'company_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'danish_identity_number' => 'danish_identity_number-input',
+            'email' => 'email-input',
+            'family_name' => 'family_name-input',
+            'given_name' => 'given_name-input',
+            'id' => 'id-input',
+            'language' => 'language-input',
+            'metadata' => 'metadata-input',
+            'phone_number' => 'phone_number-input',
+            'postal_code' => 'postal_code-input',
+            'region' => 'region-input',
+            'swedish_identity_number' => 'swedish_identity_number-input',
+          },
+        }.to_json,
+        headers: response_headers
+      )
+    end
+
+    it 'wraps the response and calls the right endpoint' do
+      expect(delete_response).to be_a(GoCardlessPro::Resources::Customer)
+
+      expect(stub).to have_been_requested
+    end
+
+    describe 'retry behaviour' do
+      it "doesn't retry errors" do
+        stub_url = '/customers/:identity'.gsub(':identity', resource_id)
+        stub = stub_request(:delete, /.*api.gocardless.com#{stub_url}/).
+               to_timeout
+
+        expect { delete_response }.to raise_error(Faraday::TimeoutError)
+        expect(stub).to have_been_requested
+      end
+    end
+
+    context 'when the request needs a body and custom header' do
+      let(:body) { { foo: 'bar' } }
+      let(:headers) { { 'Foo' => 'Bar' } }
+      subject(:delete_response) { client.customers.remove(resource_id, body, headers) }
+
+      let(:resource_id) { 'ABC123' }
+
+      let!(:stub) do
+        # /customers/%v
+        stub_url = '/customers/:identity'.gsub(':identity', resource_id)
+        stub_request(:delete, /.*api.gocardless.com#{stub_url}/).
+          with(
+            body: { foo: 'bar' },
+            headers: { 'Foo' => 'Bar' }
+          ).to_return(
+            body: {
+              'customers' => {
+
+                'address_line1' => 'address_line1-input',
+                'address_line2' => 'address_line2-input',
+                'address_line3' => 'address_line3-input',
+                'city' => 'city-input',
+                'company_name' => 'company_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'danish_identity_number' => 'danish_identity_number-input',
+                'email' => 'email-input',
+                'family_name' => 'family_name-input',
+                'given_name' => 'given_name-input',
+                'id' => 'id-input',
+                'language' => 'language-input',
+                'metadata' => 'metadata-input',
+                'phone_number' => 'phone_number-input',
+                'postal_code' => 'postal_code-input',
+                'region' => 'region-input',
+                'swedish_identity_number' => 'swedish_identity_number-input',
+              },
+            }.to_json,
+            headers: response_headers
+          )
+      end
+    end
+  end
 end

metadata

@@ -1,43 +1,49 @@
 --- !ruby/object:Gem::Specification
 name: gocardless_pro
 version: !ruby/object:Gem::Version
-  version: 2.13.0
+  version: 2.14.0
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-28 00:00:00.000000000 Z
+date: 2019-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.7.0
-  type: :development
+        version: 0.9.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.7.0
+        version: 0.9.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
-  name: public_suffix
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.5
+        version: 3.7.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.5
+        version: 3.7.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -81,25 +87,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.9.11
 - !ruby/object:Gem::Dependency
-  name: faraday
+  name: public_suffix
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.2
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :runtime
+        version: 2.0.5
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.9.2
-    - - "<"
+        version: 2.0.5
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.13.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.13.0
 description: 
 email:
 - engineering@gocardless.com