gocardless_pro 2.12.0 → 2.13.0

data/spec/resources/event_spec.rb

@@ -20,6 +20,7 @@ describe GoCardlessPro::Resources::Event do
 
               'action' => 'action-input',
               'created_at' => 'created_at-input',
+              'customer_notifications' => 'customer_notifications-input',
               'details' => 'details-input',
               'id' => 'id-input',
               'links' => 'links-input',
@@ -44,6 +45,8 @@ describe GoCardlessPro::Resources::Event do
 
         expect(get_list_response.records.first.created_at).to eq('created_at-input')
 
+        expect(get_list_response.records.first.customer_notifications).to eq('customer_notifications-input')
+
         expect(get_list_response.records.first.details).to eq('details-input')
 
         expect(get_list_response.records.first.id).to eq('id-input')
@@ -70,6 +73,7 @@ describe GoCardlessPro::Resources::Event do
 
             'action' => 'action-input',
             'created_at' => 'created_at-input',
+            'customer_notifications' => 'customer_notifications-input',
             'details' => 'details-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -92,6 +96,7 @@ describe GoCardlessPro::Resources::Event do
 
             'action' => 'action-input',
             'created_at' => 'created_at-input',
+            'customer_notifications' => 'customer_notifications-input',
             'details' => 'details-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -130,6 +135,7 @@ describe GoCardlessPro::Resources::Event do
 
                 'action' => 'action-input',
                 'created_at' => 'created_at-input',
+                'customer_notifications' => 'customer_notifications-input',
                 'details' => 'details-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
@@ -162,6 +168,7 @@ describe GoCardlessPro::Resources::Event do
 
               'action' => 'action-input',
               'created_at' => 'created_at-input',
+              'customer_notifications' => 'customer_notifications-input',
               'details' => 'details-input',
               'id' => 'id-input',
               'links' => 'links-input',

data/spec/services/creditor_bank_accounts_service_spec.rb

@@ -186,10 +186,39 @@ describe GoCardlessPro::Services::CreditorBankAccountsService do
           )
       end
 
-      it 'fetches the already-created resource' do
-        post_create_response
-        expect(post_stub).to have_been_requested
-        expect(get_stub).to have_been_requested
+      context 'with default behaviour' do
+        it 'fetches the already-created resource' do
+          post_create_response
+          expect(post_stub).to have_been_requested
+          expect(get_stub).to have_been_requested
+        end
+      end
+
+      context 'with on_idempotency_conflict: :raise' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :raise
+          )
+        end
+
+        it 'raises an IdempotencyConflict error' do
+          expect { post_create_response }.
+            to raise_error(GoCardlessPro::IdempotencyConflict)
+        end
+      end
+
+      context 'with on_idempotency_conflict: :unknown' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :unknown
+          )
+        end
+
+        it 'raises an ArgumentError' do
+          expect { post_create_response }.to raise_error(ArgumentError)
+        end
       end
     end
   end

data/spec/services/creditors_service_spec.rb

@@ -211,10 +211,39 @@ describe GoCardlessPro::Services::CreditorsService do
           )
       end
 
-      it 'fetches the already-created resource' do
-        post_create_response
-        expect(post_stub).to have_been_requested
-        expect(get_stub).to have_been_requested
+      context 'with default behaviour' do
+        it 'fetches the already-created resource' do
+          post_create_response
+          expect(post_stub).to have_been_requested
+          expect(get_stub).to have_been_requested
+        end
+      end
+
+      context 'with on_idempotency_conflict: :raise' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :raise
+          )
+        end
+
+        it 'raises an IdempotencyConflict error' do
+          expect { post_create_response }.
+            to raise_error(GoCardlessPro::IdempotencyConflict)
+        end
+      end
+
+      context 'with on_idempotency_conflict: :unknown' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :unknown
+          )
+        end
+
+        it 'raises an ArgumentError' do
+          expect { post_create_response }.to raise_error(ArgumentError)
+        end
       end
     end
   end

data/spec/services/customer_bank_accounts_service_spec.rb

@@ -186,10 +186,39 @@ describe GoCardlessPro::Services::CustomerBankAccountsService do
           )
       end
 
-      it 'fetches the already-created resource' do
-        post_create_response
-        expect(post_stub).to have_been_requested
-        expect(get_stub).to have_been_requested
+      context 'with default behaviour' do
+        it 'fetches the already-created resource' do
+          post_create_response
+          expect(post_stub).to have_been_requested
+          expect(get_stub).to have_been_requested
+        end
+      end
+
+      context 'with on_idempotency_conflict: :raise' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :raise
+          )
+        end
+
+        it 'raises an IdempotencyConflict error' do
+          expect { post_create_response }.
+            to raise_error(GoCardlessPro::IdempotencyConflict)
+        end
+      end
+
+      context 'with on_idempotency_conflict: :unknown' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :unknown
+          )
+        end
+
+        it 'raises an ArgumentError' do
+          expect { post_create_response }.to raise_error(ArgumentError)
+        end
       end
     end
   end

data/spec/services/customer_notifications_service_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+describe GoCardlessPro::Services::CustomerNotificationsService do
+  let(:client) do
+    GoCardlessPro::Client.new(
+      access_token: 'SECRET_TOKEN'
+    )
+  end
+
+  let(:response_headers) { { 'Content-Type' => 'application/json' } }
+
+  describe '#handle' do
+    subject(:post_response) { client.customer_notifications.handle(resource_id) }
+
+    let(:resource_id) { 'ABC123' }
+
+    let!(:stub) do
+      # /customer_notifications/%v/actions/handle
+      stub_url = '/customer_notifications/:identity/actions/handle'.gsub(':identity', resource_id)
+      stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+        body: {
+          'customer_notifications' => {
+
+            'action_taken' => 'action_taken-input',
+            'action_taken_at' => 'action_taken_at-input',
+            'action_taken_by' => 'action_taken_by-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'type' => 'type-input',
+          },
+        }.to_json,
+        headers: response_headers
+      )
+    end
+
+    it 'wraps the response and calls the right endpoint' do
+      expect(post_response).to be_a(GoCardlessPro::Resources::CustomerNotification)
+
+      expect(stub).to have_been_requested
+    end
+
+    describe 'retry behaviour' do
+      it "doesn't retry errors" do
+        stub_url = '/customer_notifications/:identity/actions/handle'.gsub(':identity', resource_id)
+        stub = stub_request(:post, /.*api.gocardless.com#{stub_url}/).
+               to_timeout
+
+        expect { post_response }.to raise_error(Faraday::TimeoutError)
+        expect(stub).to have_been_requested
+      end
+    end
+
+    context 'when the request needs a body and custom header' do
+      let(:body) { { foo: 'bar' } }
+      let(:headers) { { 'Foo' => 'Bar' } }
+      subject(:post_response) { client.customer_notifications.handle(resource_id, body, headers) }
+
+      let(:resource_id) { 'ABC123' }
+
+      let!(:stub) do
+        # /customer_notifications/%v/actions/handle
+        stub_url = '/customer_notifications/:identity/actions/handle'.gsub(':identity', resource_id)
+        stub_request(:post, /.*api.gocardless.com#{stub_url}/).
+          with(
+            body: { foo: 'bar' },
+            headers: { 'Foo' => 'Bar' }
+          ).to_return(
+            body: {
+              'customer_notifications' => {
+
+                'action_taken' => 'action_taken-input',
+                'action_taken_at' => 'action_taken_at-input',
+                'action_taken_by' => 'action_taken_by-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'type' => 'type-input',
+              },
+            }.to_json,
+            headers: response_headers
+          )
+      end
+    end
+  end
+end

data/spec/services/customers_service_spec.rb

@@ -29,6 +29,7 @@ describe GoCardlessPro::Services::CustomersService do
           'id' => 'id-input',
           'language' => 'language-input',
           'metadata' => 'metadata-input',
+          'phone_number' => 'phone_number-input',
           'postal_code' => 'postal_code-input',
           'region' => 'region-input',
           'swedish_identity_number' => 'swedish_identity_number-input',
@@ -55,6 +56,7 @@ describe GoCardlessPro::Services::CustomersService do
                 'id' => 'id-input',
                 'language' => 'language-input',
                 'metadata' => 'metadata-input',
+                'phone_number' => 'phone_number-input',
                 'postal_code' => 'postal_code-input',
                 'region' => 'region-input',
                 'swedish_identity_number' => 'swedish_identity_number-input',
@@ -81,6 +83,7 @@ describe GoCardlessPro::Services::CustomersService do
                   'id' => 'id-input',
                   'language' => 'language-input',
                   'metadata' => 'metadata-input',
+                  'phone_number' => 'phone_number-input',
                   'postal_code' => 'postal_code-input',
                   'region' => 'region-input',
                   'swedish_identity_number' => 'swedish_identity_number-input',
@@ -163,6 +166,7 @@ describe GoCardlessPro::Services::CustomersService do
           'id' => 'id-input',
           'language' => 'language-input',
           'metadata' => 'metadata-input',
+          'phone_number' => 'phone_number-input',
           'postal_code' => 'postal_code-input',
           'region' => 'region-input',
           'swedish_identity_number' => 'swedish_identity_number-input',
@@ -212,6 +216,7 @@ describe GoCardlessPro::Services::CustomersService do
                 'id' => 'id-input',
                 'language' => 'language-input',
                 'metadata' => 'metadata-input',
+                'phone_number' => 'phone_number-input',
                 'postal_code' => 'postal_code-input',
                 'region' => 'region-input',
                 'swedish_identity_number' => 'swedish_identity_number-input',
@@ -221,10 +226,39 @@ describe GoCardlessPro::Services::CustomersService do
           )
       end
 
-      it 'fetches the already-created resource' do
-        post_create_response
-        expect(post_stub).to have_been_requested
-        expect(get_stub).to have_been_requested
+      context 'with default behaviour' do
+        it 'fetches the already-created resource' do
+          post_create_response
+          expect(post_stub).to have_been_requested
+          expect(get_stub).to have_been_requested
+        end
+      end
+
+      context 'with on_idempotency_conflict: :raise' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :raise
+          )
+        end
+
+        it 'raises an IdempotencyConflict error' do
+          expect { post_create_response }.
+            to raise_error(GoCardlessPro::IdempotencyConflict)
+        end
+      end
+
+      context 'with on_idempotency_conflict: :unknown' do
+        let(:client) do
+          GoCardlessPro::Client.new(
+            access_token: 'SECRET_TOKEN',
+            on_idempotency_conflict: :unknown
+          )
+        end
+
+        it 'raises an ArgumentError' do
+          expect { post_create_response }.to raise_error(ArgumentError)
+        end
       end
     end
   end
@@ -251,6 +285,7 @@ describe GoCardlessPro::Services::CustomersService do
             'id' => 'id-input',
             'language' => 'language-input',
             'metadata' => 'metadata-input',
+            'phone_number' => 'phone_number-input',
             'postal_code' => 'postal_code-input',
             'region' => 'region-input',
             'swedish_identity_number' => 'swedish_identity_number-input',
@@ -302,6 +337,8 @@ describe GoCardlessPro::Services::CustomersService do
 
         expect(get_list_response.records.first.metadata).to eq('metadata-input')
 
+        expect(get_list_response.records.first.phone_number).to eq('phone_number-input')
+
         expect(get_list_response.records.first.postal_code).to eq('postal_code-input')
 
         expect(get_list_response.records.first.region).to eq('region-input')
@@ -361,6 +398,7 @@ describe GoCardlessPro::Services::CustomersService do
             'id' => 'id-input',
             'language' => 'language-input',
             'metadata' => 'metadata-input',
+            'phone_number' => 'phone_number-input',
             'postal_code' => 'postal_code-input',
             'region' => 'region-input',
             'swedish_identity_number' => 'swedish_identity_number-input',
@@ -393,6 +431,7 @@ describe GoCardlessPro::Services::CustomersService do
             'id' => 'id-input',
             'language' => 'language-input',
             'metadata' => 'metadata-input',
+            'phone_number' => 'phone_number-input',
             'postal_code' => 'postal_code-input',
             'region' => 'region-input',
             'swedish_identity_number' => 'swedish_identity_number-input',
@@ -434,6 +473,7 @@ describe GoCardlessPro::Services::CustomersService do
               'id' => 'id-input',
               'language' => 'language-input',
               'metadata' => 'metadata-input',
+              'phone_number' => 'phone_number-input',
               'postal_code' => 'postal_code-input',
               'region' => 'region-input',
               'swedish_identity_number' => 'swedish_identity_number-input',
@@ -466,6 +506,7 @@ describe GoCardlessPro::Services::CustomersService do
                                      'id' => 'id-input',
                                      'language' => 'language-input',
                                      'metadata' => 'metadata-input',
+                                     'phone_number' => 'phone_number-input',
                                      'postal_code' => 'postal_code-input',
                                      'region' => 'region-input',
                                      'swedish_identity_number' => 'swedish_identity_number-input',
@@ -503,6 +544,7 @@ describe GoCardlessPro::Services::CustomersService do
               'id' => 'id-input',
               'language' => 'language-input',
               'metadata' => 'metadata-input',
+              'phone_number' => 'phone_number-input',
               'postal_code' => 'postal_code-input',
               'region' => 'region-input',
               'swedish_identity_number' => 'swedish_identity_number-input',
@@ -538,6 +580,7 @@ describe GoCardlessPro::Services::CustomersService do
                                      'id' => 'id-input',
                                      'language' => 'language-input',
                                      'metadata' => 'metadata-input',
+                                     'phone_number' => 'phone_number-input',
                                      'postal_code' => 'postal_code-input',
                                      'region' => 'region-input',
                                      'swedish_identity_number' => 'swedish_identity_number-input',
@@ -586,6 +629,7 @@ describe GoCardlessPro::Services::CustomersService do
                 'id' => 'id-input',
                 'language' => 'language-input',
                 'metadata' => 'metadata-input',
+                'phone_number' => 'phone_number-input',
                 'postal_code' => 'postal_code-input',
                 'region' => 'region-input',
                 'swedish_identity_number' => 'swedish_identity_number-input',
@@ -628,6 +672,7 @@ describe GoCardlessPro::Services::CustomersService do
               'id' => 'id-input',
               'language' => 'language-input',
               'metadata' => 'metadata-input',
+              'phone_number' => 'phone_number-input',
               'postal_code' => 'postal_code-input',
               'region' => 'region-input',
               'swedish_identity_number' => 'swedish_identity_number-input',
@@ -747,6 +792,7 @@ describe GoCardlessPro::Services::CustomersService do
               'id' => 'id-input',
               'language' => 'language-input',
               'metadata' => 'metadata-input',
+              'phone_number' => 'phone_number-input',
               'postal_code' => 'postal_code-input',
               'region' => 'region-input',
               'swedish_identity_number' => 'swedish_identity_number-input',

data/spec/services/events_service_spec.rb

@@ -19,6 +19,7 @@ describe GoCardlessPro::Services::EventsService do
 
             'action' => 'action-input',
             'created_at' => 'created_at-input',
+            'customer_notifications' => 'customer_notifications-input',
             'details' => 'details-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -48,6 +49,8 @@ describe GoCardlessPro::Services::EventsService do
 
         expect(get_list_response.records.first.created_at).to eq('created_at-input')
 
+        expect(get_list_response.records.first.customer_notifications).to eq('customer_notifications-input')
+
         expect(get_list_response.records.first.details).to eq('details-input')
 
         expect(get_list_response.records.first.id).to eq('id-input')
@@ -97,6 +100,7 @@ describe GoCardlessPro::Services::EventsService do
 
             'action' => 'action-input',
             'created_at' => 'created_at-input',
+            'customer_notifications' => 'customer_notifications-input',
             'details' => 'details-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -119,6 +123,7 @@ describe GoCardlessPro::Services::EventsService do
 
             'action' => 'action-input',
             'created_at' => 'created_at-input',
+            'customer_notifications' => 'customer_notifications-input',
             'details' => 'details-input',
             'id' => 'id-input',
             'links' => 'links-input',
@@ -150,6 +155,7 @@ describe GoCardlessPro::Services::EventsService do
 
               'action' => 'action-input',
               'created_at' => 'created_at-input',
+              'customer_notifications' => 'customer_notifications-input',
               'details' => 'details-input',
               'id' => 'id-input',
               'links' => 'links-input',
@@ -172,6 +178,7 @@ describe GoCardlessPro::Services::EventsService do
 
                                      'action' => 'action-input',
                                      'created_at' => 'created_at-input',
+                                     'customer_notifications' => 'customer_notifications-input',
                                      'details' => 'details-input',
                                      'id' => 'id-input',
                                      'links' => 'links-input',
@@ -199,6 +206,7 @@ describe GoCardlessPro::Services::EventsService do
 
               'action' => 'action-input',
               'created_at' => 'created_at-input',
+              'customer_notifications' => 'customer_notifications-input',
               'details' => 'details-input',
               'id' => 'id-input',
               'links' => 'links-input',
@@ -224,6 +232,7 @@ describe GoCardlessPro::Services::EventsService do
 
                                      'action' => 'action-input',
                                      'created_at' => 'created_at-input',
+                                     'customer_notifications' => 'customer_notifications-input',
                                      'details' => 'details-input',
                                      'id' => 'id-input',
                                      'links' => 'links-input',
@@ -262,6 +271,7 @@ describe GoCardlessPro::Services::EventsService do
 
                 'action' => 'action-input',
                 'created_at' => 'created_at-input',
+                'customer_notifications' => 'customer_notifications-input',
                 'details' => 'details-input',
                 'id' => 'id-input',
                 'links' => 'links-input',
@@ -294,6 +304,7 @@ describe GoCardlessPro::Services::EventsService do
 
               'action' => 'action-input',
               'created_at' => 'created_at-input',
+              'customer_notifications' => 'customer_notifications-input',
               'details' => 'details-input',
               'id' => 'id-input',
               'links' => 'links-input',