gocardless_pro 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8c9ec530e509727543e6ab0142302f928749b00
-  data.tar.gz: 9d034d961ac65edaff460c30812fafeae80f8568
+  metadata.gz: 39c5c4f0dcfab5cebeeba56aa2e1801e9775a6d0
+  data.tar.gz: c1cc2f6d595d13011d219282b08fe37301e7e0c2
 SHA512:
-  metadata.gz: 5758970f6680e461020c00ecf0a4df121da2bffec487d203ba4a2338def6856bd8fda4ce376ec320f1b4decb0cbac751826d054d5da9b42295deed02cc8e60ed
-  data.tar.gz: 0ea10725022cef83ba659d5df6d2db1ac7b9ecbad6671846114185205da20baf987a96da26fcb0c6539624b246a8d12d245713c66dc26e622ab23bcf3ab6a290
+  metadata.gz: 3180f056a519890bea499e2daf2c983e296709432c63fb4de98df96ffa446217c5bf595e3df4ffe8e06bf3b1b0204647d377aebfb4ff675113ac1650b0bfdc31
+  data.tar.gz: 85bb043efad721d43dc239865411f3ba5ce962841153ec92fcdf590cb2ee068ce4f19bca397385415e6c5599786e8bf1b29975ca1be323fd8e81a8a4d3c515c8

data/.rubocop.yml

@@ -0,0 +1,5 @@
+Layout/DotPosition:
+  EnforcedStyle: trailing
+
+Style/TrailingCommaInLiteral:
+  EnforcedStyleForMultiline: comma

data/circle.yml

@@ -1,3 +1,11 @@
-machine:
-  ruby:
-    version: 2.0.0-p353
+dependencies:
+  override:
+    - 'rvm-exec 2.2.7 bundle install'
+    - 'rvm-exec 2.3.4 bundle install'
+    - 'rvm-exec 2.4.1 bundle install'
+
+test:
+  override:
+    - 'rvm-exec 2.2.7 bundle exec rspec'
+    - 'rvm-exec 2.3.4 bundle exec rspec'
+    - 'rvm-exec 2.4.1 bundle exec rspec'

data/demo.rb

@@ -1,9 +1,9 @@
- require_relative 'lib/gocardless_pro'
+require_relative 'lib/gocardless_pro'
 
 @client = GoCardlessPro::Client.new(
-  access_token: ENV["GOCARDLESS_TOKEN"],
+  access_token: ENV['GOCARDLESS_TOKEN'],
   environment: :sandbox
 )
 
-puts "Your first customer:"
+puts 'Your first customer:'
 puts "-> #{@client.customers.list.records.first.inspect}"

data/gocardless_pro.gemspec

@@ -4,23 +4,23 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'gocardless_pro/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "gocardless_pro"
+  spec.name          = 'gocardless_pro'
   spec.version       = GoCardlessPro::VERSION
   spec.authors       = %w(GoCardless)
   spec.email         = %w(engineering@gocardless.com)
   spec.summary       = %q{A gem for calling the GoCardless Pro API}
-  spec.homepage      = "https://github.com/gocardless/gocardless-pro-ruby"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/gocardless/gocardless-pro-ruby'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
   spec.add_development_dependency 'rspec', '~> 3.1'
   spec.add_development_dependency 'webmock', '~> 1.18'
-  spec.add_development_dependency 'rubocop', '~> 0.35.1'
+  spec.add_development_dependency 'rubocop', '~> 0.49.1'
   spec.add_development_dependency 'yard', '~> 0.8.7.6'
 
-  spec.add_dependency 'faraday', ['>= 0.8.9', '< 0.10']
+  spec.add_dependency 'faraday', ['>= 0.9.2', '< 1.0']
 end

data/lib/gocardless_pro.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.
@@ -19,7 +20,7 @@ version_file = 'gocardless_pro/version'
 if File.file? File.expand_path("#{version_file}.rb", File.dirname(__FILE__))
   require_relative version_file
 else
-  GoCardlessPro::VERSION = ''
+  GoCardlessPro::VERSION = ''.freeze
 end
 
 require_relative 'gocardless_pro/api_service'

data/lib/gocardless_pro/api_service.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.
@@ -38,7 +39,7 @@ module GoCardlessPro
     # @param path [String] the URL (without the base domain) to make the request to
     # @param options [Hash] the options hash
     def make_request(method, path, options = {})
-      fail ArgumentError, 'options must be a hash' unless options.is_a?(Hash)
+      raise ArgumentError, 'options must be a hash' unless options.is_a?(Hash)
       options[:headers] ||= {}
       options[:headers] = @headers.merge(options[:headers])
       Request.new(@connection, method, @path_prefix + path, options).request
@@ -50,7 +51,7 @@ module GoCardlessPro
       url.password = 'REDACTED' unless url.password.nil?
       "#<GoCardlessPro::Client url=\"#{url}\">"
     end
-    alias_method :to_s, :inspect
+    alias to_s inspect
 
     private
 

data/lib/gocardless_pro/client.rb

@@ -79,7 +79,7 @@ module GoCardlessPro
     #   authentication.
     #
     def initialize(options)
-      access_token = options.delete(:access_token) || fail('No Access Token given to GoCardless Client')
+      access_token = options.delete(:access_token) || raise('No Access Token given to GoCardless Client')
       environment = options.delete(:environment) || :live
       url = options.delete(:url) || url_for_environment(environment)
       options = custom_options(options)
@@ -94,7 +94,7 @@ module GoCardlessPro
       elsif environment === :sandbox
         'https://api-sandbox.gocardless.com'
       else
-        fail "Unknown environment key: #{environment}"
+        raise "Unknown environment key: #{environment}"
       end
     end
 
@@ -115,11 +115,11 @@ module GoCardlessPro
       {
         default_headers: {
           'GoCardless-Version' => '2015-07-06',
-          'User-Agent' => "#{user_agent}",
+          'User-Agent' => user_agent.to_s,
           'Content-Type' => 'application/json',
           'GoCardless-Client-Library' => 'gocardless-pro-ruby',
-          'GoCardless-Client-Version' => '2.1.0'
-        }
+          'GoCardless-Client-Version' => '2.2.0',
+        },
       }
     end
 
@@ -139,7 +139,7 @@ module GoCardlessPro
           comment = [
             "#{ruby_engine}/#{ruby_version}",
             "#{RUBY_ENGINE}/#{interpreter_version}",
-            "#{RUBY_PLATFORM}"
+            RUBY_PLATFORM.to_s,
           ]
           comment << "faraday/#{Faraday::VERSION}"
           "#{gem_info} #{comment.join(' ')}"

data/lib/gocardless_pro/error.rb

@@ -6,7 +6,7 @@ module GoCardlessPro
     # intialize a new error
     #  @param error the error from the API
     def initialize(error)
-      fail ArgumentError, 'GoCardless errors expect a hash' unless error.is_a?(Hash)
+      raise ArgumentError, 'GoCardless errors expect a hash' unless error.is_a?(Hash)
       @error = error
     end
 
@@ -22,9 +22,9 @@ module GoCardlessPro
 
     def to_s
       if errors.any?
-        errors
-          .map { |err| "#{err['field']} #{err['message']}" }
-          .join(', ')
+        errors.
+          map { |err| "#{err['field']} #{err['message']}" }.
+          join(', ')
       else
         @error['message']
       end

data/lib/gocardless_pro/middlewares/raise_gocardless_errors.rb

@@ -6,13 +6,13 @@ module GoCardlessPro
 
       def on_complete(env)
         if !json?(env) || API_ERROR_STATUSES.include?(env.status)
-          fail ApiError, generate_error_data(env)
+          raise ApiError, generate_error_data(env)
         end
 
         if CLIENT_ERROR_STATUSES.include?(env.status)
           json_body ||= JSON.parse(env.body) unless env.body.empty?
           error_type = json_body['error']['type']
-          fail(error_class_for_type(error_type), json_body['error'])
+          raise(error_class_for_type(error_type), json_body['error'])
         end
       end
 
@@ -23,7 +23,7 @@ module GoCardlessPro
           validation_failed: GoCardlessPro::ValidationError,
           gocardless: GoCardlessPro::GoCardlessError,
           invalid_api_usage: GoCardlessPro::InvalidApiUsageError,
-          invalid_state: GoCardlessPro::InvalidStateError
+          invalid_state: GoCardlessPro::InvalidStateError,
         }.fetch(type.to_sym)
       end
 
@@ -33,7 +33,7 @@ module GoCardlessPro
                        "code: #{env.status}\n" \
                        "headers: #{env.response_headers}\n" \
                        "body: #{env.body}",
-          'code' => env.status
+          'code' => env.status,
         }
       end
 

data/lib/gocardless_pro/request.rb

@@ -71,10 +71,10 @@ module GoCardlessPro
     def request_body
       if @method == :get
         nil
-      elsif [:post, :put, :delete].include?(@method)
+      elsif %i[post put delete].include?(@method)
         @given_options.fetch(:params, {})
       else
-        fail "Unknown request method #{@method}"
+        raise "Unknown request method #{@method}"
       end
     end
 

data/lib/gocardless_pro/resources/bank_details_lookup.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/creditor.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/creditor_bank_account.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/customer.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/customer_bank_account.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/event.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/mandate.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/mandate_pdf.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/payment.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/payout.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/redirect_flow.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/refund.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/resources/subscription.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+
 #
 # This client is automatically generated from a template and JSON schema definition.
 # See https://github.com/gocardless/gocardless-pro-ruby#contributing before editing.

data/lib/gocardless_pro/services/base_service.rb

@@ -21,7 +21,7 @@ module GoCardlessPro
 
       # Get the envelope key for the given service. Children are expected to implement this method.
       def envelope_key
-        fail NotImplementedError
+        raise NotImplementedError
       end
     end
   end

data/lib/gocardless_pro/version.rb

@@ -4,5 +4,5 @@ end
 
 module GoCardlessPro
   # Current version of the GC gem
-  VERSION = '2.1.0'
+  VERSION = '2.2.0'.freeze
 end

data/spec/api_service_spec.rb

@@ -7,14 +7,14 @@ describe GoCardlessPro::ApiService do
     {
       status: 200,
       body: '{}',
-      headers: { 'Content-Type' => 'application/json' }
+      headers: { 'Content-Type' => 'application/json' },
     }
   end
 
   it 'uses basic auth' do
-    stub = stub_request(:get, 'https://api.example.com/customers')
-           .with(headers: { 'Authorization' => 'Bearer secret_token' })
-           .to_return(default_response)
+    stub = stub_request(:get, 'https://api.example.com/customers').
+           with(headers: { 'Authorization' => 'Bearer secret_token' }).
+           to_return(default_response)
 
     service.make_request(:get, '/customers')
     expect(stub).to have_been_requested
@@ -22,17 +22,17 @@ describe GoCardlessPro::ApiService do
 
   describe 'making a get request without any parameters' do
     it 'is expected to call the correct stub' do
-      stub = stub_request(:get, /.*api.example.com\/customers/)
-             .to_return(default_response)
+      stub = stub_request(:get, /.*api.example.com\/customers/).
+             to_return(default_response)
 
       service.make_request(:get, '/customers')
       expect(stub).to have_been_requested
     end
 
     it "doesn't include an idempotency key" do
-      stub = stub_request(:get, /.*api.example.com\/customers/)
-             .with { |request| !request.headers.key?('Idempotency-Key') }
-             .to_return(default_response)
+      stub = stub_request(:get, /.*api.example.com\/customers/).
+             with { |request| !request.headers.key?('Idempotency-Key') }.
+             to_return(default_response)
 
       service.make_request(:get, '/customers')
       expect(stub).to have_been_requested
@@ -41,17 +41,17 @@ describe GoCardlessPro::ApiService do
 
   describe 'making a get request with query parameters' do
     it 'correctly passes the query parameters' do
-      stub = stub_request(:get, /.*api.example.com\/customers\?a=1&b=2/)
-             .to_return(default_response)
+      stub = stub_request(:get, /.*api.example.com\/customers\?a=1&b=2/).
+             to_return(default_response)
 
       service.make_request(:get, '/customers', params: { a: 1, b: 2 })
       expect(stub).to have_been_requested
     end
 
     it "doesn't include an idempotency key" do
-      stub = stub_request(:get, /.*api.example.com\/customers\?a=1&b=2/)
-             .with { |request| !request.headers.key?('Idempotency-Key') }
-             .to_return(default_response)
+      stub = stub_request(:get, /.*api.example.com\/customers\?a=1&b=2/).
+             with { |request| !request.headers.key?('Idempotency-Key') }.
+             to_return(default_response)
 
       service.make_request(:get, '/customers', params: { a: 1, b: 2 })
       expect(stub).to have_been_requested
@@ -60,13 +60,13 @@ describe GoCardlessPro::ApiService do
 
   describe 'making a post request with some data' do
     it 'passes the data in as the post body' do
-      stub = stub_request(:post, /.*api.example.com\/customers/)
-             .with(body: { given_name: 'Jack', family_name: 'Franklin' })
-             .to_return(default_response)
+      stub = stub_request(:post, /.*api.example.com\/customers/).
+             with(body: { given_name: 'Jack', family_name: 'Franklin' }).
+             to_return(default_response)
 
       service.make_request(:post, '/customers', params: {
                              given_name: 'Jack',
-                             family_name: 'Franklin'
+                             family_name: 'Franklin',
                            })
       expect(stub).to have_been_requested
     end
@@ -74,16 +74,16 @@ describe GoCardlessPro::ApiService do
     it 'generates a random idempotency key' do
       allow(SecureRandom).to receive(:uuid).and_return('random-uuid')
 
-      stub = stub_request(:post, /.*api.example.com\/customers/)
-             .with(
+      stub = stub_request(:post, /.*api.example.com\/customers/).
+             with(
                body: { given_name: 'Jack', family_name: 'Franklin' },
                headers: { 'Idempotency-Key' => 'random-uuid' }
-             )
-             .to_return(default_response)
+             ).
+             to_return(default_response)
 
       service.make_request(:post, '/customers', params: {
                              given_name: 'Jack',
-                             family_name: 'Franklin'
+                             family_name: 'Franklin',
                            })
       expect(stub).to have_been_requested
     end
@@ -91,19 +91,19 @@ describe GoCardlessPro::ApiService do
 
   describe 'making a post request with data and custom header' do
     it 'passes the data in as the post body' do
-      stub = stub_request(:post, /.*api.example.com\/customers/)
-             .with(
+      stub = stub_request(:post, /.*api.example.com\/customers/).
+             with(
                body: { given_name: 'Jack', family_name: 'Franklin' },
                headers: { 'Foo' => 'Bar' }
-             )
-             .to_return(default_response)
+             ).
+             to_return(default_response)
 
       service.make_request(:post, '/customers', params: {
                              given_name: 'Jack',
-                             family_name: 'Franklin'
+                             family_name: 'Franklin',
                            },
                                                 headers: {
-                                                  'Foo' => 'Bar'
+                                                  'Foo' => 'Bar',
                                                 })
       expect(stub).to have_been_requested
     end
@@ -111,38 +111,38 @@ describe GoCardlessPro::ApiService do
     it 'merges in a random idempotency key' do
       allow(SecureRandom).to receive(:uuid).and_return('random-uuid')
 
-      stub = stub_request(:post, /.*api.example.com\/customers/)
-             .with(
+      stub = stub_request(:post, /.*api.example.com\/customers/).
+             with(
                body: { given_name: 'Jack', family_name: 'Franklin' },
                headers: { 'Idempotency-Key' => 'random-uuid', 'Foo' => 'Bar' }
-             )
-             .to_return(default_response)
+             ).
+             to_return(default_response)
 
       service.make_request(:post, '/customers', params: {
                              given_name: 'Jack',
-                             family_name: 'Franklin'
+                             family_name: 'Franklin',
                            },
                                                 headers: {
-                                                  'Foo' => 'Bar'
+                                                  'Foo' => 'Bar',
                                                 })
       expect(stub).to have_been_requested
     end
 
     context 'with a custom idempotency key' do
       it "doesn't replace it with a randomly-generated idempotency key" do
-        stub = stub_request(:post, /.*api.example.com\/customers/)
-               .with(
+        stub = stub_request(:post, /.*api.example.com\/customers/).
+               with(
                  body: { given_name: 'Jack', family_name: 'Franklin' },
                  headers: { 'Idempotency-Key' => 'my-custom-idempotency-key' }
-               )
-               .to_return(default_response)
+               ).
+               to_return(default_response)
 
         service.make_request(:post, '/customers', params: {
                                given_name: 'Jack',
-                               family_name: 'Franklin'
+                               family_name: 'Franklin',
                              },
                                                   headers: {
-                                                    'Idempotency-Key' => 'my-custom-idempotency-key'
+                                                    'Idempotency-Key' => 'my-custom-idempotency-key',
                                                   })
         expect(stub).to have_been_requested
       end
@@ -151,25 +151,25 @@ describe GoCardlessPro::ApiService do
 
   describe 'making a put request with some data' do
     it 'passes the data in as the request body' do
-      stub = stub_request(:put, /.*api.example.com\/customers\/CU123/)
-             .with(body: { given_name: 'Jack', family_name: 'Franklin' })
-             .to_return(default_response)
+      stub = stub_request(:put, /.*api.example.com\/customers\/CU123/).
+             with(body: { given_name: 'Jack', family_name: 'Franklin' }).
+             to_return(default_response)
 
       service.make_request(:put, '/customers/CU123', params: {
                              given_name: 'Jack',
-                             family_name: 'Franklin'
+                             family_name: 'Franklin',
                            })
       expect(stub).to have_been_requested
     end
 
     it "doesn't include an idempotency key" do
-      stub = stub_request(:put, /.*api.example.com\/customers\/CU123/)
-             .with { |request| !request.headers.key?('Idempotency-Key') }
-             .to_return(default_response)
+      stub = stub_request(:put, /.*api.example.com\/customers\/CU123/).
+             with { |request| !request.headers.key?('Idempotency-Key') }.
+             to_return(default_response)
 
       service.make_request(:put, '/customers/CU123', params: {
                              given_name: 'Jack',
-                             family_name: 'Franklin'
+                             family_name: 'Franklin',
                            })
       expect(stub).to have_been_requested
     end