gocardless_pro 1.1.0 → 2.0.0

data/spec/resources/bank_details_lookup_spec.rb

@@ -1,37 +1,120 @@
 require 'spec_helper'
 
 describe GoCardlessPro::Resources::BankDetailsLookup do
-  describe 'initialising' do
-    let(:data) do
-      {
+  let(:client) do
+    GoCardlessPro::Client.new(
+      access_token: 'SECRET_TOKEN'
+    )
+  end
+
+  let(:response_headers) { { 'Content-Type' => 'application/json' } }
 
-        'available_debit_schemes' => 'available_debit_schemes-input',
+  describe '#create' do
+    subject(:post_create_response) { client.bank_details_lookups.create(params: new_resource) }
+    context 'with a valid request' do
+      let(:new_resource) do
+        {
 
-        'bank_name' => 'bank_name-input',
+          'available_debit_schemes' => 'available_debit_schemes-input',
+          'bank_name' => 'bank_name-input',
+          'bic' => 'bic-input'
+        }
+      end
 
-        'bic' => 'bic-input'
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/bank_details_lookups})
+          .with(
+            body: {
+              'bank_details_lookups' => {
 
-      }
-    end
+                'available_debit_schemes' => 'available_debit_schemes-input',
+                'bank_name' => 'bank_name-input',
+                'bic' => 'bic-input'
+              }
+            }
+          )
+          .to_return(
+            body: {
+              'bank_details_lookups' =>
 
-    it 'can be initialized from an unenveloped response' do
-      resource = described_class.new(data)
+                {
 
-      expect(resource.available_debit_schemes).to eq('available_debit_schemes-input')
+                  'available_debit_schemes' => 'available_debit_schemes-input',
+                  'bank_name' => 'bank_name-input',
+                  'bic' => 'bic-input'
+                }
 
-      expect(resource.bank_name).to eq('bank_name-input')
+            }.to_json,
+            headers: response_headers
+          )
+      end
 
-      expect(resource.bic).to eq('bic-input')
+      it 'creates and returns the resource' do
+        expect(post_create_response).to be_a(GoCardlessPro::Resources::BankDetailsLookup)
+      end
     end
 
-    it 'can handle new attributes without erroring' do
-      data['foo'] = 'bar'
-      expect { described_class.new(data) }.to_not raise_error
+    context 'with a request that returns a validation error' do
+      let(:new_resource) { {} }
+
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/bank_details_lookups}).to_return(
+          body: {
+            error: {
+              type: 'validation_failed',
+              code: 422,
+              errors: [
+                { message: 'test error message', field: 'test_field' }
+              ]
+            }
+          }.to_json,
+          headers: response_headers,
+          status: 422
+        )
+      end
+
+      it 'throws the correct error' do
+        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
+      end
     end
 
-    describe '#to_h' do
-      it 'returns a hash representing the resource' do
-        expect(described_class.new(data).to_h).to eq(data)
+    context 'with a request that returns an idempotent creation conflict error' do
+      let(:id) { 'ID123' }
+
+      let(:new_resource) do
+        {
+
+          'available_debit_schemes' => 'available_debit_schemes-input',
+          'bank_name' => 'bank_name-input',
+          'bic' => 'bic-input'
+        }
+      end
+
+      let!(:post_stub) do
+        stub_request(:post, %r{.*api.gocardless.com/bank_details_lookups}).to_return(
+          body: {
+            error: {
+              type: 'invalid_state',
+              code: 409,
+              errors: [
+                {
+                  message: 'A resource has already been created with this idempotency key',
+                  reason: 'idempotent_creation_conflict',
+                  links: {
+                    conflicting_resource_id: id
+                  }
+                }
+              ]
+            }
+          }.to_json,
+          headers: response_headers,
+          status: 409
+        )
+      end
+
+      it 'raises an InvalidStateError' do
+        expect { post_create_response }.to raise_error(GoCardlessPro::InvalidStateError)
+        expect(post_stub).to have_been_requested
       end
     end
   end

data/spec/resources/creditor_bank_account_spec.rb

@@ -1,79 +1,455 @@
 require 'spec_helper'
 
 describe GoCardlessPro::Resources::CreditorBankAccount do
-  describe 'initialising' do
-    let(:data) do
-      {
+  let(:client) do
+    GoCardlessPro::Client.new(
+      access_token: 'SECRET_TOKEN'
+    )
+  end
 
-        'account_holder_name' => 'account_holder_name-input',
+  let(:response_headers) { { 'Content-Type' => 'application/json' } }
 
-        'account_number_ending' => 'account_number_ending-input',
+  describe '#create' do
+    subject(:post_create_response) { client.creditor_bank_accounts.create(params: new_resource) }
+    context 'with a valid request' do
+      let(:new_resource) do
+        {
 
-        'bank_name' => 'bank_name-input',
+          'account_holder_name' => 'account_holder_name-input',
+          'account_number_ending' => 'account_number_ending-input',
+          'bank_name' => 'bank_name-input',
+          'country_code' => 'country_code-input',
+          'created_at' => 'created_at-input',
+          'currency' => 'currency-input',
+          'enabled' => 'enabled-input',
+          'id' => 'id-input',
+          'links' => 'links-input',
+          'metadata' => 'metadata-input'
+        }
+      end
 
-        'country_code' => 'country_code-input',
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/creditor_bank_accounts})
+          .with(
+            body: {
+              'creditor_bank_accounts' => {
 
-        'created_at' => 'created_at-input',
+                'account_holder_name' => 'account_holder_name-input',
+                'account_number_ending' => 'account_number_ending-input',
+                'bank_name' => 'bank_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'currency' => 'currency-input',
+                'enabled' => 'enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'metadata' => 'metadata-input'
+              }
+            }
+          )
+          .to_return(
+            body: {
+              'creditor_bank_accounts' =>
 
-        'currency' => 'currency-input',
+                {
 
-        'enabled' => 'enabled-input',
+                  'account_holder_name' => 'account_holder_name-input',
+                  'account_number_ending' => 'account_number_ending-input',
+                  'bank_name' => 'bank_name-input',
+                  'country_code' => 'country_code-input',
+                  'created_at' => 'created_at-input',
+                  'currency' => 'currency-input',
+                  'enabled' => 'enabled-input',
+                  'id' => 'id-input',
+                  'links' => 'links-input',
+                  'metadata' => 'metadata-input'
+                }
 
-        'id' => 'id-input',
+            }.to_json,
+            headers: response_headers
+          )
+      end
 
-        'links' => {
+      it 'creates and returns the resource' do
+        expect(post_create_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
+      end
+    end
 
-          'creditor' => 'creditor-input'
+    context 'with a request that returns a validation error' do
+      let(:new_resource) { {} }
 
-        },
+      before do
+        stub_request(:post, %r{.*api.gocardless.com/creditor_bank_accounts}).to_return(
+          body: {
+            error: {
+              type: 'validation_failed',
+              code: 422,
+              errors: [
+                { message: 'test error message', field: 'test_field' }
+              ]
+            }
+          }.to_json,
+          headers: response_headers,
+          status: 422
+        )
+      end
+
+      it 'throws the correct error' do
+        expect { post_create_response }.to raise_error(GoCardlessPro::ValidationError)
+      end
+    end
 
-        'metadata' => 'metadata-input'
+    context 'with a request that returns an idempotent creation conflict error' do
+      let(:id) { 'ID123' }
+
+      let(:new_resource) do
+        {
+
+          'account_holder_name' => 'account_holder_name-input',
+          'account_number_ending' => 'account_number_ending-input',
+          'bank_name' => 'bank_name-input',
+          'country_code' => 'country_code-input',
+          'created_at' => 'created_at-input',
+          'currency' => 'currency-input',
+          'enabled' => 'enabled-input',
+          'id' => 'id-input',
+          'links' => 'links-input',
+          'metadata' => 'metadata-input'
+        }
+      end
+
+      let!(:post_stub) do
+        stub_request(:post, %r{.*api.gocardless.com/creditor_bank_accounts}).to_return(
+          body: {
+            error: {
+              type: 'invalid_state',
+              code: 409,
+              errors: [
+                {
+                  message: 'A resource has already been created with this idempotency key',
+                  reason: 'idempotent_creation_conflict',
+                  links: {
+                    conflicting_resource_id: id
+                  }
+                }
+              ]
+            }
+          }.to_json,
+          headers: response_headers,
+          status: 409
+        )
+      end
+
+      let!(:get_stub) do
+        stub_url = "/creditor_bank_accounts/#{id}"
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/)
+          .to_return(
+            body: {
+              'creditor_bank_accounts' => {
+
+                'account_holder_name' => 'account_holder_name-input',
+                'account_number_ending' => 'account_number_ending-input',
+                'bank_name' => 'bank_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'currency' => 'currency-input',
+                'enabled' => 'enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'metadata' => 'metadata-input'
+              }
+            }.to_json,
+            headers: response_headers
+          )
+      end
 
-      }
+      it 'fetches the already-created resource' do
+        post_create_response
+        expect(post_stub).to have_been_requested
+        expect(get_stub).to have_been_requested
+      end
     end
+  end
+
+  describe '#list' do
+    describe 'with no filters' do
+      subject(:get_list_response) { client.creditor_bank_accounts.list }
 
-    it 'can be initialized from an unenveloped response' do
-      resource = described_class.new(data)
+      before do
+        stub_request(:get, %r{.*api.gocardless.com/creditor_bank_accounts}).to_return(
+          body: {
+            'creditor_bank_accounts' => [{
+
+              'account_holder_name' => 'account_holder_name-input',
+              'account_number_ending' => 'account_number_ending-input',
+              'bank_name' => 'bank_name-input',
+              'country_code' => 'country_code-input',
+              'created_at' => 'created_at-input',
+              'currency' => 'currency-input',
+              'enabled' => 'enabled-input',
+              'id' => 'id-input',
+              'links' => 'links-input',
+              'metadata' => 'metadata-input'
+            }],
+            meta: {
+              cursors: {
+                before: nil,
+                after: 'ABC123'
+              }
+            }
+          }.to_json,
+          headers: response_headers
+        )
+      end
 
-      expect(resource.account_holder_name).to eq('account_holder_name-input')
+      it 'wraps each item in the resource class' do
+        expect(get_list_response.records.map(&:class).uniq.first).to eq(GoCardlessPro::Resources::CreditorBankAccount)
 
-      expect(resource.account_number_ending).to eq('account_number_ending-input')
+        expect(get_list_response.records.first.account_holder_name).to eq('account_holder_name-input')
 
-      expect(resource.bank_name).to eq('bank_name-input')
+        expect(get_list_response.records.first.account_number_ending).to eq('account_number_ending-input')
 
-      expect(resource.country_code).to eq('country_code-input')
+        expect(get_list_response.records.first.bank_name).to eq('bank_name-input')
 
-      expect(resource.created_at).to eq('created_at-input')
+        expect(get_list_response.records.first.country_code).to eq('country_code-input')
 
-      expect(resource.currency).to eq('currency-input')
+        expect(get_list_response.records.first.created_at).to eq('created_at-input')
 
-      expect(resource.enabled).to eq('enabled-input')
+        expect(get_list_response.records.first.currency).to eq('currency-input')
 
-      expect(resource.id).to eq('id-input')
+        expect(get_list_response.records.first.enabled).to eq('enabled-input')
 
-      expect(resource.links.creditor).to eq('creditor-input')
+        expect(get_list_response.records.first.id).to eq('id-input')
+
+        expect(get_list_response.records.first.metadata).to eq('metadata-input')
+      end
+
+      it 'exposes the cursors for before and after' do
+        expect(get_list_response.before).to eq(nil)
+        expect(get_list_response.after).to eq('ABC123')
+      end
 
-      expect(resource.metadata).to eq('metadata-input')
+      specify { expect(get_list_response.api_response.headers).to eql('content-type' => 'application/json') }
     end
+  end
+
+  describe '#all' do
+    let!(:first_response_stub) do
+      stub_request(:get, %r{.*api.gocardless.com/creditor_bank_accounts$}).to_return(
+        body: {
+          'creditor_bank_accounts' => [{
 
-    it 'can handle new attributes without erroring' do
-      data['foo'] = 'bar'
-      expect { described_class.new(data) }.to_not raise_error
+            'account_holder_name' => 'account_holder_name-input',
+            'account_number_ending' => 'account_number_ending-input',
+            'bank_name' => 'bank_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'currency' => 'currency-input',
+            'enabled' => 'enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'metadata' => 'metadata-input'
+          }],
+          meta: {
+            cursors: { after: 'AB345' },
+            limit: 1
+          }
+        }.to_json,
+        headers: response_headers
+      )
     end
 
-    it 'can handle new link attributes without erroring' do
-      data['links']['foo'] = 'bar'
-      expect { described_class.new(data) }.to_not raise_error
+    let!(:second_response_stub) do
+      stub_request(:get, %r{.*api.gocardless.com/creditor_bank_accounts\?after=AB345}).to_return(
+        body: {
+          'creditor_bank_accounts' => [{
+
+            'account_holder_name' => 'account_holder_name-input',
+            'account_number_ending' => 'account_number_ending-input',
+            'bank_name' => 'bank_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'currency' => 'currency-input',
+            'enabled' => 'enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'metadata' => 'metadata-input'
+          }],
+          meta: {
+            limit: 2,
+            cursors: {}
+          }
+        }.to_json,
+        headers: response_headers
+      )
     end
 
-    it 'can handle a nil links value' do
-      data['links'] = nil
-      expect { described_class.new(data).links }.to_not raise_error
+    it 'automatically makes the extra requests' do
+      expect(client.creditor_bank_accounts.all.to_a.length).to eq(2)
+      expect(first_response_stub).to have_been_requested
+      expect(second_response_stub).to have_been_requested
     end
+  end
+
+  describe '#get' do
+    let(:id) { 'ID123' }
+
+    subject(:get_response) { client.creditor_bank_accounts.get(id) }
+
+    context 'passing in a custom header' do
+      let!(:stub) do
+        stub_url = '/creditor_bank_accounts/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/)
+          .with(headers: { 'Foo' => 'Bar' })
+          .to_return(
+            body: {
+              'creditor_bank_accounts' => {
+
+                'account_holder_name' => 'account_holder_name-input',
+                'account_number_ending' => 'account_number_ending-input',
+                'bank_name' => 'bank_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'currency' => 'currency-input',
+                'enabled' => 'enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'metadata' => 'metadata-input'
+              }
+            }.to_json,
+            headers: response_headers
+          )
+      end
+
+      subject(:get_response) do
+        client.creditor_bank_accounts.get(id, headers: {
+                                            'Foo' => 'Bar'
+                                          })
+      end
+
+      it 'includes the header' do
+        get_response
+        expect(stub).to have_been_requested
+      end
+    end
+
+    context 'when there is a creditor_bank_account to return' do
+      before do
+        stub_url = '/creditor_bank_accounts/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: {
+            'creditor_bank_accounts' => {
+
+              'account_holder_name' => 'account_holder_name-input',
+              'account_number_ending' => 'account_number_ending-input',
+              'bank_name' => 'bank_name-input',
+              'country_code' => 'country_code-input',
+              'created_at' => 'created_at-input',
+              'currency' => 'currency-input',
+              'enabled' => 'enabled-input',
+              'id' => 'id-input',
+              'links' => 'links-input',
+              'metadata' => 'metadata-input'
+            }
+          }.to_json,
+          headers: response_headers
+        )
+      end
+
+      it 'wraps the response in a resource' do
+        expect(get_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
+      end
+    end
+
+    context 'when nothing is returned' do
+      before do
+        stub_url = '/creditor_bank_accounts/:identity'.gsub(':identity', id)
+        stub_request(:get, /.*api.gocardless.com#{stub_url}/).to_return(
+          body: '',
+          headers: response_headers
+        )
+      end
+
+      it 'returns nil' do
+        expect(get_response).to be_nil
+      end
+    end
+
+    context "when an ID is specified which can't be included in a valid URI" do
+      let(:id) { '`' }
+
+      it "doesn't raise an error" do
+        expect { get_response }.to_not raise_error(/bad URI/)
+      end
+    end
+  end
+
+  describe '#disable' do
+    subject(:post_response) { client.creditor_bank_accounts.disable(resource_id) }
+
+    let(:resource_id) { 'ABC123' }
+
+    let!(:stub) do
+      # /creditor_bank_accounts/%v/actions/disable
+      stub_url = '/creditor_bank_accounts/:identity/actions/disable'.gsub(':identity', resource_id)
+      stub_request(:post, /.*api.gocardless.com#{stub_url}/).to_return(
+        body: {
+          'creditor_bank_accounts' => {
+
+            'account_holder_name' => 'account_holder_name-input',
+            'account_number_ending' => 'account_number_ending-input',
+            'bank_name' => 'bank_name-input',
+            'country_code' => 'country_code-input',
+            'created_at' => 'created_at-input',
+            'currency' => 'currency-input',
+            'enabled' => 'enabled-input',
+            'id' => 'id-input',
+            'links' => 'links-input',
+            'metadata' => 'metadata-input'
+          }
+        }.to_json,
+        headers: response_headers
+      )
+    end
+
+    it 'wraps the response and calls the right endpoint' do
+      expect(post_response).to be_a(GoCardlessPro::Resources::CreditorBankAccount)
+
+      expect(stub).to have_been_requested
+    end
+
+    context 'when the request needs a body and custom header' do
+      let(:body) { { foo: 'bar' } }
+      let(:headers) { { 'Foo' => 'Bar' } }
+      subject(:post_response) { client.creditor_bank_accounts.disable(resource_id, body, headers) }
+
+      let(:resource_id) { 'ABC123' }
+
+      let!(:stub) do
+        # /creditor_bank_accounts/%v/actions/disable
+        stub_url = '/creditor_bank_accounts/:identity/actions/disable'.gsub(':identity', resource_id)
+        stub_request(:post, /.*api.gocardless.com#{stub_url}/)
+          .with(
+            body: { foo: 'bar' },
+            headers: { 'Foo' => 'Bar' }
+          ).to_return(
+            body: {
+              'creditor_bank_accounts' => {
 
-    describe '#to_h' do
-      it 'returns a hash representing the resource' do
-        expect(described_class.new(data).to_h).to eq(data)
+                'account_holder_name' => 'account_holder_name-input',
+                'account_number_ending' => 'account_number_ending-input',
+                'bank_name' => 'bank_name-input',
+                'country_code' => 'country_code-input',
+                'created_at' => 'created_at-input',
+                'currency' => 'currency-input',
+                'enabled' => 'enabled-input',
+                'id' => 'id-input',
+                'links' => 'links-input',
+                'metadata' => 'metadata-input'
+              }
+            }.to_json,
+            headers: response_headers
+          )
       end
     end
   end